[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546570880 I set up a schedule and set a baseline of when the skywalking online in our environment, and it will search endpoint within a

[GitHub] [skywalking] wu-sheng commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
wu-sheng commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546570859 Ping us after you done. This is an automated message from the Apache

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546570880 I set up a schedule and set a baseline of when the skywalking online in the our environment, and it will search endpoint within a

[GitHub] [skywalking] arugal commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546569893 Please do not merge this PR yet, I also have an enhance to the plugin

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546568571 the code already support both register time and heartbeat time, i just add a new searchEndpoint and convet duration argument into start

[GitHub] [skywalking] wu-sheng commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
wu-sheng commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546564477 There is no endpoint by time, it doesn't have the heartbeat. You need to learn deeper.

[GitHub] [skywalking] wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close

2019-10-25 Thread GitBox
wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-546564387 This is not a communication issue, every time you shutdown the agent, the TCP broken, and you got this at server side.

[GitHub] [skywalking] wu-sheng commented on issue #3714: [CI] Run build jobs on different nodes parallelly

2019-10-25 Thread GitBox
wu-sheng commented on issue #3714: [CI] Run build jobs on different nodes parallelly URL: https://github.com/apache/skywalking/pull/3714#issuecomment-546564312 Please move this as a record in WIKI. We may need this someday.

[GitHub] [skywalking] arugal commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546564230 /run ci This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] arugal commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546562539 /run agent-plugin-test-3 This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
wu-sheng commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546562078 You break the test case. This is an automated message from the Apache

[GitHub] [skywalking] kezhenxu94 closed pull request #3714: [CI] Run build jobs on different nodes parallelly

2019-10-25 Thread GitBox
kezhenxu94 closed pull request #3714: [CI] Run build jobs on different nodes parallelly URL: https://github.com/apache/skywalking/pull/3714 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3717: fix deficient code, "/socket.io/" http segment declare

2019-10-25 Thread GitBox
wu-sheng commented on issue #3717: fix deficient code, "/socket.io/" http segment declare URL: https://github.com/apache/skywalking/pull/3717#issuecomment-546473089 Data sync complete, please add the test back and fix the test bug.

[GitHub] [skywalking] wu-sheng merged pull request #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
wu-sheng merged pull request #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716 This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking] branch master updated: [test/plugin] to check agent register status (#3716)

2019-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new c81e8a0 [test/plugin] to check agent

[GitHub] [skywalking] dmsolr commented on issue #3717: fix deficient code, "/socket.io/" http segment declare

2019-10-25 Thread GitBox
dmsolr commented on issue #3717: fix deficient code, "/socket.io/" http segment declare URL: https://github.com/apache/skywalking/pull/3717#issuecomment-546452664 @wu-sheng @mrproliu , I have remove it. Please add it back after fixing it.

[GitHub] [skywalking] wu-sheng commented on issue #3717: fix deficient code, "/socket.io/" http segment declare

2019-10-25 Thread GitBox
wu-sheng commented on issue #3717: fix deficient code, "/socket.io/" http segment declare URL: https://github.com/apache/skywalking/pull/3717#issuecomment-546448054 @mrproliu I have asked @dmsolr to remove socket.io test in jenkins file, which will give you 1-2 days to fix and update this

[GitHub] [skywalking] wu-sheng commented on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
wu-sheng commented on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546447423 Please remove the socket.io test for now. This is an automated message

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
wu-sheng commented on a change in pull request #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#discussion_r339164581 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
wu-sheng commented on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546444313 /run agent-plugin-test-1 This is an automated message from the Apache

[GitHub] [skywalking] dmsolr commented on issue #3717: fix deficient code, "/socket.io/" http segment declare

2019-10-25 Thread GitBox
dmsolr commented on issue #3717: fix deficient code, "/socket.io/" http segment declare URL: https://github.com/apache/skywalking/pull/3717#issuecomment-546439739 > @dmsolr , you can have a look Hi @mrproliu I am sorry to let you know that PR passed because the

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3714: [CI] Run build jobs on different nodes parallelly

2019-10-25 Thread GitBox
kezhenxu94 edited a comment on issue #3714: [CI] Run build jobs on different nodes parallelly URL: https://github.com/apache/skywalking/pull/3714#issuecomment-546408930 We don't need to group the jobs anymore, because the jobs are scheduled on different nodes in a smaller granularity

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3714: [CI] Run build jobs on different nodes parallelly

2019-10-25 Thread GitBox
kezhenxu94 edited a comment on issue #3714: [CI] Run build jobs on different nodes parallelly URL: https://github.com/apache/skywalking/pull/3714#issuecomment-546408930 We don't need to group the jobs anymore, because the jobs are scheduled on different nodes in a smaller granularity

[GitHub] [skywalking] innerpeacez opened a new pull request #3718: Istio deploy script

2019-10-25 Thread GitBox
innerpeacez opened a new pull request #3718: Istio deploy script URL: https://github.com/apache/skywalking/pull/3718 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [X] New feature provided - [ ] Improve

[GitHub] [skywalking] kezhenxu94 commented on issue #3714: [CI] Run build jobs on different nodes parallelly

2019-10-25 Thread GitBox
kezhenxu94 commented on issue #3714: [CI] Run build jobs on different nodes parallelly URL: https://github.com/apache/skywalking/pull/3714#issuecomment-546408930 We don't need to group the jobs anymore, because the jobs are scheduled on different nodes in a smaller granularity (test

[GitHub] [skywalking] kezhenxu94 commented on issue #3695: [WIP]Add postgresql agent sql query param show

2019-10-25 Thread GitBox
kezhenxu94 commented on issue #3695: [WIP]Add postgresql agent sql query param show URL: https://github.com/apache/skywalking/pull/3695#issuecomment-546401226 @aderm ping me when you think it's ready This is an automated

[GitHub] [skywalking] aderm commented on a change in pull request #3695: [WIP]Add postgresql agent sql query param show

2019-10-25 Thread GitBox
aderm commented on a change in pull request #3695: [WIP]Add postgresql agent sql query param show URL: https://github.com/apache/skywalking/pull/3695#discussion_r339111566 ## File path:

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3714: [CI] Run build jobs on different nodes parallelly

2019-10-25 Thread GitBox
kezhenxu94 opened a new pull request #3714: [CI] Run build jobs on different nodes parallelly URL: https://github.com/apache/skywalking/pull/3714 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] mrproliu commented on issue #3717: fix deficient code, "/socket.io/" http segment declare

2019-10-25 Thread GitBox
mrproliu commented on issue #3717: fix deficient code, "/socket.io/" http segment declare URL: https://github.com/apache/skywalking/pull/3717#issuecomment-546397421 @dmsolr , you can have a look This is an automated message

[GitHub] [skywalking] mrproliu opened a new pull request #3717: fix deficient code, "/socket.io/" http segment declare

2019-10-25 Thread GitBox
mrproliu opened a new pull request #3717: fix deficient code, "/socket.io/" http segment declare URL: https://github.com/apache/skywalking/pull/3717 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature

[GitHub] [skywalking] kezhenxu94 commented on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
kezhenxu94 commented on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546326758 > In fact, I think the validate-tool skips the segment of `health-check`. HDYT? Ignoring the `healthCheck` span sounds good

[GitHub] [skywalking] sfy1231 commented on issue #3474: CANCELLED: cancelled before receiving half close

2019-10-25 Thread GitBox
sfy1231 commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-546318462 > I don't think that is the issue. But the log points to this is a communication issue, so could u give some adive or fix

[GitHub] [skywalking] dmsolr commented on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
dmsolr commented on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546306769 In fact, I think the validate-tool skips the segment of `health-check`. HDYT?

[GitHub] [skywalking] dmsolr edited a comment on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
dmsolr edited a comment on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546305337 > Can you explain why change `` to `ge ` in `expectedData.yml`, does it have side effects? This is why we modify the

[GitHub] [skywalking] dmsolr commented on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
dmsolr commented on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546305337 > Can you explain why change `` to `ge ` in `expectedData.yml`, does it have side effects? This is why we modify the

[GitHub] [skywalking] arugal commented on a change in pull request #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
arugal commented on a change in pull request #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#discussion_r338982868 ## File path: test/plugin/scenarios/ehcache-2.x-scenario/config/expectedData.yaml ## @@ -23,26 +23,8

[GitHub] [skywalking] arugal commented on a change in pull request #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
arugal commented on a change in pull request #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#discussion_r338982868 ## File path: test/plugin/scenarios/ehcache-2.x-scenario/config/expectedData.yaml ## @@ -23,26 +23,8

[GitHub] [skywalking] zhaoyuguang removed a comment on issue #3715: [plugin]support log4j2 AsyncLogger

2019-10-25 Thread GitBox
zhaoyuguang removed a comment on issue #3715: [plugin]support log4j2 AsyncLogger URL: https://github.com/apache/skywalking/pull/3715#issuecomment-546270665 /run agent-plugin-test-1 This is an automated message from the Apache

[GitHub] [skywalking] zhaoyuguang commented on issue #3715: [plugin]support log4j2 AsyncLogger

2019-10-25 Thread GitBox
zhaoyuguang commented on issue #3715: [plugin]support log4j2 AsyncLogger URL: https://github.com/apache/skywalking/pull/3715#issuecomment-546270665 /run agent-plugin-test-1 This is an automated message from the Apache Git

[GitHub] [skywalking] xiaoy00 commented on issue #3715: [plugin]support log4j2 AsyncLogger

2019-10-25 Thread GitBox
xiaoy00 commented on issue #3715: [plugin]support log4j2 AsyncLogger URL: https://github.com/apache/skywalking/pull/3715#issuecomment-546268097 /run agent-plugin-test-1 This is an automated message from the Apache Git

[GitHub] [skywalking] arugal commented on a change in pull request #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
arugal commented on a change in pull request #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#discussion_r338947360 ## File path:

[GitHub] [skywalking] dmsolr commented on issue #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
dmsolr commented on issue #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716#issuecomment-546260244 FYI @arugal This is an automated message from the Apache Git Service.

[GitHub] [skywalking] dmsolr opened a new pull request #3716: [test/plugin] to check agent register status

2019-10-25 Thread GitBox
dmsolr opened a new pull request #3716: [test/plugin] to check agent register status URL: https://github.com/apache/skywalking/pull/3716 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [

[GitHub] [skywalking] dmsolr commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
dmsolr commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#discussion_r338939980 ## File path:

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546256519 or merge above code into searchEndpoint(), and make SERVER detect_point as arguments, to meet both needs.

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546255328 for example, like above. This is an automated message from the Apache

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546255196 searchEndpointByTime(duration: Duration!, keyword: String!, serviceId: ID!, limit: Int!): [Endpoint!]!

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546254824 public List searchEndpointByTime(final Duration duration, final String keyword, final String serviceId, final int

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546254824 `public List searchEndpointByTime(final Duration duration, final String keyword, final String serviceId, final int limit)

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546252422 yes i know, endpoint topology is what i started, it tell me endpoint<->endpoint relationship, and i try to bind each endpoint

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546252422 yes i know, endpoint topology is what i started, it tell me endpoint<->endpoint relationship, and i try to bind each endpoint

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546252422 yes i know, endpoint topology is what i started, it tell me endpoint<->endpoint relationship, and i try to bind each endpoint

[GitHub] [skywalking] dmsolr commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
dmsolr commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546252584 Hi @arugal , I have run many times. The result shows the 1st version passed. But it is blocked on the 2nd version because `To visit entry

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546252422 yes i know, endpoint topology is what i started, it tell me endpoint<->endpoint relationship, and i try to bind each endpoint

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-25 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-546252422 yes i know, endpoint topology is what i started, it tell me endpoint<->endpoint relationship, and i try to bind each endpoint with their

[GitHub] [skywalking] arugal commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#discussion_r338933034 ## File path:

[GitHub] [skywalking] arugal commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#discussion_r338932369 ## File path:

[GitHub] [skywalking] xiaoy00 opened a new pull request #3715: [plugin]support log4j2 AsyncLogger

2019-10-25 Thread GitBox
xiaoy00 opened a new pull request #3715: [plugin]support log4j2 AsyncLogger URL: https://github.com/apache/skywalking/pull/3715 Please answer these questions before submitting pull request - Why submit this pull request? - [1 ] Bug fix - [ ] New feature provided - [ ]

[GitHub] [skywalking] kezhenxu94 closed pull request #3714: [CI] Hint when builds are skipped

2019-10-25 Thread GitBox
kezhenxu94 closed pull request #3714: [CI] Hint when builds are skipped URL: https://github.com/apache/skywalking/pull/3714 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] arugal commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546246445 /run agent-plugin-test-3 This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
wu-sheng commented on a change in pull request #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#discussion_r338910687 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3713: cannot get the TID using the ConsoleAppender +LogstashEncoder+TradeIdJsonProvider

2019-10-25 Thread GitBox
wu-sheng commented on issue #3713: cannot get the TID using the ConsoleAppender +LogstashEncoder+TradeIdJsonProvider URL: https://github.com/apache/skywalking/issues/3713#issuecomment-546223024 You could contribute this to the project by yourself. It is not hard.

[GitHub] [skywalking] wu-sheng commented on issue #3712: [istio-ci] Deploy istio and OAP

2019-10-25 Thread GitBox
wu-sheng commented on issue #3712: [istio-ci] Deploy istio and OAP URL: https://github.com/apache/skywalking/issues/3712#issuecomment-546219929 Make sense to me. When you need a jenkins trigger, let me known. This is an

[GitHub] [skywalking] arugal commented on issue #3698: [test/plugin] immigrate undertow scenario

2019-10-25 Thread GitBox
arugal commented on issue #3698: [test/plugin] immigrate undertow scenario URL: https://github.com/apache/skywalking/pull/3698#issuecomment-546216125 /run agent-plugin-test-3 This is an automated message from the Apache Git