[GitHub] [skywalking-cli] kezhenxu94 merged pull request #56: Add traces search

2020-08-17 Thread GitBox
kezhenxu94 merged pull request #56: URL: https://github.com/apache/skywalking-cli/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #56: Add traces search

2020-08-17 Thread GitBox
kezhenxu94 commented on a change in pull request #56: URL: https://github.com/apache/skywalking-cli/pull/56#discussion_r471929804 ## File path: display/graph/tree/list.go ## @@ -0,0 +1,190 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[skywalking-cli] branch master updated: Add traces search (#56)

2020-08-17 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new eeec64b Add traces search (#56)

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5339: Add support for spring @Scheduled

2020-08-17 Thread GitBox
wu-sheng commented on a change in pull request #5339: URL: https://github.com/apache/skywalking/pull/5339#discussion_r471929578 ## File path:

[GitHub] [skywalking] hailin0 commented on a change in pull request #5339: Add support for spring @Scheduled

2020-08-17 Thread GitBox
hailin0 commented on a change in pull request #5339: URL: https://github.com/apache/skywalking/pull/5339#discussion_r471928247 ## File path:

[GitHub] [skywalking] xbkaishui edited a comment on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, pay

2020-08-17 Thread GitBox
xbkaishui edited a comment on issue #5329: URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675260845 For the headers part, it maybe contains sensitive data, such as token, or userInfo related. shoud we add option choose to filter by header names?

[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, e

2020-08-17 Thread GitBox
xbkaishui commented on issue #5329: URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675260845 For the headers part, it maybe contains senstive data, such as token, or userInfo related. shoud we add option choose to filter by header names?

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5339: Add support for spring @Scheduled

2020-08-17 Thread GitBox
wu-sheng commented on a change in pull request #5339: URL: https://github.com/apache/skywalking/pull/5339#discussion_r471923271 ## File path: test/plugin/scenarios/spring-scheduled-scenario/config/expectedData.yaml ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software

[GitHub] [skywalking] hailin0 commented on a change in pull request #5339: Add support for spring @Scheduled

2020-08-17 Thread GitBox
hailin0 commented on a change in pull request #5339: URL: https://github.com/apache/skywalking/pull/5339#discussion_r471922334 ## File path: test/plugin/scenarios/spring-scheduled-scenario/config/expectedData.yaml ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] commented on pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
codecov[bot] commented on pull request #5345: URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) Report > Merging [#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] wu-sheng commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, et

2020-08-17 Thread GitBox
wu-sheng commented on issue #5329: URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675244422 Done This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] snakorse opened a new pull request #5345: Fix CLRThread metrics setId error.

2020-08-17 Thread GitBox
snakorse opened a new pull request #5345: URL: https://github.com/apache/skywalking/pull/5345 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance ___ ###

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, e

2020-08-17 Thread GitBox
xbkaishui commented on issue #5329: URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675239448 I want to try, please assign to me This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
wu-sheng commented on issue #5344: URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675238906 You could do anything you want. I just say, we don't have that concept. Why need APM in the tesr and dev env? Strange thing.

[GitHub] [skywalking] gyjx commented on issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
gyjx commented on issue #5344: URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675236166 Does SK not support service partitioning? Do I need to deploy three SK services? dev test pre This is an

[GitHub] [skywalking] wu-sheng commented on issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
wu-sheng commented on issue #5344: URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675235477 No, we don't have that. Management is not our agenda today. This is an automated message from the Apache Git

[GitHub] [skywalking] gyjx commented on issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
gyjx commented on issue #5344: URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675235260 I'm sorry, maybe I didn't make it clear. I mean, if I have three links: development, testing and pre release, but I just want to deploy a skywalking service, how will I divide it?

[GitHub] [skywalking] wu-sheng commented on issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
wu-sheng commented on issue #5344: URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675224138 What do you mean by how to access? We don't set any limitation for this. This is an automated message from the

[GitHub] [skywalking] wu-sheng closed issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
wu-sheng closed issue #5344: URL: https://github.com/apache/skywalking/issues/5344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] gyjx opened a new issue #5344: How to access the same skywalking service in multiple environments?

2020-08-17 Thread GitBox
gyjx opened a new issue #5344: URL: https://github.com/apache/skywalking/issues/5344 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [X ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] wu-sheng commented on issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

2020-08-17 Thread GitBox
wu-sheng commented on issue #5343: URL: https://github.com/apache/skywalking/issues/5343#issuecomment-675214918 6.4 is a very old version for the community. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng closed issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

2020-08-17 Thread GitBox
wu-sheng closed issue #5343: URL: https://github.com/apache/skywalking/issues/5343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

2020-08-17 Thread GitBox
wu-sheng commented on issue #5343: URL: https://github.com/apache/skywalking/issues/5343#issuecomment-675214806 Do you delete the templates? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations

2020-08-17 Thread GitBox
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-675214362 @kezhenxu94 Could you take a look the error? @BFergerson I think the key error is here,

[GitHub] [skywalking] pingliu opened a new issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

2020-08-17 Thread GitBox
pingliu opened a new issue #5343: URL: https://github.com/apache/skywalking/issues/5343 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or discussion - [X ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] ascrutae commented on pull request #5335: fix bug about webflux broken trace

2020-08-17 Thread GitBox
ascrutae commented on pull request #5335: URL: https://github.com/apache/skywalking/pull/5335#issuecomment-675213869 Got it! On Aug 18, 2020, 10:19 AM +0800, 吴晟 Wu Sheng , wrote: > @ascrutae I close this for now. Wait for your fix. > — > You are receiving this because you were

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5339: Add support for spring @Scheduled

2020-08-17 Thread GitBox
wu-sheng commented on a change in pull request #5339: URL: https://github.com/apache/skywalking/pull/5339#discussion_r471877418 ## File path: test/plugin/scenarios/spring-scheduled-scenario/config/expectedData.yaml ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software

[GitHub] [skywalking] wu-sheng closed pull request #5335: fix bug about webflux broken trace

2020-08-17 Thread GitBox
wu-sheng closed pull request #5335: URL: https://github.com/apache/skywalking/pull/5335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] wu-sheng commented on pull request #5335: fix bug about webflux broken trace

2020-08-17 Thread GitBox
wu-sheng commented on pull request #5335: URL: https://github.com/apache/skywalking/pull/5335#issuecomment-675210299 @ascrutae I close this for now. Wait for your fix. This is an automated message from the Apache Git

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

2020-08-17 Thread GitBox
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

[GitHub] [skywalking] hanahmily commented on a change in pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
hanahmily commented on a change in pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#discussion_r471810755 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -24,6 +24,12 @@ Alarm rule is constituted by following keys - **Exclude names**. The

[skywalking] branch labeled-alarm updated (3ec59c3 -> 04374d5)

2020-08-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch labeled-alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 3ec59c3 Merge branch 'master' into labeled-alarm add b8e5ff5 Remove Buffer redundant strategy

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

2020-08-17 Thread GitBox
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging

  1   2   3   4   >