[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5390: Support IN filter expressions in OAL

2020-08-26 Thread GitBox
codecov[bot] commented on pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr=h1) Report > Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5391: The OAP8.1 configuration SW_TRACE_SAMPLE_RATE does not take effect

2020-08-26 Thread GitBox
wu-sheng commented on issue #5391: URL: https://github.com/apache/skywalking/issues/5391#issuecomment-680780164 I don't know what is the difference, I don't remember anyone changed this. The dynamic configuration document is in the backend setup. If I remember correctly, the sampling rate

[GitHub] [skywalking] linliaoy commented on issue #5391: The OAP8.1 configuration SW_TRACE_SAMPLE_RATE does not take effect

2020-08-26 Thread GitBox
linliaoy commented on issue #5391: URL: https://github.com/apache/skywalking/issues/5391#issuecomment-680779291 It's true, it's not the same as when I used 6.6. There is also a way to dynamically configure the sampling rate, I can't find the documentation.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL

2020-08-26 Thread GitBox
wu-sheng commented on a change in pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#discussion_r477177573 ## File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4 ## @@ -61,6 +61,26 @@ SRC_PROFILE_TASK:

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #5392: skywalking kafka

2020-08-26 Thread GitBox
wu-sheng closed issue #5392: URL: https://github.com/apache/skywalking/issues/5392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5392: skywalking kafka

2020-08-26 Thread GitBox
wu-sheng commented on issue #5392: URL: https://github.com/apache/skywalking/issues/5392#issuecomment-680777995 Read the document. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] sunwen123 opened a new issue #5392: skywalking kafka

2020-08-26 Thread GitBox
sunwen123 opened a new issue #5392: URL: https://github.com/apache/skywalking/issues/5392 can we use kafka as apm collector This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng commented on issue #5391: The OAP8.1 configuration SW_TRACE_SAMPLE_RATE does not take effect

2020-08-26 Thread GitBox
wu-sheng commented on issue #5391: URL: https://github.com/apache/skywalking/issues/5391#issuecomment-680776996 Why shouldn't? We never said 1 == 100% sampling. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng closed issue #5391: The OAP8.1 configuration SW_TRACE_SAMPLE_RATE does not take effect

2020-08-26 Thread GitBox
wu-sheng closed issue #5391: URL: https://github.com/apache/skywalking/issues/5391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] linliaoy opened a new issue #5391: The OAP8.1 configuration SW_TRACE_SAMPLE_RATE does not take effect

2020-08-26 Thread GitBox
linliaoy opened a new issue #5391: URL: https://github.com/apache/skywalking/issues/5391 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support IN filter expressions in OAL

2020-08-26 Thread GitBox
arugal commented on a change in pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#discussion_r477173735 ## File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java ## @@ -18,18 +18,42 @@ package

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL

2020-08-26 Thread GitBox
wu-sheng commented on a change in pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#discussion_r477172997 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java ## @@ -23,6

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support in filter expressions in OAL

2020-08-26 Thread GitBox
wu-sheng commented on a change in pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#discussion_r477172393 ## File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4 ## @@ -61,6 +61,26 @@ SRC_PROFILE_TASK:

[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support in filter expressions in OAL

2020-08-26 Thread GitBox
arugal commented on a change in pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#discussion_r477172347 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java ## @@ -23,6

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support in filter expressions in OAL

2020-08-26 Thread GitBox
wu-sheng commented on a change in pull request #5390: URL: https://github.com/apache/skywalking/pull/5390#discussion_r477169957 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java ## @@ -23,6

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] arugal opened a new pull request #5390: Support in filter expressions in OAL

2020-08-26 Thread GitBox
arugal opened a new pull request #5390: URL: https://github.com/apache/skywalking/pull/5390 Support `in` expression and fix some question. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
codecov[bot] commented on pull request #5389: URL: https://github.com/apache/skywalking/pull/5389#issuecomment-68076 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=h1) Report > Merging [#5389](https://codecov.io/gh/apache/skywalking/pull/5389?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng opened a new pull request #5389: Provide TraceSegmentReportService#collectInSync service as the alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread GitBox
wu-sheng opened a new pull request #5389: URL: https://github.com/apache/skywalking/pull/5389 All discussion is tracked on #5358, this should resolve #5358. To all @apache/skywalking-committers, from my understanding, I still think all agents should keep using streaming as it is today.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[skywalking] branch sync-report created (now c2a0b90)

2020-08-26 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch sync-report in repository https://gitbox.apache.org/repos/asf/skywalking.git. at c2a0b90 Unary alternative to `TraceSegmentReportService.collect` This branch includes the following new

[skywalking] 01/01: Unary alternative to `TraceSegmentReportService.collect`

2020-08-26 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch sync-report in repository https://gitbox.apache.org/repos/asf/skywalking.git commit c2a0b9022352a71f1a830e42fdd737abcce4a1d9 Author: Wu Sheng AuthorDate: Wed Aug 26 16:53:11 2020 +0800

[skywalking-data-collect-protocol] branch master updated: Add a sync collecting service for trace report.

2020-08-26 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git The following commit(s) were added to refs/heads/master by this push: new cdd5861 Add a sync

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng merged pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
wu-sheng merged pull request #5386: URL: https://github.com/apache/skywalking/pull/5386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[skywalking] branch master updated: Use traceId as the judgment condition for sampling trace. (#5386)

2020-08-26 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 720c1dd Use traceId as the judgment

[GitHub] [skywalking] wu-sheng commented on issue #5388: When use zpkin receiver pulgin and mysql as backend storage, the oap can't start up

2020-08-26 Thread GitBox
wu-sheng commented on issue #5388: URL: https://github.com/apache/skywalking/issues/5388#issuecomment-680740889 We only said it works with the ES6. Nothing more. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng closed issue #5388: When use zpkin receiver pulgin and mysql as backend storage, the oap can't start up

2020-08-26 Thread GitBox
wu-sheng closed issue #5388: URL: https://github.com/apache/skywalking/issues/5388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] czs1993 opened a new issue #5388: When use zpkin receiver pulgin and mysql as backend storage, the oap can't start up

2020-08-26 Thread GitBox
czs1993 opened a new issue #5388: URL: https://github.com/apache/skywalking/issues/5388 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
wu-sheng commented on issue #5387: URL: https://github.com/apache/skywalking/issues/5387#issuecomment-680728949 We are impossible to test on your env. I just posted all test processes. Please take a look. There could be many factors and configurations to affect the result.

[GitHub] [skywalking] DerekHQ commented on issue #5387: SkyWalking 8.1.0, Mysql8.0, Table doesn't exist; Not to create table auto!

2020-08-26 Thread GitBox
DerekHQ commented on issue #5387: URL: https://github.com/apache/skywalking/issues/5387#issuecomment-680728129 Datasource Create is OK! 2020-08-26 15:53:24,945 - com.zaxxer.hikari.HikariDataSource - 80 [main] INFO [] - HikariPool-1 - Starting... 2020-08-26 15:53:26,019 -

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5386: Use traceId as the judgment condition for sampling trace.

2020-08-26 Thread GitBox
codecov[bot] edited a comment on pull request #5386: URL: https://github.com/apache/skywalking/pull/5386#issuecomment-680706113 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5386?src=pr=h1) Report > Merging

<    1   2   3   4   5   6   >