Re: [I] [Bug] [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on issue #11583: URL: https://github.com/apache/skywalking/issues/11583#issuecomment-1823901826 > 2\. wrapEmit(span, res, false): this line change to wrapEmit(span, res, false, 'end') , the trace log will be sent to skyworking too Can you send a pull request?

[I] [Bug] [skywalking]

2023-11-22 Thread via GitHub
aunsy-com opened a new issue, #11583: URL: https://github.com/apache/skywalking/issues/11583 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

(skywalking) branch kezhenxu94-patch-1 deleted (was e1190d61fd)

2023-11-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git was e1190d61fd Fix hardcoded module version The revisions that were on this branch are still

(skywalking) branch master updated: Fix hardcoded module version (#11582)

2023-11-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 5e97709c30 Fix hardcoded module version

Re: [PR] Fix hardcoded module version [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 merged PR #11582: URL: https://github.com/apache/skywalking/pull/11582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix hardcoded module version [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 opened a new pull request, #11582: URL: https://github.com/apache/skywalking/pull/11582 Follow up https://github.com/apache/skywalking/pull/11579 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number.

(skywalking) 01/01: Fix hardcoded module version

2023-11-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit e1190d61fd908c9fb4f09823cd8445411cd6fd1b Author: kezhenxu94 AuthorDate: Thu Nov 23 11:39:43 2023

(skywalking) branch kezhenxu94-patch-1 created (now e1190d61fd)

2023-11-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at e1190d61fd Fix hardcoded module version This branch includes the following new commits:

(skywalking) branch master updated: Fix a typo and missing key in doc (#11580)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 14fdb6fbd8 Fix a typo and missing key in

Re: [PR] Fix a typo and missing key in doc [skywalking]

2023-11-22 Thread via GitHub
wu-sheng merged PR #11580: URL: https://github.com/apache/skywalking/pull/11580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix a typo and missing key in doc [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 opened a new pull request, #11580: URL: https://github.com/apache/skywalking/pull/11580 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

Re: [PR] Combine banyand and bydbctl Dockerfile [skywalking-banyandb]

2023-11-22 Thread via GitHub
codecov-commenter commented on PR #356: URL: https://github.com/apache/skywalking-banyandb/pull/356#issuecomment-1823746445 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/356?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

(skywalking) branch config-dump deleted (was 311a3f0965)

2023-11-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git was 311a3f0965 Fix file header. The revisions that were on this branch are still contained in other

(skywalking) branch master updated: Support `Scratch The OAP Config Dump`. (#11579)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new dd09d08c0c Support `Scratch The OAP Config

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng merged PR #11579: URL: https://github.com/apache/skywalking/pull/11579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Combine banyand and bydbctl Dockerfile [skywalking-banyandb]

2023-11-22 Thread via GitHub
ButterBright opened a new pull request, #356: URL: https://github.com/apache/skywalking-banyandb/pull/356 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [x] Update the [`CHANGES`

(skywalking) branch config-dump updated (0b3dd4dfe8 -> 311a3f0965)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git from 0b3dd4dfe8 Make name consistent. add 311a3f0965 Fix file header. No new revisions were added by this

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on PR #11579: URL: https://github.com/apache/skywalking/pull/11579#issuecomment-1822839502 I updated the codes 1. Moved the config `keywords4MaskingSecretsOfConfig` to the `debugging-query-plugin`. 2. Removed `SW_DISABLE_CONFIG_DUMP`, as the module itself could be

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
github-actions[bot] commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402119150 ## oap-server/server-query-plugin/debugging-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingQueryConfig.java: ## @@ -0,0

(skywalking) branch config-dump updated (41044c983d -> 0b3dd4dfe8)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git from 41044c983d Fix add 0b3dd4dfe8 Make name consistent. No new revisions were added by this update.

(skywalking) branch config-dump updated (89855e8f2c -> 41044c983d)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git from 89855e8f2c Fix Licenses. add 41044c983d Fix No new revisions were added by this update. Summary of

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402083838 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -535,6 +539,10 @@ health-checker: default: checkIntervalSeconds:

(skywalking) branch config-dump updated: Fix Licenses.

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/config-dump by this push: new 89855e8f2c Fix Licenses.

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402079849 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -137,6 +137,10 @@ core: trainingPeriodHttpUriRecognitionPattern:

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on PR #11579: URL: https://github.com/apache/skywalking/pull/11579#issuecomment-1822803619 And as I mentioned at https://github.com/apache/skywalking/pull/11579#discussion_r1402062433, there should be more debugging relative APIs exposed. -- This is an automated

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on PR #11579: URL: https://github.com/apache/skywalking/pull/11579#issuecomment-1822799686 > Looks like the implementation doesn't take care the dynamic configurations at all, when a config key `K`'s default is `V` and is set to `V2` in dynamic configuration, the dump

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402068882 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -137,6 +137,10 @@ core: trainingPeriodHttpUriRecognitionPattern:

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402063642 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -535,6 +539,10 @@ health-checker: default: checkIntervalSeconds:

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402061808 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -535,6 +539,10 @@ health-checker: default: checkIntervalSeconds:

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402062433 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -137,6 +137,10 @@ core: trainingPeriodHttpUriRecognitionPattern:

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402061170 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -137,6 +137,10 @@ core: trainingPeriodHttpUriRecognitionPattern:

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402059363 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -137,6 +137,10 @@ core: trainingPeriodHttpUriRecognitionPattern:

(skywalking) branch config-dump updated (33b84543ee -> 46ede733b4)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git from 33b84543ee Fix config add 46ede733b4 Update

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
kezhenxu94 commented on code in PR #11579: URL: https://github.com/apache/skywalking/pull/11579#discussion_r1402053035 ## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java: ## @@ -224,6 +224,21 @@ public class CoreModuleConfig

(skywalking) branch config-dump updated: Fix config

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/config-dump by this push: new 33b84543ee Fix config 33b84543ee

Re: [PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng commented on PR #11579: URL: https://github.com/apache/skywalking/pull/11579#issuecomment-1822764614 The meaningful config dump ```shell > curl http://127.0.0.1:12800/debugging/config/dump cluster.provider=standalone core.provider=default

[PR] Support `Scratch The OAP Config Dump`. [skywalking]

2023-11-22 Thread via GitHub
wu-sheng opened a new pull request, #11579: URL: https://github.com/apache/skywalking/pull/11579 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

(skywalking) 01/01: Support `Scratch The OAP Config Dump`.

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 3208d74ac1a9fb5397a754bcf5fad2153ec2ec04 Author: Wu Sheng AuthorDate: Wed Nov 22 21:20:45 2023 +0800

(skywalking) branch config-dump created (now 3208d74ac1)

2023-11-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch config-dump in repository https://gitbox.apache.org/repos/asf/skywalking.git at 3208d74ac1 Support `Scratch The OAP Config Dump`. This branch includes the following new commits:

Re: [I] [Bug] intercept failure [skywalking]

2023-11-22 Thread via GitHub
huange7 commented on issue #10991: URL: https://github.com/apache/skywalking/issues/10991#issuecomment-1822554901 Hi, @wangbaobisheng . Looks like I'm having the same problem, how did you solve it? -- This is an automated message from the Apache Git Service. To respond to the message,