Re: [PR] Upgrate otel collector version [skywalking]

2024-01-22 Thread via GitHub
wankai123 commented on code in PR #11819: URL: https://github.com/apache/skywalking/pull/11819#discussion_r1462849297 ## test/e2e-v2/cases/apisix/otel-collector/docker-compose.yml: ## @@ -25,7 +25,7 @@ services: networks: e2e: otel-collector: -image: otel/open

[PR] Upgrate otel collector version [skywalking]

2024-01-22 Thread via GitHub
peachisai opened a new pull request, #11819: URL: https://github.com/apache/skywalking/pull/11819 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/ap

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462830222 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

Re: [PR] Add hierarchy relations auto-matching for MYSQL/POSTGRESQL/SO11Y_OAP/VIRTUAL_DATABASE. Fix MQE in dashboards when using `Card widget`. [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11818: URL: https://github.com/apache/skywalking/pull/11818#discussion_r1462829324 ## docs/en/changes/changes.md: ## @@ -40,6 +40,7 @@ * Update Kubernetes related UI templates for adapt data from eBPF access log. * Fix dashboard `K8S-Service-

Re: [PR] support class cache for ByteBuddy [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r1462699146 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java: ## @@ -0,0 +1,195 @@ +/* + * L

Re: [PR] Add hierarchy relations auto-matching for MYSQL/POSTGRESQL/SO11Y_OAP/VIRTUAL_DATABASE. Fix MQE in dashboards when using `Card widget`. [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11818: URL: https://github.com/apache/skywalking/pull/11818#discussion_r1462819955 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -11,12 +11,17 @@ There 2 ways to detect the connections: ### Automatically Matching -| Upper lay

Re: [PR] support class cache for ByteBuddy [skywalking]

2024-01-22 Thread via GitHub
revolyw commented on code in PR #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r1462815432 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java: ## @@ -0,0 +1,195 @@ +/* + * Li

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462794539 ## docs/en/setup/backend/backend-rocketmq-monitoring.md: ## @@ -0,0 +1,73 @@ +# RocketMQ monitoring + +SkyWalking leverages rocketmq-exporter for collecting metr

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905387750 > The Card Widget requires SINGLE_VALUE. Please check others UI templates. Done -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] Add hierarchy relations auto-matching for MYSQL/POSTGRESQL/SO11Y_OAP/VIRTUAL_DATABASE. Fix MQE in dashboards when using `Card widget`. [skywalking]

2024-01-22 Thread via GitHub
wankai123 opened a new pull request, #11818: URL: https://github.com/apache/skywalking/pull/11818 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs

Re: [PR] Bump up changes GHA to detect submodule changes [skywalking]

2024-01-22 Thread via GitHub
Superskyyy commented on PR #11772: URL: https://github.com/apache/skywalking/pull/11772#issuecomment-1905335127 The changes workflow needs to be approved for a specific commit by the asf admin. Otherwise it cannot run. 🥹 -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462720475 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

Re: [PR] Stream column-based storage [skywalking-banyandb]

2024-01-22 Thread via GitHub
hanahmily commented on code in PR #377: URL: https://github.com/apache/skywalking-banyandb/pull/377#discussion_r1462695433 ## banyand/stream/series_span.go: ## @@ -0,0 +1,62 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements

Re: [PR] support class cache for ByteBuddy [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r1462699146 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java: ## @@ -0,0 +1,195 @@ +/* + * L

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462696699 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

Re: [PR] support class cache for ByteBuddy [skywalking]

2024-01-22 Thread via GitHub
revolyw commented on code in PR #4858: URL: https://github.com/apache/skywalking/pull/4858#discussion_r1462696201 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/bytebuddy/CacheableTransformerDecorator.java: ## @@ -0,0 +1,195 @@ +/* + * Li

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462696138 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licen

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462694049 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licen

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462691943 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462691424 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462690607 ## docs/en/setup/backend/backend-rocketmq-monitoring.md: ## @@ -0,0 +1,73 @@ +# RocketMQ monitoring + +SkyWalking leverages rocketmq-exporter for collecting metri

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462676347 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/rocketmq/rocketmq-topic.json: ## @@ -0,0 +1,299 @@ +[ + { +"id": "RocketMQ-Topic",

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905223095 > Do we need a doc update to refer to new RocketMQ release? No, the personal repo was only used in the e2e. The docs do not mention the repo. -- This is an automated messa

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905214458 Do we need a doc update to refer to new RocketMQ release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905205135 > FYI, RocketMQ upstream is working on the release. > > Thread, https://lists.apache.org/thread/wp8nl4tmd3t15dlc8jb7kq07z1cv4qh0 The official image has been pulished,

(skywalking-java) branch main updated: Fix words (#669)

2024-01-22 Thread wankai
This is an automated email from the ASF dual-hosted git repository. wankai pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 822a73be6a Fix words (#669) 822a73be6a is d

(skywalking-java) branch wu-sheng-patch-1 deleted (was 3d68c9c310)

2024-01-22 Thread wankai
This is an automated email from the ASF dual-hosted git repository. wankai pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git was 3d68c9c310 Fix words The revisions that were on this branch are still contained in other reference

Re: [PR] Fix words [skywalking-java]

2024-01-22 Thread via GitHub
wankai123 merged PR #669: URL: https://github.com/apache/skywalking-java/pull/669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Stream column-based storage [skywalking-banyandb]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #377: URL: https://github.com/apache/skywalking-banyandb/pull/377#issuecomment-1905150514 Please fix the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix words [skywalking-java]

2024-01-22 Thread via GitHub
wu-sheng opened a new pull request, #669: URL: https://github.com/apache/skywalking-java/pull/669 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://githu

(skywalking-java) 01/01: Fix words

2024-01-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git commit 3d68c9c310a57c3c3068991791f7a7b71d995ddb Author: 吴晟 Wu Sheng AuthorDate: Tue Jan 23 09:47:35 2024 +0

(skywalking-java) branch wu-sheng-patch-1 created (now 3d68c9c310)

2024-01-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at 3d68c9c310 Fix words This branch includes the following new commits: new 3d68c9c310 Fix wor

Re: [I] [Feature] Support Service and Intance Hierarchy Relationship from Layer to Layer [skywalking]

2024-01-22 Thread via GitHub
wu-sheng closed issue #11615: [Feature] Support Service and Intance Hierarchy Relationship from Layer to Layer URL: https://github.com/apache/skywalking/issues/11615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Feature] Support Service and Intance Hierarchy Relationship from Layer to Layer [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on issue #11615: URL: https://github.com/apache/skywalking/issues/11615#issuecomment-1905112722 The kernel has been added. We will need to bundle more relationship step by step before the v10 release. -- This is an automated message from the Apache Git Service. To respo

(skywalking-php) branch dependabot/cargo/shlex-1.3.0 deleted (was 0927fde)

2024-01-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/cargo/shlex-1.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-php.git was 0927fde Bump shlex from 1.1.0 to 1.3.0 The revisions that were on this branch are

Re: [PR] Bump shlex from 1.1.0 to 1.3.0 [skywalking-php]

2024-01-22 Thread via GitHub
dependabot[bot] commented on PR #106: URL: https://github.com/apache/skywalking-php/pull/106#issuecomment-1905071185 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version

Re: [PR] Bump shlex from 1.1.0 to 1.3.0 [skywalking-php]

2024-01-22 Thread via GitHub
wu-sheng closed pull request #106: Bump shlex from 1.1.0 to 1.3.0 URL: https://github.com/apache/skywalking-php/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

(skywalking-php) branch dependabot/cargo/shlex-1.3.0 created (now 0927fde)

2024-01-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/cargo/shlex-1.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-php.git at 0927fde Bump shlex from 1.1.0 to 1.3.0 No new revisions were added by this update.

[PR] Bump shlex from 1.1.0 to 1.3.0 [skywalking-php]

2024-01-22 Thread via GitHub
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/skywalking-php/pull/106 Bumps [shlex](https://github.com/comex/rust-shlex) from 1.1.0 to 1.3.0. Changelog Sourced from https://github.com/comex/rust-shlex/blob/master/CHANGELOG.md";>shlex's changelog.

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
Fine0830 commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1904127945 This PR fixes the following bug https://github.com/apache/skywalking-booster-ui/assets/20871783/f0026f08-cd02-4546-b921-425bd5e29d7d -- This is an automated

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
CzyerChen commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1904096070 > @CzyerChen This fix is about resizing. What is the cause at your side? At my side, I see the trace-list-download svg initial height depends on the span count and

Re: [I] [Bug] Booster-UI d3 trace graph is incomplete [skywalking]

2024-01-22 Thread via GitHub
wu-sheng closed issue #11809: [Bug] Booster-UI d3 trace graph is incomplete URL: https://github.com/apache/skywalking/issues/11809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

(skywalking-booster-ui) branch main updated: fix: resizing window causes the trace graph to display incorrectly (#367)

2024-01-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 7aef327d fix: resizing window causes

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
wu-sheng merged PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
Fine0830 commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1904072379 The bug is easy to reproduce in the `demo` env. Actually, this is not related to the data. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [I] Observability Of Kubernetes Some indicators do not have data [skywalking]

2024-01-22 Thread via GitHub
wu-sheng closed issue #11815: Observability Of Kubernetes Some indicators do not have data URL: https://github.com/apache/skywalking/issues/11815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] Observability Of Kubernetes Some indicators do not have data [skywalking]

2024-01-22 Thread via GitHub
5279314 opened a new issue, #11815: URL: https://github.com/apache/skywalking/issues/11815 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

Re: [PR] Stream column-based storage [skywalking-banyandb]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #377: URL: https://github.com/apache/skywalking-banyandb/pull/377#issuecomment-1904017020 Please resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1904015730 Such as, whether the list at the left side(segment list), or some other things limit the height? Or make the vertical scrolling bar doesn't work as expected? -- This is a

[PR] Stream column-based storage [skywalking-banyandb]

2024-01-22 Thread via GitHub
ButterBright opened a new pull request, #377: URL: https://github.com/apache/skywalking-banyandb/pull/377 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11474. - [x] Update the [`CHANGES` log](

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1904006769 @CzyerChen This fix is about resizing. What is the cause at your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
Fine0830 commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1903655123 Please check if it is the latest code, it works on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

(skywalking-website) branch asf-site updated: deploy: fe0471f578a9a1fae0f184d69a384e4680aa5aa5

2024-01-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 245d47c3692 deploy: fe0471f5

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
CzyerChen commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1903619135 I tried by changing the initial height of svg, then the full image can displayed. https://github.com/apache/skywalking-booster-ui/assets/22817918/9c7283f7-fe6d-4709-bebe-

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
CzyerChen commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1903611655 > @CzyerChen Could you check this? In my case , data: ``` { "data": { "trace": { "spans": [ { "traceId": "dd4b956

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
CzyerChen commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1903554696 > @CzyerChen Could you check this? ok, I'll validate this version. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] fix: resizing window causes the trace graph to display incorrectly [skywalking-booster-ui]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #367: URL: https://github.com/apache/skywalking-booster-ui/pull/367#issuecomment-1903546892 @CzyerChen Could you check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go