[PR] fix: remove click event after unmounted [skywalking-booster-ui]

2024-02-20 Thread via GitHub
zhourunjie1988 opened a new pull request, #372: URL: https://github.com/apache/skywalking-booster-ui/pull/372 The _handleClick_ function calls the _stopPropagation_, so we'd better remove the click events after component unmounted to prevent potential problems, such as adding click events

(skywalking-website) branch fix-kapa-again-htaccess updated (fdb55c54a1a -> 8ab7a94f3e2)

2024-02-20 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a change to branch fix-kapa-again-htaccess in repository https://gitbox.apache.org/repos/asf/skywalking-website.git from fdb55c54a1a Try if config.toml works add 8ab7a94f3e2 Fix No new revisions were

Re: [PR] Try if config.toml works [skywalking-website]

2024-02-20 Thread via GitHub
netlify[bot] commented on PR #680: URL: https://github.com/apache/skywalking-website/pull/680#issuecomment-1955998680 ###  Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit |

[PR] Try if config.toml works [skywalking-website]

2024-02-20 Thread via GitHub
Superskyyy opened a new pull request, #680: URL: https://github.com/apache/skywalking-website/pull/680 Maybe this will work https://www.byteinthesky.com/tutorials/adding-content-security-policy-to-hugo-site/#hugo-configuration-file -- This is an automated message from the Apache Git

(skywalking-website) branch fix-kapa-again-htaccess updated: Try if config.toml works

2024-02-20 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a commit to branch fix-kapa-again-htaccess in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/fix-kapa-again-htaccess by this push:

(skywalking-website) branch fix-kapa-again-htaccess created (now 1f5ccd7267a)

2024-02-20 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a change to branch fix-kapa-again-htaccess in repository https://gitbox.apache.org/repos/asf/skywalking-website.git at 1f5ccd7267a Remove trailing slash (#679) No new revisions were added by this update.

(skywalking-go) annotated tag v0.4.0 updated (6426060 -> 214966c)

2024-02-20 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag v0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag v0.4.0 was modified! *** from 6426060 (commit) to 214966c (tag) tagging

(skywalking-go) annotated tag toolkit/v0.4.0 updated (6426060 -> 5ec35e0)

2024-02-20 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.4.0 was modified! *** from 6426060 (commit) to 5ec35e0 (tag)

Re: [PR] Update Changes for ready release 0.4.0 [skywalking-go]

2024-02-20 Thread via GitHub
mrproliu merged PR #171: URL: https://github.com/apache/skywalking-go/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-go) branch main updated: Update Changes for ready release 0.4.0 (#171)

2024-02-20 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 6426060 Update Changes for ready release

Re: [I] [Feature] Support OTEL Android monitoring [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on issue #11657: URL: https://github.com/apache/skywalking/issues/11657#issuecomment-1955905978 Please follow [SWIP](https://skywalking.apache.org/docs/main/next/en/swip/readme/) to write the proposal. Notice, as this is new, we need you to provide details as much

Re: [I] [Feature] Support OTEL Android monitoring [skywalking]

2024-02-20 Thread via GitHub
ro4i7 commented on issue #11657: URL: https://github.com/apache/skywalking/issues/11657#issuecomment-1955904349 I wanna work on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Update Changes for ready release 0.4.0 [skywalking-go]

2024-02-20 Thread via GitHub
mrproliu opened a new pull request, #171: URL: https://github.com/apache/skywalking-go/pull/171 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Feature] Expose traceId in PHP for Enhanced Observability [skywalking]

2024-02-20 Thread via GitHub
wu-sheng closed issue #11885: [Feature] Expose traceId in PHP for Enhanced Observability URL: https://github.com/apache/skywalking/issues/11885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(skywalking-php) branch master updated: Inject skywalking context. (#107)

2024-02-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-php.git The following commit(s) were added to refs/heads/master by this push: new c23e76a Inject skywalking context.

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
wu-sheng merged PR #107: URL: https://github.com/apache/skywalking-php/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955728454 > > > $spanId should not be for the entire request, right? > > > > > > It is not. It is variable according to span creation and stop status. > > I would like to

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955725165 > > $spanId should not be for the entire request, right? > > It is not. It is variable according to span creation and stop status. I would like to implement $spanId in the

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955716258 > > How about $spanId? > > $spanId should not be for the entire request, right? It is not. It is variable according to span creation and stop status. -- This is an

Re: [I] [Feature] skywalking-client-js supports Core Web Vitals metrics [skywalking]

2024-02-20 Thread via GitHub
wu-sheng closed issue #11902: [Feature] skywalking-client-js supports Core Web Vitals metrics URL: https://github.com/apache/skywalking/issues/11902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955693441 > How about $spanId? $spanId should not be for the entire request, right? -- This is an automated message from the Apache Git Service. To respond to the message, please

[I] [Feature] skywalking-client-js supports Core Web Vitals metrics [skywalking]

2024-02-20 Thread via GitHub
tanshanshan opened a new issue, #11902: URL: https://github.com/apache/skywalking/issues/11902 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954215353 You could sync the UI submodule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954206722 @peachisai I think this is only about translation. The UI should work without this, right? -- This is an automated message from the Apache Git Service. To respond to the

(skywalking-booster-ui) branch main updated: Update i18n for rocketmq monitoring (#359)

2024-02-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 73420366 Update i18n for rocketmq

Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]

2024-02-20 Thread via GitHub
wu-sheng merged PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]

2024-02-20 Thread via GitHub
peachisai commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954213885 > Update i18n for rocketmq monitoring Yes,I just remenber it -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add a new menu for rocketmq monitoring [skywalking-booster-ui]

2024-02-20 Thread via GitHub
peachisai commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954203392 @wu-sheng Hello, Should this be mentioned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954159953 > @peachisai Are you working on the showcase or the blog? @wankai123 Should we consider this as a part of showcase? Or the showcase is already too complex? Yes, I have tried

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954131649 OK. But I think we should be careful about whether activate this on the demo.skywalking.a.o. We have a heavy resource requirement of CPU and Memory already. -- This is an

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
wankai123 commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954129406 > Should we consider this as a part of showcase? Or the showcase is already too complex? The rocketMQ monitoring could be added to the `ShowCase` first, this part is not

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1954108830 And please update the docs according, after you added the span ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954072644 @peachisai Are you working on the showcase or the blog? @wankai123 Should we consider this as a part of showcase? Or the showcase is already too complex? -- This is an automated

Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]

2024-02-20 Thread via GitHub
wu-sheng merged PR #11901: URL: https://github.com/apache/skywalking/pull/11901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking) branch master updated: Mock `/api/v1/status/buildinfo` for PromQL API (#11901)

2024-02-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new a41bd6eddd Mock `/api/v1/status/buildinfo`

Re: [I] [Feature] Implement parts of Prometheus `status` HTTP API [skywalking]

2024-02-20 Thread via GitHub
wu-sheng closed issue #11714: [Feature] Implement parts of Prometheus `status` HTTP API URL: https://github.com/apache/skywalking/issues/11714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-195384 > > Should we consider the whole trace context? > > $serviceName, $instanceName, $traceId, $traceSegmentId are injected. How about $spanId? -- This is an automated

Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on code in PR #11901: URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495533200 ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/PromQLConfig.java: ## @@ -31,4 +31,12 @@ public class

Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on code in PR #11901: URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495531905 ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/PromQLConfig.java: ## @@ -31,4 +31,12 @@ public class

Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on code in PR #11901: URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495531006 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -443,6 +443,13 @@ promql: restMaxThreads: ${SW_PROMQL_REST_MAX_THREADS:200}

(skywalking-go) branch main updated: fix sql instrument with DBQueryContext (#168)

2024-02-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 140c58d fix sql instrument with

Re: [PR] fix sql instrument with DBQueryContext [skywalking-go]

2024-02-20 Thread via GitHub
wu-sheng merged PR #168: URL: https://github.com/apache/skywalking-go/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Inject skywalking context. [skywalking-php]

2024-02-20 Thread via GitHub
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1953830055 > Should we consider the whole trace context? $serviceName, $instanceName, $traceId, $traceSegmentId are injected. -- This is an automated message from the Apache Git Service.

Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on code in PR #11901: URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495424254 ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/entity/BuildInfo.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed

[PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]

2024-02-20 Thread via GitHub
wankai123 opened a new pull request, #11901: URL: https://github.com/apache/skywalking/pull/11901 - [X] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #11714. - [X] Update the [`CHANGES`