Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-09 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2046518883 Pending on OTEL side discussion, as I want to keep the whole context continuous. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix unexpected 'decode' AttributeError when MySQLdb module is mapped by PyMySQL [skywalking-python]

2024-04-09 Thread via GitHub
Superskyyy commented on PR #336: URL: https://github.com/apache/skywalking-python/pull/336#issuecomment-2046238790 Ok I will take a look thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
wu-sheng merged PR #431: URL: https://github.com/apache/skywalking-banyandb/pull/431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-banyandb) branch main updated: docs: generate protobuf api before bydbctl build (#431)

2024-04-09 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 9aff13b5 docs: generate protobuf api

Re: [PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
wu-sheng commented on code in PR #431: URL: https://github.com/apache/skywalking-banyandb/pull/431#discussion_r1557466974 ## bydbctl/README.md: ## @@ -5,5 +5,8 @@ ## Build ``` +# If you haven't generated the API code yet +make -C ../api generate + Review Comment: Then

Re: [PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
wu-sheng commented on code in PR #431: URL: https://github.com/apache/skywalking-banyandb/pull/431#discussion_r1557466974 ## bydbctl/README.md: ## @@ -5,5 +5,8 @@ ## Build ``` +# If you haven't generated the API code yet +make -C ../api generate + Review Comment: Then

Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]

2024-04-09 Thread via GitHub
junit commented on issue #12040: URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2044752105 Have you solved it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
qazxcdswe123 commented on code in PR #431: URL: https://github.com/apache/skywalking-banyandb/pull/431#discussion_r1557414044 ## bydbctl/README.md: ## @@ -5,5 +5,8 @@ ## Build ``` +# If you haven't generated the API code yet +make -C ../api generate + Review Comment:

Re: [PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
qazxcdswe123 commented on code in PR #431: URL: https://github.com/apache/skywalking-banyandb/pull/431#discussion_r1557414044 ## bydbctl/README.md: ## @@ -5,5 +5,8 @@ ## Build ``` +# If you haven't generated the API code yet +make -C ../api generate + Review Comment:

Re: [PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
wu-sheng commented on code in PR #431: URL: https://github.com/apache/skywalking-banyandb/pull/431#discussion_r1557317830 ## bydbctl/README.md: ## @@ -5,5 +5,8 @@ ## Build ``` +# If you haven't generated the API code yet +make -C ../api generate + Review Comment: Do we

[PR] docs: generate protobuf api before bydbctl build [skywalking-banyandb]

2024-04-09 Thread via GitHub
qazxcdswe123 opened a new pull request, #431: URL: https://github.com/apache/skywalking-banyandb/pull/431 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [x] Update the [`CHANGES`

(skywalking) branch master updated: Bump up dependencies to fix CVEs (#12080)

2024-04-09 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new c79423c358 Bump up dependencies to fix

Re: [PR] Bump up dependencies to fix CVEs [skywalking]

2024-04-09 Thread via GitHub
wu-sheng merged PR #12080: URL: https://github.com/apache/skywalking/pull/12080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix unexpected 'decode' AttributeError when MySQLdb module is mapped by PyMySQL [skywalking-python]

2024-04-09 Thread via GitHub
wu-sheng commented on PR #336: URL: https://github.com/apache/skywalking-python/pull/336#issuecomment-2044465617 @kezhenxu94 Please take a look. We also have some CIs fail, but should be irrelevant. We may need some fixes first. -- This is an automated message from the Apache Git

Re: [PR] Bump up dependencies to fix CVEs [skywalking]

2024-04-09 Thread via GitHub
wu-sheng commented on code in PR #12080: URL: https://github.com/apache/skywalking/pull/12080#discussion_r1557221753 ## dist-material/release-docs/LICENSE: ## @@ -615,6 +618,14 @@ The text of each license is also included in licenses/LICENSE-[project].txt.

Re: [PR] Bump up dependencies to fix CVEs [skywalking]

2024-04-09 Thread via GitHub
wu-sheng commented on code in PR #12080: URL: https://github.com/apache/skywalking/pull/12080#discussion_r1557218487 ## dist-material/release-docs/LICENSE: ## @@ -615,6 +618,14 @@ The text of each license is also included in licenses/LICENSE-[project].txt.

Re: [PR] Fix unexpected 'decode' AttributeError when MySQLdb module is mapped by PyMySQL [skywalking-python]

2024-04-09 Thread via GitHub
wu-sheng commented on PR #336: URL: https://github.com/apache/skywalking-python/pull/336#issuecomment-2044383561 And you should follow PR template to `Update the CHANGELOG.md.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fix unexpected 'decode' AttributeError when MySQLdb module is mapped by PyMySQL [skywalking-python]

2024-04-09 Thread via GitHub
wu-sheng commented on PR #336: URL: https://github.com/apache/skywalking-python/pull/336#issuecomment-2044336520 Please fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix unexpected 'decode' AttributeError when MySQLdb module is mapped by PyMySQL [skywalking-python]

2024-04-09 Thread via GitHub
ZEALi opened a new pull request, #336: URL: https://github.com/apache/skywalking-python/pull/336 In some use cases, `pymysql.install_as_MySQLdb()` will be used to initialize a 'fake' MySQLdb module, which is actually mapped to pymysql module. Unfortunately, sw_mysqlclient plugin

Re: [PR] Add Apache Airflow Monitoring [skywalking]

2024-04-09 Thread via GitHub
wu-sheng commented on PR #12072: URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2044327249 FYI @songzhendong We will update the MAL implementation for https://github.com/apache/skywalking/issues/11992. Then UI side will update to support multiple-label tags as well.