Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
wu-sheng commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2053479322 I don't think e2e tool works. But at least, we could have compiling passed on Windows CI. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
Superskyyy commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2053472512 One can add windows Github action to the .github workflows, just I'm not sure if our e2e pipeline can work on windows. -- This is an automated message from the Apache Git

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
ShyunnY commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2052042749 @wu-sheng Sorry, since this is my first time participating in a `skywalking` project, I may not be familiar with the `skywalking` style, but today I understand it.

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
wu-sheng commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2052018054 You could use one PR to fix two issues, which is fine. The expectation in SkyWalking is, we prefer PR resolves known relative issues once for all. -- This is an automated

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
wu-sheng commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2052016475 To be honest, as you are fixing Windows compiling, the new resolved issue should be fixed as well. And this PR has CI pipeline failing, which can't be merged by anyone, and

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
ShyunnY commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2051951867 cc @wu-sheng Hello! When I was fixing [issue](https://github.com/apache/skywalking/issues/12068), I found that go-agent had other problems, which made it impossible to carry

[I] [Bug] Go-agent hybrid compilation under Windows platform cannot copy source files correctly [skywalking]

2024-04-12 Thread via GitHub
ShyunnY opened a new issue, #12097: URL: https://github.com/apache/skywalking/issues/12097 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

(skywalking-website) branch eye060 deleted (was 5390ef8c73e)

2024-04-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch eye060 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git was 5390ef8c73e Release license-eye 0.6.0 The revisions that were on this branch are still contained in

(skywalking-website) branch master updated: Release license-eye 0.6.0 (#698)

2024-04-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 7d161f169ae Release license-eye

Re: [PR] Release license-eye 0.6.0 [skywalking-website]

2024-04-12 Thread via GitHub
wu-sheng merged PR #698: URL: https://github.com/apache/skywalking-website/pull/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Release license-eye 0.6.0 [skywalking-website]

2024-04-12 Thread via GitHub
netlify[bot] commented on PR #698: URL: https://github.com/apache/skywalking-website/pull/698#issuecomment-2051691717 ###  Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit |

(skywalking-website) branch eye060 created (now 5390ef8c73e)

2024-04-12 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch eye060 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git at 5390ef8c73e Release license-eye 0.6.0 This branch includes the following new commits: new

[PR] Release license-eye 0.6.0 [skywalking-website]

2024-04-12 Thread via GitHub
kezhenxu94 opened a new pull request, #698: URL: https://github.com/apache/skywalking-website/pull/698 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(skywalking-website) 01/01: Release license-eye 0.6.0

2024-04-12 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch eye060 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git commit 5390ef8c73eb8ff1c6d84e9708b0ce5fb521a323 Author: kezhenxu94 AuthorDate: Fri Apr 12 20:43:31 2024 +0800

(skywalking) branch master updated: Aggregate nginx service metrics by using `multiple labels` feature & Remove unused type label in latency metrics. (#12096)

2024-04-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 7a6a19db7f Aggregate nginx service metrics

Re: [PR] Fix inaccuracy nginx service metrics. [skywalking]

2024-04-12 Thread via GitHub
wu-sheng merged PR #12096: URL: https://github.com/apache/skywalking/pull/12096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]

2024-04-12 Thread via GitHub
wu-sheng closed issue #11982: [Bug] Metrics are not aggregated properly as OTEL collector targeting per node URL: https://github.com/apache/skywalking/issues/11982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(skywalking-booster-ui) branch main updated: fix: remove unused configurations (#386)

2024-04-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 62eb054f fix: remove unused

Re: [PR] fix: remove unused configurations [skywalking-booster-ui]

2024-04-12 Thread via GitHub
wu-sheng merged PR #386: URL: https://github.com/apache/skywalking-booster-ui/pull/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix: remove unused configurations [skywalking-booster-ui]

2024-04-12 Thread via GitHub
Fine0830 opened a new pull request, #386: URL: https://github.com/apache/skywalking-booster-ui/pull/386 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] chore: enhance makefile [skywalking-go]

2024-04-12 Thread via GitHub
mrproliu merged PR #180: URL: https://github.com/apache/skywalking-go/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-go) branch main updated: chore: enhance makefile (#180)

2024-04-12 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new a3ad846 chore: enhance makefile (#180)

Re: [PR] Fix inaccuracy nginx service metrics. [skywalking]

2024-04-12 Thread via GitHub
weixiang1862 commented on PR #12096: URL: https://github.com/apache/skywalking/pull/12096#issuecomment-2051206116 service metrics: ![image](https://github.com/apache/skywalking/assets/16346644/d0718150-f90d-455c-bd02-a4e287e567a9) instance1 metrics:

[PR] Fix inaccuracy nginx service metrics. [skywalking]

2024-04-12 Thread via GitHub
weixiang1862 opened a new pull request, #12096: URL: https://github.com/apache/skywalking/pull/12096 ### Fix inaccuracy nginx service metrics. - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it.

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
ShyunnY commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2051087415 Block -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix: hybird compilation issue on windows [skywalking-go]

2024-04-12 Thread via GitHub
mrproliu commented on PR #179: URL: https://github.com/apache/skywalking-go/pull/179#issuecomment-2051039874 Could you help to add some screenshot in here? @ShyunnY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the