Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
wu-sheng merged PR #12109: URL: https://github.com/apache/skywalking/pull/12109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: panic happens when reporter init failed [skywalking-go]

2024-04-17 Thread via GitHub
aquarkgn commented on PR #123: URL: https://github.com/apache/skywalking-go/pull/123#issuecomment-2062950563 这个问题有可能是因为导入 `_ "github.com/apache/skywalking-go"` 之前进行了日志打印, 原因可能是skywalking-go-agent命令在执行日志上报时发现skywalking-go包还没有初始化。 以我自己的为例,我将日志打印放在了初始化中,会立即遇到空指针报错。 ``` package

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
CzyerChen commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1569897215 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/activemq/activemq-broker.json: ## @@ -0,0 +1,355 @@ +[ +{ +"id":

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
CzyerChen commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1569897215 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/activemq/activemq-broker.json: ## @@ -0,0 +1,355 @@ +[ +{ +"id":

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
wankai123 commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2062929692 The others are LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]

2024-04-17 Thread via GitHub
wu-sheng closed issue #11982: [Bug] Metrics are not aggregated properly as OTEL collector targeting per node URL: https://github.com/apache/skywalking/issues/11982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(skywalking) branch master updated: Fix inaccurate MongoDB Metrics & Add label for complex MQE in Nginx dashboard. (#12126)

2024-04-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new d71f858f2f Fix inaccurate MongoDB Metrics

Re: [PR] Fix inaccurate MongoDB Metrics & Add label for complex MQE in Nginx dashboard. [skywalking]

2024-04-17 Thread via GitHub
wu-sheng merged PR #12126: URL: https://github.com/apache/skywalking/pull/12126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
wankai123 commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1569865141 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/activemq/activemq-broker.json: ## @@ -0,0 +1,355 @@ +[ +{ +"id":

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
CzyerChen commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1569864332 ## test/e2e-v2/cases/activemq/docker-compose.yml: ## @@ -0,0 +1,100 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
CzyerChen commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1569841126 ## docs/en/setup/backend/backend-activemq-monitoring.md: ## @@ -0,0 +1,105 @@ +# ActiveMQ classic monitoring + +SkyWalking leverages jmx prometheus exporter for

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
wu-sheng commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2062868091 Yes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2062867772 > I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. And I found the Nginx dashboards have

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 commented on code in PR #12126: URL: https://github.com/apache/skywalking/pull/12126#discussion_r1569806890 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mongodb/mongodb-cluster.json: ## @@ -231,7 +232,7 @@

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
wu-sheng commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1569798133 ## docs/en/setup/backend/backend-activemq-monitoring.md: ## @@ -0,0 +1,105 @@ +# ActiveMQ classic monitoring + +SkyWalking leverages jmx prometheus exporter for

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
wankai123 commented on code in PR #12126: URL: https://github.com/apache/skywalking/pull/12126#discussion_r1569747463 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mongodb/mongodb-cluster.json: ## @@ -231,7 +232,7 @@

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2061329463 > I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. > And I found the Nginx dashboards

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
wankai123 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2061285245 I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. And I found the Nginx dashboards have

Re: [I] logstash logback plugin get tid is "TID:N/A" [skywalking]

2024-04-17 Thread via GitHub
qlanto224 commented on issue #5746: URL: https://github.com/apache/skywalking/issues/5746#issuecomment-2061058028 > 解决了 > > ``` > > ${logging.logstash} > > > > > UTC >

[PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 opened a new pull request, #12126: URL: https://github.com/apache/skywalking/pull/12126 ### Fix inaccurate MongoDB Metrics - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. - [x]

Re: [I] [Bug] Data truncation: Data too long for column 'alarm_message' 'message' [skywalking]

2024-04-17 Thread via GitHub
ibingdian commented on issue #11325: URL: https://github.com/apache/skywalking/issues/11325#issuecomment-2060570910 > > > > > It seems that the number of bytes you wrote exceeds the field length. > > I understand the cause of the error, I just wanted to know if it can be

[I] [Feature] MQE support `sort/sort_labels` functions. [skywalking]

2024-04-17 Thread via GitHub
wankai123 opened a new issue, #12121: URL: https://github.com/apache/skywalking/issues/12121 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

Re: [PR] Add ActiveMQ classic monitoring [skywalking]

2024-04-17 Thread via GitHub
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060489465 OK, @wankai123 Let us skip that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the