This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new 0bf535e861 Fix TracingSegmentRunner (testi
wu-sheng merged PR #688:
URL: https://github.com/apache/skywalking-java/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
wu-sheng commented on PR #688:
URL: https://github.com/apache/skywalking-java/pull/688#issuecomment-2106099397
> Now I think all cleanup and teardown could work correctly, the code LGTM,
thanks @JoeCqupt for your attentive discovery and don't forget to update
CHANGES, let's wait for other t
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new 7dd7914765 Add pool metrics support for
D
wu-sheng closed issue #12207: [Feature] Add URLParser for
Derby/Sybase/SQLite/DB2/OceanBase
URL: https://github.com/apache/skywalking/issues/12207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wu-sheng merged PR #687:
URL: https://github.com/apache/skywalking-java/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
wu-sheng commented on PR #687:
URL: https://github.com/apache/skywalking-java/pull/687#issuecomment-2105737714
@CzyerChen You added RocketMQ plugin test, right? I noticed, it is unstable
for various PRs. Could you check the CI logs?
--
This is an automated message from the Apache Git Serv
wu-sheng commented on code in PR #95:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597441444
##
MODULE.bazel:
##
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
wu-sheng commented on code in PR #95:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597414568
##
MODULE.bazel:
##
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
mmorel-35 commented on code in PR #95:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r159741
##
MODULE.bazel:
##
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
wu-sheng commented on code in PR #95:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597414322
##
MODULE.bazel:
##
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
mmorel-35 commented on code in PR #95:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597413956
##
MODULE.bazel:
##
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
wu-sheng commented on code in PR #95:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597413418
##
MODULE.bazel:
##
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
CodePrometheus commented on PR #688:
URL: https://github.com/apache/skywalking-java/pull/688#issuecomment-2105638556
I think
`org.apache.skywalking.apm.agent.core.test.tools.TracingSegmentRunner#withAfters`
also needs to be modified.
--
This is an automated message from the Apache Git Se
mmorel-35 opened a new pull request, #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95
I pushed
[skywalking-data-collect-protocol@9.7.0](https://github.com/bazelbuild/bazel-central-registry/pull/1671)
in the BCR.
This provide the MODULE and patchprovided th
lujiajing1126 commented on PR #688:
URL: https://github.com/apache/skywalking-java/pull/688#issuecomment-2105635384
Nice catch. But you have to verify all test cases work as expected. I notice
we've declared many `cleanup`s or `teardown`s. But they are actually not
running at all.
--
Thi
JoeCqupt opened a new pull request, #688:
URL: https://github.com/apache/skywalking-java/pull/688
### Fix
- [ ] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
TracingSegmentRunner override method withAfters made Jun
JoeCqupt opened a new issue, #12210:
URL: https://github.com/apache/skywalking/issues/12210
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
CzyerChen commented on code in PR #687:
URL: https://github.com/apache/skywalking-java/pull/687#discussion_r1597388878
##
docs/en/setup/service-agent/java-agent/Supported-list.md:
##
@@ -172,6 +172,21 @@ The meter plugin provides the advanced metrics
collections, which are not
wu-sheng commented on code in PR #687:
URL: https://github.com/apache/skywalking-java/pull/687#discussion_r1597388364
##
docs/en/setup/service-agent/java-agent/Supported-list.md:
##
@@ -172,6 +172,21 @@ The meter plugin provides the advanced metrics
collections, which are not a
20 matches
Mail list logo
