Almot77 commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109322821
Okay, i'l test it now.
We use php application in docker + sw php libay for trace collecting +
grafana dashboards (made from sw examples for grafana)
--
This is an
Almot77 commented on PR #445:
URL:
https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109320331
Okay, i'l test it now.
We use php application in docker + sw php libay for trace collecting +
grafana dashboards (made from sw examples for grafana)
--
This is an
CzyerChen commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109206083
> I can see RocketMQ case fails again.
OK，I will check RocketMQ case first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
wu-sheng commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109188070
I reopened this as we don't know gow this happens.
@Almot77 We will need more, could you package the whole data folder to us,
then we could address what is the illegal
hanahmily commented on PR #445:
URL:
https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109168664
> Will we cherry-pick this commit to v0.6.x?
I prefer waiting for 24 hours for future feedback on the error, and
regardless of the result, a new patch is necessary.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
was c023b1ab Update change log
The revisions that were on this branch are still contained in
other
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new c8270670 Fix topn query nil and add
wu-sheng closed issue #12219: [Bug] SIGSEGV: segmentation violation in
banyand/query.(*topNQueryProcessor).Rev.func1()
URL: https://github.com/apache/skywalking/issues/12219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wu-sheng merged PR #445:
URL: https://github.com/apache/skywalking-banyandb/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wu-sheng commented on PR #445:
URL:
https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109152626
> Will we cherry-pick this commit to v0.6.x?
It depends on why this happens. If this is blocking the general use, we
should have 0.6.1. Otherwise, it is not in urgent.
lujiajing1126 commented on PR #445:
URL:
https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109147544
Will we cherry-pick this commit to v0.6.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
from 01a270cd Fix license
add c023b1ab Update change log
No new revisions were added by this
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
from 58d9aaf3 Fix topn query nil and add more context to err
add 01a270cd Fix license
No new
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to annotated tag v0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
*** WARNING: tag v0.2.0 was modified! ***
from 5c073c1 (commit)
to a402dd8 (tag)
hanahmily commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109036234
The nil error is fixed by
https://github.com/apache/skywalking-banyandb/pull/445/files#diff-695073ea8dec3fcdaae77a3fcfb4eabc7290daade34399aee1de42d7b476R124
But
wu-sheng commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109032259
This error is easy to fix, @Almot77 but we want to know how you could
trigger it, as we have run many tests to verify features.
--
This is an automated message from the
hanahmily opened a new pull request, #445:
URL: https://github.com/apache/skywalking-banyandb/pull/445
- [x] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Fixes apache/skywalking#12219.
- [ ] Update the [`CHANGES`
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 58d9aaf3ebdf9a9fad381009683c1d5c9250d27e
Author: Gao Hongtao
AuthorDate: Tue May 14 07:55:44 2024
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
discard a3464aff Fix topn query nil and add more context to err
new 58d9aaf3 Fix topn query nil and
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit a3464aff95e673a89bf0af4a48843b76094ec15c
Author: Gao Hongtao
AuthorDate: Tue May 14 07:55:44 2024
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
at a3464aff Fix topn query nil and add more context to err
This branch includes the following new
wu-sheng commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109013133
Are you using docker quick start? We haven't upgraded it to latest. It needs
v10 oap and latest banyandb 0.6.
--
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to annotated tag v0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
*** WARNING: tag v0.2.0 was deleted! ***
tag was 2ebb393
The revisions that were on this
Almot77 commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108659386
> Your configuration is not well formatted. Please correct them. And what
does `SW_STORAGE: elasticsearch` mean? I think we don't need Elasticsearch when
you use BanyanDB.
>
prostocvet commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108655703
> s/bus.go:270 +
It`s docker-compose file to run SW with selected db profile: elastic or
banyandb.
right way to run it:
docker compose --profile banyandb up -d
JoeCqupt commented on PR #690:
URL: https://github.com/apache/skywalking-java/pull/690#issuecomment-2108081345
after i clear my .m2/repository dir. then everything is all right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wu-sheng commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108057982
@lujiajing1126 What is the case of occurring this error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lujiajing1126 commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108047447
After checking the code, it seems error is not handled properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wu-sheng commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108046013
Your configuration is not well formatted. Please correct them. And what does
`SW_STORAGE: elasticsearch` mean? I think we don't need Elasticsearch when you
use BanyanDB.
wu-sheng commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2108028821
I can see RocketMQ case fails again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Almot77 opened a new issue, #12219:
URL: https://github.com/apache/skywalking/issues/12219
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
wu-sheng commented on code in PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#discussion_r1598620639
##
CHANGES.md:
##
@@ -11,6 +11,7 @@ Release Notes.
* Use a daemon thread to flush logs.
* Fix typos in `URLParser`.
* Add support for
dashanji closed issue #12040: [Bug] SkyWalking Operator helm does not yet
include the CRD for BanyanDB.
URL: https://github.com/apache/skywalking/issues/12040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dashanji commented on issue #12040:
URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2107693144
Fix in https://github.com/apache/skywalking-helm/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 5c073c1 Move image
hanahmily merged PR #17:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wu-sheng commented on issue #12040:
URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2107585227
@ButterBright How about this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107534947
> > I think you got it wrong. It should be in ContextManager#continued
method, which controls the context.
>
> Understood. How can the
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107529372
> > This is a force sampling(unsampling), we don't need to worry about
sampling counter.
>
> ForceSampling might not necessarily be true. I feel that it could still
impact
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107509503
> This is a force sampling(unsampling), we don't need to worry about
sampling counter.
> This is a force sampling(unsampling), we don't need to worry about
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107480474
> I think you got it wrong. It should be in ContextManager#continued method,
which controls the context.
Understood. How can the
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107451077
This is a force sampling(unsampling), we don't need to worry about sampling
counter.
--
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107449336
I think you got it wrong. It should be in ContextManager#continued method,
which controls the context.
--
This is an automated message from the Apache Git Service.
To respond to
JoeCqupt closed issue #12218: [Bug] skywalking-java maven build problem
URL: https://github.com/apache/skywalking/issues/12218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
JoeCqupt closed pull request #690: update dependencies
URL: https://github.com/apache/skywalking-java/pull/690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107376314
> When this is about ContextManager, it should not affect
TracingContext#CreateLocal span. Only snapshot should be changed, and
ContextManager asked TracingContext switching to
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107355009
When this is about ContextManager, it should not affect
TracingContext#CreateLocal span. Only snapshot should be changed, and
ContextManager asked TracingContext switching to
ButterBright commented on PR #17:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2107324862
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107275825
You are adding a mechanism for local span creation. This should not happen,
if there is a context switching out, it must be controlled by ContextManager.
--
This is an automated
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107265410
I don't have direct answer, if I had, I already told you in the last
discussion.
The reason it doesn't exist is, the tracing context is created before the
snapshot is
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107252722
> I think we need to separate the context. Cross thread is different from
cross process. Cross process is defined here,
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107220318
I am feeling you are doing a hijack only, which should not be the official
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107218830
I think we need to separate the context. Cross thread is different from
cross process.
Cross process is defined here,
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107191416
> Add what?
here: https://github.com/apache/skywalking-java/pull/689#issue-2292115894
--
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107183993
Add what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wu-sheng commented on PR #17:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2107183002
Do we need to update docs accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107173269
> Please write a proposal about what is a force-ignoring mechanism. The
discussion we did was only about the context.
Added.
--
This is an automated message from the
wu-sheng commented on PR #690:
URL: https://github.com/apache/skywalking-java/pull/690#issuecomment-2107025344
CI has covered all compiling process, nothing wrong happens.
Please be clear why you failed.
--
This is an automated message from the Apache Git Service.
To respond to the
JoeCqupt opened a new pull request, #690:
URL: https://github.com/apache/skywalking-java/pull/690
### Fix
- [ ] Add a unit test to verify that the fix works.
- [] Explain briefly why the bug exists and how to fix it.
- [ ] If this pull request
JoeCqupt opened a new issue, #12218:
URL: https://github.com/apache/skywalking/issues/12218
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106941367
For an official proposal, you could refer to
SWIP(https://skywalking.apache.org/docs/main/next/en/swip/readme/), which is
mandatory for OAP, but not for the agent.
A key part
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106934764
> Please write a proposal about what is a force-ignoring mechanism. The
discussion we did was only about the context.
Do you have a proposal template?
--
This is an
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106928547
Please write a proposal about what is a force-ignoring mechanism. The
discussion we did was only about the context.
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch wu-sheng-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git
was 84a30e5a76 Fix next SWIP ID
The revisions that were on this branch are still contained in
other
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 7f20b99b4f Fix next SWIP ID (#12217)
gzlicanyi opened a new pull request, #689:
URL: https://github.com/apache/skywalking-java/pull/689
Add a [forceIgnoring
mechanism](https://github.com/apache/skywalking/discussions/12161) and apply it
to the plugins (Spring Cloud Gateway, HttpClient, JDK-ForkJoinPool,
JDK-Threading,
wu-sheng merged PR #12217:
URL: https://github.com/apache/skywalking/pull/12217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wu-sheng opened a new pull request, #12217:
URL: https://github.com/apache/skywalking/pull/12217
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch wu-sheng-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git
at 84a30e5a76 Fix next SWIP ID
This branch includes the following new commits:
new 84a30e5a76 Fix
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch wu-sheng-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 84a30e5a76b22814ce016069b62d7a84b97c4907
Author: 吴晟 Wu Sheng
AuthorDate: Mon May 13 16:00:44 2024 +0800
wu-sheng commented on PR #17:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2106807251
Do we want to control this in the same place? Like we may need to override
repo and commit ID within dev stage?
--
This is an automated message from the Apache Git
ButterBright opened a new pull request, #17:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/17
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wu-sheng merged PR #16:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 5f364d1 Update
ButterBright opened a new pull request, #16:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/16
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch release-0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
was a8aabbc Fix failed release command
The revisions that were on this branch are still
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new bd45247 Fix failed
hanahmily merged PR #15:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hanahmily opened a new pull request, #15:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/15
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch release-0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
commit a8aabbc22a835c2895f65577e9e67ca1dbf790f2
Author: Gao Hongtao
AuthorDate: Mon May 13
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch release-0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
omit 0c9b601 Prepare release 0.2.0
add 39048fc Prepare release 0.2.0 (#14)
new
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to annotated tag v0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
*** WARNING: tag v0.2.0 was modified! ***
from 39048fc (commit)
to 2ebb393 (tag)
hanahmily closed pull request #13: Use Docker Hub as image source to replace
ghcr
URL: https://github.com/apache/skywalking-banyandb-helm/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
butterbright pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 39048fc Prepare
ButterBright merged PR #14:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hanahmily opened a new pull request, #14:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/14
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch release-0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
commit 0c9b601c3633358e7c624ddce29c09ef85ac22c1
Author: Gao Hongtao
AuthorDate: Mon May 13
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch release-0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
at 0c9b601 Prepare release 0.2.0
This branch includes the following new commits:
new
88 matches
Mail list logo
