AirTrioa opened a new pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >) URL: https://github.com/apache/skywalking/pull/4320 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - Related issues ___ ### Bug fix - Bug description. When some older projects (using Oracle database) access skywalking, we find that the port and database name of Oracle are incorrectly identified. The port is recognized as 1521 by default and the database name is recognized as < port > / < dbname >. We found that when we cut the Oracle URL, we only recognize the URL of one sid connection mode (jdbc: oracle: thin: @ < host >: < port >: < Sid >); so here I added the recognition of the URL of another sidsid connection mode (jdbc: oracle: thin: @ < host >: < port > / < Sid >). - How to fix? An if branch is added before setting the default port.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
