EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660749551
all done
This is an automated message from the Apache Git Service.
To respond to the message, please log on
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660746378
> @EvanLjp Still need you to polish this PR.
no problem,I had some personal things this weekend, so I was delayed
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660092729
@wu-sheng already rename module + delete invalid file
This is an automated message from the Apache Git
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-659159329
> And need to prompt the user in the documentation to use this function need
to obtain configmaps permissions, for example
>
> ```
> rules:
> - apiGroups: [""]
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-658021937
@wu-sheng Sorry about having to write the wrong folder path , i hava been
tested it in our privite cluster
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-658021274
## test env
private kubernets cluster
## before dynamic-config
```
apiVersion: v1
kind: ConfigMap
metadata:
name: skywalking-dynamic-config
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657240614
sorry,i would try to test it now
This is an automated message from the Apache Git Service.
To respond to the
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657239955
sorry, i would be check it again. i don't have the test env for official
version.i have been tested it in company version . i would like to compare it .
I am very sorry
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657228672
yes , this code has been already running on our production env
This is an automated message from the Apache
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-657222173
i would like to fix this little bugs now , and i don't know how to add the
e2e process .
Recently, i am so busy on my work . prefer to add the e2e process in the
next
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-654307474
> @EvanLjp Please update the document.
done
This is an automated message from the Apache Git Service.
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-652184130
@wu-sheng how to pass all ci processes? Whether branch coverage is required
This is an automated message
EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647418288
I will add unit tests later, thanks for review first
This is an automated message from the Apache Git
13 matches
Mail list logo
