[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-12-01 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-560205713 @wu-sheng Thanks for your reminder, will move the pulsar plugin test soon. This is an aut

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-24 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-534867040 @wu-sheng @dmsolr @kezhenxu94 Thanks for your help, very nice experience in Skywalking community. ---

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-24 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-534480064 Sorry, i'm lost here. I have bind port by using: This is an automated message from the Ap

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-24 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-534474018 @wu-sheng Currently, pulsar broker using static port, is that the error cause? This is a

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-24 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-534469363 @wu-sheng Currently, pulsar broker use static port, let me try to fix it. This is an auto

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-23 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-534373957 @wu-sheng I have paste the local integration test result to the description of this PR. Please help review the pulsar scenario integration. -

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-23 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-534019501 @wu-sheng Ok, thanks. I'm doing the local integration tests now. This is an automated mes

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-23 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-533990353 /run ci This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-20 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-533465687 @dmsolr @wu-sheng I misunderstood it, will move it back, thanks. This is an automated mes

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-19 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-533075064 @dmsolr Thanks for your review, i have move the span creation of consumer to beforeMethod. Please help take a look again. ---

[GitHub] [skywalking] codelipenghui commented on issue #3476: Add pulsar apm plugin

2019-09-18 Thread GitBox
codelipenghui commented on issue #3476: Add pulsar apm plugin URL: https://github.com/apache/skywalking/pull/3476#issuecomment-532948338 @wu-sheng I have fix the conflicts and past the local test screenshot to the description of this PR, please help take a look the test result screenshot.