[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-579134965 Some discuss not about this PR. I found there is bad throughput about OAP server collect tracing. I have tried to use skywalking in my production env,

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-576532610 It seems test case passed with client tracing This is an automated message from the Apache Git

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575155705 @GuoDuanLZ The test case need to update for client tracing This is an automated message

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573529847 You convinced me, the client-side tracing is also important to trace. This is an automated

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573524127 I agree with you, the error of unreachable or network perf unstable issues are also important for service. I can simplify client-side tracing for this,

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-57357 The original plugin doesn't provide the client-side tracing, I add it for my case and optional powerful tracing.

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573499115 In the default config, all gRPC calls are internal calls. No client-side tracing will be created. I think the default config is enough for most cases (most of

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573498339 @wu-sheng If you trace the both of client and server-side, you would get the tracing like blow of bi-streaming call: ``` + | +-+(Server1) Exit:

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573431678 @wu-sheng @wayilau @kezhenxu94 This PR is ready for reviews. This is an automated message

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-571909973 > What is this? Could you explain a little more? I will update the doc of PR later, I am too busy to update PR in the working day.

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-570994639 > If you enhance the plugin, i think you should adjust Grpc tests cases, then use ci to check first. Yes, it already in our checklist, and @GuoDuanLZ