kezhenxu94 commented on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733525745
> > I added a bool flag named unnormal, it's not required. Because the default value of bool is true. > > If we create a isNormal flag, we probably have to add this flag most of the time. > > What do you think ？ > > I think this is only coding style. You could give the parameter `true` if no input parameter. Right? `unnormal` is anti-protocol, which should not be recommended. +1, @fgksgf make `isNormal` type of string, and give it default value `true`, and validate that it should be either `true` or `false` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
