[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-23 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337890743 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/so

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337829296 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/so

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337825252 ## File path: test/plugin/scenarios/netty-socketio-scenario/config/expectedData.yaml ## @@ -0,0 +1,97 @@ +#

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-21 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337314201 ## File path: Jenkinsfile-Agent-Test ## @@ -88,6 +88,12 @@ pipeline { sh 'ba

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-20 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336828653 ## File path: Jenkinsfile-Agent-Test ## @@ -81,11 +81,17 @@ pipeline { }

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-20 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336826468 ## File path: test/plugin/scenarios/netty-socketio-scenario/config/expectedData.yaml ## @@ -0,0 +1,97 @@ +#

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-20 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336818914 ## File path: Jenkinsfile-Agent-Test ## @@ -81,11 +81,17 @@ pipeline { }

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-20 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336818344 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/test/java/org/apache/skywalking/apm/plugin/netty/so

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-18 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336426810 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/so

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-17 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336339580 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/so

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-17 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r336291179 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/so