[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources

2020-11-16 Thread GitBox
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524355984 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. |

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources

2020-11-16 Thread GitBox
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524329962 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. |

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources

2020-11-16 Thread GitBox
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524329616 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. |

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources

2020-11-16 Thread GitBox
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524031233 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources

2020-11-16 Thread GitBox
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524029956 ## File path: