wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-881904451
> you mean just put the fallback behavior in the span of origin request
rather than in a separate span?
> I think that's might be better for most cases , since most of
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-881891163
> The problem of the old code is that get the span from attributes within
the execution of Mono would get span for latter request twice. so just move
this part of code out
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-881221354
Webflux case fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-881193468
Still fail. @yujiaxinlong
--
This is an automated
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-879051897
@yujiaxinlong Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-878952898
> @wu-sheng
> kind of forgot about this PR, this issue seems still exist in latest
version, is there anything I can do or just waiting for review of
> @ascrutae
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-839791341
Closing as no update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wu-sheng commented on pull request #5886:
URL: https://github.com/apache/skywalking/pull/5886#issuecomment-732563841
Please update the changelog.
This is an automated message from the Apache Git Service.
To respond to the
