[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent

2021-01-21 Thread GitBox
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764325292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent

2021-01-20 Thread GitBox
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764329003 > Only one problem, it's disabled by default at OAP side, while it's enabled at the agent side's, causing unnecessary error logs like this: > > ``` > ERROR 2021-01-

[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent

2021-01-20 Thread GitBox
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764325292 > Let's enable at the OAP side. This is a low cost feature. done. This is an automated message from t

[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent

2021-01-20 Thread GitBox
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-763732906 > [apache/skywalking-data-collect-protocol#45](https://github.com/apache/skywalking-data-collect-protocol/pull/45) The Java package was wrong. I am fixing with that PR. Plea

[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent

2021-01-19 Thread GitBox
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762844848 > @zifeihan Don't use the UI to merge one by one. It costs too many CI resources. OK, get it. This i