[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #2: Make async stuff work reliably

tom-pytel edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735255536 > > * Context.capture() and restore() will be made redundant / unnecessary by this? > > Yes I believe they're unnecessary after this PR, feel free to remove

[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #2: Make async stuff work reliably

tom-pytel edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735256060 Ready for merge I think, tests need to be updated since I changes some tags. I couldn't really come up with a ready-to-use example vs. the previous version since

[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #2: Make async stuff work reliably

tom-pytel edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735256060 Ready for merge I think, tests need to be changed since I added tags which weren't previously being returned. I couldn't really come up with a ready-to-use example

[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #2: Make async stuff work reliably

tom-pytel edited a comment on pull request #2: URL: https://github.com/apache/skywalking-nodejs/pull/2#issuecomment-735256060 Ready for merge I think, tests need to be changed since I added tags which weren't previously being returned. I couldn't really come up with a ready-to-use example