[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-27 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-450296854 Closing. No update in half month. Have to. Sorry. ---

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-22 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-449607689 Any update? This pr stays in silence for last whole week. If no more update in next week, @candyleer you deci

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-15 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-447623704 @ASCE1885 Please answer @candyleer question, to make sure whether this PR is ready to merge. ---

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446866368 @ASCE1885 Before people begin to review, please fix your CI first. --

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446861368 Approve(not merge) this PR when you think it is ready. --

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446861250 @candyleer Please review this PR. This is an