Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
wu-sheng commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2062868091 Yes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2062867772 > I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. And I found the Nginx dashboards have

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 commented on code in PR #12126: URL: https://github.com/apache/skywalking/pull/12126#discussion_r1569806890 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mongodb/mongodb-cluster.json: ## @@ -231,7 +232,7 @@

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
wankai123 commented on code in PR #12126: URL: https://github.com/apache/skywalking/pull/12126#discussion_r1569747463 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mongodb/mongodb-cluster.json: ## @@ -231,7 +232,7 @@

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2061329463 > I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. > And I found the Nginx dashboards

Re: [PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
wankai123 commented on PR #12126: URL: https://github.com/apache/skywalking/pull/12126#issuecomment-2061285245 I suggest adding the label to simplify the name of the metric, otherwise it will show the total expression if it's not a labeled metric. And I found the Nginx dashboards have

[PR] Fix inaccurate MongoDB Metrics [skywalking]

2024-04-17 Thread via GitHub
weixiang1862 opened a new pull request, #12126: URL: https://github.com/apache/skywalking/pull/12126 ### Fix inaccurate MongoDB Metrics - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. - [x]