wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2041051915
@CodePrometheus Pleaae sync submodule to make this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng merged PR #377:
URL: https://github.com/apache/skywalking-booster-ui/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2036821567
@Fine0830 Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2036486023
The idea of implementation is:
Maintain a Map to represent the relationship between the event name and the
corresponding MutationObserver. When entering the page,
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2033543431
> @CodePrometheus Is the new way working?
I've been a little busy at work recently, don't have enough time to look
carefully. This way should be achievable,
wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2033474975
@CodePrometheus Is the new way working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Fine0830 commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2029974111
> Can you remove the div event listener when clicking search and add it back
after the trace rendering?
You can use
Fine0830 commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2029920324
> Can you remove the div event listener when clicking search and add it back
after the trace rendering?
Please change the codes base on this and remove the
wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2029892022
@Fine0830 Could you verify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2029860359
Could we proceed to the next step, do I need to provide video for double
check?
--
This is an automated message from the Apache Git Service.
To respond to the
Fine0830 commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2029032674
> > We already have it
[here](https://github.com/apache/skywalking-booster-ui/blob/main/src/views/dashboard/related/trace/components/D3Graph/Index.vue#L299)
>
> Yes,
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2028746474
> We already have it
[here](https://github.com/apache/skywalking-booster-ui/blob/main/src/views/dashboard/related/trace/components/D3Graph/Index.vue#L299)
Yes,
Fine0830 commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2028629132
> > Can you remove the div event listener when clicking search and add it
back after the trace rendering?
>
> I checked and found that the current implementation and
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2028544369
> Can you remove the div event listener when clicking search and add it back
after the trace rendering?
I checked and found that the current implementation and
Fine0830 commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2028063321
> > What do you mean? Why does this feature affect search?
>
> When click search, the trace will be rendered once, and when the segment
list reaches the
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2028040128
> What do you mean? Why does this feature affect search?
When click search, the trace will be rendered once, and when the segment
list reaches the default
Fine0830 commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2028037114
> cc @Fine0830 In order to avoid repeated rendering of the trace with the
search event, I used `mitt` to identify the event name, WDYT? have any other
suggestions, please
wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2027997045
Logically, this is good for me. Wait for @Fine0830 to check code details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2027995830
> I think when you apply a new query, the segment list sidebar should be pop
up automatically. Otherwise, it is confusing, especially when query without
trace ID, it
wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2026352991
I think when you apply a new query, the segment list sidebar should be pop
up automatically. Otherwise, it is confusing, especially when query without
trace ID, it would be
CodePrometheus commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1543252686
##
src/views/dashboard/related/trace/TraceList.vue:
##
@@ -187,7 +188,7 @@ limitations under the License. -->
}
.list {
-width: 280px;
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2025640139
> The tips are not destroyed.
The reason is that when re-rendering, I neglected to remove `.d3-tip`, has
been corrected.
> And, could you verify how this
CodePrometheus commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1543252686
##
src/views/dashboard/related/trace/TraceList.vue:
##
@@ -187,7 +188,7 @@ limitations under the License. -->
}
.list {
-width: 280px;
CodePrometheus commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1543251156
##
src/views/dashboard/related/trace/components/D3Graph/Index.vue:
##
@@ -60,6 +61,9 @@ limitations under the License. -->
}
draw();
Fine0830 commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1542223513
##
src/views/dashboard/related/trace/components/D3Graph/Index.vue:
##
@@ -60,6 +61,9 @@ limitations under the License. -->
}
draw();
wu-sheng commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2024232892
https://github.com/apache/skywalking-booster-ui/assets/5441976/0fb16de2-a0bd-4648-b875-d34be62125a4;>
The tips are not destroyed.
And, could you verify how this
CodePrometheus commented on PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2024213622
@wu-sheng Hello Teacher Wu, regarding the discussion on the automatic
expansion of the left panel when searching, I have been thinking about it in
the past few weeks.
CodePrometheus opened a new pull request, #377:
URL: https://github.com/apache/skywalking-booster-ui/pull/377
### Summary
Good morning everyone, the main modification this time is to introduce the
drag function in the trace panel, and reference to
28 matches
Mail list logo
