This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new d2b1f1a Add a document link in plugin contribution. (#2023)
d2b1f1a is described below
commit d2b1f1a5e0dc36b49848da6f0c369328c358f62a
Author: 吴晟 Wu Sheng <wu.sh...@foxmail.com>
AuthorDate: Sat Dec 8 21:01:58 2018 +0800
Add a document link in plugin contribution. (#2023)
---
docs/en/guides/Java-Plugin-Development-Guide.md | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/docs/en/guides/Java-Plugin-Development-Guide.md
b/docs/en/guides/Java-Plugin-Development-Guide.md
index 7de1317..5de9406 100644
--- a/docs/en/guides/Java-Plugin-Development-Guide.md
+++ b/docs/en/guides/Java-Plugin-Development-Guide.md
@@ -281,9 +281,12 @@ We are welcome everyone to contribute plugins.
Please follow there steps:
1. Submit an issue about which plugins are you going to contribute, including
supported version.
-1. Create sub modules under `apm-sniffer/apm-sdk-plugin`, and the name should
include supported library name and versions
+1. Create sub modules under `apm-sniffer/apm-sdk-plugin` or
`apm-sniffer/optional-plugins`, and the name should include supported library
name and versions
1. Follow this guide to develop. Make sure comments and test cases are
provided.
1. Develop and test.
-1. Send the pull request and ask for review, and provide the automatic test
cases by following PMC members guides.
+1. Send the pull request and ask for review.
+1. Provide the automatic test cases.
+All test cases are hosted in [SkywalkingTest/skywalking-agent-testcases
repository](https://github.com/SkywalkingTest/skywalking-agent-testcases).
+About how to write a test case, follow the [How to
write](https://github.com/SkywalkingTest/skywalking-agent-testcases/blob/master/docs/how-to-write-a-plugin-testcase.md)
document.
1. The plugin committers approves your plugins after automatic test cases
provided and the tests passed in our CI.
1. The plugin accepted by SkyWalking.
