Re: [PR] Add support for amqp [skywalking-go]

2024-02-19 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1952947913 > Are you using a HTTP handler to trigger consumer? I think you can't create another entry span when the first one not finished. You will need a local span in the middle, or

Re: [PR] Add support for amqp [skywalking-go]

2024-02-09 Thread via GitHub
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1935577697 Are you using a HTTP handler to trigger consumer? I think you can't create another entry span when the first one not finished. You will need a local span in the middle, or use a

Re: [PR] Add support for amqp [skywalking-go]

2024-02-09 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1935516907 Thank you for the reminder, Teacher Wu. I checked that the context between the producer and consumer is connected, as shown in Figure 1. However, when I introduce an HTTP

Re: [PR] Add support for amqp [skywalking-go]

2024-02-06 Thread via GitHub
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1930786342 This is trace broken due to lack od reference of span for the entry(consumer) span. Did you check context carrier injected into message header/metadata, and successfully

Re: [PR] Add support for amqp [skywalking-go]

2024-02-06 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1930127661 terribly sorry, I've been stuck on a problem for a while, When I was dealing with consumer span, something didn't look right and there was no connection. I'm still trying to

Re: [PR] Add support for amqp [skywalking-go]

2024-02-05 Thread via GitHub
mrproliu commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1926857460 Please help to fix the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add support for amqp [skywalking-go]

2024-01-30 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1917682818 I used `SkyWalkingDynamicField` to deal with the peer value problem, and my locally env has passed the ./run.sh amqp test -- This is an automated message from the Apache Git

Re: [PR] Add support for amqp [skywalking-go]

2024-01-28 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913632299 copy that, I'll try again locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add support for amqp [skywalking-go]

2024-01-28 Thread via GitHub
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913624608 I think that depends on the codes. `amqp` is a DNS name, if the codes have resolved it, and you use it as peer, then, it is an IP as always. -- This is an automated message from

Re: [PR] Add support for amqp [skywalking-go]

2024-01-28 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913623178 Ok, I'll update the dos. Since a new service was added to docker-composer this time, I found out through CI `reason: [peer]: expected=>{amqp:5672},

Re: [PR] Add support for amqp [skywalking-go]

2024-01-28 Thread via GitHub
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913613023 @CodePrometheus Plugin docs should be updated. `support-plugins.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add support for amqp [skywalking-go]

2024-01-28 Thread via GitHub
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913612246 @mrproliu is on vacation, this PR will be reviewed after he is back. Please wait for next week. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add support for amqp [skywalking-go]

2024-01-28 Thread via GitHub
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913609875 Ref https://github.com/apache/skywalking/pull/11838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use