mrproliu merged PR #167:
URL: https://github.com/apache/skywalking-go/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mrproliu commented on code in PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#discussion_r1479262761
##
CHANGES.md:
##
@@ -22,6 +22,7 @@ Release Notes.
* Fix enhance method error when unknown parameter type.
* Fix wrong tracing context when trace have been
mrproliu commented on PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#issuecomment-1928825979
Please update the
[CHANGES.md](https://github.com/apache/skywalking-go/blob/main/CHANGES.md),
thanks.
--
This is an automated message from the Apache Git Service.
To respond to
Ruff-nono commented on code in PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#discussion_r1479161253
##
plugins/gin/intercepter.go:
##
@@ -59,3 +62,10 @@ func (h *ContextInterceptor) AfterInvoke(invocation
operator.Invocation, result
span.End()
mrproliu commented on code in PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#discussion_r1479149579
##
plugins/gin/intercepter.go:
##
@@ -59,3 +62,10 @@ func (h *ContextInterceptor) AfterInvoke(invocation
operator.Invocation, result
span.End()
Ruff-nono commented on code in PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#discussion_r1479140895
##
plugins/gin/intercepter.go:
##
@@ -59,3 +62,10 @@ func (h *ContextInterceptor) AfterInvoke(invocation
operator.Invocation, result
span.End()
mrproliu commented on code in PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#discussion_r1478104412
##
plugins/gin/intercepter.go:
##
@@ -59,3 +62,10 @@ func (h *ContextInterceptor) AfterInvoke(invocation
operator.Invocation, result
span.End()
wu-sheng commented on PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#issuecomment-1918927495
Let's wait for project lead back from vacation. It should be next Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to