[GitHub] peng-yongsheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？

2018-04-10 Thread GitBox 
peng-yongsheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？
URL: 
https://github.com/apache/incubator-skywalking/issues/1065#issuecomment-380322424
 
 
   Sure, the host setting of agent gRPC module must bind on IP/HOST which your 
agent side can be connected.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] gMan1990 opened a new issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？

2018-04-10 Thread GitBox 
gMan1990 opened a new issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？
URL: https://github.com/apache/incubator-skywalking/issues/1065
 
 
   
https://github.com/apache/incubator-skywalking/blob/03824c2f8f43d55746ac466f0252bd78c1b48363/apm-collector/apm-collector-boot/src/main/resources/application.yml#L16
   ```
   curl http://:10800/agent/gRPC
   [":11800"]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization

2018-04-10 Thread GitBox 
peng-yongsheng commented on issue #1032: Collector performance optimization
URL: 
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
 
 
   ## Report digest
   ```
   metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
   metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
   metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total: 
12(s)
   ```
   Those points could be a source of performance bottlenecks.
   
   ## Performance optimization
   ### Segment parse
    Change cache component from Guava to Caffeine, [ Caffeine's 
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
   ```
   metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
   metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
   metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total: 
6(s)
   ```
    Make all the loggers class variable to have the static modifier.
   ```
   Before:
   /segment/parse
Avg=636584 (nanosecond), Success Rate=100%, Calls=14000, 
Total=8912189125 (nanosecond)
   
   After:
   /segment/parse
Avg=524138 (nanosecond), Success Rate=100%, Calls=14097, 
Total=7388775602 (nanosecond)
   ```
   
    Time stamp format to time bucket performance optimization.
   ```
   Before:
   /segment/parse
Avg=557410 (nanosecond), Success Rate=100%, Calls=14139, 
Total=7881231734 (nanosecond)
   /utils/timeBucket/getSecondTimeBucket
Avg=9768 (nanosecond), Success Rate=100%, Calls=17417, Total=170135908 
(nanosecond)
   /utils/timeBucket/getMinuteTimeBucket
Avg=7384 (nanosecond), Success Rate=100%, Calls=82536, Total=609514865 
(nanosecond)
   
   After:
   /segment/parse
Avg=503868 (nanosecond), Success Rate=100%, Calls=14085, 
Total=7096993057 (nanosecond)
   /utils/timeBucket/getSecondTimeBucket
Avg=13636 (nanosecond), Success Rate=100%, Calls=3664, Total=49964432 
(nanosecond)
   /utils/timeBucket/getMinuteTimeBucket
Avg=6148 (nanosecond), Success Rate=100%, Calls=27512, Total=169161105 
(nanosecond)
   ```
   
    Instance of and time bucket transform
   1. Add contains point method instead instance of for decide span listener 
class type.
   1. Transform minute time bucket just once.
   
   ```
   Before:
   /segment/parse
Avg=503868 (nanosecond), Success Rate=100%, Calls=14085, 
Total=7096993057 (nanosecond)
   After:
   /segment/parse
Avg=81916 (nanosecond), Success Rate=100%, Calls=455534, 
Total=37315774880 (nanosecond)
   ```
   
   ### Storage
    Short Column Name
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1063: Add an incubating feature section for preparing to merge ElasticSearch HTTP implementor

2018-04-10 Thread GitBox 
coveralls commented on issue #1063: Add an incubating feature section for 
preparing to merge ElasticSearch HTTP implementor
URL: 
https://github.com/apache/incubator-skywalking/pull/1063#issuecomment-380321142
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16453582/badge)](https://coveralls.io/builds/16453582)
   
   Coverage remained the same at 19.763% when pulling 
**3f371103521cd0ebe2331b84bbaf8e54a8a9817f on wu-sheng-patch-1** into 
**8dda60eb7d520c8e4b85e72733a3944379f29e32 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng opened a new issue #1064: Add annotation named SQLAs to help collector storage module extension

2018-04-10 Thread GitBox 
peng-yongsheng opened a new issue #1064: Add annotation named SQLAs to help 
collector storage module extension
URL: https://github.com/apache/incubator-skywalking/issues/1064
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [X] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   Someone wanted to extend the collector storage module, he/her reference to 
ElasticSearch DAO implementation only. But not everyone knows ElasticSearch 
query API. 
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.
   Add annotation named SQLAs, write the query implementation as a SQL to 
describe the query logic. Because of most developer know the SQL query language.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1048: Create Setting-override-CN.md

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1048: Create Setting-override-CN.md
URL: 
https://github.com/apache/incubator-skywalking/pull/1048#issuecomment-380318703
 
 
   @w281015308 Sorry, I have to close this. @candyleer 's #1062 has been 
merged. It includes all Chinese documents.
   
   Thanks for your contributions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #1048: Create Setting-override-CN.md

2018-04-10 Thread GitBox 
wu-sheng closed pull request #1048: Create Setting-override-CN.md
URL: https://github.com/apache/incubator-skywalking/pull/1048
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/cn/Setting-override-CN.md b/docs/cn/Setting-override-CN.md
new file mode 100644
index 0..f009dff4b
--- /dev/null
+++ b/docs/cn/Setting-override-CN.md
@@ -0,0 +1,38 @@
+# 自定义设置
+## 支持版本
+5.0.0-beta + 
+
+_Agent 自定义设置 从 3.2.5_ 版本开始支持。
+
+## 什么是自定义设置?
+ SkyWalking 默认为客户端提供 `agent.config`和 `application.yml` 文件用于服务端设置. 
+
+自定义设置是指终端用户可以在一些配置文件里使用内置属性自定义相关配置。
+
+## 自定义优先级
+系统属性(-D) > 配置文件
+ 
+## 自定义
+### 代理
+在配置文件里使用 `skywalking.` + key 作为系统属性和环境变量去自定义对应的值.
+
+- 为什么要使用`skywalking.`这个前缀?
+
+ 代理系统和目标应用会共享属性和环境变量,所以使用这个前缀避免同名变量冲突。
+  
+### 收集器
+在配置文件里使用 key 作为系统属性和环境变量去自定义对应的值.
+
+例如:
+- 在 `application.yml`文件里设置
+```yaml
+agent_gRPC:
+  gRPC:
+host: localhost
+port: 11800
+```
+
+- 使用系统属性重写端口到 31200,并且把下面这行代码添加到 startup 脚本里.
+```
+-Dagent_gRPC.gRPC.port=31200
+```


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
wu-sheng closed pull request #1062: chinese documents translation, sync with 
english
URL: https://github.com/apache/incubator-skywalking/pull/1062
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/README_ZH.md b/docs/README_ZH.md
index 2c00178ee..f8c09690c 100644
--- a/docs/README_ZH.md
+++ b/docs/README_ZH.md
@@ -1,10 +1,16 @@
 ## 中文文档
 [![EN doc](https://img.shields.io/badge/document-English-blue.svg)](README.md)
 
-  * [项目简介](/README_ZH.md)
-  * [快速入门](cn/Quick-start-CN.md)
-  * [中间件，框架与类库支持列表](Supported-list.md)
-* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md)
+  * 快速入门
+* [快速入门](cn/Quick-start-CN.md)
+* [中间件，框架与类库支持列表](Supported-list.md)
+* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md)
+  * 高级特性
+* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md)
+* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md)
+* [开启TLS](cn/TLS-CN.md)
+* [命名空间隔离](cn/Namespace-CN.md)
+* [基于Token认证](cn/Token-auth-CN.md)
   * APM相关介绍资料
 * 
[OpenTracing中文版](https://github.com/opentracing-contrib/opentracing-specification-zh)
   * Application Toolkit，应用程序工具包
diff --git a/docs/cn/Application-toolkit-CN.md 
b/docs/cn/Application-toolkit-CN.md
index ca0a0b0ec..e3551fbc4 100644
--- a/docs/cn/Application-toolkit-CN.md
+++ b/docs/cn/Application-toolkit-CN.md
@@ -1,9 +1,9 @@
 # 什么是sky-walking应用程序工具包?
-Sky-walking应用程序工具包是一系列的类库，有skywalking团队提供。通过这些类库，你可以在你的应用程序内，访问sky-walking的一些内部信息.
+Sky-walking应用程序工具包是一系列的类库，由skywalking团队提供。通过这些类库，你可以在你的应用程序内，访问sky-walking的一些内部信息.
 
 _**最为重要的是**_, 即使你移除skywalking的探针，或者不激活探针，这些类库也不会对应用程序有任何影响，也不会影响性能.
 
-工具包提供以下核心能力
+# 工具包提供以下核心能力
 1. 将追踪信息和log组件集成，如log4j, log4j2 和 logback
 1. 兼容CNCF OpenTracing标准的手动埋点
 1. 使用Skywalking专有的标注和交互性API
diff --git a/docs/cn/Application-toolkit-logback-1.x-CN.md 
b/docs/cn/Application-toolkit-logback-1.x-CN.md
index a82ef1e25..2a18f1146 100644
--- a/docs/cn/Application-toolkit-logback-1.x-CN.md
+++ b/docs/cn/Application-toolkit-logback-1.x-CN.md
@@ -11,7 +11,7 @@
 ```xml
 
 
-
+
 %d{-MM-dd HH:mm:ss.SSS} [%tid] [%thread] %-5level 
%logger{36} -%msg%n
 
 
diff --git a/docs/cn/Application-toolkit-trace-CN.md 
b/docs/cn/Application-toolkit-trace-CN.md
index dab3f7ea4..84695938b 100644
--- a/docs/cn/Application-toolkit-trace-CN.md
+++ b/docs/cn/Application-toolkit-trace-CN.md
@@ -16,4 +16,4 @@ modelAndView.addObject("traceId", TraceContext.traceId());
 ```
 _示例代码，仅供参考_
 
-* 对任何需要追踪的方法，使用@Trace标注，则此方法会被加入到追踪链中。
+* 对任何需要追踪的方法，使用 `@Trace` 标注，则此方法会被加入到追踪链中。
diff --git a/docs/cn/Deploy-backend-in-standalone-mode-CN.md 
b/docs/cn/Deploy-backend-in-standalone-mode-CN.md
index 2d7f83b8f..c0cea67be 100644
--- a/docs/cn/Deploy-backend-in-standalone-mode-CN.md
+++ b/docs/cn/Deploy-backend-in-standalone-mode-CN.md
@@ -3,7 +3,7 @@
 
 如果使用单机collector用于非演示环境，你可选择使用Elasticsearch作为存储实现。
 
-**在5.0.0-alpha版本中，暂不提供H2实现**
+**在5.0.0-alpha版本中，暂不提供H2实现, 所以在启动之前,必须先部署ElasticSearch**
 
 ## 所需的第三方软件
 - JDK8+
@@ -12,25 +12,17 @@
 - 前向[发布页面](https://github.com/apache/incubator-skywalking/releases)
 
 ## Quick Start
-Collector单机模拟启动简单，提供和集群模式相同的功能，单机模式下除端口被占用的情况下，直接启动即可。
+Collector单机模拟启动简单，提供和集群模式相同的功能，单机模式下除端口(8080, 10800, 11800, 
12800)被占用的情况下，直接启动即可。
 
 ## 部署后台服务
 1. 解压安装包`tar -xvf skywalking-collector.tar.gz`，windows用户可以选择zip包
 1. 运行`bin/startup.sh`启动。windows用户为.bat文件。
 
-- 
**注意：startup.sh将会启动collector和UI两个进程，UI通过127.0.0.1:10800访问本地collector，无需额外配置。**
+- **注意：在5.0.0-alpha 
版本中,startup.sh将会启动collector和UI两个进程，UI通过127.0.0.1:10800访问本地collector，无需额外配置。**
 
 ## 使用Elastic Search代替H2存储
-- 在单机模式下除了支持内置的H2数据库运行，也支持其他的存储（当前已支持的ElasticSearch 
5.3），取消Storage相关配置节的注释，并修改配置。
-```yaml
-#storage:
-#  elasticsearch:
-#cluster_name: CollectorDBCluster
-#cluster_transport_sniffer: true
-#cluster_nodes: localhost:9300
-#index_shards_number: 2
-#index_replicas_number: 0
-```
+- 在单机模式下，`collector`也支持其他的存储（当前已支持的ElasticSearch 5.3），取消  
`application.yml`配置文件中的`storage` 相关配置节的注释，并修改配置,默认的配置是`collector`
+和 `Elasticsearch` 运行在同一台机器上。
 
 ## 部署Elasticsearch
 - 修改`elasticsearch.yml`文件
diff --git a/docs/cn/Deploy-skywalking-agent-CN.md 
b/docs/cn/Deploy-skywalking-agent-CN.md
index 6c3e73009..560158226 100644
--- a/docs/cn/Deploy-skywalking-agent-CN.md
+++ b/docs/cn/Deploy-skywalking-agent-CN.md
@@ -67,7 +67,7 @@ logging.level=DEBUG
 - 配置除了通过`/config/agent.config`文件外，可以通过环境变量和VM参数（-D）来进行设置
   - 参数的key = `skywalking.` + `agent.config`文件中的key
   - 优先级：系统环境变量 > VM参数（-D） > `/config/agent.config`中的配置
-- Log默认使用文件输出，输出到`/log`目录中
+- Log默认使用文件输出，输出到`/logs`目录中
 
 # Tomcat配置探针FAQ
 - Tomcat 7
diff --git a/docs/cn/Direct-uplink-CN.md b/docs/cn/Direct-uplink-CN.md
new file mode 100644
index 0..dc35c8d32
--- /dev/null
+++ b/docs/cn/Direct-uplink-CN.md
@@ -0,0

[GitHub] coveralls commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
coveralls commented on issue #1062: chinese documents translation, sync with 
english
URL: 
https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380317246
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16453361/badge)](https://coveralls.io/builds/16453361)
   
   Coverage remained the same at 19.763% when pulling 
**d7ad53db499c9112c1e7ef2104a5cb28e886ac76 on candyleer:doc_cn** into 
**99dc132d72ba967b605bf98c5132a1e30f8504f4 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #871: Add elasticSearch-http storage module.

2018-04-10 Thread GitBox 
wu-sheng commented on issue #871: Add elasticSearch-http storage module.
URL: 
https://github.com/apache/incubator-skywalking/pull/871#issuecomment-380315966
 
 
   @cyberdak Related pr #1063 proposed, please see. If we agree with all things 
we have discussed, please consider to 
   1. Add `(Incubating)` in your document title
   1. Solve conflict
   1. Follow my previous comments, e.g. remove the setting in 
`application.yml`, even in comments.
   1. Passed the CI
   
   Then I will start to merge. @cyberdak You can test in your company env, and 
provide us more feedback about this feature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #1063: Add an incubating feature section for preparing to merge ElasticSearch HTTP implementor

2018-04-10 Thread GitBox 
wu-sheng opened a new pull request #1063: Add an incubating feature section for 
preparing to merge ElasticSearch HTTP implementor
URL: https://github.com/apache/incubator-skywalking/pull/1063
 
 
   @peng-yongsheng @cyberdak 
   
   In case the SkyWalking iteration is fast, and ES HTTP implementor has no 
hard in default. I added this section in official English document, @cyberdak 
please add you document link to here.
   
   Then we can prepare for merging the feature, and provide to the community. 
@cyberdak will lead the maintain works for this.
   
   Sounds good?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1062: chinese documents translation, sync with 
english
URL: 
https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380312285
 
 
   > dose it relate with this pr? this make me confused when i just update the 
documents only
   
   You update submodule to another unexisted commitid. My guess, it is related 
to your fork repo. So please reverse it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
candyleer commented on issue #1062: chinese documents translation, sync with 
english
URL: 
https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380312294
 
 
   @wu-sheng yeah,i found it ,i will remove this dirty commit and commit again


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #998: GraphQL type AppServerInfo#name rename and redefine.

2018-04-10 Thread GitBox 
wu-sheng closed issue #998: GraphQL type AppServerInfo#name rename and redefine.
URL: https://github.com/apache/incubator-skywalking/issues/998
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #998: GraphQL type AppServerInfo#name rename and redefine.

2018-04-10 Thread GitBox 
wu-sheng commented on issue #998: GraphQL type AppServerInfo#name rename and 
redefine.
URL: 
https://github.com/apache/incubator-skywalking/issues/998#issuecomment-380311275
 
 
   Frontend has been fixed by 
https://github.com/apache/incubator-skywalking-ui/pull/154
   
   Closing. Thanks @candyleer


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
candyleer commented on issue #1062: chinese documents translation, sync with 
english
URL: 
https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380310593
 
 
   @peng-yongsheng  travis-ci has failed cause of:
   ```
   error: Server does not allow request for unadvertised object 
cad43d3d6a0bfa3cc5cb4e9a58f3ae2e3dee73c7
   Fetched in submodule path 'skywalking-ui', but it did not contain 
cad43d3d6a0bfa3cc5cb4e9a58f3ae2e3dee73c7. Direct fetching of that commit failed.
   ```
   dose it relate with this pr? this make me confused when i just update the 
documents only


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
candyleer commented on issue #1062: chinese documents translation, sync with 
english
URL: 
https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380308866
 
 
   Direct uplink translation maybe not correct.please check 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer opened a new pull request #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox 
candyleer opened a new pull request #1062: chinese documents translation, sync 
with english
URL: https://github.com/apache/incubator-skywalking/pull/1062
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   - [x] document
   
   - Related issues
   #1024 
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng commented on issue #1047: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox 
peng-yongsheng commented on issue #1047: Refactor the collector configuration 
initialization.
URL: 
https://github.com/apache/incubator-skywalking/issues/1047#issuecomment-380306733
 
 
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng closed issue #1047: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox 
peng-yongsheng closed issue #1047: Refactor the collector configuration 
initialization.
URL: https://github.com/apache/incubator-skywalking/issues/1047
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng closed issue #1050: Add a FAQ about SkyWalking upgrade

2018-04-10 Thread GitBox 
peng-yongsheng closed issue #1050: Add a FAQ about SkyWalking upgrade
URL: https://github.com/apache/incubator-skywalking/issues/1050
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng commented on issue #1050: Add a FAQ about SkyWalking upgrade

2018-04-10 Thread GitBox 
peng-yongsheng commented on issue #1050: Add a FAQ about SkyWalking upgrade
URL: 
https://github.com/apache/incubator-skywalking/issues/1050#issuecomment-380306680
 
 
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: 
https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380304104
 
 
   @wu-sheng yes, I agree with your opinion because I also see the starting 
script. So I just wonder the reason. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: 
https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380303407
 
 
   @weenyaimac I don't know that. They are two separated processes in OS, just 
start up by one script. So I didn't think there is any connection between them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: 
https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380300905
 
 
   Ok, I will try my best. 
   I also have another question with it. Why webapp process also quits when 
collector process quits?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: 
https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380300247
 
 
   > Thanks. I see, and the document isn't right, it writes 'Elasticsearch 5.x'
   
   Yes. If you have time, please send a pull request to fix this document for 
helping others. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: 
https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380300081
 
 
   Thanks. I see, and the document isn't right, it writes 'Elasticsearch 5.x'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: 
https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380299114
 
 
   Hi, from the document, we only supported 5.x 
(https://github.com/apache/incubator-skywalking/blob/master/docs/en/Deploy-backend-in-cluster-mode.md#required-of-third-party-softwares),
 already mentioned. 
   
   From my experience, 5.3 or 5.5 should be a good choice.
   
   @peng-yongsheng I think we don't support 5.6, the document isn't right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
wu-sheng closed issue #1061: Collector throws NoNodeAvailableException using 
Elasticsearch 6.2.3
URL: https://github.com/apache/incubator-skywalking/issues/1061
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weenyaimac opened a new issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox 
weenyaimac opened a new issue #1061: Collector throws NoNodeAvailableException 
using Elasticsearch 6.2.3
URL: https://github.com/apache/incubator-skywalking/issues/1061
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   
   Collector will throw 'NoNodeAvailableException' when starting if I use ES 
6.2.3 as storage. The detailed exception message from collector.log is as 
follows:
   
   `Exception in thread "main" NoNodeAvailableException[None of the configured 
nodes are available: 
[{#transport#-1}{S77BV75vRxewCFuNupH8LQ}{10.79.10.69}{10.79.10.69:9200}, 
{#transpor
   t#-2}{ptgYMMWCSIamqACJMgnwkQ}{10.79.10.68}{10.79.10.68:9200}]]
at 
org.elasticsearch.client.transport.TransportClientNodesService.ensureNodesAreAvailable(TransportClientNodesService.java:347)
at 
org.elasticsearch.client.transport.TransportClientNodesService.execute(TransportClientNodesService.java:245)
at 
org.elasticsearch.client.transport.TransportProxyClient.execute(TransportProxyClient.java:59)
at 
org.elasticsearch.client.transport.TransportClient.doExecute(TransportClient.java:363)
at 
org.elasticsearch.client.support.AbstractClient.execute(AbstractClient.java:408)
at 
org.elasticsearch.client.support.AbstractClient$IndicesAdmin.execute(AbstractClient.java:1256)
at 
org.elasticsearch.action.ActionRequestBuilder.execute(ActionRequestBuilder.java:80)
at 
org.elasticsearch.action.ActionRequestBuilder.execute(ActionRequestBuilder.java:54)
at 
org.elasticsearch.action.ActionRequestBuilder.get(ActionRequestBuilder.java:62)
at 
org.apache.skywalking.apm.collector.client.elasticsearch.ElasticSearchClient.isExistsIndex(ElasticSearchClient.java:131)
at 
org.apache.skywalking.apm.collector.storage.es.base.define.ElasticSearchStorageInstaller.isExists(ElasticSearchStorageInstaller.java:129)
at 
org.apache.skywalking.apm.collector.storage.StorageInstaller.install(StorageInstaller.java:46)
at 
org.apache.skywalking.apm.collector.storage.es.StorageModuleEsProvider.start(StorageModuleEsProvider.java:294)
at 
org.apache.skywalking.apm.collector.core.module.BootstrapFlow.start(BootstrapFlow.java:63)
at 
org.apache.skywalking.apm.collector.core.module.ModuleManager.init(ModuleManager.java:70)
at 
org.apache.skywalking.apm.collector.boot.CollectorBootStartUp.main(CollectorBootStartUp.java:43)
   `
   
   My collector is  a standalone server, and related detailed configuration 
from application.yml is as follows:
   
   `ui:
 jetty:
   host: 10.79.10.69
   port: 12800
   context_path: /
   
   storage:
 elasticsearch:
   cluster_name: collector-db-cluster
   cluster_transport_sniffer: true
   cluster_nodes: 10.79.10.69:9200,10.79.10.68:9200
   index_shards_number: 2
   index_replicas_number: 0
   ttl: 7` 
   
   Is the ES version too high, right?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1060: the menu icons cannot be displayed without internet

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1060: the menu icons cannot be displayed without 
internet
URL: 
https://github.com/apache/incubator-skywalking/issues/1060#issuecomment-380295403
 
 
   @hanahmily Please check whether this can be fixed in beta. I would not think 
this is a serious problem, but somewhere (ex bank system in this issue ) may 
don't have internet access.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] breakenknife opened a new issue #1060: the menu icons cannot be displayed without internet

2018-04-10 Thread GitBox 
breakenknife opened a new issue #1060: the menu icons cannot be displayed 
without internet
URL: https://github.com/apache/incubator-skywalking/issues/1060
 
 
   
   
   As the figure above shows,the smallicons of menu is missing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1059: Update README_ZH.md

2018-04-10 Thread GitBox 
coveralls commented on issue #1059: Update README_ZH.md
URL: 
https://github.com/apache/incubator-skywalking/pull/1059#issuecomment-380153358
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16440901/badge)](https://coveralls.io/builds/16440901)
   
   Coverage remained the same at 19.763% when pulling 
**04c4ccbab3e4e74ee4f282831b3b8ee300875d5f on peng-yongsheng-patch-1** into 
**931f3cfb50f4365dc44583df32ff7417e2486e9c on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng opened a new pull request #1059: Update README_ZH.md

2018-04-10 Thread GitBox 
peng-yongsheng opened a new pull request #1059: Update README_ZH.md
URL: https://github.com/apache/incubator-skywalking/pull/1059
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [X] Document
   
   Style issues when use *.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #1052: Collector 5.0.0-alpha version upgrade FAQ.

2018-04-10 Thread GitBox 
wu-sheng closed pull request #1052: Collector 5.0.0-alpha version upgrade FAQ.
URL: https://github.com/apache/incubator-skywalking/pull/1052
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/README.md b/docs/README.md
index a3bb22fbe..fefc0a63a 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -38,4 +38,5 @@
 * [Why only traces in UI?](cn/FAQ/Why-have-traces-no-others.md)
 * [Too many GRPC logs in the console](cn/FAQ/Too-many-gRPC-logs.md)
 * [The trace doesn't continue in kafka consumer 
side](en/FAQ/kafka-plugin.md)
-
+* [Agent or collector version upgrade](en/FAQ/Upgrade.md)
+
\ No newline at end of file
diff --git a/docs/en/FAQ/Upgrade.md b/docs/en/FAQ/Upgrade.md
new file mode 100644
index 0..2f18bb8b4
--- /dev/null
+++ b/docs/en/FAQ/Upgrade.md
@@ -0,0 +1,12 @@
+# Upgrade FAQs
+## Version 3.x -> 5.0.0-alpha
+### Collector
+- **Problem**
+There is no information showing in the UI.
+
+- **Cause**
+In upgrate from 3.2.6 to 5.0.0, Elasticsearch indexes aren't recreated, 
because not indexes exist, but aren't compatible with 5.0.0-alpha.
+When service name registered, the es will create this column by default type 
string, which is wrong.
+
+- **Solution**
+Clean the data folder in ElasticSearch and restart ElasticSearch, collector 
and your under monitoring application.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ.

2018-04-10 Thread GitBox 
coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ.
URL: 
https://github.com/apache/incubator-skywalking/pull/1052#issuecomment-379615075
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16438214/badge)](https://coveralls.io/builds/16438214)
   
   Coverage remained the same at 19.763% when pulling 
**eb77c92b8bf16b850401082f9a8f991ea4d2af61 on 
peng-yongsheng:document/upgrade_faq** into 
**4eb5dabbea40645c687d008cb174fa10c0d069be on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1058: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox 
coveralls commented on issue #1058: Refactor the collector configuration 
initialization.
URL: 
https://github.com/apache/incubator-skywalking/pull/1058#issuecomment-380094356
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16437000/badge)](https://coveralls.io/builds/16437000)
   
   Coverage decreased (-0.03%) to 19.763% when pulling 
**62f6aa946d3ebb3b95653a8023a806bcf0351aee on peng-yongsheng:feature/1047** 
into **8abb01dce255ce4ef12a599eb43c5873f92fe851 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ.

2018-04-10 Thread GitBox 
coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ.
URL: 
https://github.com/apache/incubator-skywalking/pull/1052#issuecomment-379615075
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16436683/badge)](https://coveralls.io/builds/16436683)
   
   Coverage increased (+0.03%) to 19.79% when pulling 
**9bada1b05adeb2f6529ca974c08cc6e64645c4e3 on 
peng-yongsheng:document/upgrade_faq** into 
**566f7f8fbc73a4195dc17aa2a1b9d9c3f27eb4c4 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #1057: fix #1055 and make code more readable

2018-04-10 Thread GitBox 
wu-sheng closed pull request #1057: fix #1055 and make code more readable
URL: https://github.com/apache/incubator-skywalking/pull/1057
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
 
b/apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
index f98a2b854..c224aa5a2 100644
--- 
a/apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
+++ 
b/apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
@@ -59,72 +59,91 @@ public static void premain(String agentArgs, 
Instrumentation instrumentation) th
 
 pluginFinder = new PluginFinder(new 
PluginBootstrap().loadPlugins());
 
-ServiceManager.INSTANCE.boot();
 } catch (Exception e) {
 logger.error(e, "Skywalking agent initialized failure. Shutting 
down.");
 return;
 }
 
+new AgentBuilder.Default()
+.type(pluginFinder.buildMatch())
+.transform(new Transformer(pluginFinder))
+.with(new Listener())
+.installOn(instrumentation);
+
+try {
+ServiceManager.INSTANCE.boot();
+} catch (Exception e) {
+logger.error(e, "Skywalking agent boot failure.");
+}
+
 Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
 @Override public void run() {
 ServiceManager.INSTANCE.shutdown();
 }
 }, "skywalking service shutdown thread"));
+}
 
-new 
AgentBuilder.Default().type(pluginFinder.buildMatch()).transform(new 
AgentBuilder.Transformer() {
-@Override
-public DynamicType.Builder transform(DynamicType.Builder 
builder, TypeDescription typeDescription,
-ClassLoader classLoader, JavaModule module) {
-List pluginDefines = 
pluginFinder.find(typeDescription, classLoader);
-if (pluginDefines.size() > 0) {
-DynamicType.Builder newBuilder = builder;
-EnhanceContext context = new EnhanceContext();
-for (AbstractClassEnhancePluginDefine define : 
pluginDefines) {
-DynamicType.Builder possibleNewBuilder = 
define.define(typeDescription.getTypeName(), newBuilder, classLoader, context);
-if (possibleNewBuilder != null) {
-newBuilder = possibleNewBuilder;
-}
-}
-if (context.isEnhanced()) {
-logger.debug("Finish the prepare stage for {}.", 
typeDescription.getName());
-}
+private static class Transformer implements AgentBuilder.Transformer {
+private PluginFinder pluginFinder;
 
-return newBuilder;
+Transformer(PluginFinder pluginFinder) {
+this.pluginFinder = pluginFinder;
+}
+
+@Override
+public DynamicType.Builder transform(DynamicType.Builder 
builder, TypeDescription typeDescription, ClassLoader classLoader, JavaModule 
module) {
+List pluginDefines = 
pluginFinder.find(typeDescription, classLoader);
+if (pluginDefines.size() > 0) {
+DynamicType.Builder newBuilder = builder;
+EnhanceContext context = new EnhanceContext();
+for (AbstractClassEnhancePluginDefine define : pluginDefines) {
+DynamicType.Builder possibleNewBuilder = 
define.define(typeDescription.getTypeName(), newBuilder, classLoader, context);
+if (possibleNewBuilder != null) {
+newBuilder = possibleNewBuilder;
+}
+}
+if (context.isEnhanced()) {
+logger.debug("Finish the prepare stage for {}.", 
typeDescription.getName());
 }
 
-logger.debug("Matched class {}, but ignore by finding 
mechanism.", typeDescription.getTypeName());
-return builder;
+return newBuilder;
 }
-}).with(new AgentBuilder.Listener() {
-@Override
-public void onDiscovery(String typeName, ClassLoader classLoader, 
JavaModule module, boolean loaded) {
 
-}
+logger.debug("Matched class {}, but ignore by finding mechanism.", 
typeDescription.getTypeName());
+return builder;
+}
+}
 
-@Override
-public void onTransformation(TypeDescription typeDescription, 
ClassLoader classLoader, JavaModule module,
-

[GitHub] ascrutae commented on issue #1057: fix #1055 and make code more readable

2018-04-10 Thread GitBox 
ascrutae commented on issue #1057: fix #1055 and make code more readable
URL: 
https://github.com/apache/incubator-skywalking/pull/1057#issuecomment-380019836
 
 
   This PR is passed. Here is the [test 
report](https://github.com/SkywalkingTest/agent-integration-test-report/blob/master/2018/4/candyleer/testReport-master-2018-04-10-13-15.md)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hanahmily commented on issue #1058: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox 
hanahmily commented on issue #1058: Refactor the collector configuration 
initialization.
URL: 
https://github.com/apache/incubator-skywalking/pull/1058#issuecomment-380013410
 
 
   I've got it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1058: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1058: Refactor the collector configuration 
initialization.
URL: 
https://github.com/apache/incubator-skywalking/pull/1058#issuecomment-380011255
 
 
   @peng-yongsheng Your CI fails.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1004: on the web ui startTime auto refresh?

2018-04-10 Thread GitBox 
wu-sheng commented on issue #1004:  on the web ui startTime  auto refresh?
URL: 
https://github.com/apache/incubator-skywalking/issues/1004#issuecomment-379986184
 
 
   Fixed and closing this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer commented on issue #1004: on the web ui startTime auto refresh?

2018-04-10 Thread GitBox 
candyleer commented on issue #1004: on the web ui startTime  auto refresh?
URL: 
https://github.com/apache/incubator-skywalking/issues/1004#issuecomment-379986042
 
 
   @xjr100419 this bug has been fixed in skywalking-ui module in 
[https://github.com/apache/incubator-skywalking-ui/pull/156](https://github.com/apache/incubator-skywalking-ui/pull/156)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services