[GitHub] carlvine500 opened a new pull request #1067: add doc for TraceCrossThread

carlvine500 opened a new pull request #1067: add doc for TraceCrossThread URL: https://github.com/apache/incubator-skywalking/pull/1067 ### New feature or improvement - add doc for TraceCrossThread This is an

[GitHub] nikitap492 opened a new pull request #1069: Replaced ObjectUtils for java.utils.Objects methods

nikitap492 opened a new pull request #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] coveralls commented on issue #845: add jdk-cross-thread-plugin

coveralls commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516 [](https://coveralls.io/builds/16458762) Coverage increased (+0.05%)

[GitHub] wu-sheng closed pull request #1066: Update README.md

wu-sheng closed pull request #1066: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/1066 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] coveralls commented on issue #1067: add doc for TraceCrossThread

coveralls commented on issue #1067: add doc for TraceCrossThread URL: https://github.com/apache/incubator-skywalking/pull/1067#issuecomment-380388288 [](https://coveralls.io/builds/16457290) Coverage remained the

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

wu-sheng commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380382159 @ascrutae https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/15 is still open. Please feedback the status, thanks.

[GitHub] wu-sheng opened a new pull request #1068: GraphQL for Thermodynamic in overview page.

wu-sheng opened a new pull request #1068: GraphQL for Thermodynamic in overview page. URL: https://github.com/apache/incubator-skywalking/pull/1068 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

carlvine500 commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380381521 test is ok now 

[GitHub] coveralls commented on issue #1067: add doc for TraceCrossThread

coveralls commented on issue #1067: add doc for TraceCrossThread URL: https://github.com/apache/incubator-skywalking/pull/1067#issuecomment-380388288 [](https://coveralls.io/builds/16456822) Coverage remained the

[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380493664 @nikitap492 For better and easier review and further merge, I recommend you close this pr, and open several

[GitHub] nikitap492 commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

nikitap492 commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480827 There is no defference between these two methods. It is just a good practice to use already written methods,

[GitHub] coveralls commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

coveralls commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480149 [](https://coveralls.io/builds/16462289)

[GitHub] nikitap492 commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

nikitap492 commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480827 There is no defference between these two methods. It is just a good practice to use already written methods,

[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104 @nikitap492 Thanks. That is better to understand your pr. Then I will focus on codes only for this pr. At

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

wu-sheng commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380643444 > we expect to create a span in parent thread when I run a main method , and parent thread's globalTraceId will join the children thread

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

carlvine500 commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380648218 meaningless but a little useful . span created once in parent span, cost is limited . if we skip trace when there is no active context

[GitHub] wu-sheng commented on issue #940: [skywalking-ui]Request Error 500

wu-sheng commented on issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380643161 @peng-yongsheng I am wondering, whether this is a problem about too much data in single one query for ElasticSearch or Collector? `500`

[GitHub] wu-sheng commented on issue #940: [skywalking-ui]Request Error 500

wu-sheng commented on issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380648224 @weenyaimac Yes, I am aware that shell. Do you mean other people don't know that, they should change the shell when they deploy the

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

carlvine500 commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380643087 1. I agree with your idea 2. we expect to create a span in parent thread when I run a main method , and parent thread's globalTraceId

[GitHub] peng-yongsheng commented on issue #940: [skywalking-ui]Request Error 500

peng-yongsheng commented on issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380646714 Exception is `Read timed out`, maybe the query performance is poor with 1 hour data of application function.

[GitHub] wu-sheng commented on issue #940: [skywalking-ui]Request Error 500

wu-sheng commented on issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380646976 @peng-yongsheng Yes. 1 hours is most likely the largest duration (considering result points). Look like a performance issue.

[GitHub] wu-sheng commented on issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running

wu-sheng commented on issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running URL: https://github.com/apache/incubator-skywalking/issues/974#issuecomment-380340050 @archer-christ `TraceContext.traceId()` is based on SkyWalking agent core too, this

[GitHub] wu-sheng closed issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running

wu-sheng closed issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running URL: https://github.com/apache/incubator-skywalking/issues/974 This is an automated message from the Apache

[GitHub] wu-sheng opened a new pull request #1066: Update README.md

wu-sheng opened a new pull request #1066: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/1066 Fix format This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] coveralls commented on issue #1066: Update README.md

coveralls commented on issue #1066: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/1066#issuecomment-380347372 [](https://coveralls.io/builds/16454862) Coverage remained the same at 19.763%

[GitHub] coveralls commented on issue #845: add jdk-cross-thread-plugin

coveralls commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516 [](https://coveralls.io/builds/16475338) Coverage increased (+0.03%)

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

wu-sheng commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380654667 > meaningless but a little useful . span created once in parent span, cost is limited . if we skip trace when there is no active context ,

[GitHub] carlvine500 opened a new pull request #1070: add ContextManager.isActive()

carlvine500 opened a new pull request #1070: add ContextManager.isActive() URL: https://github.com/apache/incubator-skywalking/pull/1070 ___ ### New feature or improvement add ContextManager.isActive() This is an

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

carlvine500 commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380658521 thank for your suggestion, remove redundant LocalSpan in parent thread looks all right in skywalking-ui . http

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

carlvine500 commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380658521 thank for your suggestion, remove redundant LocalSpan in parent thread looks all right in skywalking-ui . http

[GitHub] coveralls commented on issue #1070: add ContextManager.isActive()

coveralls commented on issue #1070: add ContextManager.isActive() URL: https://github.com/apache/incubator-skywalking/pull/1070#issuecomment-380662810 [](https://coveralls.io/builds/16474298) Coverage decreased

[GitHub] coveralls commented on issue #1070: add ContextManager.isActive()

coveralls commented on issue #1070: add ContextManager.isActive() URL: https://github.com/apache/incubator-skywalking/pull/1070#issuecomment-380662810 [](https://coveralls.io/builds/16474320) Coverage decreased

[GitHub] wu-sheng closed pull request #1070: add ContextManager.isActive()

wu-sheng closed pull request #1070: add ContextManager.isActive() URL: https://github.com/apache/incubator-skywalking/pull/1070 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] wu-sheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？

wu-sheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？ URL: https://github.com/apache/incubator-skywalking/issues/1065#issuecomment-380670103 Closing this. This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng closed issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？

wu-sheng closed issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？ URL: https://github.com/apache/incubator-skywalking/issues/1065 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] coveralls commented on issue #845: add jdk-cross-thread-plugin

coveralls commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516 [](https://coveralls.io/builds/16473742) Coverage increased (+0.04%)

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

carlvine500 commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380658521 thank for your suggestion, remove redundant LocalSpan in parent thread looks all right in skywalking-ui .

[GitHub] coveralls commented on issue #845: add jdk-cross-thread-plugin

coveralls commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516 [](https://coveralls.io/builds/16474274) Coverage increased (+0.04%)

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

wu-sheng commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380667733 #1070 has been merged. Please adjust, recheck and rerun the tests. @ascrutae After this is done, post the test report here.