[GitHub] wu-sheng commented on a change in pull request #1109: New Change logs for next release
wu-sheng commented on a change in pull request #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#discussion_r186316040 ## File path: CHANGES.md ## @@ -1,19 +1,79 @@ Changes by Version == Release Notes. + + 5.0.0-beta + -- + + UI -> Collector GraphQL query protocol + - Replace all tps to throughtput/cpm(calls per min) + - Add `getThermodynamic` service + - Update version to beta + + Agent Changes + - Support TLS. + - Support namespace. + - Support direct link. + - Support token. + - Add across thread toolkit. + - Add new plugin extend machenism to override agent core implementations. + - Fix an agent start up sequence bug. + - Fix wrong gc count. + - Remove system env override. + - Add Spring AOP aspect patch to avoid aop conflicts. + + Collector Changes + - Trace query based on timeline. + - Delete JVM aggregation in second. + - Support TLS. + - Support namespace. + - Support token auth. + - Group and aggregate requests based on reponse time and timeline, support Thermodynamic chart query + - Support component librariy setting through yml file for better extendibility. + - Optimize performance. + - Support short column name in ES or other storage implementor. + - Add a new cache module implementor, based on **Caffeine**. + - Support system property override settings. + - Refactor settings initialization. + - Provide collector instrumentation agent. + - Support .NET core component libraries. + - Fix `divide zero` in query. + - Fix `Data don't remove as expected` in ES implementor. + - Add some checks in collector modulization core. + - Add some test cases. + + UI Changes + - New trace query UI. + - New Application UI, merge server tab(removed) into applciation as sub page. + - Add Thermodynamic chart in overview page. + - Change all tps to cpm(calls per minutes). + - Fix wrong osName in server view. + - Fix wrong startTime in trace view. + - Fix some icons internet requirements. Review comment: @hanahmily Updated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1181: Provide dynamic refresh file in agent
wu-sheng opened a new issue #1181: Provide dynamic refresh file in agent URL: https://github.com/apache/incubator-skywalking/issues/1181 This requirement came from the upgrade, SkyWalking's agent and protocol are stable enough, and didn't need to update for a long time. But considering right now, there are a lot of buffer in agent, so end users must reboot the monitored applications to upgrade backend, which caused by backend upgrade is not forward-compatible. I proposal to provide a dynamic flush like this: ```properties # false by default, change to `true` if need runtime refresh. # After refresh happends, agent will rewrite this to true. need_refresh=false # default value is reboot time. After refresh happends, agent will rewrite this timestamp last_refresh_time = x ``` By having this feature, the backend break upgrade should be: 1. Stop all backends. 1. Clear the ElasticSearch data. 1. Set all flush file to **true**, and wait all agents refreshed and updated the new refresh time. 1. Start up new version collector. FYI @hanahmily @peng-yongsheng @liuhaoyang @yuleyule66 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1181: Provide dynamic refresh file in agent
ascrutae commented on issue #1181: Provide dynamic refresh file in agent URL: https://github.com/apache/incubator-skywalking/issues/1181#issuecomment-386951992 Get it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #1109: New Change logs for next release
hanahmily commented on a change in pull request #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#discussion_r186314768 ## File path: CHANGES.md ## @@ -1,19 +1,79 @@ Changes by Version == Release Notes. + + 5.0.0-beta + -- + + UI -> Collector GraphQL query protocol + - Replace all tps to throughtput/cpm(calls per min) + - Add `getThermodynamic` service + - Update version to beta + + Agent Changes + - Support TLS. + - Support namespace. + - Support direct link. + - Support token. + - Add across thread toolkit. + - Add new plugin extend machenism to override agent core implementations. + - Fix an agent start up sequence bug. + - Fix wrong gc count. + - Remove system env override. + - Add Spring AOP aspect patch to avoid aop conflicts. + + Collector Changes + - Trace query based on timeline. + - Delete JVM aggregation in second. + - Support TLS. + - Support namespace. + - Support token auth. + - Group and aggregate requests based on reponse time and timeline, support Thermodynamic chart query + - Support component librariy setting through yml file for better extendibility. + - Optimize performance. + - Support short column name in ES or other storage implementor. + - Add a new cache module implementor, based on **Caffeine**. + - Support system property override settings. + - Refactor settings initialization. + - Provide collector instrumentation agent. + - Support .NET core component libraries. + - Fix `divide zero` in query. + - Fix `Data don't remove as expected` in ES implementor. + - Add some checks in collector modulization core. + - Add some test cases. + + UI Changes + - New trace query UI. + - New Application UI, merge server tab(removed) into applciation as sub page. + - Add Thermodynamic chart in overview page. + - Change all tps to cpm(calls per minutes). + - Fix wrong osName in server view. + - Fix wrong startTime in trace view. + - Fix some icons internet requirements. Review comment: Missing issues: New Topology UI. New response time / throughput TopN list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1109: New Change logs for next release
coveralls commented on issue #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#issuecomment-383520328 [](https://coveralls.io/builds/16858467) Coverage remained the same at 23.358% when pulling **f6ad0e31adf776406b4a95f9599622568cdd811e on beta-changes** into **db8b931cbbad8e20efa43058cc35f5b4b460ccec on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1109: New Change logs for next release
coveralls commented on issue #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#issuecomment-383520328 [](https://coveralls.io/builds/16858674) Coverage increased (+0.004%) to 23.362% when pulling **ec5347a1764ca9022c19471e57584ddcae418746 on beta-changes** into **db8b931cbbad8e20efa43058cc35f5b4b460ccec on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng closed pull request #1179: Fix first formula, like #1164
peng-yongsheng closed pull request #1179: Fix first formula, like #1164
URL: https://github.com/apache/incubator-skywalking/pull/1179
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/MergePersistenceWorker.java
b/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/MergePersistenceWorker.java
index 4f4786eae..2fc7d8049 100644
---
a/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/MergePersistenceWorker.java
+++
b/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/MergePersistenceWorker.java
@@ -86,6 +86,7 @@ public MergePersistenceWorker(ModuleManager moduleManager) {
if (mergeDataCache.containsKey(input.getId())) {
mergeDataCache.get(input.getId()).mergeAndFormulaCalculateData(input);
} else {
+input.calculateFormula();
mergeDataCache.put(input.getId(), input);
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1179: Fix first formula, like #1164
coveralls commented on issue #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179#issuecomment-386851449 [](https://coveralls.io/builds/16854343) Coverage increased (+0.004%) to 23.36% when pulling **3f6855267e2d5dc11f2670f456515ee48bb20f70 on candyleer:fix_first_formula** into **bd28d447d188d173550c05cc27ab3a800dab1b84 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1178: Fix If traceId not exists result will return all traces
coveralls commented on issue #1178: Fix If traceId not exists result will return all traces URL: https://github.com/apache/incubator-skywalking/pull/1178#issuecomment-386815145 [](https://coveralls.io/builds/16854366) Coverage increased (+0.006%) to 23.362% when pulling **2de9e5268376cd55c3821f7585460f2470f3484e on candyleer:fix_when_traceid_not_exists** into **bd28d447d188d173550c05cc27ab3a800dab1b84 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1178: Fix If traceId not exists result will return all traces
coveralls commented on issue #1178: Fix If traceId not exists result will return all traces URL: https://github.com/apache/incubator-skywalking/pull/1178#issuecomment-386815145 [](https://coveralls.io/builds/16854509) Coverage increased (+0.002%) to 23.362% when pulling **95c5d31e5657cc1630d39e072aa13fd15aa8c20b on candyleer:fix_when_traceid_not_exists** into **d14eb2be3f9d5956735aa7240104df0d7fc1a07e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng closed pull request #1178: Fix If traceId not exists result will return all traces
peng-yongsheng closed pull request #1178: Fix If traceId not exists result will
return all traces
URL: https://github.com/apache/incubator-skywalking/pull/1178
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/SegmentTopService.java
b/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/SegmentTopService.java
index b9f362f3e..55a356f28 100644
---
a/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/SegmentTopService.java
+++
b/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/SegmentTopService.java
@@ -20,6 +20,7 @@
import java.util.List;
import org.apache.skywalking.apm.collector.core.module.ModuleManager;
+import org.apache.skywalking.apm.collector.core.util.CollectionUtils;
import org.apache.skywalking.apm.collector.core.util.StringUtils;
import org.apache.skywalking.apm.collector.storage.StorageModule;
import org.apache.skywalking.apm.collector.storage.dao.ui.IGlobalTraceUIDAO;
@@ -54,6 +55,9 @@ public TraceBrief loadTop(long startSecondTimeBucket, long
endSecondTimeBucket,
TraceBrief traceBrief;
if (StringUtils.isNotEmpty(traceId)) {
List segmentIds = globalTraceUIDAO.getSegmentIds(traceId);
+if (CollectionUtils.isEmpty(segmentIds)) {
+return new TraceBrief();
+}
traceBrief = segmentDurationUIDAO.loadTop(startSecondTimeBucket,
endSecondTimeBucket, minDuration, maxDuration, operationName, applicationId,
limit, from, segmentIds.toArray(new String[0]));
} else {
traceBrief = segmentDurationUIDAO.loadTop(startSecondTimeBucket,
endSecondTimeBucket, minDuration, maxDuration, operationName, applicationId,
limit, from);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
