[GitHub] wu-sheng closed pull request #1249: Provide runtime context.
wu-sheng closed pull request #1249: Provide runtime context. URL: https://github.com/apache/incubator-skywalking/pull/1249 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1251: Add sha512 into the release vote mail
wu-sheng opened a new issue #1251: Add sha512 into the release vote mail URL: https://github.com/apache/incubator-skywalking/issues/1251 In the beta release vote: ``` > Release Candidate: > *https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-beta/ I strongly recommend using suffixes like -RC1 in the release candidate URL and tag -- how do voters (and anyone checking the vote later) know if you happened to make a 'second 5.0.0-beta' release candidate? For that reason the VOTE email should also include svn revision number from dist.apache.org, and/oor sha checksum of the files under vote. Assuming r26864 (from "svn log") aka sha512 checksums 33b13cc7bc4ddea46d727ed8910c54c2e3b9acd6614a7f937e01e34ae6403942791ec3505d16de674605c665a4c0805271eb90a94775701d941462c530a99d11 apache-skywalking-apm-incubating-5.0.0-beta-src.tgz 770ad70ad3e23fbd93ea675528a81735848a92557f91036b23652b4c2a0282a7198bf9a09fd4570f8bef180d956e81e4f93a9c2308106de1b3d815feeb0dfd84 apache-skywalking-apm-incubating-5.0.0-beta.tar.gz d4ca36ed94a6d3557b747fe3ba3daf1dee5dca6d0f827af404762344c41214b4e5ff2173536e6c2feac383d9d0bdbaa648a5f0b8eee9f1b0913734d2c5adfffa apache-skywalking-apm-incubating-5.0.0-beta.zip ``` Make the adjustments in release doc. - Add sha512 text into the mail **Release Candidate:** section. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1240: Add application filter for service and two conditions for trace query.
wu-sheng commented on issue #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240#issuecomment-390684847 @peng-yongsheng @hanahmily I wouldn't merge, or try to merge this pr. Please consider this as a place to discuss only. Since you agree on this, you can send your separated PRs to support this query. I will keep this open until the two PRS merged. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span
wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-390598555 > Now,I have an application and it is slow in some machine, but i don't know which machine, so Do we need add hostname or other info to traceSegment or add tag to span? There is an application id and instance id in every segment, which include application code, machine info, such as ip, hostname, processid. I think I can move this into a query requirement for trace, to discuss whether could we provide this in beta2. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new issue #1248: Hope to add hostname or ip to traceSegment or span
candyleer opened a new issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [x] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. Now,I have an application and it is slow in some machine, but i don't know which machine, so Do we need add `hostname` or other info to traceSegment or add tag to span? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #1249: Provide runtime context.
wu-sheng opened a new pull request #1249: Provide runtime context. URL: https://github.com/apache/incubator-skywalking/pull/1249 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related issues ___ A simple trace runtime context0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span
wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-390598792 @hanahmily @peng-yongsheng What do you think about this in beta2? It makes sense in some cases. I am just not sure about the milestone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1249: Provide runtime context.
ascrutae commented on issue #1249: Provide runtime context. URL: https://github.com/apache/incubator-skywalking/pull/1249#issuecomment-390609933 Ref: #1243 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new issue #1250: Dashboard to Service page Error
candyleer opened a new issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? request dashbord ``` http://localhost:8000/api/dashboard ``` response ```
[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-390805885 @candyleer Can you provide me your zipkin demo? I will do this in these days. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes
candyleer commented on issue #1215: No traceId In trace page sometimes
URL:
https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390832701
this may caused by `global_trace` not initialized for current trace id
```java
traceBrief.getTraces().forEach(trace -> {
List traceIds =
globalTraceUIDAO.getGlobalTraceId(trace.getSegmentId());
trace.getTraceIds().addAll(traceIds);
});
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes
candyleer commented on issue #1215: No traceId In trace page sometimes
URL:
https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390832701
this may caused by `global_trace` not initialized for current trace id
```
traceBrief.getTraces().forEach(trace -> {
List traceIds =
globalTraceUIDAO.getGlobalTraceId(trace.getSegmentId());
trace.getTraceIds().addAll(traceIds);
});
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390836611 the `TraceSegment` save in es, but the `global_trace` is on the way to save to es. so some trace don't have global trace id. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390836611 the `TraceSegment` saved in es, but the `global_trace` is on the way to save to es. so some trace don't have global trace id. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390836611 the `TraceSegment` saved in es, but the `global_trace` is on the way to save to es. so some trace don't have global trace id.should wait for a moment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new pull request #1253: fix NPE when has connection exception
candyleer opened a new pull request #1253: fix NPE when has connection exception
URL: https://github.com/apache/incubator-skywalking/pull/1253
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
when the request cannot connect the remote server, exception will be
thrown in `client.dispatcher().executed(this);` in okhttp3, so the method will
return null thus will cause `afterMethodInterceptor` ,so the span cannot be
correctly stop.
```java
@Override public Response execute() throws IOException {
synchronized (this) {
if (executed) throw new IllegalStateException("Already Executed");
executed = true;
}
captureCallStackTrace();
try {
client.dispatcher().executed(this);
Response result = getResponseWithInterceptorChain();
if (result == null) throw new IOException("Canceled");
return result;
} finally {
client.dispatcher().finished(this);
}
}
```
exception:
```
java.lang.NullPointerException
at
org.apache.skywalking.apm.plugin.okhttp.v3.RealCallInterceptor.afterMethod(RealCallInterceptor.java:103)
at
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:105)
at okhttp3.RealCall.execute(RealCall.java)
at
com.xxx.dockeradmin.opt.handle.HarborRestfulClient.listTags(HarborRestfulClient.java:141)
at
com.xxx.dockeradmin.rest.ReleaseResource.queryImages$original$MocrkffM(ReleaseResource.java:113)
at
com.xxx.dockeradmin.rest.ReleaseResource.queryImages$original$MocrkffM$accessor$SZQYOmMW(ReleaseResource.java)
at
com.xxx.dockeradmin.rest.ReleaseResource$auxiliary$uddrEsXs.call(Unknown Source)
at
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:93)
at
com.xxx.dockeradmin.rest.ReleaseResource.queryImages(ReleaseResource.java)
at
com.xxx.dockeradmin.rest.ReleaseResource$$FastClassBySpringCGLIB$$89ccea1d.invoke()
at
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:738)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at
org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:97)
at
com.xxx.dockeradmin.aspect.AuthAspect.aspectAroudHttpInvoke(AuthAspect.java:65)
at sun.reflect.GeneratedMethodAccessor135.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:629)
at
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:618)
at
org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:70)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
```
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1253: Fix NPE in Okhttp plugin when connect failed
coveralls commented on issue #1253: Fix NPE in Okhttp plugin when connect failed URL: https://github.com/apache/incubator-skywalking/pull/1253#issuecomment-390867553 [](https://coveralls.io/builds/17099260) Coverage increased (+0.007%) to 23.499% when pulling **4a3d06be8b60ce5cc54d06d3b2a8117ce2c2c043 on candyleer:fix_ok_http3** into **e249e0607d461b609eb76be48c046d114b34bfd5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1244: Consider to use the released version of org.apache.skywalking:apm-checkstyle
wu-sheng opened a new issue #1244: Consider to use the released version of org.apache.skywalking:apm-checkstyle URL: https://github.com/apache/incubator-skywalking/issues/1244 In the beta release vote: ``` +0 mvn clean package mostly builds (see below) build fails in apm-webapp because [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project apm-webapp: Execution validate of goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its dependencies could not be resolved: Could not find artifact org.apache.skywalking:apm-checkstyle:jar:5.0.0-beta in central (https://repo.maven.apache.org/maven2) -> [Help 1] This is fixed by using "mvn install" instead within apm-checkstyle ``` This is caused by beta is still under vote. And this will fail if we change the dependency version every time. I suggest we stay in beta release for a longer time, until we release 5.0.0-GA and change it to GA, and stay This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1246: Add `re-tag` step in release document
wu-sheng opened a new issue #1246: Add `re-tag` step in release document URL: https://github.com/apache/incubator-skywalking/issues/1246 In the beta release vote: ``` > Release Tag : > * v5.0.0-beta Should be v5.0.0-beta-RC1 (or later) while under vote, and then re-tagged once vote has been accepted. ``` Adjust the release document, and also a part of #1245 . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1239: file name too long on windows7 when i checkout 5.0.0-beta
wu-sheng closed issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta
wu-sheng commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239#issuecomment-390590017 @leilianjie I am closing this. Run some search in Baidu or Google. There should be some solution for this. If you resolved this, please consider to provide FAQ doc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390590807 @candyleer @ascrutae I have just understood Hytrix 's way. Look like the only way to support is, providing three segments for incoming request, request process and callback. The disadvantage is the service dependency map doesn't work, because multiple threads means haven't direct dependencies, anything else should be OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span
wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span URL: https://github.com/apache/incubator-skywalking/issues/1200#issuecomment-390591290 I will remove the milestone, I have finish some prototype codes of this(branch manual-span), also make context-switchable(branch context-switchable) Manual span APIs looks like every complex to use, and cost a lot to wait for the segment finish status. So I have some doubts whether we should provide this. I will wait for more explicit requirements for both of them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390821301 @SevenPointOld Could you finish this PR soon? I look forward to merge this pr into beta2 release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
