[GitHub] ascrutae opened a new pull request #1292: Fix the interceptor class is incorrect
ascrutae opened a new pull request #1292: Fix the interceptor class is incorrect URL: https://github.com/apache/incubator-skywalking/pull/1292 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393204351 > gRPC will blocked cause by the workers blocked which gRPC invoked. Agent has a time out mechanism. If you are going to block at server side, we need to review the mechanism again. The server side safe may trigger agent out of memory. That will be a bigger issue/concern for end users. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1294: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng opened a new pull request #1294: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/pull/1294 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues #1291 ___ ### Bug fix - Bug description. Aggregate workers and persistence workers own two cache collections. One of the their use to cache the data merged by streaming data. The other one is waiting to export aggregated when persistence timer scanning. But if persistence speed can not catch streaming speed, the cache collection's size will increased too large. Collector will crash down when all the workers cached huge data. - How to fix? Block streaming, mandatory persistent cache data to storage then clean the cache data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393194109 It's be done, testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393195388 gRPC will blocked cause by the workers blocked which gRPC invoked. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae opened a new pull request #1293: Fix the issue that Hystrix plugin case NPE
ascrutae opened a new pull request #1293: Fix the issue that Hystrix plugin case NPE URL: https://github.com/apache/incubator-skywalking/pull/1293 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues #1285 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1292: Fix the interceptor class is incorrect
wu-sheng closed pull request #1292: Fix the interceptor class is incorrect
URL: https://github.com/apache/incubator-skywalking/pull/1292
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
b/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
index 272316ebf..07e7f2bc4 100644
---
a/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
+++
b/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
@@ -38,6 +38,7 @@
private static final String ENHANCE_CLASS = "redis.clients.jedis.Jedis";
private static final String CONSTRUCTOR_WITH_STRING_ARG_INTERCEPT_CLASS =
"org.apache.skywalking.apm.plugin.jedis.v2.JedisConstructorWithStringArgInterceptor";
private static final String
CONSTRUCTOR_WITH_SHARD_INFO_ARG_INTERCEPT_CLASS =
"org.apache.skywalking.apm.plugin.jedis.v2.JedisConstructorWithShardInfoArgInterceptor";
+private static final String CONSTRUCTOR_WITH_HOST_AND_PORT_INTERCEPT_CLASS
=
"org.apache.skywalking.apm.plugin.jedis.v2.JedisClusterConstructorWithHostAndPortArgInterceptor";
private static final String CONSTRUCTOR_WITH_URI_ARG_INTERCEPT_CLASS =
"org.apache.skywalking.apm.plugin.jedis.v2.JedisConstructorWithUriArgInterceptor";
private static final String JEDIS_METHOD_INTERCET_CLASS =
"org.apache.skywalking.apm.plugin.jedis.v2.JedisMethodInterceptor";
@@ -68,7 +69,7 @@ public String getConstructorInterceptor() {
@Override
public String getConstructorInterceptor() {
-return CONSTRUCTOR_WITH_SHARD_INFO_ARG_INTERCEPT_CLASS;
+return CONSTRUCTOR_WITH_HOST_AND_PORT_INTERCEPT_CLASS;
}
},
new ConstructorInterceptPoint() {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1293: Fix the issue that Hystrix plugin case NPE
coveralls commented on issue #1293: Fix the issue that Hystrix plugin case NPE URL: https://github.com/apache/incubator-skywalking/pull/1293#issuecomment-393365473 [](https://coveralls.io/builds/17243248) Coverage remained the same at 23.8% when pulling **2522f1c7122c723833226674320153aad191f9c0 on ascrutae:fix/hystrix-npe** into **3f7a86f98f8f719f1a6ee44acbc88b9e942a7e97 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365944 @wu-sheng ok, after released, I will fix and test asap This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1285: hystrix plugin bug
wu-sheng commented on issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285#issuecomment-393365943 @xyydcoo I think this should be fixed by #1293 If you want this now, please compile the source codes from master branch, and copy this plugin.jar to your place. Attention: don't use the whole master distribution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1285: hystrix plugin bug
wu-sheng closed issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393355460 @wu-sheng we are preparing to release, maybe today or tomorrow, after released, I will resolve the conflict and test again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1294: [Collector] Crash down by OutOfMemoryError exception.
coveralls commented on issue #1294: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/pull/1294#issuecomment-393371556 [](https://coveralls.io/builds/17243603) Coverage decreased (-0.009%) to 23.791% when pulling **7e1252c570bcb143bf54e6ebad2057b8e1afe1b4 on peng-yongsheng:fixed/1291** into **a960272f7148eb2a620a1f50276469f4b7b17d4e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1294: [Collector] Crash down by OutOfMemoryError exception.
wu-sheng closed pull request #1294: [Collector] Crash down by OutOfMemoryError
exception.
URL: https://github.com/apache/incubator-skywalking/pull/1294
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/PersistenceWorker.java
b/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/PersistenceWorker.java
index 9331b2ae9..056f2cc03 100644
---
a/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/PersistenceWorker.java
+++
b/apm-collector/apm-collector-analysis/analysis-worker-model/src/main/java/org/apache/skywalking/apm/collector/analysis/worker/model/impl/PersistenceWorker.java
@@ -20,12 +20,13 @@
import java.util.*;
import
org.apache.skywalking.apm.collector.analysis.worker.model.base.AbstractLocalAsyncWorker;
+import org.apache.skywalking.apm.collector.configuration.ConfigurationModule;
+import
org.apache.skywalking.apm.collector.configuration.service.IWorkerCacheSizeConfig;
import
org.apache.skywalking.apm.collector.core.annotations.trace.GraphComputingMetric;
import org.apache.skywalking.apm.collector.core.cache.Collection;
import org.apache.skywalking.apm.collector.core.cache.*;
import org.apache.skywalking.apm.collector.core.data.StreamData;
import org.apache.skywalking.apm.collector.core.module.ModuleManager;
-import org.apache.skywalking.apm.collector.core.util.StringUtils;
import org.apache.skywalking.apm.collector.storage.StorageModule;
import org.apache.skywalking.apm.collector.storage.base.dao.*;
import org.slf4j.*;
@@ -43,12 +44,7 @@
PersistenceWorker(ModuleManager moduleManager) {
super(moduleManager);
this.batchDAO =
moduleManager.find(StorageModule.NAME).getService(IBatchDAO.class);
-
-if (StringUtils.isNotEmpty(System.getProperty("batchSize"))) {
-this.blockBatchPersistenceSize =
Integer.valueOf(System.getProperty("batchSize"));
-} else {
-this.blockBatchPersistenceSize = 50;
-}
+this.blockBatchPersistenceSize =
moduleManager.find(ConfigurationModule.NAME).getService(IWorkerCacheSizeConfig.class).cacheSize();
}
public boolean flushAndSwitch() {
diff --git
a/apm-collector/apm-collector-boot/src/main/resources/application.yml
b/apm-collector/apm-collector-boot/src/main/resources/application.yml
index 46133ab4f..a5f995ded 100644
--- a/apm-collector/apm-collector-boot/src/main/resources/application.yml
+++ b/apm-collector/apm-collector-boot/src/main/resources/application.yml
@@ -91,4 +91,6 @@ configuration:
applicationAverageResponseTimeThreshold: 2000
# thermodynamic
thermodynamicResponseTimeStep: 50
-thermodynamicCountOfResponseTimeSteps: 40
\ No newline at end of file
+thermodynamicCountOfResponseTimeSteps: 40
+# max collection's size of worker cache collection, setting it smaller when
collector OutOfMemory crashed.
+workerCacheMaxSize: 1
\ No newline at end of file
diff --git
a/apm-collector/apm-collector-configuration/collector-configuration-define/src/main/java/org/apache/skywalking/apm/collector/configuration/ConfigurationModule.java
b/apm-collector/apm-collector-configuration/collector-configuration-define/src/main/java/org/apache/skywalking/apm/collector/configuration/ConfigurationModule.java
index 9e9d0abb1..3b970daf9 100644
---
a/apm-collector/apm-collector-configuration/collector-configuration-define/src/main/java/org/apache/skywalking/apm/collector/configuration/ConfigurationModule.java
+++
b/apm-collector/apm-collector-configuration/collector-configuration-define/src/main/java/org/apache/skywalking/apm/collector/configuration/ConfigurationModule.java
@@ -18,16 +18,7 @@
package org.apache.skywalking.apm.collector.configuration;
-import
org.apache.skywalking.apm.collector.configuration.service.IApdexThresholdService;
-import
org.apache.skywalking.apm.collector.configuration.service.IApplicationAlarmRuleConfig;
-import
org.apache.skywalking.apm.collector.configuration.service.IApplicationReferenceAlarmRuleConfig;
-import
org.apache.skywalking.apm.collector.configuration.service.ICollectorConfig;
-import
org.apache.skywalking.apm.collector.configuration.service.IComponentLibraryCatalogService;
-import
org.apache.skywalking.apm.collector.configuration.service.IInstanceAlarmRuleConfig;
-import
org.apache.skywalking.apm.collector.configuration.service.IInstanceReferenceAlarmRuleConfig;
-import
org.apache.skywalking.apm.collector.configuration.service.IResponseTimeDistributionConfigService;
[GitHub] SevenPointOld commented on issue #443: Which companies are using SkyWalking
SevenPointOld commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-392719221 重庆宜迅联供应链科技有限公司 https://www.tsfinance.com.cn/ 线下环境预研中，5.0.0-beta，即将在生产试用 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1293: Fix the issue that Hystrix plugin case NPE
wu-sheng closed pull request #1293: Fix the issue that Hystrix plugin case NPE
URL: https://github.com/apache/incubator-skywalking/pull/1293
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandGetFallbackInterceptor.java
b/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandGetFallbackInterceptor.java
index f935c77eb..2dd1f4f9c 100644
---
a/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandGetFallbackInterceptor.java
+++
b/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandGetFallbackInterceptor.java
@@ -36,7 +36,9 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
AbstractSpan activeSpan =
ContextManager.createLocalSpan(enhanceRequireObjectCache.getOperationNamePrefix()
+ "/Fallback");
activeSpan.setComponent(ComponentsDefine.HYSTRIX);
-ContextManager.continued(snapshot);
+if (snapshot != null) {
+ContextManager.continued(snapshot);
+}
}
@Override
diff --git
a/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandRunInterceptor.java
b/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandRunInterceptor.java
index c6f1bcc97..28dce1a39 100644
---
a/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandRunInterceptor.java
+++
b/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/HystrixCommandRunInterceptor.java
@@ -41,7 +41,9 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
AbstractSpan activeSpan =
ContextManager.createLocalSpan(enhanceRequireObjectCache.getOperationNamePrefix()
+ "/Execution");
activeSpan.setComponent(ComponentsDefine.HYSTRIX);
-ContextManager.continued(snapshot);
+if (snapshot != null) {
+ContextManager.continued(snapshot);
+}
// Because of `fall back` method running in other thread. so we need
capture concurrent span for tracing.
enhanceRequireObjectCache.setContextSnapshot(ContextManager.capture());
diff --git
a/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/SWExecutionHookWrapper.java
b/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/SWExecutionHookWrapper.java
index eedc646cd..fbe0022a0 100644
---
a/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/SWExecutionHookWrapper.java
+++
b/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/SWExecutionHookWrapper.java
@@ -41,7 +41,9 @@ public SWExecutionHookWrapper(HystrixCommandExecutionHook
actual) {
public void onStart(HystrixInvokable commandInstance) {
EnhancedInstance enhancedInstance = (EnhancedInstance)commandInstance;
EnhanceRequireObjectCache enhanceRequireObjectCache =
(EnhanceRequireObjectCache)enhancedInstance.getSkyWalkingDynamicField();
-enhanceRequireObjectCache.setContextSnapshot(ContextManager.capture());
+if (ContextManager.isActive()) {
+
enhanceRequireObjectCache.setContextSnapshot(ContextManager.capture());
+}
actual.onStart(commandInstance);
}
@@ -166,7 +168,9 @@ public SWExecutionHookWrapper(HystrixCommandExecutionHook
actual) {
@Override public void onStart(HystrixCommand commandInstance) {
EnhancedInstance enhancedInstance = (EnhancedInstance)commandInstance;
EnhanceRequireObjectCache enhanceRequireObjectCache =
(EnhanceRequireObjectCache)enhancedInstance.getSkyWalkingDynamicField();
-enhanceRequireObjectCache.setContextSnapshot(ContextManager.capture());
+if (ContextManager.isActive()) {
+
enhanceRequireObjectCache.setContextSnapshot(ContextManager.capture());
+}
actual.onStart(commandInstance);
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365696 @leizhiyuan Ping me after you have done. I definitely hope this could be provided in beta2 release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393373603 Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1291: [Collector] Crash down by OutOfMemoryError exception.
wu-sheng closed issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xjr100419 commented on issue #1296: fix mysql Connection URL Syntax
xjr100419 commented on issue #1296: fix mysql Connection URL Syntax URL: https://github.com/apache/incubator-skywalking/issues/1296#issuecomment-393400690 Connection URL Syntax: https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-jdbc-url-format.html database The default database or catalog to open. If the database is not specified, the connection is made with no default database. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1297: tiny框架插件开发，遇到探针启动报错
wu-sheng commented on issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393408750 @yrjjf all description should be in English. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xjr100419 opened a new issue #1296: fix mysql Connection URL Syntax
xjr100419 opened a new issue #1296: fix mysql Connection URL Syntax
URL: https://github.com/apache/incubator-skywalking/issues/1296
- Why do you submit this issue?
My orm framework mysql link does not specify the database:
protocol//[hosts][/database][?properties] -》protocol//[hosts][?properties]
In code
MysqlURLParser.fetchDatabaseHostsIndexRange()
`
protected URLLocation fetchDatabaseHostsIndexRange() {
int hostLabelStartIndex = url.indexOf("//");
int hostLabelEndIndex = url.indexOf("/", hostLabelStartIndex + 2);
return new URLLocation(hostLabelStartIndex + 2, hostLabelEndIndex);
}
`
thent it report an error
`
ERROR 2018-05-31 10:21:06 InstMethodsInter : class[class
com.mysql.jdbc.Driver] after method[connect] intercept failure
java.lang.StringIndexOutOfBoundsException: String index out of range: -14
at java.lang.String.substring(String.java:1967)
at
org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.MysqlURLParser.parse(MysqlURLParser.java:59)
at
org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.URLParser.parser(URLParser.java:48)
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yrjjf opened a new issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf opened a new issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? tiny插件开发过程中，出现探针启动报错，但是原因定位不了，希望能协助定位 ___ ### Bug - Which version of SkyWalking, OS and JRE? centos7.2 JDK1.7.0_79 - Which company or project? tiny框架， jetty9.2.22 - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. tiny插件开发完成后， 探针启动过程中出现报错。报错如下： DEBUG 2018-05-31 12:09:34 AbstractClassEnhancePluginDefine : prepare to enhance class org.tinygroup.cepcoremutiremoteimpl.node.CEPC oreClientImpl by com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation. ERROR 2018-05-31 12:09:34 SkyWalkingAgent : Enhance class org.tinygroup.cepcoremutiremoteimpl.node.CEPCoreClientImpl error. java.lang.AbstractMethodError at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassEnhancePluginDefine.enhanceInstance(ClassEnhancePlug inDefine.java:159) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassEnhancePluginDefine.enhance(ClassEnhancePluginDefine .java:73) at org.apache.skywalking.apm.agent.core.plugin.AbstractClassEnhancePluginDefine.define(AbstractClassEnhancePluginDefine.java :75) at org.apache.skywalking.apm.agent.SkyWalkingAgent$Transformer.transform(SkyWalkingAgent.java:100) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Transformer$Compound.transform(AgentBuild er.java:2335) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$Transformation$Simple$Resolution. apply(AgentBuilder.java:8902) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.doTransform( AgentBuilder.java:9306) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(Ag entBuilder.java:9269) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.access$1300( AgentBuilder.java:9047) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDisp atcher.run(AgentBuilder.java:9625) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDisp atcher.run(AgentBuilder.java:9575) at java.security.AccessController.doPrivileged(Native Method) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(Ag entBuilder.java:9194) at sun.instrument.TransformerManager.transform(TransformerManager.java:188) at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:424) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:800) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:449) at java.net.URLClassLoader.access$100(URLClassLoader.java:71) at java.net.URLClassLoader$1.run(URLClassLoader.java:361) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at org.eclipse.jetty.webapp.WebAppClassLoader.findClass(WebAppClassLoader.java:510) at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:441) at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:403) at java.lang.Class.getDeclaredMethods0(Native Method) at java.lang.Class.privateGetDeclaredMethods(Class.java:2615) at java.lang.Class.getDeclaredMethods(Class.java:1860) at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.buildLifecycleMetadata(InitDestroyAnn otationBeanPostProcessor.java:196) at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.findLifecycleMetadata(InitDestroyAnno tationBeanPostProcessor.java:178) at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessMergedBeanDefinition(InitD estroyAnnotationBeanPostProcessor.java:124) at
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404721 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. tiny-rpc-3.4.7=com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404492 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. tiny-rpc-3.4.7=com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
URL:
https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404378
package com.hsjry.monitor.sw.client.agent.define;
import net.bytebuddy.description.method.MethodDescription;
import net.bytebuddy.matcher.ElementMatcher;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.InstanceMethodsInterceptPoint;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassInstanceMethodsEnhancePluginDefine;
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
import org.apache.skywalking.apm.agent.core.plugin.match.NameMatch;
import static net.bytebuddy.matcher.ElementMatchers.named;
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
public class TinyRPCInstrumentation extends
ClassInstanceMethodsEnhancePluginDefine {
private static final String ENHANCE_CLASS =
"org.tinygroup.cepcoremutiremoteimpl.node.CEPCoreClientImpl";
private static final String INTERCEPT_CLASS =
"com.hsjry.monitor.sw.client.agent.TinyRPCInterceptor";
@Override
protected ClassMatch enhanceClass() {
return NameMatch.byName(ENHANCE_CLASS);
}
@Override
protected ConstructorInterceptPoint[] getConstructorsInterceptPoints() {
//return new ConstructorInterceptPoint[] {
//new ConstructorInterceptPoint() {
//@Override
//public ElementMatcher
getConstructorMatcher() {
//return any();
//}
//
//@Override
//public String getConstructorInterceptor() {
//return CONSTRUCTOR_INTERCEPT_CLASS;
//}
//}
//};
return new ConstructorInterceptPoint[0];
}
@Override
protected InstanceMethodsInterceptPoint[]
getInstanceMethodsInterceptPoints() {
return new InstanceMethodsInterceptPoint[] {
new InstanceMethodsInterceptPoint() {
@Override
public ElementMatcher
getMethodsMatcher() {
return named("sendEvent");
}
@Override
public String getMethodsInterceptor() {
return INTERCEPT_CLASS;
}
@Override public boolean isOverrideArgs() {
return false;
}
}
};
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
URL:
https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404427
//
// Source code recreated from a .class file by IntelliJ IDEA
// (powered by Fernflower decompiler)
//
package org.tinygroup.cepcoremutiremoteimpl.node;
import io.netty.bootstrap.Bootstrap;
import io.netty.channel.ChannelHandler;
import io.netty.channel.ChannelInitializer;
import io.netty.channel.ChannelOption;
import io.netty.channel.socket.SocketChannel;
import io.netty.channel.socket.nio.NioSocketChannel;
import io.netty.handler.codec.serialization.ClassResolvers;
import io.netty.handler.timeout.IdleStateHandler;
import java.util.concurrent.TimeUnit;
import org.tinygroup.cepcore.CEPCore;
import org.tinygroup.cepcoremutiremoteimpl.util.ParamUtil;
import org.tinygroup.event.Event;
import org.tinygroup.event.central.Node;
import org.tinygroup.logger.LogLevel;
import org.tinygroup.logger.Logger;
import org.tinygroup.logger.LoggerFactory;
import org.tinygroup.nettyremote.codec.serialization.HessianDecoder;
import org.tinygroup.nettyremote.codec.serialization.HessianEncoder;
import org.tinygroup.nettyremote.impl.ClientImpl;
public class CEPCoreClientImpl extends ClientImpl {
private static final Logger LOGGER =
LoggerFactory.getLogger(CEPCoreClientImpl.class);
private Node node;
private CEPCore core;
private NodeHandler nodeHandler;
private int scReConnectInterval = 0;
protected int getReConnectInterval() {
if (this.scReConnectInterval != 0) {
return this.scReConnectInterval;
} else {
this.scReConnectInterval =
ParamUtil.getParamIntValue("sc-reconnect-interval",
super.getReConnectInterval());
return this.scReConnectInterval;
}
}
public CEPCoreClientImpl(int remotePort, String remoteHost, Node node,
CEPCore core) {
super(remotePort, remoteHost, true);
this.node = node;
this.core = core;
}
public void reReg() {
this.nodeHandler.reRegToSc(this);
}
public void unReg() {
this.nodeHandler.unRegToSc(this);
}
public void unEnable() {
this.nodeHandler.enableToSc(this, false);
}
public void enable() {
this.nodeHandler.enableToSc(this, true);
}
public void stop() {
LOGGER.logMessage(LogLevel.INFO, "开始停止与SC ip:{} port:{}的连接", new
Object[]{this.getRemoteHost(), this.getRemotePort()});
super.beginStop();
try {
this.unReg();
} catch (Exception var2) {
LOGGER.errorMessage("向sc注销时发生异常", var2, new Object[0]);
}
super.stop();
LOGGER.logMessage(LogLevel.INFO, "停止与SC ip:{} port:{}的连接完成", new
Object[]{this.getRemoteHost(), this.getRemotePort()});
}
private void writeEvent(Event event) {
ResponseManager.putIfAbsent(event.getEventId());
this.write(event);
}
public Event sentEvent(Event event) {
this.writeEvent(event);
return ResponseManager.getResponse(event.getEventId(),
event.getServiceRequest().getServiceId());
}
protected void init(Bootstrap b) {
((Bootstrap)((Bootstrap)((Bootstrap)b.channel(NioSocketChannel.class)).option(ChannelOption.TCP_NODELAY,
true)).option(ChannelOption.SO_KEEPALIVE, true)).handler(new
ChannelInitializer() {
public void initChannel(SocketChannel ch) throws Exception {
ch.pipeline().addLast(new ChannelHandler[]{new
HessianDecoder(ParamUtil.getPackageMaxSize(),
ClassResolvers.cacheDisabled((ClassLoader)null))});
ch.pipeline().addLast("MessageEncoder", new
HessianEncoder());
Integer heartBeatTime = ParamUtil.getHeartBeatTime();
if (heartBeatTime != 0) {
ch.pipeline().addLast(new ChannelHandler[]{new
IdleStateHandler(0L, 0L, (long)heartBeatTime, TimeUnit.SECONDS)});
}
CEPCoreClientImpl.this.nodeHandler = new
NodeHandler(CEPCoreClientImpl.this, CEPCoreClientImpl.this.node,
CEPCoreClientImpl.this.core);
ch.pipeline().addLast(new
ChannelHandler[]{CEPCoreClientImpl.this.nodeHandler});
}
});
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404721 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. tiny-rpc-3.4.7=com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404820 tiny-rpc-3.4.7=com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
URL:
https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404343
package com.hsjry.monitor.sw.client.agent;
import com.google.common.base.MoreObjects;
import org.apache.skywalking.apm.agent.core.context.CarrierItem;
import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.network.trace.component.Component;
import org.tinygroup.event.Event;
import java.lang.reflect.Method;
public class TinyRPCInterceptor implements InstanceMethodsAroundInterceptor {
private static String generateViewPoint(Event request) {
StringBuilder viewPoint = new
StringBuilder(request.getServiceRequest().getNodeName());
viewPoint.append("." + request.getServiceRequest().getServiceId());
viewPoint.append("(" +
request.getServiceRequest().getContext().getItemMap().toString() + ")");
return viewPoint.toString();
}
@Override
public void beforeMethod(EnhancedInstance enhancedInstance, Method
method, Object[] objects, Class[] classes, MethodInterceptResult
methodInterceptResult) throws Throwable {
Event request = (Event)objects[0];
ContextCarrier contextCarrier = new ContextCarrier();
CarrierItem next = contextCarrier.items();
while (next.hasNext()) {
next = next.next();
next.setHeadValue(MoreObjects.toStringHelper(request.getServiceRequest().getContext().getItemMap().get(next.getHeadKey())).toString());
}
AbstractSpan span =
ContextManager.createEntrySpan(generateViewPoint(request), contextCarrier);
SpanLayer.asRPCFramework(span);
span.setComponent(new Component() {
@Override
public int getId() {
return 110;
}
@Override
public String getName() {
return "tiny-rpc";
}
});
}
@Override
public Object afterMethod(EnhancedInstance enhancedInstance, Method
method, Object[] objects, Class[] classes, Object o) throws Throwable {
Event response = (Event)o;
if (response != null && response.getThrowable() != null) {
AbstractSpan span = ContextManager.activeSpan();
span.log(response.getThrowable());
span.errorOccurred();
}
ContextManager.stopSpan();
return o;
}
@Override
public void handleMethodException(EnhancedInstance enhancedInstance,
Method method, Object[] objects, Class[] classes, Throwable throwable) {
AbstractSpan activeSpan = ContextManager.activeSpan();
activeSpan.errorOccurred();
activeSpan.log(throwable);
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错
yrjjf commented on issue #1297: tiny框架插件开发，遇到探针启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1297#issuecomment-393404492 # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. tiny-rpc-3.4.7=com.hsjry.monitor.sw.client.agent.define.TinyRPCInstrumentation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see？
wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see？ URL: https://github.com/apache/incubator-skywalking/issues/1295#issuecomment-393392205 I am not familiar with Eclipse env. Also in IntelliJ. We already provided document about how to build our source codes in command line, and only provided that, because that stays unchangeable. https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see？
wu-sheng commented on issue #1295: This error does not know how to solve? Can anyone help me see？ URL: https://github.com/apache/incubator-skywalking/issues/1295#issuecomment-393392425 And if you are not familiar with all SkyWalking project structure, I don't recommend you to start from run in IDE. We provide binary distribution, please consider to use that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xjr100419 closed issue #1257: TraceContext.traceId() [Ignored Trace]
xjr100419 closed issue #1257: TraceContext.traceId() [Ignored Trace] URL: https://github.com/apache/incubator-skywalking/issues/1257 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liyuyun opened a new issue #1295: This error does not know how to solve? Can anyone help me see？
liyuyun opened a new issue #1295: This error does not know how to solve? Can anyone help me see？ URL: https://github.com/apache/incubator-skywalking/issues/1295 Exception in thread "main" java.util.ServiceConfigurationError: org.apache.skywalking.apm.collector.core.module.ModuleProvider: Provider org.apache.skywalking.apm.collector.ui.jetty.UIModuleJettyProvider could not be instantiated at java.util.ServiceLoader.fail(ServiceLoader.java:232) at java.util.ServiceLoader.access$100(ServiceLoader.java:185) at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384) at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404) at java.util.ServiceLoader$1.next(ServiceLoader.java:480) at org.apache.skywalking.apm.collector.core.module.ModuleDefine.prepare(ModuleDefine.java:62) at org.apache.skywalking.apm.collector.core.module.ModuleManager.init(ModuleManager.java:53) at org.apache.skywalking.apm.collector.boot.CollectorBootStartUp.main(CollectorBootStartUp.java:45) Caused by: java.lang.NoClassDefFoundError: javax/servlet/http/HttpServlet at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:763) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) at java.net.URLClassLoader.access$100(URLClassLoader.java:73) at java.net.URLClassLoader$1.run(URLClassLoader.java:368) at java.net.URLClassLoader$1.run(URLClassLoader.java:362) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:361) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.getDeclaredConstructors0(Native Method) at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671) at java.lang.Class.getConstructor0(Class.java:3075) at java.lang.Class.newInstance(Class.java:412) at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:380) ... 5 more Caused by: java.lang.ClassNotFoundException: javax.servlet.http.HttpServlet at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 22 more This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xyydcoo opened a new issue #1285: hystrix plugin bug
xyydcoo opened a new issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285 When I started at spring boot, there was an exception when I invoked other services through CommandLineRunner using feign, causing the service startup failure. Feign opened the hystrix. After removing the agent-hystrix-plugin, the service is restored to normal start. spring boot 1.5.10 spring cloud Dalston.SR5 [log.txt](https://github.com/apache/incubator-skywalking/files/2053186/log.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xyydcoo opened a new issue #1287: kafka exception
xyydcoo opened a new issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287 When I use the log4j2 output log to Kafka to produce an exception spring-kafka.version:1.1.7.RELEASE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kevinyyyy opened a new pull request #1286: modify launch link address to Apache
kevin opened a new pull request #1286: modify launch link address to Apache URL: https://github.com/apache/incubator-skywalking/pull/1286 Please answer these questions before submitting pull request - Why submit this pull request? Bug fix - Related issues ___ ### Bug fix - The old launch link address was wrong - How to fix? Modify the address to `http://skywalking.apache.org/downloads/` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae opened a new pull request #1288: Support the Chinese in config properties
ascrutae opened a new pull request #1288: Support the Chinese in config properties URL: https://github.com/apache/incubator-skywalking/pull/1288 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector
coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [](https://coveralls.io/builds/17227466) Coverage decreased (-0.06%) to 23.801% when pulling **4792e564037b541833529325a510829fb0308f55 on zipkin/receiver-v1** into **af5eedebd3475434047b9e0b2bf85e42809dbc6c on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1286: modify launch link address to Apache
wu-sheng closed pull request #1286: modify launch link address to Apache URL: https://github.com/apache/incubator-skywalking/pull/1286 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/cn/Deploy-backend-in-cluster-mode-CN.md b/docs/cn/Deploy-backend-in-cluster-mode-CN.md index 71f6baae8..4252e0308 100644 --- a/docs/cn/Deploy-backend-in-cluster-mode-CN.md +++ b/docs/cn/Deploy-backend-in-cluster-mode-CN.md @@ -5,7 +5,7 @@ - Zookeeper 3.4.10 ## 下载发布版本 -- 前向[发布页面](https://github.com/apache/incubator-skywalking/releases) +- 前向[发布页面](http://skywalking.apache.org/downloads/) ## 部署Elasticsearch - 修改`elasticsearch.yml`文件 diff --git a/docs/cn/Deploy-backend-in-standalone-mode-CN.md b/docs/cn/Deploy-backend-in-standalone-mode-CN.md index c0cea67be..23c00bb7c 100644 --- a/docs/cn/Deploy-backend-in-standalone-mode-CN.md +++ b/docs/cn/Deploy-backend-in-standalone-mode-CN.md @@ -9,7 +9,7 @@ - JDK8+ ## 下载发布版本 -- 前向[发布页面](https://github.com/apache/incubator-skywalking/releases) +- 前向[发布页面](http://skywalking.apache.org/downloads/) ## Quick Start Collector单机模拟启动简单，提供和集群模式相同的功能，单机模式下除端口(8080, 10800, 11800, 12800)被占用的情况下，直接启动即可。 diff --git a/docs/cn/Deploy-skywalking-agent-CN.md b/docs/cn/Deploy-skywalking-agent-CN.md index 560158226..d4c928b5a 100644 --- a/docs/cn/Deploy-skywalking-agent-CN.md +++ b/docs/cn/Deploy-skywalking-agent-CN.md @@ -1,5 +1,5 @@ ## 下载skywalking探针发布版本 -- 前向[发布页面](https://github.com/apache/incubator-skywalking/releases) +- 前向[发布页面](http://skywalking.apache.org/downloads/) ## 部署探针 1. 拷贝skywalking-agent目录到所需位置，探针包含整个目录，请不要改变目录结构 diff --git a/docs/en/Deploy-backend-in-cluster-mode.md b/docs/en/Deploy-backend-in-cluster-mode.md index 6c0f9e6f8..1d537c4d4 100644 --- a/docs/en/Deploy-backend-in-cluster-mode.md +++ b/docs/en/Deploy-backend-in-cluster-mode.md @@ -5,7 +5,7 @@ - Zookeeper 3.4.10 ## Download released version -- Go to [released page](https://github.com/apache/incubator-skywalking/releases) +- Go to [released page](http://skywalking.apache.org/downloads/) ## Deploy Elasticsearch server - Modify `elasticsearch.yml` diff --git a/docs/en/Deploy-backend-in-standalone-mode.md b/docs/en/Deploy-backend-in-standalone-mode.md index 6186e7cba..5256f1cf2 100644 --- a/docs/en/Deploy-backend-in-standalone-mode.md +++ b/docs/en/Deploy-backend-in-standalone-mode.md @@ -9,7 +9,7 @@ If you are using SkyWalking in a low throughputs monitoring scenario, and don't * JDK 8+ ## Download -* [Releases](https://github.com/apache/incubator-skywalking/releases) +* [Releases](http://skywalking.apache.org/downloads/) ## Quick start You can simply tar/unzip and startup if ports 8080, 10800, 11800, 12800 are free. diff --git a/docs/en/Deploy-skywalking-agent.md b/docs/en/Deploy-skywalking-agent.md index b2fde13fc..d3352463e 100644 --- a/docs/en/Deploy-skywalking-agent.md +++ b/docs/en/Deploy-skywalking-agent.md @@ -1,5 +1,5 @@ ## Download skywalking agent release version -- Go to [release page](https://github.com/apache/incubator-skywalking/releases) +- Go to [release page](http://skywalking.apache.org/downloads/) ## Deploy skywalking javaagent 1. Copy the agent package to anywhere you like. The logs, plugins and config are all included in the package. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1285: hystrix plugin bug
wu-sheng commented on issue #1285: hystrix plugin bug URL: https://github.com/apache/incubator-skywalking/issues/1285#issuecomment-393087875 @ascrutae If the hytrix makes more complex than we expected, please consider #1284 as an option. I don't want we deal too much about the across thread This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1286: modify launch link address to Apache
coveralls commented on issue #1286: modify launch link address to Apache URL: https://github.com/apache/incubator-skywalking/pull/1286#issuecomment-393103263 [](https://coveralls.io/builds/17227910) Coverage increased (+0.004%) to 23.811% when pulling **b607e644fd7c397059360b4bf1fd7f94c99c2e95 on kevin:modify_launch_link** into **dbc0f8b9d2d7b6e18eb98d718709b04e205b1d7f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DevWithLin opened a new pull request #1289: Update README_ZH.md
DevWithLin opened a new pull request #1289: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/1289 fix Typos Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug Fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. 创建与2015年 - How to fix? 创建于2015年 ___ ### New feature or improvement - Describe the details and related test reports. fix Typos This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1288: Support the Chinese in config properties
coveralls commented on issue #1288: Support the Chinese in config properties URL: https://github.com/apache/incubator-skywalking/pull/1288#issuecomment-393115870 [](https://coveralls.io/builds/17229605) Coverage decreased (-0.004%) to 23.803% when pulling **9ad0435dd33fd6eb39e90849de62a0360d0791d9 on ascrutae:fix/support-chinese** into **b8dcf2692842790beb95369cde38a1a87d58373f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1288: Support the Chinese in config properties
wu-sheng closed pull request #1288: Support the Chinese in config properties
URL: https://github.com/apache/incubator-skywalking/pull/1288
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/ConfigReadFailedException.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/ConfigReadFailedException.java
new file mode 100644
index 0..00a5ca90c
--- /dev/null
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/ConfigReadFailedException.java
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.conf;
+
+public class ConfigReadFailedException extends Exception {
+public ConfigReadFailedException(String message, Throwable parent) {
+super(message, parent);
+}
+}
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
index 27e0cf934..477455b76 100644
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
@@ -22,6 +22,8 @@
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.UnsupportedEncodingException;
import java.util.Iterator;
import java.util.Map;
import java.util.Properties;
@@ -53,7 +55,7 @@
* At the end, `agent.application_code` and `collector.servers` must be
not blank.
*/
public static void initialize() throws ConfigNotFoundException,
AgentPackageNotFoundException {
-InputStream configFileStream;
+InputStreamReader configFileStream;
try {
configFileStream = loadConfigFromAgentFolder();
@@ -115,15 +117,17 @@ private static void overrideConfigBySystemEnv() throws
IllegalAccessException {
*
* @return the config file {@link InputStream}, or null if not needEnhance.
*/
-private static InputStream loadConfigFromAgentFolder() throws
AgentPackageNotFoundException, ConfigNotFoundException {
+private static InputStreamReader loadConfigFromAgentFolder() throws
AgentPackageNotFoundException, ConfigNotFoundException,
ConfigReadFailedException {
File configFile = new File(AgentPackagePath.getPath(),
CONFIG_FILE_NAME);
if (configFile.exists() && configFile.isFile()) {
try {
logger.info("Config file found in {}.", configFile);
-return new FileInputStream(configFile);
+return new InputStreamReader(new FileInputStream(configFile),
"UTF-8");
} catch (FileNotFoundException e) {
throw new ConfigNotFoundException("Fail to load agent.config",
e);
+} catch (UnsupportedEncodingException e) {
+throw new ConfigReadFailedException("Fail to load
agent.config", e);
}
}
throw new ConfigNotFoundException("Fail to load agent config file.");
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coder-yqj opened a new pull request #1290: Hotfix/fixbug reids
coder-yqj opened a new pull request #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290 Please answer these questions before submitting pull request - Why submit this pull request? - [√ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. When creating jedis using JedisShardInfo, the jedis plugin cannot collect the redis IP and port Numbers - How to fix? add a ConstructorInterceptPoint to match the construction method with a JedisShardInfo type ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1289: Update README_ZH.md
coveralls commented on issue #1289: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/1289#issuecomment-393120045 [](https://coveralls.io/builds/17228914) Coverage remained the same at 23.811% when pulling **f2067058a824076b1dd76bcb9b333aeeb6a5b534 on DevWithLin:patch-1** into **43a4faaec42120f6ca16386a664e6630f36f5188 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1290: Hotfix/fixbug reids
wu-sheng commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393149053 @ascrutae Look like we miss a construct. Please confirm. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1290: Hotfix/fixbug reids
coveralls commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393157904 [](https://coveralls.io/builds/17230973) Coverage increased (+0.001%) to 23.804% when pulling **1504fd35e094059eb1d08d80726f9fb7a08d12f2 on coder-yqj:hotfix/fixbug-reids** into **7cf67ffa6038b3c3c7b4b5a14d5d94fa810da876 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1290: Hotfix/fixbug reids
wu-sheng closed pull request #1290: Hotfix/fixbug reids
URL: https://github.com/apache/incubator-skywalking/pull/1290
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
b/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
index 96a310af8..272316ebf 100644
---
a/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
+++
b/apm-sniffer/apm-sdk-plugin/jedis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jedis/v2/define/JedisInstrumentation.java
@@ -34,6 +34,7 @@
public class JedisInstrumentation extends
ClassInstanceMethodsEnhancePluginDefine {
private static final String HOST_AND_PORT_ARG_TYPE_NAME =
"redis.clients.jedis.HostAndPort";
+private static final String JEDIS_SHARD_INFO_ARG_TYPE_NAME =
"redis.clients.jedis.JedisShardInfo";
private static final String ENHANCE_CLASS = "redis.clients.jedis.Jedis";
private static final String CONSTRUCTOR_WITH_STRING_ARG_INTERCEPT_CLASS =
"org.apache.skywalking.apm.plugin.jedis.v2.JedisConstructorWithStringArgInterceptor";
private static final String
CONSTRUCTOR_WITH_SHARD_INFO_ARG_INTERCEPT_CLASS =
"org.apache.skywalking.apm.plugin.jedis.v2.JedisConstructorWithShardInfoArgInterceptor";
@@ -70,6 +71,17 @@ public String getConstructorInterceptor() {
return CONSTRUCTOR_WITH_SHARD_INFO_ARG_INTERCEPT_CLASS;
}
},
+new ConstructorInterceptPoint() {
+@Override
+ public ElementMatcher
getConstructorMatcher() {
+return takesArgumentWithType(0,
JEDIS_SHARD_INFO_ARG_TYPE_NAME);
+}
+
+@Override
+public String getConstructorInterceptor() {
+return CONSTRUCTOR_WITH_SHARD_INFO_ARG_INTERCEPT_CLASS;
+}
+},
new ConstructorInterceptPoint() {
@Override
public ElementMatcher
getConstructorMatcher() {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng commented on issue #1290: Hotfix/fixbug reids
wu-sheng commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393164506 @coder-yqj Thanks for fixing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1290: Hotfix/fixbug reids
coveralls commented on issue #1290: Hotfix/fixbug reids URL: https://github.com/apache/incubator-skywalking/pull/1290#issuecomment-393157904 [](https://coveralls.io/builds/17230886) Coverage increased (+0.001%) to 23.804% when pulling **1504fd35e094059eb1d08d80726f9fb7a08d12f2 on coder-yqj:hotfix/fixbug-reids** into **7cf67ffa6038b3c3c7b4b5a14d5d94fa810da876 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393178581 Solution: Block the workers which cache collection's size exceed the setting. Add a configuration item: ``` configuration: default: workerCacheSizeThreshold: 1 ``` @wu-sheng Are there some advise for my solution? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393178581 Solution: Block the workers which cache collection's size exceed the setting. Add a configuration item: ``` configuration: default: workerCacheMaxSize: 1 ``` @wu-sheng Are there some advise for my solution? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new issue #1291: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng opened a new issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [X] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Bug - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. Aggregate workers and persistence workers own two cache collections. One of the their use to cache the data merged by streaming data. The other one is waiting to export aggregated when persistence timer scanning. But if persistence speed can not catch streaming speed, the cache collection's size will increased too large. Collector will crash down when all the workers cached huge data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
peng-yongsheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393178581 Solution: Block the workers which cache collection's size exceed the setting. Add a configuration item: ``` configuration: default: workerCacheSizeThreshold: 1 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception.
wu-sheng commented on issue #1291: [Collector] Crash down by OutOfMemoryError exception. URL: https://github.com/apache/incubator-skywalking/issues/1291#issuecomment-393192839 @peng-yongsheng My suggestion, you should be care of the gRPC buffer too. And do you confirm you want to do this in beta2? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
