[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [](https://coveralls.io/builds/17403776) Coverage decreased (-0.02%) to 24.005% when pulling **f2ec82e443587e95ad67c9d4a37e65eda771d2b0 on ascrutae:fix/modify-tomcat-buried-point** into **a6d9a605ed266a70286423ca241934038bca2b61 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor
URL:
https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395940948
I had test this PR in the following scenarios:
**Scenario One**:
1. visit `http://localhost:8080/test3` by using browser
2. the `/test3` mapping method throw an runtime exception
And here is the segment:
```
spans {
parentSpanId: -1
startTime: 1528521133425
endTime: 1528521133644
operationName: "/test3"
spanLayer: Http
componentId: 14
isError: true
tags {
key: "url"
value: "http://localhost:8080/test3;
}
tags {
key: "http.method"
value: "GET"
}
}
```
**Scenario Two**:
1. visit `http://localhost:8080/test1` by using browser
2. The `/test1` mapping method will forward to the URL
`http://localhost:8080/test2`
3. The `/test2` mapping method set value to redis
And Here is the segment
```
spans {
spanId: 1
parentSpanId: 0
startTime: 1528520530757
endTime: 1528520530769
operationName: "Jedis/set"
peer: "null"
spanType: Exit
spanLayer: Cache
componentId: 30
tags {
key: "db.type"
value: "Redis"
}
tags {
key: "db.statement"
value: "set 1"
}
}
spans {
parentSpanId: -1
spanId: 0
startTime: 1528520530426
endTime: 1528520530792
operationName: "/test1"
spanLayer: Http
componentId: 14
tags {
key: "url"
value: "http://localhost:8080/test1;
}
tags {
key: "http.method"
value: "GET"
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.
wu-sheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940726 @peng-yongsheng ci fails. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1262: Filter non-active service name when UI query.
peng-yongsheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940126 1. Add application id to be a query condition of searchService method. 2. Filter service name by given time which calculated by the minute metric TTL setting. ( CurrentTimeStamp - minuteMetricTTL ) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor
ascrutae commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#discussion_r194212804 ## File path: apm-sniffer/apm-sdk-plugin/tomcat-7.x-8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat78x/define/TomcatInstrumentation.java ## @@ -37,7 +37,7 @@ /** * Enhance class. */ -private static final String ENHANCE_CLASS = "org.apache.catalina.core.StandardWrapperValve"; +private static final String ENHANCE_CLASS = "org.apache.catalina.core.StandardHostValve"; Review comment: Done! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1279: trace graphql query error..
wu-sheng closed issue #1279: trace graphql query error.. URL: https://github.com/apache/incubator-skywalking/issues/1279 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1304: UNIMPLEMENTED: Method not found: ApplicationRegisterService/applicationCodeRegister
wu-sheng closed issue #1304: UNIMPLEMENTED: Method not found: ApplicationRegisterService/applicationCodeRegister URL: https://github.com/apache/incubator-skywalking/issues/1304 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans
wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332#issuecomment-395929732 Moved to UI issue already. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans
wu-sheng closed issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #180: Improve user experience of span detail in trace page
wu-sheng opened a new issue #180: Improve user experience of span detail in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/180 If there are many spans in trace, span detail is at the bottom of page, even can't see in default page. Need to scroll page to see. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #179: Change chars to black from white in trace page
wu-sheng opened a new issue #179: Change chars to black from white in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/179 This is the feedback from community. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#discussion_r194208823 ## File path: apm-sniffer/apm-sdk-plugin/tomcat-7.x-8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat78x/define/TomcatInstrumentation.java ## @@ -37,7 +37,7 @@ /** * Enhance class. */ -private static final String ENHANCE_CLASS = "org.apache.catalina.core.StandardWrapperValve"; +private static final String ENHANCE_CLASS = "org.apache.catalina.core.StandardHostValve"; Review comment: `exception` method may not exist in `org.apache.catalina.core.StandardHostValve` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395921149 @wu-sheng @candyleer I had change the code. and now the spring mvc plugin will not create the entry span when every forward even happened. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395921149 @wu-sheng @candyleer I had change the code. and now the spring mvc plugin will not create the entry span when every forward event happened. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #178: 5.0.0/beta2
wu-sheng closed pull request #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #169: Check data for Sankey chart
wu-sheng closed issue #169: Check data for Sankey chart URL: https://github.com/apache/incubator-skywalking-ui/issues/169 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #173: Linking heatmap of dashboard to trace search page
wu-sheng closed issue #173: Linking heatmap of dashboard to trace search page URL: https://github.com/apache/incubator-skywalking-ui/issues/173 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #175: Filter nodes by appCode
wu-sheng closed issue #175: Filter nodes by appCode URL: https://github.com/apache/incubator-skywalking-ui/issues/175 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #167: The format about exception stack is irregular
wu-sheng closed issue #167: The format about exception stack is irregular URL: https://github.com/apache/incubator-skywalking-ui/issues/167 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #178: 5.0.0/beta2
wu-sheng commented on issue #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178#issuecomment-395725070 @hanahmily Merge is OK to me. Thise three could be considered, because @peng-yongsheng can't be ready in this week. So, consider at least one more week before tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on issue #178: 5.0.0/beta2
hanahmily commented on issue #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178#issuecomment-395724527 @wu-sheng This PR contains all beta2 features that are confirmed one week ago, and I prefer to merge them to master now. > 1. Access control > 1. Make the chars in the trace in black. > 1. Do you consider improving the experience of span detail? The position is the most concerned feedback for now. These features initially are considered to be putted into next release. But if they are urgent, it's all right to put them in beta2, then a new PR will fix them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #151: Place conjecture nodes outside application topology
wu-sheng commented on issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151#issuecomment-395717743 After we provided new filter mechanism for topology map, do we still implement this? even in the future? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #117: Can't see any traces in skywalking UI
wu-sheng commented on issue #117: Can't see any traces in skywalking UI URL: https://github.com/apache/incubator-skywalking-ui/issues/117#issuecomment-395717508 Closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #117: Can't see any traces in skywalking UI
wu-sheng closed issue #117: Can't see any traces in skywalking UI URL: https://github.com/apache/incubator-skywalking-ui/issues/117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1331: modify the document
wu-sheng closed pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/cn/Deploy-skywalking-agent-CN.md b/docs/cn/Deploy-skywalking-agent-CN.md index 91ac6ac67d..1dd07aae70 100644 --- a/docs/cn/Deploy-skywalking-agent-CN.md +++ b/docs/cn/Deploy-skywalking-agent-CN.md @@ -70,14 +70,20 @@ logging.level=DEBUG - Log默认使用文件输出，输出到`/logs`目录中 # Tomcat配置探针FAQ -- Linux Tomcat 7, Tomcat 8 +- Linux Tomcat 7, Tomcat 8 修改`tomcat/bin/catalina.sh`，在首行加入如下信息 ```shell CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-agent.jar"; export CATALINA_OPTS ``` -- Windows Tomcat7, Tomcat 8 +- Windows Tomcat 7, Tomcat 8 修改`tomcat/bin/catalina.bat`，在首行加入如下信息 ```shell -set "CATALINA_OPTS=... -javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- JAR 部署 +修改启动命令添加启动参数`-javaagent` + ```shell + java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar yourApp.jar + ``` + diff --git a/docs/en/Deploy-skywalking-agent.md b/docs/en/Deploy-skywalking-agent.md index a270064cec..8ddcb5ae38 100644 --- a/docs/en/Deploy-skywalking-agent.md +++ b/docs/en/Deploy-skywalking-agent.md @@ -30,14 +30,19 @@ New agent package looks like this： - The default logging output folder is `/logs`. # Deploy agent in Tomcat FAQ -- Linux Tomcat 7, Tomcat 8 +- Linux Tomcat 7, Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-agent.jar"; export CATALINA_OPTS ``` -- Windows Tomcat7, Tomcat 8 +- Windows Tomcat 7, Tomcat 8 Change the first line of `tomcat/bin/catalina.bat`. ```shell -set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- JAR file +Add `-javaagent` argument to command line in which you start your app. And make sure to add it before the `-jar` argument. eg: + ```shell + java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar yourApp.jar + ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #170: add sofarpc icon
wu-sheng closed pull request #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/public/img/node/SOFARPC.png b/public/img/node/SOFARPC.png new file mode 100644 index 000..281f997 Binary files /dev/null and b/public/img/node/SOFARPC.png differ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily opened a new pull request #178: 5.0.0/beta2
hanahmily opened a new pull request #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178 Merge to master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans
wu-sheng commented on issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332#issuecomment-395706125 I understood and received this feedback before. @hanahmily Please make the decision when will you support this requirement? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zpf1989 opened a new issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans
zpf1989 opened a new issue #1332: trace detail ui：enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332 Hello,I'm using incubator-skywalking 5.0-beta. I have a request contains many spans(almost 40),and in the trace detail page,the trace view of all the spans has no limit height,and my browser can't display the span panel when I select one to see the details data at the bottom. As shown below:    Now if I try to see the span details at the bottom,I must scroll the right bar to the bottom. And after check the span details and scroll back up,I can hardly find which span I just selected. So,could you think about making the span detail visible all the time? And making the trace view above scrollable itself? This may cause height reduce of the trace view above,we can make the span detail panel be able to hide/show by hand. If I don't clear my meaning,you can contact the member in your QQ group,who's name is **Rider**. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SoberChina commented on a change in pull request #1331: modify the document
SoberChina commented on a change in pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r194000297 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag - Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell -set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- JAR file +Change the boot command Review comment: ok, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1331: modify the document
wu-sheng commented on a change in pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r193998527 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag - Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell -set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- JAR file +Change the boot command Review comment: I want to recommend you to change your English expression. - My suggestion Add `-javaagent` argument to command line in which you start your app. And make sure to add it before the -jar argument. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SoberChina commented on issue #1331: modify the document
SoberChina commented on issue #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#issuecomment-395698847 The pr [#1330](https://github.com/apache/incubator-skywalking/pull/1330) is in conflict with me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SoberChina opened a new pull request #1331: modify the document
SoberChina opened a new pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331 Please answer these questions before submitting pull request - Why submit this pull request? modify the document - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1329: tomcat 探针使用说明修改
wu-sheng commented on issue #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329#issuecomment-395692551 You don't need to close every time. Just update your branch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SoberChina closed pull request #1328: Modify the document
SoberChina closed pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/cn/Deploy-skywalking-agent-CN.md b/docs/cn/Deploy-skywalking-agent-CN.md index d4c928b5a0..4c673b00f6 100644 --- a/docs/cn/Deploy-skywalking-agent-CN.md +++ b/docs/cn/Deploy-skywalking-agent-CN.md @@ -79,5 +79,11 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag - Tomcat 8 修改`tomcat/bin/catalina.sh`，在首行加入如下信息 ```shell -set "CATALINA_OPTS=... -javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- Spring Boot JAR 部署 +修改启动命令 + ```shell + java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar youProject.jar + ``` +> windows path eg: `E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar` \ No newline at end of file diff --git a/docs/en/Deploy-skywalking-agent.md b/docs/en/Deploy-skywalking-agent.md index d3352463e3..764580c927 100644 --- a/docs/en/Deploy-skywalking-agent.md +++ b/docs/en/Deploy-skywalking-agent.md @@ -39,5 +39,11 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag - Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell -set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- Spring Boot JAR file +Change the boot command + ```shell + java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar youProject.jar + ``` +> windows path eg: `E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar` \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haotian2015 closed pull request #1329: tomcat 探针使用说明修改
haotian2015 closed pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/cn/Deploy-skywalking-agent-CN.md b/docs/cn/Deploy-skywalking-agent-CN.md index d4c928b5a0..91ac6ac67d 100644 --- a/docs/cn/Deploy-skywalking-agent-CN.md +++ b/docs/cn/Deploy-skywalking-agent-CN.md @@ -70,14 +70,14 @@ logging.level=DEBUG - Log默认使用文件输出，输出到`/logs`目录中 # Tomcat配置探针FAQ -- Tomcat 7 +- Linux Tomcat 7, Tomcat 8 修改`tomcat/bin/catalina.sh`，在首行加入如下信息 ```shell CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-agent.jar"; export CATALINA_OPTS ``` -- Tomcat 8 -修改`tomcat/bin/catalina.sh`，在首行加入如下信息 +- Windows Tomcat7, Tomcat 8 +修改`tomcat/bin/catalina.bat`，在首行加入如下信息 ```shell set "CATALINA_OPTS=... -javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" ``` \ No newline at end of file diff --git a/docs/en/Deploy-skywalking-agent.md b/docs/en/Deploy-skywalking-agent.md index d3352463e3..a270064cec 100644 --- a/docs/en/Deploy-skywalking-agent.md +++ b/docs/en/Deploy-skywalking-agent.md @@ -30,14 +30,14 @@ New agent package looks like this： - The default logging output folder is `/logs`. # Deploy agent in Tomcat FAQ -- Tomcat 7 +- Linux Tomcat 7, Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-agent.jar"; export CATALINA_OPTS ``` -- Tomcat 8 -Change the first line of `tomcat/bin/catalina.sh`. +- Windows Tomcat7, Tomcat 8 +Change the first line of `tomcat/bin/catalina.bat`. ```shell set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" ``` \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haotian2015 opened a new pull request #1330: tomcat 探针使用说明修改
haotian2015 opened a new pull request #1330: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1330 tomcat 探针使用说明修改 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1328: Modify the document
wu-sheng commented on a change in pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328#discussion_r193989348 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,11 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag - Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell -set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- Spring Boot JAR file +Change the boot command + ```shell + java -javaagent:/path/to/skywalking-agent/skywalking-agent.jar -jar youProject.jar + ``` +> windows path eg: `E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar` Review comment: Why need a windows path? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1328: Modify the document
wu-sheng commented on a change in pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328#discussion_r193989016 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,11 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag - Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell -set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar" -``` \ No newline at end of file +set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar" +``` +- Spring Boot JAR file Review comment: This also fits all jar file start up. Recommend remove Spring, or just mention Spring in contents, not title. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1329: tomcat 探针使用说明修改
wu-sheng commented on a change in pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329#discussion_r193988001 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -30,13 +30,13 @@ New agent package looks like this： - The default logging output folder is `/logs`. # Deploy agent in Tomcat FAQ -- Tomcat 7 +- Linux Tomcat 7, Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. ```shell CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-agent.jar"; export CATALINA_OPTS ``` -- Tomcat 8 +- Windows Tomcat7, Tomcat 8 Change the first line of `tomcat/bin/catalina.sh`. Review comment: Windows haven't `*.sh` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haotian2015 opened a new pull request #1329: tomcat 探针使用说明修改
haotian2015 opened a new pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329 tomcat 探针使用说明修改 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SoberChina opened a new pull request #1328: Modify the document
SoberChina opened a new pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328 Please answer these questions before submitting pull request - Why submit this pull request? Modify the document - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1322: Add Client version when agent register instance
wu-sheng commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395677014 > ok,I read current code,we should add a field agent_version in instance index when instance registered, ui show in this place That is an easy way. Even you do so, you have to face there are so many agents in the cluster. Let's say at least thousands of them. That is why we should add a new group, named `Settings`，an `Agent status` page under that group. By that, you could see the status of all, and group them by application codes, IP, or version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395676001 I am saying, creating span for `forward` is high payload for agent. It is not necessary. Please consider 1. Use RuntimeContext to notify MVC plugins to either create an entrySpan, or just create an existed EntrySpan's event. 1. Keep `forward` and new URL as event params only. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395672961 The `forward` support by containers(e.g. Tomcat, jetty-server), we should modify all the containers plugin for this. > If trigger forward, such as error handling, then each forward step will be a local span? Not for every step, just the forward span. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395672961 The `forward` support by containers(e.g. Tomcat, jetty-server), we should modify all the containers plugin for this. > If trigger forward, such as error handling, then each forward step will be a local span? Not for every step, just the forward span. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1327: Application Avg Throughput Issue
wu-sheng commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395672039 @peng-yongsheng Could you give some explanation about how does the collector calculate the throughputs of server? The UI did a very simple calculatio: ** avg = (t1.avg + t2.avg + tn.avg ) / n**. The most possible error is the last time bucket, Tn is not finished. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395669919 > That's right. The event is the new local span that i said. I am a little confusing, do you say forward event of http MVC handler, or even of tracing? Are these going to proposal? - For a simple MVC request, it stays as same as before. - If trigger forward, such as error handling, then each forward step will be a local span? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1327: Application Avg Throughput Issue
candyleer commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395668746 just curious why they are not consistent This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.
wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326#issuecomment-395668407 You can fix these things for the community. We are always welcome your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.
wu-sheng closed issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.
wu-sheng commented on issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326#issuecomment-395668282 Please feel free to submit your pr to modify the en/cn documents. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1327: Application Avg Throughput Issue
wu-sheng commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395668005 It is calculated by UI component, I think. Is it a problem for you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1322: Add Client version when agent register instance
candyleer commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395667816 ok,I read current code,we should add a field `agent_version` in `instance` index when instance registered, ui show in this place  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new issue #1327: Application Avg Throughput Issue
candyleer opened a new issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? beta2 - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version.  it seems the throughput is not get from server but it is calculated by the avg trend,does it need to be modified? ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haotian2015 opened a new issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.
haotian2015 opened a new issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326 linux 环境下，tomcat 7和tomcat8的探针配置应该是一样的，文档中tomcat8的配置应该是windows系统的配置 路径：incubator-skywalking/docs/en/Deploy-skywalking-agent.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395663060 good idea This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395660899 @ascrutae What do you mean about `event should be display in the trace topology`? Event of a new local span? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
URL:
https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003
in the class
`org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor`
* if more than one entry span are created in the same thread,entry span will
be override
* so in `beforeMethod`,the forward error request will override the request
which user request.
so
```
@Override
public void beforeMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
EnhanceRequireObjectCache pathMappingCache =
(EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField();
String requestURL = pathMappingCache.findPathMapping(method);
if (requestURL == null) {
requestURL = getRequestURL(method);
pathMappingCache.addPathMapping(method, requestURL);
requestURL = pathMappingCache.findPathMapping(method);
}
String hystrixIsolateStrategy =
(String)ContextManager.getRuntimeContext().get(ISOLATE_STRATEGY_KEY_IN_RUNNING_CONTEXT);
HttpServletRequest request =
(HttpServletRequest)ContextManager.getRuntimeContext().get(REQUEST_KEY_IN_RUNTIME_CONTEXT);
if (hystrixIsolateStrategy != null) {
ContextManager.createLocalSpan(requestURL);
} else if (request != null) {
ContextCarrier contextCarrier = new ContextCarrier();
CarrierItem next = contextCarrier.items();
while (next.hasNext()) {
next = next.next();
next.setHeadValue(request.getHeader(next.getHeadKey()));
}
AbstractSpan span = ContextManager.createEntrySpan(requestURL,
contextCarrier);
Tags.URL.set(span, request.getRequestURL().toString());
Tags.HTTP.METHOD.set(span, request.getMethod());
span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
SpanLayer.asHttp(span);
}
}
```
the code in this forward error situation will create two entry span and
they are in the same thread,so span and tag info will be overide so the info
may be not correct.
eg.
the operation name is "/hello",but the tag url maybe
''http://127.0.0.1:8080/error'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
URL:
https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003
in the class
`org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor`
* if more than one entry span are created in the same thread,entry span will
be override
* so in `beforeMethod`,the forward error request will override the request
which user request.
so
```
@Override
public void beforeMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
EnhanceRequireObjectCache pathMappingCache =
(EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField();
String requestURL = pathMappingCache.findPathMapping(method);
if (requestURL == null) {
requestURL = getRequestURL(method);
pathMappingCache.addPathMapping(method, requestURL);
requestURL = pathMappingCache.findPathMapping(method);
}
String hystrixIsolateStrategy =
(String)ContextManager.getRuntimeContext().get(ISOLATE_STRATEGY_KEY_IN_RUNNING_CONTEXT);
HttpServletRequest request =
(HttpServletRequest)ContextManager.getRuntimeContext().get(REQUEST_KEY_IN_RUNTIME_CONTEXT);
if (hystrixIsolateStrategy != null) {
ContextManager.createLocalSpan(requestURL);
} else if (request != null) {
ContextCarrier contextCarrier = new ContextCarrier();
CarrierItem next = contextCarrier.items();
while (next.hasNext()) {
next = next.next();
next.setHeadValue(request.getHeader(next.getHeadKey()));
}
AbstractSpan span = ContextManager.createEntrySpan(requestURL,
contextCarrier);
Tags.URL.set(span, request.getRequestURL().toString());
Tags.HTTP.METHOD.set(span, request.getMethod());
span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
SpanLayer.asHttp(span);
}
}
```
the code in this forward error situation will create two entry span and
they are in the same thread,so span and tag info will be overide so the info
may be not correct
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
URL:
https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003
in the class
`org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor`
* if more than one entry span are created in the same thread,entry span will
be override
* so in `beforeMethod`,the forward error request will override the request
which user request.
so
```
@Override
public void beforeMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
EnhanceRequireObjectCache pathMappingCache =
(EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField();
String requestURL = pathMappingCache.findPathMapping(method);
if (requestURL == null) {
requestURL = getRequestURL(method);
pathMappingCache.addPathMapping(method, requestURL);
requestURL = pathMappingCache.findPathMapping(method);
}
String hystrixIsolateStrategy =
(String)ContextManager.getRuntimeContext().get(ISOLATE_STRATEGY_KEY_IN_RUNNING_CONTEXT);
HttpServletRequest request =
(HttpServletRequest)ContextManager.getRuntimeContext().get(REQUEST_KEY_IN_RUNTIME_CONTEXT);
if (hystrixIsolateStrategy != null) {
ContextManager.createLocalSpan(requestURL);
} else if (request != null) {
ContextCarrier contextCarrier = new ContextCarrier();
CarrierItem next = contextCarrier.items();
while (next.hasNext()) {
next = next.next();
next.setHeadValue(request.getHeader(next.getHeadKey()));
}
AbstractSpan span = ContextManager.createEntrySpan(requestURL,
contextCarrier);
Tags.URL.set(span, request.getRequestURL().toString());
Tags.HTTP.METHOD.set(span, request.getMethod());
span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
SpanLayer.asHttp(span);
}
}
```
the code in this forward error situation will create two entry span and
they are in the same thread,so span and tag info will be overide so we the
info may be not correct
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
URL:
https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003
in the class
`org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor`
* if more than one entry span are created in the same thread,entry span will
merge
* so in `beforeMethod`,the forward error request will override the request
which user request.
so
```
@Override
public void beforeMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
EnhanceRequireObjectCache pathMappingCache =
(EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField();
String requestURL = pathMappingCache.findPathMapping(method);
if (requestURL == null) {
requestURL = getRequestURL(method);
pathMappingCache.addPathMapping(method, requestURL);
requestURL = pathMappingCache.findPathMapping(method);
}
String hystrixIsolateStrategy =
(String)ContextManager.getRuntimeContext().get(ISOLATE_STRATEGY_KEY_IN_RUNNING_CONTEXT);
HttpServletRequest request =
(HttpServletRequest)ContextManager.getRuntimeContext().get(REQUEST_KEY_IN_RUNTIME_CONTEXT);
if (hystrixIsolateStrategy != null) {
ContextManager.createLocalSpan(requestURL);
} else if (request != null) {
ContextCarrier contextCarrier = new ContextCarrier();
CarrierItem next = contextCarrier.items();
while (next.hasNext()) {
next = next.next();
next.setHeadValue(request.getHeader(next.getHeadKey()));
}
AbstractSpan span = ContextManager.createEntrySpan(requestURL,
contextCarrier);
Tags.URL.set(span, request.getRequestURL().toString());
Tags.HTTP.METHOD.set(span, request.getMethod());
span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
SpanLayer.asHttp(span);
}
}
```
the code in this forward error situation will create two entry span and
they are in the same thread,so span and tag info will be overide
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
URL:
https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395659003
in the class
`org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor`
* if more than one entry span are created,entry span will merge
* so in `beforeMethod`,the forward error request will override the request
which user request.
so
```
@Override
public void beforeMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
EnhanceRequireObjectCache pathMappingCache =
(EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField();
String requestURL = pathMappingCache.findPathMapping(method);
if (requestURL == null) {
requestURL = getRequestURL(method);
pathMappingCache.addPathMapping(method, requestURL);
requestURL = pathMappingCache.findPathMapping(method);
}
String hystrixIsolateStrategy =
(String)ContextManager.getRuntimeContext().get(ISOLATE_STRATEGY_KEY_IN_RUNNING_CONTEXT);
HttpServletRequest request =
(HttpServletRequest)ContextManager.getRuntimeContext().get(REQUEST_KEY_IN_RUNTIME_CONTEXT);
if (hystrixIsolateStrategy != null) {
ContextManager.createLocalSpan(requestURL);
} else if (request != null) {
ContextCarrier contextCarrier = new ContextCarrier();
CarrierItem next = contextCarrier.items();
while (next.hasNext()) {
next = next.next();
next.setHeadValue(request.getHeader(next.getHeadKey()));
}
AbstractSpan span = ContextManager.createEntrySpan(requestURL,
contextCarrier);
Tags.URL.set(span, request.getRequestURL().toString());
Tags.HTTP.METHOD.set(span, request.getMethod());
span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
SpanLayer.asHttp(span);
}
}
```
the code in this forward error situation will create two entry span and
they are in the same thread,so span and tag info will be overide
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng opened a new issue #177: Consider to add access control for UI
wu-sheng opened a new issue #177: Consider to add access control for UI URL: https://github.com/apache/incubator-skywalking-ui/issues/177 If we deploy the web at internet, may face the data leak, without access control. Could you consider to add that? Attention, **this is not for multiple tenants**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395658256 wait a moment ,i will show you the reason This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395658112 @candyleer Could you be specific about how? Or trigger what? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395657915 @ascrutae @wu-sheng I have tried this solution, but this will trigger other problem This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
