[GitHub] hanahmily closed issue #1250: Dashboard to Service page Error

2018-06-09 Thread GitBox
hanahmily closed issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] hanahmily commented on issue #1250: Dashboard to Service page Error

2018-06-09 Thread GitBox
hanahmily commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-395971903 Duplicate of #1195. This is an automated message from the Apache Git

[GitHub] wu-sheng commented on issue #1215: No traceId In trace page sometimes

2018-06-09 Thread GitBox
wu-sheng commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-395971693 > Segment without trace id is invalid data which should be removed in response. If more and more segments that are received

[GitHub] hanahmily commented on issue #1215: No traceId In trace page sometimes

2018-06-09 Thread GitBox
hanahmily commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-395971093 Segment without trace id is invalid data which should be removed in response. If more and more segments that are received

[GitHub] wu-sheng closed issue #1223: Some doubts about the ui

2018-06-09 Thread GitBox
wu-sheng closed issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1223: Some doubts about the ui

2018-06-09 Thread GitBox
wu-sheng commented on issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-395968459 Closing this. This is an automated message from the Apache Git Service. To

[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-09 Thread GitBox
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [![Coverage Status](https://coveralls.io/builds/17405618/badge)](https://coveralls.io/builds/17405618) Coverage

[GitHub] wu-sheng closed issue #1201: Can't show the detail of Span with empty operation name

2018-06-09 Thread GitBox
wu-sheng closed issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201 This is an automated message from the Apache Git Service. To respond to

[GitHub] wu-sheng commented on issue #1201: Can't show the detail of Span with empty operation name

2018-06-09 Thread GitBox
wu-sheng commented on issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201#issuecomment-395965490 Uncertain. Close it for now. This is an

[GitHub] zouyx closed issue #1298: java.lang.ClassNotFoundException: org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsInter

2018-06-09 Thread GitBox
zouyx closed issue #1298: java.lang.ClassNotFoundException: org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsInter URL: https://github.com/apache/incubator-skywalking/issues/1298 This is an

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-09 Thread GitBox
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395964148 @ascrutae Where is the `forward` event? This is an automated

[GitHub] wu-sheng opened a new issue #1336: Visualize trace by segments

2018-06-09 Thread GitBox
wu-sheng opened a new issue #1336: Visualize trace by segments URL: https://github.com/apache/incubator-skywalking/issues/1336 From #901 discussions, we hope the UI could provide more powerful capabilities to visualize trace. Just order the spans by collectors, don't look like a good way.

[GitHub] wu-sheng closed issue #901: Sort segment in more sensible way

2018-06-09 Thread GitBox
wu-sheng closed issue #901: Sort segment in more sensible way URL: https://github.com/apache/incubator-skywalking/issues/901 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #901: Sort segment in more sensible way

2018-06-09 Thread GitBox
wu-sheng commented on issue #901: Sort segment in more sensible way URL: https://github.com/apache/incubator-skywalking/issues/901#issuecomment-395963985 Replace by #1336 This is an automated message from the Apache Git

[GitHub] wu-sheng closed issue #1282: Deploying on Kubernetes

2018-06-09 Thread GitBox
wu-sheng closed issue #1282: Deploying on Kubernetes URL: https://github.com/apache/incubator-skywalking/issues/1282 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1282: Deploying on Kubernetes

2018-06-09 Thread GitBox
wu-sheng commented on issue #1282: Deploying on Kubernetes URL: https://github.com/apache/incubator-skywalking/issues/1282#issuecomment-395963367 Closing. This is an automated message from the Apache Git Service. To respond

[GitHub] wu-sheng closed issue #1187: Link to trace query from Thermodynamic graph

2018-06-09 Thread GitBox
wu-sheng closed issue #1187: Link to trace query from Thermodynamic graph URL: https://github.com/apache/incubator-skywalking/issues/1187 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #1187: Link to trace query from Thermodynamic graph

2018-06-09 Thread GitBox
wu-sheng commented on issue #1187: Link to trace query from Thermodynamic graph URL: https://github.com/apache/incubator-skywalking/issues/1187#issuecomment-39596 Provided in https://github.com/apache/incubator-skywalking-ui/issues/173

[GitHub] wu-sheng closed issue #1176: Hope to Add application name in service search view

2018-06-09 Thread GitBox
wu-sheng closed issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view

2018-06-09 Thread GitBox
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-395962581 @hanahmily @peng-yongsheng Both sides are provided and merged, I am closing this.

[GitHub] wu-sheng closed pull request #1335: [Collector]Add application name in service search view

2018-06-09 Thread GitBox
wu-sheng closed pull request #1335: [Collector]Add application name in service search view URL: https://github.com/apache/incubator-skywalking/pull/1335 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] peng-yongsheng commented on issue #1335: [Collector]Hope to Add application name in service search view

2018-06-09 Thread GitBox
peng-yongsheng commented on issue #1335: [Collector]Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/pull/1335#issuecomment-395959409 @hanahmily UI protocol had been changed for support this issue. ``` extend type Query {

[GitHub] peng-yongsheng opened a new pull request #1335: [Collector]Hope to Add application name in service search view

2018-06-09 Thread GitBox
peng-yongsheng opened a new pull request #1335: [Collector]Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/pull/1335 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix

[GitHub] wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span

2018-06-09 Thread GitBox
wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-395958149 From the application instance id, backend knows already. No need to adjust any plugin.

[GitHub] peng-yongsheng closed issue #1124: Duplicated service search result

2018-06-09 Thread GitBox
peng-yongsheng closed issue #1124: Duplicated service search result URL: https://github.com/apache/incubator-skywalking/issues/1124 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] peng-yongsheng commented on issue #1124: Duplicated service search result

2018-06-09 Thread GitBox
peng-yongsheng commented on issue #1124: Duplicated service search result URL: https://github.com/apache/incubator-skywalking/issues/1124#issuecomment-395957961 Done This is an automated message from the Apache Git Service.

[GitHub] peng-yongsheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span

2018-06-09 Thread GitBox
peng-yongsheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-395957872 I'm ok. Collector and UI are easy to support it. But there were so many agent plugins need to develop and

[GitHub] wu-sheng closed issue #1232: Could not find remote id

2018-06-09 Thread GitBox
wu-sheng closed issue #1232: Could not find remote id URL: https://github.com/apache/incubator-skywalking/issues/1232 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng closed pull request #1333: [Collector][Bug] Could not find remote id

2018-06-09 Thread GitBox
wu-sheng closed pull request #1333: [Collector][Bug] Could not find remote id URL: https://github.com/apache/incubator-skywalking/pull/1333 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coveralls commented on issue #1333: [Collector][Bug] Could not find remote id

2018-06-09 Thread GitBox
coveralls commented on issue #1333: [Collector][Bug] Could not find remote id URL: https://github.com/apache/incubator-skywalking/pull/1333#issuecomment-395954210 [![Coverage Status](https://coveralls.io/builds/17404649/badge)](https://coveralls.io/builds/17404649) Coverage

[GitHub] liuhaoyang commented on issue #1334: [SpringMVC] after method[Index] intercept failure

2018-06-09 Thread GitBox
liuhaoyang commented on issue #1334: [SpringMVC] after method[Index] intercept failure URL: https://github.com/apache/incubator-skywalking/issues/1334#issuecomment-395954228 looks like the same problem https://github.com/apache/incubator-skywalking/issues/682

[GitHub] liuhaoyang opened a new issue #1334: [SpringMVC] after method[Index] intercept failure

2018-06-09 Thread GitBox
liuhaoyang opened a new issue #1334: [SpringMVC] after method[Index] intercept failure URL: https://github.com/apache/incubator-skywalking/issues/1334 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [

[GitHub] peng-yongsheng opened a new pull request #1333: [Collector][Bug] Could not find remote id

2018-06-09 Thread GitBox
peng-yongsheng opened a new pull request #1333: [Collector][Bug] Could not find remote id URL: https://github.com/apache/incubator-skywalking/pull/1333 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix - [ ] New feature

[GitHub] peng-yongsheng closed pull request #1262: Filter non-active service name when UI query.

2018-06-09 Thread GitBox
peng-yongsheng closed pull request #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] wu-sheng commented on issue #1322: Add Client version when agent register instance

2018-06-09 Thread GitBox
wu-sheng commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395950971 > User will hardly to find which agent version is different from each others. Agree. That is why I ask for a new

[GitHub] coveralls commented on issue #1262: Filter non-active service name when UI query.

2018-06-09 Thread GitBox
coveralls commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-391712845 [![Coverage Status](https://coveralls.io/builds/17404375/badge)](https://coveralls.io/builds/17404375)

[GitHub] peng-yongsheng commented on issue #1322: Add Client version when agent register instance

2018-06-09 Thread GitBox
peng-yongsheng commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395950147 > Show in `Running Server` page I propose recall why show agent version to user? what problem need to by

[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-09 Thread GitBox
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [![Coverage Status](https://coveralls.io/builds/17403964/badge)](https://coveralls.io/builds/17403964) Coverage