SkyWalkingRobot commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-446877875
Here is the [test
coveralls commented on issue #2040: enabled log4j2 to print traceId both in
sync and async mode
URL:
https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446886229
[](https://coveralls.io/builds/20611094)
coveralls commented on issue #2041: modify code style
URL:
https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-446977097
[](https://coveralls.io/builds/20615817)
Coverage remained the same at
wu-sheng commented on issue #2041: modify code style
URL:
https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-446994452
I am moving this into 6.0.0-beta release since it will happen soon in branch
`6-beta-release`.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch 6-beta-release
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.
from dfe2b08 [OAP Server][Cluster Plugin] Provide consul cluster plugin
(#2036)
add 2f37158
JaredTan95 opened a new pull request #2041: modify code style
URL: https://github.com/apache/incubator-skywalking/pull/2041
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve
JaredTan95 closed pull request #2041: modify code style
URL: https://github.com/apache/incubator-skywalking/pull/2041
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
wu-sheng commented on issue #2041: modify code style
URL:
https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-446994227
@JaredTan95 Please set the milestone for every pull request, especially the
one got merged. Otherwise, it will be lost in the change log.
wu-sheng commented on issue #2042: osName and hostName values are reversed
URL:
https://github.com/apache/incubator-skywalking/pull/2042#issuecomment-447002265
I am moving this to beta release too, to avoid protocol issue. @ZhHong
Thanks very much to point this out.
JaredTan95 commented on issue #2041: modify code style
URL:
https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-447004020
> I am moving this into 6.0.0-beta release since it will happen soon in
branch `6-beta-release`.
OK,Got it.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch 6-beta-release
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.
from 2f37158 modify code style (#2041)
add 0284293 /instance/register osName, hostName
wu-sheng closed pull request #2042: osName and hostName values are reversed
URL: https://github.com/apache/incubator-skywalking/pull/2042
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 0284293 /instance/register
wu-sheng commented on issue #2042: osName and hostName values are reversed
URL:
https://github.com/apache/incubator-skywalking/pull/2042#issuecomment-447001642
FYI @peng-yongsheng
This is an automated message from the
admln opened a new issue #2043: doubt about grpc agent
URL: https://github.com/apache/incubator-skywalking/issues/2043
Hello, I used the Grpc framework，client connect server, The IP, namespace,
proto interface are the same, ideally should be a client to the server, why it
is divided into
coveralls commented on issue #2042: osName and hostName values are reversed
URL:
https://github.com/apache/incubator-skywalking/pull/2042#issuecomment-447016760
[](https://coveralls.io/builds/20617804)
Coverage
ZhHong opened a new pull request #2042: osName and hostName values are reversed
URL: https://github.com/apache/incubator-skywalking/pull/2042
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447112064
For sure, Zipkin will come first, because we have the old one, need to
replace it with the new
wu-sheng opened a new issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL: https://github.com/apache/incubator-skywalking/issues/2044
Now we have a Zipkin receiver(experimental), which could process data and
reformat it to SkyWalking native format. The
wu-sheng commented on issue #2043: doubt about grpc agent
URL:
https://github.com/apache/incubator-skywalking/issues/2043#issuecomment-447088431
Version os gRPC, or demo? I think this will help
This is an automated message
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447187767
Maybe, maybe not. The point is I intend don't use our segment table to save
this for sure
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203794
> Ignite™ is a memory-centric distributed database, caching, and processing
platform for
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447207811
> Show us some sample Zipkin trace. How to design a no wait analysis system
must be base on that.
wu-sheng edited a comment on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447207811
> Show us some sample Zipkin trace. How to design a no wait analysis system
must be base
wu-sheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447232996
Why do you submit an issue without any info? How could we help you?
WithLin commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447186071
>Could you describe the use of this plugin?
Of course, because the canal client needs to pull data from the
canal-server, the canal client is
WithLin commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447191428
Ok，i will fix the codes.
This is an automated message from the Apache Git Service.
peng-yongsheng removed a comment on issue #2044: [Proposal] Make Zipkin and
Jaeger formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203274
https://ignite.apache.org
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203425
> Relationship of service based on the span with RPC info, keep in Redis(or
other) cache,
xiaoni157 opened a new issue #2045: agent and collector connect error
URL: https://github.com/apache/incubator-skywalking/issues/2045
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ]
xiaoni157 commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447233263
sorry, i commit so fast, now it has.
This is an automated message
peng-yongsheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-44722
@wu-sheng Seems he comment many info. I open it.
This is an
wu-sheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447235229
If you are using 0.0.0.0 for grpc, it only works in single node and in the
same machine. You have several choices, such as use real
wu-sheng closed issue #2045: agent and collector connect error
URL: https://github.com/apache/incubator-skywalking/issues/2045
This is an automated message from the Apache Git Service.
To respond to the message, please log
wu-sheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447238121
> It just a question, fixed nothing, why assign to the other version which
is not he use?
@peng-yongsheng two major reasons
candyleer commented on issue #2040: enabled log4j2 to print traceId both in
sync and async mode
URL:
https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-447198299
Does the threadlocal should been removed finally?
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447204113
> Yes. Known this, several people have sent this to me several months ago.
Maybe it is
wu-sheng commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447206701
@ascrutae From discussion, this related to #1805 somehow.
This is an automated
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447206658
@wu-sheng Show us some sample Zipkin trace. How to design a no wait analysis
system must be
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch 5.x
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/5.x by this push:
new 2f3642c Update README.md
2f3642c is
peng-yongsheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447233816
@xiaoni157 But, I also suggest you give priority to ask such a question in
QQ. It just a question about how to use, no need to
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447205347
Right now, I am focusing on how to make the span analysis ready in
production env.
Here
peng-yongsheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447234847
@wu-sheng It just a question, fixed nothing, why assign to the other version
which is not he use?
xiaoni157 commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447234853
In the same machine, it works well. i see document first.
This is
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447182267
> Deliver trace and span storage based on native implementation of Zipkin or
Jaeger.
wu-sheng commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447188161
From your description, if client runs in pull mode, it should use entry
span, with peer tag in it. And then we need a server side adjustment to
peng-yongsheng commented on issue #2039: [OAP Server][Storage] A new
Elasticsearch client supports 2.x, 5.x and 6.x version families.
URL:
https://github.com/apache/incubator-skywalking/issues/2039#issuecomment-447210833
### Step
1. Comparison of the differences from the request and
xiaoni157 opened a new issue #2045: agent and collector connect error
URL: https://github.com/apache/incubator-skywalking/issues/2045
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ]
wu-sheng closed issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin
URL: https://github.com/apache/incubator-skywalking/issues/665
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus /
OpenZipkin
URL:
https://github.com/apache/incubator-skywalking/issues/665#issuecomment-447109667
Move to #2044 . A more reliable and high-performance way to do this, and
make them production ready.
wu-sheng commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447061196
Also, you need to add lib and versions into the supported list after we
could be sure about the purpose of this plugin.
wu-sheng commented on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447061993
For my understanding of canal, I assume, we at least need source and
destination of canal data sync. Am I right? Where is the entry span? And the
coveralls edited a comment on issue #2035: Support canal plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-446514058
[](https://coveralls.io/builds/20619244)
Coverage increased
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203274
https://ignite.apache.org
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger
formats analysis product available
URL:
https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447205135
How many RPC info need to cache is unknown. So, a distributed memory
database is a best
wu-sheng commented on issue #2045: agent and collector connect error
URL:
https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447234371
Do you deploy agent and collector in the same machine? Please follow this
document to understand how the connection works,
56 matches
Mail list logo
