[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3367: agent support custom properties.

kezhenxu94 commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324718786 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3367: agent support custom properties.

kezhenxu94 commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324718621 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3464: Correction description about application config make NPE issue

wu-sheng commented on issue #3464: Correction description about application config make NPE issue URL: https://github.com/apache/skywalking/issues/3464#issuecomment-532020291 > Is the latest version is really is 6.3.0 version ? I think the latest is 6.4.0, we just released it

[skywalking] branch service_props updated (525450a -> 7ea14fb)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 525450a Merge branch 'master' into service_props add 7ea14fb fix minor bug. No new revisions

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #3367: agent support custom properties.

JaredTan95 commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324952660 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3367: agent support custom properties.

wu-sheng commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324940674 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-532016261 @zhaoyuguang CI passed, I think you could run tests again. This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-532016132 > I wanted to leave a top-level folder in case the light-4j team wanted to add plugins for other light-4j subprojects. I can remove it if you want. If you

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-532034970 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r324960742 ## File path:

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3323: Add Light4j plugin

SkyWalkingRobot commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-532034792 Here is the [test

[GitHub] [skywalking] wu-sheng commented on issue #3367: agent support custom properties.

wu-sheng commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-532033714 /run ci This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng removed a comment on issue #3367: agent support custom properties.

wu-sheng removed a comment on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-532033714 /run ci This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r324961853 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3367: agent support custom properties.

wu-sheng commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-532041965 @kezhenxu94 Please confirm the fix. This is an automated message from the Apache

[GitHub] [skywalking] tsuilouis commented on issue #3323: Add Light4j plugin

tsuilouis commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531995945 @wu-sheng I wanted to leave a top-level folder in case the light-4j team wanted to add plugins for other light-4j subprojects. I can remove it if you want.

[skywalking] branch boot-seq deleted (was a5e6525)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch boot-seq in repository https://gitbox.apache.org/repos/asf/skywalking.git. was a5e6525 Merge branch 'master' into boot-seq The revisions that were on this branch are still contained in

[GitHub] [skywalking] wu-sheng merged pull request #3471: Make sure the cluster register happens before streaming process.

wu-sheng merged pull request #3471: Make sure the cluster register happens before streaming process. URL: https://github.com/apache/skywalking/pull/3471 This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] wu-sheng closed issue #3402: More reasonable error output

wu-sheng closed issue #3402: More reasonable error output URL: https://github.com/apache/skywalking/issues/3402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[skywalking] branch master updated (c5b03ba -> 06c357d)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from c5b03ba fix noSuchMethod (#3408) add 06c357d Make sure the cluster register happens before streaming

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r324962153 ## File path:

[GitHub] [skywalking] wuguangkuo opened a new pull request #3475: Add feature to control the maximum agent log files

wuguangkuo opened a new pull request #3475: Add feature to control the maximum agent log files URL: https://github.com/apache/skywalking/pull/3475 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] New feature provided -

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3323: Add Light4j plugin

wu-sheng commented on a change in pull request #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#discussion_r324960873 ## File path: docs/en/setup/service-agent/java-agent/README.md ## @@ -102,6 +102,7 @@ property key | Description | Default |

[skywalking] branch service_props updated (2e0c22d -> 525450a)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 2e0c22d update name. add 06c357d Make sure the cluster register happens before streaming

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3367: agent support custom properties.

wu-sheng commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324525608 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3367: agent support custom properties.

wu-sheng commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324517417 ## File path: docs/en/setup/service-agent/java-agent/README.md ## @@ -78,6 +78,7 @@ property key | Description

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3367: agent support custom properties.

wu-sheng commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324517338 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java ##

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3367: agent support custom properties.

wu-sheng commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324517297 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java ##

[skywalking] branch boot-seq created (now b595eaf)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch boot-seq in repository https://gitbox.apache.org/repos/asf/skywalking.git. at b595eaf Make sure the cluster register happens before streaming process. This branch includes the

[skywalking] 01/01: Make sure the cluster register happens before streaming process.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch boot-seq in repository https://gitbox.apache.org/repos/asf/skywalking.git commit b595eafe462433d5f9eb4a675562e04f413a3c5b Author: Wu Sheng AuthorDate: Mon Sep 16 15:03:42 2019 +0800 Make

[GitHub] [skywalking] wu-sheng commented on issue #3408: fix springMVC4 noSuchMethod

wu-sheng commented on issue #3408: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3408#issuecomment-531650499 @ascrutae Please check. This is an automated message from the Apache Git Service. To

[skywalking] branch service_props updated (2993c99 -> ab86725)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 2993c99 update query. add ab86725 update. No new revisions were added by this update. Summary

[GitHub] [skywalking] JaredTan95 edited a comment on issue #3367: agent support custom properties.

JaredTan95 edited a comment on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-531632774 1. in my `agent.conf`, I set the following properties: ``` agent.instance_properties[org]=apache-skywalking ``` 2. after my

[GitHub] [skywalking] wu-sheng opened a new pull request #3471: Make sure the cluster register happens before streaming process.

wu-sheng opened a new pull request #3471: Make sure the cluster register happens before streaming process. URL: https://github.com/apache/skywalking/pull/3471 1. Make sure cluster register in start stage, rather than after server(grpc/jetty) started. 1. Add a `warning` log, rather than

[GitHub] [skywalking] ascrutae commented on issue #3408: fix springMVC4 noSuchMethod

ascrutae commented on issue #3408: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3408#issuecomment-531674591 Got your point, @SummerOfServenteen . The PR looks good to me This is an automated

[GitHub] [skywalking] windhost commented on issue #2666: oap service can't connect to elasticsearch in v6.1.0

windhost commented on issue #2666: oap service can't connect to elasticsearch in v6.1.0 URL: https://github.com/apache/skywalking/issues/2666#issuecomment-531676324 +1 This is an automated message from the Apache Git

[GitHub] [skywalking] windhost edited a comment on issue #2666: oap service can't connect to elasticsearch in v6.1.0

windhost edited a comment on issue #2666: oap service can't connect to elasticsearch in v6.1.0 URL: https://github.com/apache/skywalking/issues/2666#issuecomment-531676324 As I see, there quite be the error. Maybe this time, the elk is not ready. But the oap server still works.

[skywalking] branch service_props updated (d3e761f -> 2e0c22d)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from d3e761f Merge branch 'master' into service_props add 2e0c22d update name. No new revisions were

[skywalking] branch master updated (876b60c -> c5b03ba)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 876b60c Update ALS setup doc as istio 1.3 released (#3470) add c5b03ba fix noSuchMethod (#3408) No new

[skywalking] branch boot-seq updated (b595eaf -> a5e6525)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch boot-seq in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b595eaf Make sure the cluster register happens before streaming process. add c5b03ba fix noSuchMethod

[GitHub] [skywalking] wu-sheng merged pull request #3408: fix springMVC4 noSuchMethod

wu-sheng merged pull request #3408: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3408 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] windhost edited a comment on issue #2666: oap service can't connect to elasticsearch in v6.1.0

windhost edited a comment on issue #2666: oap service can't connect to elasticsearch in v6.1.0 URL: https://github.com/apache/skywalking/issues/2666#issuecomment-531676324 As I see, there quite be the error. Maybe at this time, the elk is not ready. But the oap server still works.

[skywalking] branch service_props updated (ab86725 -> d3e761f)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from ab86725 update. add c5b03ba fix noSuchMethod (#3408) add d3e761f Merge branch 'master' into

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #3367: agent support custom properties.

JaredTan95 commented on a change in pull request #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#discussion_r324579792 ## File path:

[GitHub] [skywalking] jadezhong commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0

jadezhong commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0 URL: https://github.com/apache/skywalking/issues/3469#issuecomment-531748373 by the way, we use 1.4.* undertow. This is an

[GitHub] [skywalking] jadezhong edited a comment on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0

jadezhong edited a comment on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0 URL: https://github.com/apache/skywalking/issues/3469#issuecomment-531748373 ps., we use 1.4.* undertow. This is an

[GitHub] [skywalking] wu-sheng commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0

wu-sheng commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0 URL: https://github.com/apache/skywalking/issues/3469#issuecomment-531749874 We can't verify in every case. If you think there is an issue, I think it is better to fix and send pull request.

[GitHub] [skywalking] SummerOfServenteen commented on issue #3474: CANCELLED: cancelled before receiving half close

SummerOfServenteen commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531752906 But it will cause data to no longer be written to es, and after a period of time, there will be no data on the page.

[GitHub] [skywalking] wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531756135 I don't think that is the issue. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531756124 I don't think that is the issue. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531756150 I don't think that is the issue. This is an automated message

[GitHub] [skywalking] wu-sheng removed a comment on issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng removed a comment on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531756150 I don't think that is the issue. This is an automated

[GitHub] [skywalking] wu-sheng removed a comment on issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng removed a comment on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531756135 I don't think that is the issue. This is an automated

[GitHub] [skywalking] SummerOfServenteen commented on issue #3474: CANCELLED: cancelled before receiving half close

SummerOfServenteen commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531742103 I I also have this problem.In what scenario did it happen?Are your applications concurrently large?

[GitHub] [skywalking] wu-sheng closed issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng closed issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close

wu-sheng commented on issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474#issuecomment-531747997 Half closing means, client disconnects from OAP, no matter what reason triggers this.

[GitHub] [skywalking] wu-sheng commented on issue #3471: Make sure the cluster register happens before streaming process.

wu-sheng commented on issue #3471: Make sure the cluster register happens before streaming process. URL: https://github.com/apache/skywalking/pull/3471#issuecomment-531748241 /run ci This is an automated message from the

[GitHub] [skywalking] wu-sheng closed issue #3472: [Agent] How can i get TraceId in c#. net core 2.2

wu-sheng closed issue #3472: [Agent] How can i get TraceId in c#. net core 2.2 URL: https://github.com/apache/skywalking/issues/3472 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #3472: [Agent] How can i get TraceId in c#. net core 2.2

wu-sheng commented on issue #3472: [Agent] How can i get TraceId in c#. net core 2.2 URL: https://github.com/apache/skywalking/issues/3472#issuecomment-531707365 .net core agent is not skywalking's officially yet. So, submit this at agent core repo.

[GitHub] [skywalking] jadezhong commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0

jadezhong commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0 URL: https://github.com/apache/skywalking/issues/3469#issuecomment-531712369 @wu-sheng found out this problem caused by apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin under

[GitHub] [skywalking] Zack-Ku opened a new issue #3473: How to set SSL in Agent?

Zack-Ku opened a new issue #3473: How to set SSL in Agent? URL: https://github.com/apache/skywalking/issues/3473 We deploy skywalking In kubernetes .And with ssl ingress expose. But I can't find the ssl connect setting in the agent.config? When i connect the kubernetes ssl expose, it

[GitHub] [skywalking] yujiaxinlong commented on issue #3428: SpringCloudGateway plugin generate same trace id after Exception

yujiaxinlong commented on issue #3428: SpringCloudGateway plugin generate same trace id after Exception URL: https://github.com/apache/skywalking/issues/3428#issuecomment-531715886 tried version 6.5.0, the problem caused by "Unable to find instance" has been resolved , but there seems

[GitHub] [skywalking] yujiaxinlong edited a comment on issue #3428: SpringCloudGateway plugin generate same trace id after Exception

yujiaxinlong edited a comment on issue #3428: SpringCloudGateway plugin generate same trace id after Exception URL: https://github.com/apache/skywalking/issues/3428#issuecomment-531715886 @zhaoyuguang tried version 6.5.0, the problem caused by "Unable to find instance" has been

[GitHub] [skywalking] yujiaxinlong edited a comment on issue #3428: SpringCloudGateway plugin generate same trace id after Exception

yujiaxinlong edited a comment on issue #3428: SpringCloudGateway plugin generate same trace id after Exception URL: https://github.com/apache/skywalking/issues/3428#issuecomment-531715886 @zhaoyuguang tried version 6.5.0, the problem caused by "Unable to find instance" has been

[GitHub] [skywalking] yujiaxinlong edited a comment on issue #3428: SpringCloudGateway plugin generate same trace id after Exception

yujiaxinlong edited a comment on issue #3428: SpringCloudGateway plugin generate same trace id after Exception URL: https://github.com/apache/skywalking/issues/3428#issuecomment-531715886 @zhaoyuguang tried version 6.5.0, the problem caused by "Unable to find instance" has been

[GitHub] [skywalking] jadezhong commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0

jadezhong commented on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0 URL: https://github.com/apache/skywalking/issues/3469#issuecomment-531724657 get undertow-2.x-plugin from 6.3.0, package it and upload it onto server's .../agent/plugins/, test and no

[GitHub] [skywalking] chaoyueg opened a new issue #3472: [Agent] How can i get TraceId in c#. net core 2.2

chaoyueg opened a new issue #3472: [Agent] How can i get TraceId in c#. net core 2.2 URL: https://github.com/apache/skywalking/issues/3472 [Agent] How can i get TraceId in c#. net core 2.2 i want to get the skywalking's traceId , then the trace in Skywalking can be linked with

[GitHub] [skywalking] jadezhong edited a comment on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0

jadezhong edited a comment on issue #3469: got traceId "N/A" in the class extends ZuulFilter under 6.4.0 URL: https://github.com/apache/skywalking/issues/3469#issuecomment-531712369 @wu-sheng found out this problem caused by apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin

[GitHub] [skywalking] webb2019 opened a new issue #3474: CANCELLED: cancelled before receiving half close

webb2019 opened a new issue #3474: CANCELLED: cancelled before receiving half close URL: https://github.com/apache/skywalking/issues/3474 ___ ### Question OAP Keep printing this error:

[GitHub] [skywalking] Zack-Ku closed issue #3473: How to set SSL in Agent?

Zack-Ku closed issue #3473: How to set SSL in Agent? URL: https://github.com/apache/skywalking/issues/3473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use