[GitHub] [skywalking-client-js] Fine0830 closed pull request #2: Feat: add report ways and JS errors monitor
Fine0830 closed pull request #2: Feat: add report ways and JS errors monitor URL: https://github.com/apache/skywalking-client-js/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4066: There is no service on ui page.
wu-sheng closed issue #4066: There is no service on ui page. URL: https://github.com/apache/skywalking/issues/4066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4066: There is no service on ui page.
wu-sheng commented on issue #4066: There is no service on ui page. URL: https://github.com/apache/skywalking/issues/4066#issuecomment-565775265 Please follow document and faq, yout timezone or time is not right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] adventurer2008 opened a new issue #4066: There is no service on ui page.
adventurer2008 opened a new issue #4066: There is no service on ui page. URL: https://github.com/apache/skywalking/issues/4066 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion ___ ### Question - What do you want to know? I'm testing skywalking . I use h2 as database and added jar file to tomcat server,which version is 8.0+. Tomcat server is working ok and log file is also ok. The agent log is as below: DEBUG 2019-12-15 11:31:12:707 SkywalkingAgent-2-GRPCChannelManager-0 GRPCChannelManager : Selected collector grpc service running, reconnect:false. DEBUG 2019-12-15 11:31:12:711 SkywalkingAgent-5-ServiceAndEndpointRegisterClient-0 ServiceAndEndpointRegisterClient : ServiceAndEndpointRegisterClient running, status:CONNECTED. DEBUG 2019-12-15 11:31:14:320 SkywalkingAgent-5-ServiceAndEndpointRegisterClient-0 ServiceAndEndpointRegisterClient : ServiceAndEndpointRegisterClient running, status:CONNECTED. DEBUG 2019-12-15 11:31:15:711 SkywalkingAgent-5-ServiceAndEndpointRegisterClient-0 ServiceAndEndpointRegisterClient : ServiceAndEndpointRegisterClient running, status:CONNECTED. But in ui page . there is no service . But endpoint is normal. When I click the URL of tomcat server. I may see the endpoint number is added, but service number is still zero.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4064: Improve skywalking-deploy.sh
codecov-io commented on issue #4064: Improve skywalking-deploy.sh URL: https://github.com/apache/skywalking/pull/4064#issuecomment-565773127 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4064?src=pr=h1) Report > Merging [#4064](https://codecov.io/gh/apache/skywalking/pull/4064?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0513dd8d451651f264005e11b565cccacac69a7c?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4064?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4064 +/- ## === Coverage 26.85% 26.85% === Files1134 1134 Lines 2498024980 Branches 3601 3601 === Hits 6709 6709 Misses 1767417674 Partials 597 597 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4064?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4064?src=pr=footer). Last update [0513dd8...46e6d1c](https://codecov.io/gh/apache/skywalking/pull/4064?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3991: Can't find the link to download the apache-skywalking-bin-es7.tar.gz or apache-skywalking-bin-es7.zip
wu-sheng commented on issue #3991: Can't find the link to download the apache-skywalking-bin-es7.tar.gz or apache-skywalking-bin-es7.zip URL: https://github.com/apache/skywalking/issues/3991#issuecomment-565773051 We have unfinished features in 6.6.0, we will try to release in the next month. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] adventurer2008 commented on issue #3991: Can't find the link to download the apache-skywalking-bin-es7.tar.gz or apache-skywalking-bin-es7.zip
adventurer2008 commented on issue #3991: Can't find the link to download the apache-skywalking-bin-es7.tar.gz or apache-skywalking-bin-es7.zip URL: https://github.com/apache/skywalking/issues/3991#issuecomment-565772910 ES7.0+can't be supported by skywalking 6.5, which has some errors when starting up. Hopefully skywalking 6.6 soon release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch master updated (4c6a323 -> 0513dd8d)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 4c6a323 Fix NullPointerException in Spring interceptor (#4063) add 0513dd8d fix es agent remote peers error when multi host. (#4065) No new revisions were added by this update. Summary of changes: .../apm/plugin/elasticsearch/v6/RemotePeerCache.java | 2 +- .../v6/interceptor/RestHighLevelClientConInterceptorTest.java | 11 +++ 2 files changed, 4 insertions(+), 9 deletions(-)
[GitHub] [skywalking] wu-sheng merged pull request #4065: fix es agent remote peers error when multi host.
wu-sheng merged pull request #4065: fix es agent remote peers error when multi host. URL: https://github.com/apache/skywalking/pull/4065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch reduce-register-load updated (e7ff719 -> baa9cc6)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from e7ff719 Fix Spring Async case. add baa9cc6 Fix another NPE No new revisions were added by this update. Summary of changes: .../trace/provider/parser/listener/segment/SegmentSpanListener.java | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)
[skywalking] branch reduce-register-load updated (55afbde -> e7ff719)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 55afbde Fix okhttp case. add e7ff719 Fix Spring Async case. No new revisions were added by this update. Summary of changes: test/plugin/scenarios/spring-async-scenario/config/expectedData.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [skywalking] asf-ci commented on issue #4065: fix es agent remote peers error when multi host.
asf-ci commented on issue #4065: fix es agent remote peers error when multi host. URL: https://github.com/apache/skywalking/pull/4065#issuecomment-565730222 FAILURE --none-- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm opened a new pull request #4065: fix es agent remote peers error when multi host.
aderm opened a new pull request #4065: fix es agent remote peers error when multi host. URL: https://github.com/apache/skywalking/pull/4065 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. When connecting to a remote ES cluster with multi-node host, only the last node is displayed in peers with a comma in front - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch reduce-register-load updated (0cc7147 -> 55afbde)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 0cc7147 Try to fix 3 async scenarios. add 55afbde Fix okhttp case. No new revisions were added by this update. Summary of changes: test/plugin/scenarios/okhttp-scenario/config/expectedData.yaml | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)
[skywalking] branch reduce-register-load updated (bb3bbdd -> 0cc7147)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from bb3bbdd Keep name consistent with 6.x concepts. add 0cc7147 Try to fix 3 async scenarios. No new revisions were added by this update. Summary of changes: test/plugin/scenarios/hystrix-scenario/config/expectedData.yaml | 6 -- test/plugin/scenarios/okhttp-scenario/config/expectedData.yaml | 2 +- .../plugin/scenarios/spring-async-scenario/config/expectedData.yaml | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-)
[skywalking] branch reduce-register-load updated (e770637 -> bb3bbdd)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from e770637 Fix wrong error log name. add bb3bbdd Keep name consistent with 6.x concepts. No new revisions were added by this update. Summary of changes: .../agent/tool/validator/assertor/SegmentAssert.java | 4 ++-- .../agent/tool/validator/assertor/SegmentRefAssert.java | 12 ++-- .../assertor/exception/SegmentRefNotFoundException.java | 4 ++-- .../test/agent/tool/validator/entity/SegmentForRead.java | 16 .../test/agent/tool/validator/entity/SegmentRef.java | 12 ++-- 5 files changed, 24 insertions(+), 24 deletions(-)
[skywalking] branch reduce-register-load updated (51a790f -> e770637)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 51a790f Fix undertow test case. add e770637 Fix wrong error log name. No new revisions were added by this update. Summary of changes: .../test/agent/tool/validator/assertor/SegmentRefAssert.java | 8 1 file changed, 4 insertions(+), 4 deletions(-)
[skywalking] branch reduce-register-load updated (a259b02 -> 51a790f)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from a259b02 Fix several async cases. add 51a790f Fix undertow test case. No new revisions were added by this update. Summary of changes: test/plugin/scenarios/undertow-scenario/config/expectedData.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[skywalking] branch reduce-register-load updated (b80f5ec -> a259b02)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b80f5ec Fix the snapshot and add inexistence operation name id. add a259b02 Fix several async cases. No new revisions were added by this update. Summary of changes: .../apache/skywalking/apm/agent/core/context/TracingContext.java| 1 - .../scenarios/apm-toolkit-trace-scenario/config/expectedData.yaml | 6 +++--- test/plugin/scenarios/hystrix-scenario/config/expectedData.yaml | 4 ++-- test/plugin/scenarios/okhttp-scenario/config/expectedData.yaml | 2 +- .../plugin/scenarios/spring-async-scenario/config/expectedData.yaml | 2 +- 5 files changed, 7 insertions(+), 8 deletions(-)
[GitHub] [skywalking] arugal opened a new pull request #4064: Improve skywalking-deploy.sh
arugal opened a new pull request #4064: Improve skywalking-deploy.sh URL: https://github.com/apache/skywalking/pull/4064 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch reduce-register-load updated (f3968f4 -> b80f5ec)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from f3968f4 Merge branch 'master' into reduce-register-load add b80f5ec Fix the snapshot and add inexistence operation name id. No new revisions were added by this update. Summary of changes: .../apm/agent/core/context/TracingContext.java | 46 +- 1 file changed, 36 insertions(+), 10 deletions(-)
[GitHub] [skywalking] cyejing edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565708027 revert old test case, please recheck @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/16d7782a5cf38678240ccef2c04b8b9ae75ed65a?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3945 +/- ## = + Coverage 26.85% 26.9% +0.05% = Files11341131 -3 Lines 24979 24929 -50 Branches 36013589 -12 = Hits 67076707 + Misses 17674 17624 -50 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ay/v21x/HttpClientOperationsStatusInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctY2xvdWQvZ2F0ZXdheS0yLjEueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvY2xvdWQvZ2F0ZXdheS92MjF4L0h0dHBDbGllbnRPcGVyYXRpb25zU3RhdHVzSW50ZXJjZXB0b3IuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...ux/v5/ServerWebExchangeConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9zcHJpbmctd2ViZmx1eC01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vc3ByaW5nL3dlYmZsdXgvdjUvU2VydmVyV2ViRXhjaGFuZ2VDb25zdHJ1Y3RvckludGVyY2VwdG9yLmphdmE=) | `0% <ø> (ø)` | | | [...x/v5/DispatcherHandlerHandleMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9zcHJpbmctd2ViZmx1eC01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vc3ByaW5nL3dlYmZsdXgvdjUvRGlzcGF0Y2hlckhhbmRsZXJIYW5kbGVNZXRob2RJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | | | [...d/gateway/v21x/FilteringWebHandlerInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctY2xvdWQvZ2F0ZXdheS0yLjEueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvY2xvdWQvZ2F0ZXdheS92MjF4L0ZpbHRlcmluZ1dlYkhhbmRsZXJJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=footer). Last update [16d7782...dd82917](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch reduce-register-load updated (342caa0 -> f3968f4)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 342caa0 Merge branch 'master' into reduce-register-load add 4c6a323 Fix NullPointerException in Spring interceptor (#4063) add f3968f4 Merge branch 'master' into reduce-register-load No new revisions were added by this update. Summary of changes: .../apm/plugin/spring/patch/GetPropertyDescriptorsInterceptor.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[skywalking] branch master updated (a836612 -> 4c6a323)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from a836612 Fix docker-entrypoint.sh generate error. (#4062) add 4c6a323 Fix NullPointerException in Spring interceptor (#4063) No new revisions were added by this update. Summary of changes: .../apm/plugin/spring/patch/GetPropertyDescriptorsInterceptor.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[GitHub] [skywalking] wu-sheng merged pull request #4063: Fix NullPointerException in Spring interceptor
wu-sheng merged pull request #4063: Fix NullPointerException in Spring interceptor URL: https://github.com/apache/skywalking/pull/4063 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/16d7782a5cf38678240ccef2c04b8b9ae75ed65a?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3945 +/- ## = + Coverage 26.85% 26.9% +0.05% = Files11341131 -3 Lines 24979 24929 -50 Branches 36013589 -12 = Hits 67076707 + Misses 17674 17624 -50 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ay/v21x/HttpClientOperationsStatusInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctY2xvdWQvZ2F0ZXdheS0yLjEueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvY2xvdWQvZ2F0ZXdheS92MjF4L0h0dHBDbGllbnRPcGVyYXRpb25zU3RhdHVzSW50ZXJjZXB0b3IuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...ux/v5/ServerWebExchangeConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9zcHJpbmctd2ViZmx1eC01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vc3ByaW5nL3dlYmZsdXgvdjUvU2VydmVyV2ViRXhjaGFuZ2VDb25zdHJ1Y3RvckludGVyY2VwdG9yLmphdmE=) | `0% <ø> (ø)` | | | [...x/v5/DispatcherHandlerHandleMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9zcHJpbmctd2ViZmx1eC01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vc3ByaW5nL3dlYmZsdXgvdjUvRGlzcGF0Y2hlckhhbmRsZXJIYW5kbGVNZXRob2RJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | | | [...d/gateway/v21x/FilteringWebHandlerInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/3945/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctY2xvdWQvZ2F0ZXdheS0yLjEueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvY2xvdWQvZ2F0ZXdheS92MjF4L0ZpbHRlcmluZ1dlYkhhbmRsZXJJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=footer). Last update [16d7782...dd82917](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4063: Fix NullPointerException in Spring interceptor
codecov-io edited a comment on issue #4063: Fix NullPointerException in Spring interceptor URL: https://github.com/apache/skywalking/pull/4063#issuecomment-565709068 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=h1) Report > Merging [#4063](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a836612534a09aa3f30db2a1ba86ab4b70144299?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4063 +/- ## == - Coverage 26.85% 26.84% -0.01% == Files1134 1134 Lines 2497924980 +1 Branches 3601 3601 == Hits 6707 6707 - Misses 1767417675 +1 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pring/patch/GetPropertyDescriptorsInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4063/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvY29yZS1wYXRjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9wYXRjaC9HZXRQcm9wZXJ0eURlc2NyaXB0b3JzSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=footer). Last update [a836612...f11e830](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4063: Fix NullPointerException in Spring interceptor
codecov-io commented on issue #4063: Fix NullPointerException in Spring interceptor URL: https://github.com/apache/skywalking/pull/4063#issuecomment-565709068 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=h1) Report > Merging [#4063](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a836612534a09aa3f30db2a1ba86ab4b70144299?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4063 +/- ## == - Coverage 26.85% 26.84% -0.01% == Files1134 1134 Lines 2497924980 +1 Branches 3601 3601 == Hits 6707 6707 - Misses 1767417675 +1 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pring/patch/GetPropertyDescriptorsInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4063/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvY29yZS1wYXRjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9wYXRjaC9HZXRQcm9wZXJ0eURlc2NyaXB0b3JzSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=footer). Last update [a836612...f11e830](https://codecov.io/gh/apache/skywalking/pull/4063?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565708027 revert old test case, and revert test case . please recheck @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario
codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging [#4059](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a836612534a09aa3f30db2a1ba86ab4b70144299?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `28.78%`. [](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4059 +/- ## == - Coverage 26.85% 26.83% -0.02% == Files1134 1134 Lines 2497924974 -5 Branches 3601 3605 +4 == - Hits 6707 6701 -6 - Misses 1767417675 +1 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=tree) | Coverage Δ | | |---|---|---| | [...r/parser/standardization/ReferenceIdExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9SZWZlcmVuY2VJZEV4Y2hhbmdlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `72.34% <ø> (-0.58%)` | :arrow_down: | | [...r/receiver/trace/provider/parser/SegmentParse.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...ser/listener/endpoint/MultiScopesSpanListener.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL2VuZHBvaW50L011bHRpU2NvcGVzU3Bhbkxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...receiver/trace/provider/parser/SegmentParseV2.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZVYyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...ing/resttemplate/async/RestExecuteInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL1Jlc3RFeGVjdXRlSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...ring/resttemplate/sync/RestExecuteInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL3N5bmMvUmVzdEV4ZWN1dGVJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...provider/parser/standardization/SpanExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TcGFuRXhjaGFuZ2VyLmphdmE=) | `0% <0%> (ø)` | | | [...r/parser/listener/segment/SegmentSpanListener.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL3NlZ21lbnQvU2VnbWVudFNwYW5MaXN0ZW5lci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | |
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4063: Fix NullPointerException in Spring interceptor
kezhenxu94 opened a new pull request #4063: Fix NullPointerException in Spring
interceptor
URL: https://github.com/apache/skywalking/pull/4063
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
For some reasons, the Spring plugin throws NPE, after inspecting the source
codes of Spring, `org.springframework.beans.BeanWrapperImpl#getRootClass` may
indeed return `null`,
```java
public final Class getRootClass() {
return (this.rootObject != null ? this.rootObject.getClass() : null);
}
```
https://user-images.githubusercontent.com/15965696/70847712-7b46e380-1ea2-11ea-9401-651180d20833.png;>
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[skywalking] branch reduce-register-load updated (d8d6a54 -> 342caa0)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from d8d6a54 Fix NPE when no entry span in the whole segment. Set endpoint to null in segment entity. add a836612 Fix docker-entrypoint.sh generate error. (#4062) add 342caa0 Merge branch 'master' into reduce-register-load No new revisions were added by this update. Summary of changes: docker/oap/docker-entrypoint.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)
[GitHub] [skywalking] kezhenxu94 merged pull request #4062: fix docker-entrypoint.sh generate error.
kezhenxu94 merged pull request #4062: fix docker-entrypoint.sh generate error. URL: https://github.com/apache/skywalking/pull/4062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch master updated (16d7782 -> a836612)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 16d7782 Remove client side endpoint register of service mesh (#4054) add a836612 Fix docker-entrypoint.sh generate error. (#4062) No new revisions were added by this update. Summary of changes: docker/oap/docker-entrypoint.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)
[GitHub] [skywalking] codecov-io commented on issue #4062: fix docker-entrypoint.sh generate error.
codecov-io commented on issue #4062: fix docker-entrypoint.sh generate error. URL: https://github.com/apache/skywalking/pull/4062#issuecomment-565704127 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4062?src=pr=h1) Report > Merging [#4062](https://codecov.io/gh/apache/skywalking/pull/4062?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/16d7782a5cf38678240ccef2c04b8b9ae75ed65a?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4062?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4062 +/- ## === Coverage 26.85% 26.85% === Files1134 1134 Lines 2497924979 Branches 3601 3601 === Hits 6707 6707 Misses 1767417674 Partials 598 598 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4062?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4062?src=pr=footer). Last update [16d7782...f0fcfad](https://codecov.io/gh/apache/skywalking/pull/4062?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario
arugal commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565704003 > > Hi, go2sky needs to be modified? > > You could recheck. In my mind, all other agents and SDK are not using register at the SDK side. Checked, `go2sky` does not register endpoint. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario
wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565703313 > Hi, go2sky needs to be modified? You could recheck. In my mind, all other agents and SDK are not using register at the SDK side. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario
arugal commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565703264 @wu-sheng Hi, `go2sky` needs to be modified? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-client-js] Fine0830 commented on issue #2: Feat: add report ways and JS errors monitor
Fine0830 commented on issue #2: Feat: add report ways and JS errors monitor URL: https://github.com/apache/skywalking-client-js/pull/2#issuecomment-565702706 > Before merging the feature, we should > > 1. Submit the gRPC protocol to data-collect-protocol repo. > 2. Write down the usage of this `ClientMonitor` APIs in markdown. > > Also, more important, could you use some tool to design a UI prototype, don't need to be fancy, you even could draw that manually(not real page). Sync to all SkyWalking OAP developers know how to analysis and storage the data you sent. Then, this will land as query-protocol too. > > The key is, we should make feature design and protocol design works first. GotCha, Let me go head This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #2: Feat: add report ways and JS errors monitor
wu-sheng commented on a change in pull request #2: Feat: add report ways and JS errors monitor URL: https://github.com/apache/skywalking-client-js/pull/2#discussion_r357907238 ## File path: .travis.yml ## @@ -0,0 +1,15 @@ +language: node_js Review comment: I think we don't open Travis, this is not required. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch JaredTan95-patch-1 created (now f0fcfad)
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch JaredTan95-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at f0fcfad fix docker-entrypoint.sh generate error. This branch includes the following new commits: new f0fcfad fix docker-entrypoint.sh generate error. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[skywalking] 01/01: fix docker-entrypoint.sh generate error.
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch JaredTan95-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit f0fcfad1ae6d585e4c07fe63f5aa718fd6831d92
Author: Jared Tan
AuthorDate: Sat Dec 14 17:35:23 2019 +0800
fix docker-entrypoint.sh generate error.
fix docker-entrypoint.sh generate error in generateStorageMySQL() method.
---
docker/oap/docker-entrypoint.sh | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/docker/oap/docker-entrypoint.sh b/docker/oap/docker-entrypoint.sh
index c18cd1a..67d75c0 100755
--- a/docker/oap/docker-entrypoint.sh
+++ b/docker/oap/docker-entrypoint.sh
@@ -138,13 +138,13 @@ generateStorageMySQL() {
storage:
mysql:
properties:
-jdbcUrl: ${SW_JDBC_URL:"jdbc:mysql://localhost:3306/swtest"}
-dataSource.user: ${SW_DATA_SOURCE_USER:root}
-dataSource.password: ${SW_DATA_SOURCE_PASSWORD:root@1234}
-dataSource.cachePrepStmts: ${SW_DATA_SOURCE_CACHE_PREP_STMTS:true}
-dataSource.prepStmtCacheSize:
${SW_DATA_SOURCE_PREP_STMT_CACHE_SQL_SIZE:250}
-dataSource.prepStmtCacheSqlLimit:
${SW_DATA_SOURCE_PREP_STMT_CACHE_SQL_LIMIT:2048}
-dataSource.useServerPrepStmts:
${SW_DATA_SOURCE_USE_SERVER_PREP_STMTS:true}
+jdbcUrl: \${SW_JDBC_URL:"jdbc:mysql://localhost:3306/swtest"}
+dataSource.user: \${SW_DATA_SOURCE_USER:root}
+dataSource.password: \${SW_DATA_SOURCE_PASSWORD:root@1234}
+dataSource.cachePrepStmts: \${SW_DATA_SOURCE_CACHE_PREP_STMTS:true}
+dataSource.prepStmtCacheSize:
\${SW_DATA_SOURCE_PREP_STMT_CACHE_SQL_SIZE:250}
+dataSource.prepStmtCacheSqlLimit:
\${SW_DATA_SOURCE_PREP_STMT_CACHE_SQL_LIMIT:2048}
+dataSource.useServerPrepStmts:
\${SW_DATA_SOURCE_USE_SERVER_PREP_STMTS:true}
metadataQueryMaxSize: \${SW_STORAGE_MYSQL_QUERY_MAX_SIZE:5000}
EOT
}
[GitHub] [skywalking] JaredTan95 opened a new pull request #4062: fix docker-entrypoint.sh generate error.
JaredTan95 opened a new pull request #4062: fix docker-entrypoint.sh generate error. URL: https://github.com/apache/skywalking/pull/4062 fix docker-entrypoint.sh generate error in generateStorageMySQL() method. Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-client-js] Fine0830 opened a new pull request #2: Feat: add report ways and JS errors monitor
Fine0830 opened a new pull request #2: Feat: add report ways and JS errors monitor URL: https://github.com/apache/skywalking-client-js/pull/2 refer to https://github.com/apache/skywalking/issues/4060 https://github.com/apache/skywalking/issues/4061  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario
codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging [#4059](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/16d7782a5cf38678240ccef2c04b8b9ae75ed65a?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `28.78%`. [](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4059 +/- ## == - Coverage 26.85% 26.83% -0.02% == Files1134 1134 Lines 2497924974 -5 Branches 3601 3605 +4 == - Hits 6707 6701 -6 - Misses 1767417675 +1 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=tree) | Coverage Δ | | |---|---|---| | [...r/parser/standardization/ReferenceIdExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9SZWZlcmVuY2VJZEV4Y2hhbmdlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `72.34% <ø> (-0.58%)` | :arrow_down: | | [...r/receiver/trace/provider/parser/SegmentParse.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...ser/listener/endpoint/MultiScopesSpanListener.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL2VuZHBvaW50L011bHRpU2NvcGVzU3Bhbkxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...receiver/trace/provider/parser/SegmentParseV2.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZVYyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...ing/resttemplate/async/RestExecuteInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL1Jlc3RFeGVjdXRlSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...ring/resttemplate/sync/RestExecuteInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL3N5bmMvUmVzdEV4ZWN1dGVJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...provider/parser/standardization/SpanExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TcGFuRXhjaGFuZ2VyLmphdmE=) | `0% <0%> (ø)` | | | [...r/parser/listener/segment/SegmentSpanListener.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL3NlZ21lbnQvU2VnbWVudFNwYW5MaXN0ZW5lci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | |
[GitHub] [skywalking] Fine0830 opened a new issue #4061: Support the type of JS errors monitor
Fine0830 opened a new issue #4061: Support the type of JS errors monitor URL: https://github.com/apache/skywalking/issues/4061 Support the type of JS errors, It can catch some JS error log, such as JS error stack, error line, error col, error url, error message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] Fine0830 opened a new issue #4060: Add report for client monitor
Fine0830 opened a new issue #4060: Add report for client monitor URL: https://github.com/apache/skywalking/issues/4060 Report client log and info to server. Support two ways that are xhr and img. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario
codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging [#4059](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/16d7782a5cf38678240ccef2c04b8b9ae75ed65a?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `30.64%`. [](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4059 +/- ## == - Coverage 26.85% 26.83% -0.02% == Files1134 1134 Lines 2497924973 -6 Branches 3601 3604 +3 == - Hits 6707 6701 -6 Misses 1767417674 Partials 598 598 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=tree) | Coverage Δ | | |---|---|---| | [...r/parser/standardization/ReferenceIdExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9SZWZlcmVuY2VJZEV4Y2hhbmdlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `72.34% <ø> (-0.58%)` | :arrow_down: | | [...r/receiver/trace/provider/parser/SegmentParse.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...ser/listener/endpoint/MultiScopesSpanListener.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL2VuZHBvaW50L011bHRpU2NvcGVzU3Bhbkxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...receiver/trace/provider/parser/SegmentParseV2.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZVYyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...ing/resttemplate/async/RestExecuteInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL1Jlc3RFeGVjdXRlSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...ring/resttemplate/sync/RestExecuteInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL3N5bmMvUmVzdEV4ZWN1dGVJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...provider/parser/standardization/SpanExchanger.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TcGFuRXhjaGFuZ2VyLmphdmE=) | `0% <0%> (ø)` | | | [...ovider/handler/v6/grpc/RegisterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4059/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvaGFuZGxlci92Ni9ncnBjL1JlZ2lzdGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | |
[skywalking] branch reduce-register-load updated (f26c6f2 -> d8d6a54)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from f26c6f2 Update protocol, FAQ, and CHANGELOG documents to highlight this change. add d8d6a54 Fix NPE when no entry span in the whole segment. Set endpoint to null in segment entity. No new revisions were added by this update. Summary of changes: .../provider/parser/listener/segment/SegmentSpanListener.java| 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)
[skywalking] branch reduce-register-load updated (e435c78 -> f26c6f2)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from e435c78 Remove exit span from plugin test framework document. add f26c6f2 Update protocol, FAQ, and CHANGELOG documents to highlight this change. No new revisions were added by this update. Summary of changes: CHANGES.md | 11 +++ docs/en/FAQ/README.md| 1 + docs/en/FAQ/Unexpected-endpoint-register.md | 12 ...ywalking-Cross-Process-Propagation-Headers-Protocol-v2.md | 2 ++ 4 files changed, 26 insertions(+) create mode 100644 docs/en/FAQ/Unexpected-endpoint-register.md
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4059: Remove the local/exit span register mechanism in Java agent scenario
wu-sheng commented on a change in pull request #4059: Remove the local/exit
span register mechanism in Java agent scenario
URL: https://github.com/apache/skywalking/pull/4059#discussion_r357904025
##
File path:
oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v6/grpc/RegisterServiceHandler.java
##
@@ -163,14 +163,19 @@ public RegisterServiceHandler(ModuleManager
moduleManager) {
int serviceId = endpoint.getServiceId();
String endpointName = endpoint.getEndpointName();
-int endpointId = inventoryService.getOrCreate(serviceId,
endpointName, DetectPoint.fromNetworkProtocolDetectPoint(endpoint.getFrom()));
-
-if (endpointId != Const.NONE) {
-builder.addElements(EndpointMappingElement.newBuilder()
-.setServiceId(serviceId)
-.setEndpointName(endpointName)
-.setEndpointId(endpointId)
-.setFrom(endpoint.getFrom()));
+DetectPoint detectPoint =
DetectPoint.fromNetworkProtocolDetectPoint(endpoint.getFrom());
+if (DetectPoint.SERVER.equals(detectPoint)) {
+int endpointId = inventoryService.getOrCreate(serviceId,
endpointName, detectPoint);
+
+if (endpointId != Const.NONE) {
+builder.addElements(EndpointMappingElement.newBuilder()
+.setServiceId(serviceId)
+.setEndpointName(endpointName)
+.setEndpointId(endpointId)
+.setFrom(endpoint.getFrom()));
+}
+} else {
+logger.warn("Unexpected endpoint register, endpoint isn't
detected from server side. {}", request);
Review comment:
I just submit a commit to do this. please recheck.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[skywalking-kubernetes] 01/01: Merge pull request #31 from apache/typo
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git commit 1c41a0a7ab82dd7673d77358ed96bab119a829cf Merge: e9d4013 3d2470f Author: innerpeacez AuthorDate: Sat Dec 14 16:02:24 2019 +0800 Merge pull request #31 from apache/typo helm dep up skywalking README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [skywalking-kubernetes] innerpeacez merged pull request #31: helm dep up skywalking
innerpeacez merged pull request #31: helm dep up skywalking URL: https://github.com/apache/skywalking-kubernetes/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking-kubernetes] branch master updated (e9d4013 -> 1c41a0a)
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. from e9d4013 Update README.md add 3d2470f helm dep up skywalking new 1c41a0a Merge pull request #31 from apache/typo The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
