EvanLjp commented on issue #5004:
URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652313830
1. i know the service group ,but the page rander is so slow because of the
the front end render when has so many unknown services.
2. At 7.0.0 ,the service group has bug,
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
EvanLjp commented on issue #5004:
URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652337748
reply the demo picture on qq
This is an automated message from the Apache Git Service.
To respond to the message,
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
EvanLjp commented on issue #5004:
URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652331511
I think your way of thinking is right,
1. about (1) and (2) i will open a new topic to discuss it
3. about 3, i agree with you if have more than 200 node in a dashboard
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5005:
URL: https://github.com/apache/skywalking/pull/5005#issuecomment-652272837
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5005?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master@6103ca9`).
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 6103ca9 Fix wrong validation. (#5005)
wu-sheng merged pull request #5005:
URL: https://github.com/apache/skywalking/pull/5005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-652386500
Still have code style issues.
This is an automated message from the Apache Git Service.
To respond to the
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #5004:
URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652332596
Do you have a video to demo? I can't be sure of your points.
This is an automated message from the Apache Git
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
Lovnx commented on issue #4984:
URL: https://github.com/apache/skywalking/issues/4984#issuecomment-652334089
mark
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
dmsolr opened a new pull request #5006:
URL: https://github.com/apache/skywalking/pull/5006
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #5004:
URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652320820
First, about (1) and (2), those are code level thing, they are not related
to this topic. Should not change based on those.
For (3), I am not sure whether a 150 nodes topo
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5006:
URL: https://github.com/apache/skywalking/pull/5006#issuecomment-652418368
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5006?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5006:
URL: https://github.com/apache/skywalking/pull/5006#issuecomment-652418368
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5006?src=pr=h1)
Report
> Merging
wu-sheng commented on pull request #5002:
URL: https://github.com/apache/skywalking/pull/5002#issuecomment-652451803
This thing is called `span layer`. There is no value for the local span.
```Java
public enum SpanLayer {
DB(1), RPC_FRAMEWORK(2), HTTP(3), MQ(4), CACHE(5);
kezhenxu94 commented on a change in pull request #29:
URL: https://github.com/apache/skywalking-python/pull/29#discussion_r448454910
##
File path: skywalking/trace/carrier/__init__.py
##
@@ -74,14 +74,26 @@ def val(self, val: str):
if not val:
return
codecov[bot] edited a comment on pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1)
Report
> Merging
1 - 100 of 489 matches
Mail list logo