[GitHub] [skywalking] EvanLjp commented on issue #5004: skywalking ui topology graph advice

2020-07-01 Thread GitBox
EvanLjp commented on issue #5004: URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652313830 1. i know the service group ,but the page rander is so slow because of the the front end render when has so many unknown services. 2. At 7.0.0 ,the service group has bug,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on issue #5004: skywalking ui topology graph advice

2020-07-01 Thread GitBox
EvanLjp commented on issue #5004: URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652337748 reply the demo picture on qq This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on issue #5004: skywalking ui topology graph advice

2020-07-01 Thread GitBox
EvanLjp commented on issue #5004: URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652331511 I think your way of thinking is right, 1. about (1) and (2) i will open a new topic to discuss it 3. about 3, i agree with you if have more than 200 node in a dashboard

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5005: Fix wrong validation of endpoint relation entity query.

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #5005: URL: https://github.com/apache/skywalking/pull/5005#issuecomment-652272837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5005?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@6103ca9`).

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[skywalking] branch master updated: Fix wrong validation. (#5005)

2020-07-01 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 6103ca9 Fix wrong validation. (#5005)

[GitHub] [skywalking] wu-sheng merged pull request #5005: Fix wrong validation of endpoint relation entity query.

2020-07-01 Thread GitBox
wu-sheng merged pull request #5005: URL: https://github.com/apache/skywalking/pull/5005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
wu-sheng commented on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-652386500 Still have code style issues. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5004: skywalking ui topology graph advice

2020-07-01 Thread GitBox
wu-sheng commented on issue #5004: URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652332596 Do you have a video to demo? I can't be sure of your points. This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] Lovnx commented on issue #4984: apm-spring-cloud-gateway-2.1.x-plugin-8.0.1 error when I use spring-cloud-starter-gateway:2.2.2.RELEASE

2020-07-01 Thread GitBox
Lovnx commented on issue #4984: URL: https://github.com/apache/skywalking/issues/4984#issuecomment-652334089 mark This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] dmsolr opened a new pull request #5006: [WIP] Test InfluxDB E2E failed in cluster mode

2020-07-01 Thread GitBox
dmsolr opened a new pull request #5006: URL: https://github.com/apache/skywalking/pull/5006 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5004: skywalking ui topology graph advice

2020-07-01 Thread GitBox
wu-sheng commented on issue #5004: URL: https://github.com/apache/skywalking/issues/5004#issuecomment-652320820 First, about (1) and (2), those are code level thing, they are not related to this topic. Should not change based on those. For (3), I am not sure whether a 150 nodes topo

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4858: support class cache for ByteBuddy

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4858: URL: https://github.com/apache/skywalking/pull/4858#issuecomment-638705083 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4858?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5006: [WIP] Test InfluxDB E2E failed in cluster mode

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #5006: URL: https://github.com/apache/skywalking/pull/5006#issuecomment-652418368 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5006?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5006: [WIP] Test InfluxDB E2E failed in cluster mode

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #5006: URL: https://github.com/apache/skywalking/pull/5006#issuecomment-652418368 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5006?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #5002: fix shardingsphere plugin span to DB type

2020-07-01 Thread GitBox
wu-sheng commented on pull request #5002: URL: https://github.com/apache/skywalking/pull/5002#issuecomment-652451803 This thing is called `span layer`. There is no value for the local span. ```Java public enum SpanLayer { DB(1), RPC_FRAMEWORK(2), HTTP(3), MQ(4), CACHE(5);

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #29: [Core][Defect] Validate carrier before using it

2020-07-01 Thread GitBox
kezhenxu94 commented on a change in pull request #29: URL: https://github.com/apache/skywalking-python/pull/29#discussion_r448454910 ## File path: skywalking/trace/carrier/__init__.py ## @@ -74,14 +74,26 @@ def val(self, val: str): if not val: return

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-01 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

  1   2   3   4   5   >