[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[skywalking] branch health-checker updated (62e9410 -> 5f97e24)

2020-07-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch health-checker in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 62e9410 Merge branch 'master' into health-checker add 3ebcf97 ui sync (#5049) add 5f97e24

[GitHub] [skywalking] wu-sheng commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
wu-sheng commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654883163 Sorry, the case is, `class A` originally is changed by cglib, but skywalking make it implements an internal interface(EnhancedInstance), make the Spring switching to use

[GitHub] [skywalking] changyuxin commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
changyuxin commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654878560 What is the impact of the class being changed through the JdkDynamicAopProxy? This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
wu-sheng commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654859437 Read `CreateAopProxyInterceptor` and Spring's `DefaultAopProxyFactory`. From my understanding, it should be harmful, once you have classes having interface only

[skywalking] branch master updated: ui sync (#5049)

2020-07-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3ebcf97 ui sync (#5049) 3ebcf97 is

[GitHub] [skywalking] wu-sheng merged pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
wu-sheng merged pull request #5049: URL: https://github.com/apache/skywalking/pull/5049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] wu-sheng closed issue #4905: Restore and enhance the endpoint dependency page

2020-07-07 Thread GitBox
wu-sheng closed issue #4905: URL: https://github.com/apache/skywalking/issues/4905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] sj1231984 commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
sj1231984 commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654852488 After I deleted the AopProxyFactoryInstrumentation class under the core patch package and repackaged it, the program worked normally. I would like to ask, after deleting this

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] commented on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging [#5049](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5049: URL: https://github.com/apache/skywalking/pull/5049#issuecomment-654828697 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5049?src=pr=h1) Report > Merging

[GitHub] [skywalking] Fine0830 opened a new pull request #5049: UI sync: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
Fine0830 opened a new pull request #5049: URL: https://github.com/apache/skywalking/pull/5049 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[skywalking-rocketbot-ui] branch master updated: Feat: Implement endpoint dependency and metrics (#321)

2020-07-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new 5913cc8 Feat: Implement

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #321: Feat: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
wu-sheng commented on pull request #321: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/321#issuecomment-654819254 Cool!!! I am going to merge this, please update the submodule. This is an automated message

[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #321: Feat: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
wu-sheng merged pull request #321: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] wu-sheng commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
wu-sheng commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654818846 The community may have someone to do this. But, to be honest, this is not a high priority issue. Who is using this, should consider working on this. Plugins are countless, the

[GitHub] [skywalking] changyuxin commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
changyuxin commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654811535 I also encountered this problem. Has the author considered repairing this problem? This is an automated

[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on pull request #321: Feat: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
Fine0830 edited a comment on pull request #321: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/321#issuecomment-654800583 The PR was updated. @wu-sheng `/projectA/test` has two different ids.

[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on pull request #321: Feat: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
Fine0830 edited a comment on pull request #321: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/321#issuecomment-654800583 The PR was updated. @wu-sheng `/projectA/test` has two different ids.

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #321: Feat: Implement endpoint dependency and metrics

2020-07-07 Thread GitBox
Fine0830 commented on pull request #321: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/321#issuecomment-654800583 The PR was updated. @wu-sheng ![2](https://user-images.githubusercontent.com/20871783/86776221-9d948e80-c08a-11ea-822a-575e5c09a863.png)

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5045: fix @Tag returnedObject bug #5036

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #5045: URL: https://github.com/apache/skywalking/pull/5045#discussion_r450788415 ## File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/util/TagUtil.java

[GitHub] [skywalking] wu-sheng commented on issue #5048: Skywalking and Spring-data-JPS conflict

2020-07-07 Thread GitBox
wu-sheng commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-654743689 I haven't read many details, but basically, the root cause is SkyWalking enhanced the target codes with new interface, methods and field. Am I right? If so, take a look

[GitHub] [skywalking] wu-sheng closed issue #5047: InsMethodsInter: class[class org.redisson.client.RedisConnection] before/after method[send] intercept failure

2020-07-07 Thread GitBox
wu-sheng closed issue #5047: URL: https://github.com/apache/skywalking/issues/5047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5046: Add health checker module

2020-07-07 Thread GitBox
wu-sheng commented on a change in pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#discussion_r450706714 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/HealthStatus.java ## @@ -0,0 +1,29 @@ +/* + *

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1) Report > Merging

[GitHub] [skywalking] zoumingzm commented on a change in pull request #5045: fix @Tag returnedObject bug #5036

2020-07-07 Thread GitBox
zoumingzm commented on a change in pull request #5045: URL: https://github.com/apache/skywalking/pull/5045#discussion_r450654782 ## File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/util/TagUtil.java

<    1   2   3