[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
wu-sheng commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660097453 Let's make that decision first, then back to this feature. This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
wu-sheng commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660097268 By thinking the PR and Kafka transport PR, I prefer you work on a new PR. Introduce a new SPI service, called ConfigInitService. All plugins and core could provide their s

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] EvanLjp commented on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
EvanLjp commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660092729 @wu-sheng already rename module + delete invalid file This is an automated message from the Apache Git Servic

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660080461 > The concern is, the default config changed. And new backend service path added. This would be very confused. How to write plugin doc would be an issue. how about this

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
wu-sheng commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660078904 The concern is, the default config changed. And new backend service path added. This would be very confused. How to write plugin doc would be an issue.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660075856 so i cannot extension with service mode , i would be add a new extension interface ? This is an automated me

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660075197 > I think I mentioned before, neither service discovery tech should not be bounded in the agemt core level. If you want to contribute this feature, you need to put it as an o

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
wu-sheng commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660074709 Don't change the backend serive url config, it will break many deployed system. Please don't do that. This

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660072780 fixing unit test,please wait for a moment This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking] codecov[bot] commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report > Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&e

[GitHub] [skywalking-query-protocol] arugal closed pull request #30: Support query browser error log

2020-07-17 Thread GitBox
arugal closed pull request #30: URL: https://github.com/apache/skywalking-query-protocol/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660063968 I will add unit tests later, thanks for review first This is an automated message from the Apache Git Service

[GitHub] [skywalking] EvanLjp opened a new pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp opened a new pull request #5120: URL: https://github.com/apache/skywalking/pull/5120 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] New feature provided - Related issues https://github.com/apache/skywalking/i

[GitHub] [skywalking] suresh-pandi opened a new issue #5119: Inquiry: can we monitor db connection pool

2020-07-17 Thread GitBox
suresh-pandi opened a new issue #5119: URL: https://github.com/apache/skywalking/issues/5119 Please answer these questions before submitting your issue. - Why do you submit this issue? - [*] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance im

[GitHub] [skywalking] wu-sheng closed issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
wu-sheng closed issue #5118: URL: https://github.com/apache/skywalking/issues/5118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
wu-sheng commented on issue #5118: URL: https://github.com/apache/skywalking/issues/5118#issuecomment-660045350 Use 8.0, how do this is open sourced. Read the codes if want to understand something. This is an automated messa

[GitHub] [skywalking] janecms opened a new issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
janecms opened a new issue #5118: URL: https://github.com/apache/skywalking/issues/5118 Env list: - SkyWalking 6.6.0 - JRE8 - Spring cloud gateway 2.1.14 I Found all endpoint is the same value "WEBFLUX.handle" ` graphql queryEndpoints output: [ {

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&el=h1) Report > Merging [#5085](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr&e

[skywalking] branch zipkin updated: Polish test.

2020-07-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch zipkin in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/zipkin by this push: new 9e15049 Polish test. 9e15049 is described

[skywalking] branch zipkin updated: Add tests for Zipkin Context Manager.

2020-07-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch zipkin in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/zipkin by this push: new dbd97b5 Add tests for Zipkin Context Manag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659997673 > log info about agent should log in skywalking-api.log file ,why my java program will output about agent core's information Agent has issue in the initialization stage, so

[GitHub] [skywalking] wu-sheng closed issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng closed issue #5116: URL: https://github.com/apache/skywalking/issues/5116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659997403 Don't use WinRAR, don't untar the package in Windows. I noticed there are some issues that happened. Use Linux or Mac. -

[GitHub] [skywalking] wu-sheng closed issue #4965: InstMethodsInter : class[class com.mysql.cj.jdbc.ClientPreparedStatement] before method[executeQuery] intercept java.lang.NullPointerException failu

2020-07-17 Thread GitBox
wu-sheng closed issue #4965: URL: https://github.com/apache/skywalking/issues/4965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[skywalking] branch master updated: Fix issue 4965 (#5109)

2020-07-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 62f7688 Fix issue 4965 (#5109) 62f7688 is

<    1   2   3   4   >