[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #5425: Introduce label system to histogram
kezhenxu94 edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-685292939 > 2020-09-01T22:35:06.2945140Z [ERROR] Failures: > 2020-09-01T22:35:06.2945330Z [ERROR] MultipleFilesChangeMonitorTest.test:81 > I encountered similar issues several times. might we not create tmp files in e2e. E2E tests never ever run the unit tests, thus won't cause the failure `MultipleFilesChangeMonitorTest.test:81`, E2E tests indeed generate tmp files, but they should not be monitored by the aforementioned test case, and the E2E failed because of timeout (now) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #5425: Introduce label system to histogram
kezhenxu94 commented on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-685292939 > 2020-09-01T22:35:06.2945140Z [ERROR] Failures: > 2020-09-01T22:35:06.2945330Z [ERROR] MultipleFilesChangeMonitorTest.test:81 > I encountered similar issues several times. might we not create tmp files in e2e. E2E tests never ever run the unit tests, thus won't cause the failure `MultipleFilesChangeMonitorTest.test:81`, and the E2E failed because of timeout (now) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin
EvanLjp commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481678330
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
it's almost similar to a custom implement skywalking plugin in our company,
i would push it laster,thx
> Some simple caching should be enough, I don't think the `Ignored
Exception` list would be very long
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5426: exception-ignore-plugin
kezhenxu94 commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481673046
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> 1. PluginBootstrap.class.getClassLoader() is application classloader,
cannot access custom classloder classes.
If you check the exception only when it's thrown(in the `Span#log(Throwable
e)`), you can simply use the same class loader (i.e.
`e.getClass().getClassLoader()`) to load the configured class by name
> 2. So we cannot to solve it but for to judge it at run time,for excample
have following steps.
>2.1 find classes in every call by the hard config
>2.2 check the status
>I don't know if this has a performance impact when find classes
instance every time
Some simple caching should be enough, I don't think the `Ignored Exception`
list would be very long
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5426: exception-ignore-plugin
kezhenxu94 commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481673046
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> 1. PluginBootstrap.class.getClassLoader() is application classloader,
cannot access custom classloder classes.
If you check the exception only when it's thrown(in the `Span#log(Throwable
e)`), you can simply use the same class loader (i.e.
`e.getClass().getClassLoader()`) to load the configured class by name
> 2. So we cannot to solve it but for to judge it at run time,for excample
have following steps.
>2.1 find classes in every call by the hard config
>2.2 check the status
>I don't know if this has a performance impact when find classes
instance every time
Some simple caching is enough, I don't think the `Ignored Exception` list
would be very long
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5426: exception-ignore-plugin
kezhenxu94 commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481673046
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> 1. PluginBootstrap.class.getClassLoader() is application classloader,
cannot access custom classloder classes.
If you check the exception only when it's thrown(in the `Span#log(Throwable
e)`), you can simply use the same class loader to load the configured class by
name
> 2. So we cannot to solve it but for to judge it at run time,for excample
have following steps.
>2.1 find classes in every call by the hard config
>2.2 check the status
>I don't know if this has a performance impact when find classes
instance every time
Some simple caching is enough, I don't think the `Ignored Exception` list
would be very long
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin
wu-sheng commented on a change in pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#discussion_r481663911 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java ## @@ -96,6 +99,8 @@ */ protected boolean skipAnalysis; +protected String exceptionKind = ""; Review comment: Whether one or mutiple error logs are based on plugin, not core. They didn't say that API is allowed to be called max once per span in any document This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin
wu-sheng commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481656778
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
That is why, I asked you don't do the scan for class match. You should
determine the flow after exception happens and logs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin
EvanLjp commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481654955
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
this would be cause so many problems.
1. PluginBootstrap.class.getClassLoader() is application classloader,
cannot access custom classloder classes.
2. So we cannot to solve it but for to judge it at run time,for excample
have following steps.
2.1 find classes in every call by the hard config
2.2 check the status
I don't know if this has a performance impact when find classes instance
every time
@wu-sheng @kezhenxu94
Do you have any ideas to implement this feature?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin
wu-sheng commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481641690
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
`User code` is the wrong statement. All codes are user codes from the
agent's perspective. And the user could have a class loader, the framework
could have a class loader.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin
wu-sheng commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481640476
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> the package classes scan is only for the exceptions tagged with
@IgnoredException in user code,so we don't need to scan all
classes.PluginBootstrap.class.getClassLoader() have been meet the demand.
That would not be the case. Once you open `@IgnoredException` you can't tell
where it will be used. `PluginBootstrap.class.getClassLoader()` wouldn't be
able to access many classes when you use the standard J2EE container. Scan tech
is not allowed in the agent core stack or plugin stack.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin
wu-sheng commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481640476
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> the package classes scan is only for the exceptions tagged with
@IgnoredException in user code,so we don't need to scan all
classes.PluginBootstrap.class.getClassLoader() have been meet the demand.
That would be the case. Once you open `@IgnoredException` you can't tell
where it will be used. `PluginBootstrap.class.getClassLoader()` wouldn't be
able to access many classes when you use the standard J2EE container. Scan tech
is not allowed in the agent core stack or plugin stack.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin
EvanLjp commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481636021
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> I don't agree, for those exceptions thrown by some frameworks, users
cannot do anything to ignore them but only change the agent config
yes, that is the 2 point what i thought.
> 2\. If some exception defined in other lib which out of user control, the
exceptions cannot be tagged be @IgnoredException,so package scan scope is no
sense to it. the kind of exception should be ignored by hard code config.
my option is @IgnoredException is more friendly to use in user service code.
> 1. the package classes scan is only for the exceptions tagged with
@IgnoredException in user code,so we don't need to scan all
classes.PluginBootstrap.class.getClassLoader() have been meet the demand.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #349: Feature: Add serviceCode in span detail
wu-sheng commented on pull request #349: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/349#issuecomment-685271775 Please post the screenshot of all 3 pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5428: Have to setup skywalking for each nginx location
wu-sheng commented on issue #5428: URL: https://github.com/apache/skywalking/issues/5428#issuecomment-685271244 That is how things work. You need to intercept all requests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5428: Have to setup skywalking for each nginx location
wu-sheng closed issue #5428: URL: https://github.com/apache/skywalking/issues/5428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5426: exception-ignore-plugin
kezhenxu94 commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481628017
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
> In my mind , user would be like to add a new ignored exception by
@IgnoredException annotation rather than change skywalking agent config
frequency.
I don't agree, for those exceptions thrown by some frameworks, users cannot
do anything to ignore them but only change the agent config, and I suppose
that's a common case where users want to ignore exceptions from frameworks, if
they have control to where the exceptions are thrown, they can choose not to
throw the exceptions and only log some errors
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5421: Oap8.1 An OAP node USES ES6.7 to limit the problem
wu-sheng commented on issue #5421: URL: https://github.com/apache/skywalking/issues/5421#issuecomment-685270218 I don't have much experience to be shared with you, I am afraid. We don't face this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5427: frequently print warn log cause cpu using increase
wu-sheng closed issue #5427: URL: https://github.com/apache/skywalking/issues/5427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5427: frequently print warn log cause cpu using increase
wu-sheng commented on issue #5427: URL: https://github.com/apache/skywalking/issues/5427#issuecomment-685269598 Put this file https://github.com/apache/skywalking/blob/master/oap-server/server-core/src/test/resources/service-apdex-threshold.yml in the config folder. This has been fixed in the 8.x release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5425: Introduce label system to histogram
wu-sheng commented on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-685268601 I don't remember we created tmp file in the e2e. You are just posting the CI tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] ramonli opened a new issue #5428: Have to setup skywalking for each nginx location
ramonli opened a new issue #5428: URL: https://github.com/apache/skywalking/issues/5428 I am trying to integrate skywalking with nginx, what bothering me is that it seem I have to setup skywlking for each location.  can I just setup global skywalking for all nginx locations? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin
EvanLjp commented on a change in pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#discussion_r481601139 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java ## @@ -96,6 +99,8 @@ */ protected boolean skipAnalysis; +protected String exceptionKind = ""; Review comment: 1. in local span only may be 1 exception at most 2. many exceptions log may be only entry span or exist span. (entry1)-->(entry2)-->(local3)-->(exit4)-->(exit5) the exceptions in entry2,entry3,entry4 should be thought as exception Kind. the exceptions in entry1,exit5 should not be thought as exception kind. how do u think about it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] linliaoy commented on issue #5421: Oap8.1 An OAP node USES ES6.7 to limit the problem
linliaoy commented on issue #5421: URL: https://github.com/apache/skywalking/issues/5421#issuecomment-685263527  Is it necessary to change ES Client from version 6.3.2 to 6.7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin
EvanLjp commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481585531
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
I've done this before in inner apm system,there is some thinking about
this feature.
1. the package classes scan is only for the exceptions tagged with
@IgnoredException in user code,so we don't need to scan all
classes.PluginBootstrap.class.getClassLoader() have been meet the demand.
2. If some exception defined in other lib which out of user control, the
exceptions cannot be tagged be @IgnoredException,so package scan scope is no
sense to it. the kind of exception should be ignored by hard code config.
In my mind , user would be like to add a new ignored exception by
@IgnoredException annotation rather than change skywalking agent config
frequency.
How do you think about it? @wu-sheng
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin
EvanLjp commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481585531
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
I've done this before in self apm system,there is some thinking about
this feature.
1. the package classes scan is only for the exceptions tagged with
@IgnoredException in user code,so we don't need to scan all
classes.PluginBootstrap.class.getClassLoader() have been meet the demand.
2. If some exception defined in other lib which out of user control, the
exceptions cannot be tagged be @IgnoredException,so package scan scope is no
sense to it. the kind of exception should be ignored by hard code config.
In my mind , user would be like to add a new ignored exception by
@IgnoredException annotation rather than change skywalking agent config
frequency.
How do you think about it? @wu-sheng
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] killGC commented on issue #5427: frequently print warn log cause cpu using increase
killGC commented on issue #5427: URL: https://github.com/apache/skywalking/issues/5427#issuecomment-685254445 2020-08-29 07:32:02,777 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-7] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,458 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-9] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,487 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-14] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,531 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-9] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,593 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-11] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,638 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-6] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,640 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-7] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,742 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-12] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,866 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-5] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:03,867 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-14] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:04,040 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-3] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:04,106 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-10] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:04,106 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-7] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:04,356 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-15] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:04,356 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-2] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,138 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-15] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,139 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-3] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,217 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-13] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,218 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-5] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,247 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-10] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,248 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-1] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,409 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-4] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,412 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-14] WARN [] - Pick up system reserved threshold 500ms because of config missing 2020-08-29 07:32:05,645 -
[GitHub] [skywalking] killGC opened a new issue #5427: frequently print warn log cause cpu using increase
killGC opened a new issue #5427: URL: https://github.com/apache/skywalking/issues/5427 Please answer these questions before submitting your issue. 2020-08-29 07:32:06,113 - org.apache.skywalking.oap.server.core.analysis.ApdexThresholdConfig - 64 [grpcServerPool-1-thread-1] WARN [] - Pick up system reserved threshold 500ms because of config missing - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? skywalking 7.0，os linux，jre jdk8 - Which company or project? - What happened? If possible, provide a way to reproduce the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] hanahmily commented on pull request #5425: Introduce label system to histogram
hanahmily commented on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-685248751 > All e2e fail, so most likely the codes are not right. seems file changed monitor test failed: ``` 2020-09-01T22:35:06.2945140Z [ERROR] Failures: 2020-09-01T22:35:06.2945330Z [ERROR] MultipleFilesChangeMonitorTest.test:81 ``` I encountered similar issues several times. might we not create tmp files in e2e. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] xbkaishui commented on pull request #348: set dateformat with timezone
xbkaishui commented on pull request #348: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/348#issuecomment-685241882 currently I only changed the trace page date time, didn't fix the calendar picker component This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin
wu-sheng commented on a change in pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#discussion_r481526664
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java
##
@@ -96,6 +99,8 @@
*/
protected boolean skipAnalysis;
+protected String exceptionKind = "";
Review comment:
This could be overridden, such as two exceptions happened.
##
File path:
apm-sniffer/optional-plugins/exception-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/exception/ignore/ExceptionIgnorerService.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.exception.ignore;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.reflect.ClassPath;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import
org.apache.skywalking.apm.agent.core.context.DefaultExceptionIgnorerService;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractTracingSpan;
+import org.apache.skywalking.apm.agent.core.plugin.PluginBootstrap;
+import org.apache.skywalking.apm.toolkit.trace.IgnoredException;
+import org.apache.skywalking.apm.util.StringUtil;
+
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_CLASS_NAMES;
+import static
org.apache.skywalking.apm.plugin.exception.ignore.ExceptionAnalyzerConfig.Plugin.IgnoredException.IGNORED_EXCEPTION_SCAN_SCOPE;
+
+@OverrideImplementor(DefaultExceptionIgnorerService.class)
+public class ExceptionIgnorerService extends DefaultExceptionIgnorerService {
+
+private final Set exceptionClassNames = new HashSet<>();
+
+@Override
+public void prepare() throws Throwable {
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_CLASS_NAMES)) {
+
exceptionClassNames.addAll(Arrays.asList(IGNORED_EXCEPTION_CLASS_NAMES.split(",")));
+}
+if (StringUtil.isNotEmpty(IGNORED_EXCEPTION_SCAN_SCOPE)) {
+ClassPath classpath =
ClassPath.from(PluginBootstrap.class.getClassLoader());
+ImmutableSet classes =
classpath.getTopLevelClasses(IGNORED_EXCEPTION_SCAN_SCOPE);
Review comment:
We can't do this in the agent, because some classes are not in this
classloader, such as in Tomcat case, all user exception classes can't be
scanned.
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractSpan.java
##
@@ -62,6 +62,10 @@
AbstractSpan errorOccurred();
+AbstractSpan undoErrorOccurred();
+
+String exceptionKind();
Review comment:
Adding two methods in the core level is unexpected. Usually, the span
APIs are not providing capabilities to read fields.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #61: fix tree
kezhenxu94 merged pull request #61: URL: https://github.com/apache/skywalking-cli/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-cli] branch master updated: Update code style (#61)
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git
The following commit(s) were added to refs/heads/master by this push:
new 8d67d80 Update code style (#61)
8d67d80 is described below
commit 8d67d80e5dcaf5aea0e16960d7b87cc78eab9332
Author: huawei
AuthorDate: Wed Sep 2 09:46:15 2020 +0800
Update code style (#61)
---
display/graph/tree/adapter.go | 63 ---
1 file changed, 59 insertions(+), 4 deletions(-)
diff --git a/display/graph/tree/adapter.go b/display/graph/tree/adapter.go
index e06c7fa..895b5fd 100644
--- a/display/graph/tree/adapter.go
+++ b/display/graph/tree/adapter.go
@@ -28,13 +28,16 @@ import (
func Adapt(trace schema.Trace) (roots []*Node, serviceNames []string) {
all := make(map[string]*Node)
set := make(map[string]bool)
-
+ var traceID string
for _, span := range trace.Spans {
if !set[span.ServiceCode] {
serviceNames = append(serviceNames, span.ServiceCode)
set[span.ServiceCode] = true
}
all[id(span)] = node(span)
+ if traceID == "" {
+ traceID = span.TraceID
+ }
}
seen := make(map[string]bool)
@@ -44,8 +47,33 @@ func Adapt(trace schema.Trace) (roots []*Node, serviceNames
[]string) {
roots = append(roots, all[id(span)])
seen[id(span)] = true
}
+ for _, ref := range span.Refs {
+ if all[id0(ref)] == nil {
+ for i := 0; i <= ref.ParentSpanID; i++ {
+ if traceID != ref.TraceID {
+ continue
+ }
+ virtualSpan := virtualSpan(i, *ref)
+ if all[id(virtualSpan)] != nil {
+ continue
+ }
+ all[id(virtualSpan)] = node(virtualSpan)
+ if i == 0 {
+ roots = append(roots,
all[id(virtualSpan)])
+ seen[id(virtualSpan)] = true
+ } else if all[id1(ref)] != nil {
+ all[id1(ref)].Children =
append(all[id1(ref)].Children, all[id(virtualSpan)])
+ seen[id(virtualSpan)] = true
+ }
+ }
+ }
+ }
}
+ buildTree(all, seen, trace)
+ return roots, serviceNames
+}
+func buildTree(all map[string]*Node, seen map[string]bool, trace schema.Trace)
{
for len(seen) < len(trace.Spans) {
for _, span := range trace.Spans {
if seen[id(span)] {
@@ -58,15 +86,38 @@ func Adapt(trace schema.Trace) (roots []*Node, serviceNames
[]string) {
}
for _, ref := range span.Refs {
- if all[id0(ref)] != nil {
- all[id0(ref)].Children =
append(all[id0(ref)].Children, all[id(span)])
+ refData := all[id0(ref)]
+ if refData != nil {
+ refData.Children =
append(refData.Children, all[id(span)])
seen[id(span)] = true
}
}
}
}
+}
- return roots, serviceNames
+func virtualSpan(spanID int, ref schema.Ref) *schema.Span {
+ endpointName := fmt.Sprintf("VNode: %s", ref.ParentSegmentID)
+ component := fmt.Sprintf("VirtualNode: #%d", spanID)
+ peer := "No Peer"
+ fail := true
+ layer := "Broken"
+ span := schema.Span{
+ TraceID: ref.TraceID,
+ SegmentID:ref.ParentSegmentID,
+ SpanID: spanID,
+ ParentSpanID: spanID - 1,
+ EndpointName: ,
+ ServiceCode: "VirtualNode",
+ Type: fmt.Sprintf("[Broken] %s", ref.Type),
+ Peer: ,
+ Component:,
+ IsError: ,
+ Layer:,
+ Tags: nil,
+ Logs: nil,
+ }
+ return
}
func isRoot(span *schema.Span) bool {
@@ -85,6 +136,10 @@ func id0(ref *schema.Ref) string {
return fmt.Sprintf("%s:%s:%d", ref.TraceID, ref.ParentSegmentID,
ref.ParentSpanID)
}
[GitHub] [skywalking-rocketbot-ui] novayoung opened a new pull request #349: Feature: Add serviceCode in span detail ui component
novayoung opened a new pull request #349: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/349 issue: https://github.com/apache/skywalking/issues/5420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.92%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## + Coverage 51.41% 52.33% +0.92% - Complexity 3271 3310 +39 Files 878 879 +1 Lines 2176521739 -26 Branches 2087 2087 + Hits 1119111378 +187 + Misses 9680 9452 -228 - Partials894 909 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <0.00%> (-0.46%)` | `11.00% <0.00%> (ø%)` | | | [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | | | [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | | | ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.30%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## + Coverage 51.41% 51.72% +0.30% - Complexity 3271 3289 +18 Files 878 879 +1 Lines 2176521739 -26 Branches 2087 2087 + Hits 1119111244 +53 + Misses 9680 9588 -92 - Partials894 907 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `28.84% <0.00%> (-10.58%)` | `7.00% <0.00%> (-3.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.92%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## + Coverage 51.41% 52.33% +0.92% - Complexity 3271 3310 +39 Files 878 879 +1 Lines 2176521739 -26 Branches 2087 2087 + Hits 1119111378 +187 + Misses 9680 9452 -228 - Partials894 909 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <0.00%> (-0.46%)` | `11.00% <0.00%> (ø%)` | | | [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | | | [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | | | ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.33%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## + Coverage 51.41% 51.74% +0.33% - Complexity 3271 3289 +18 Files 878 877 -1 Lines 2176521728 -37 Branches 2087 2087 + Hits 1119111244 +53 + Misses 9680 9577 -103 - Partials894 907 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `28.84% <0.00%> (-10.58%)` | `7.00% <0.00%> (-3.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.20%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## + Coverage 51.41% 51.62% +0.20% - Complexity 3271 3282 +11 Files 878 877 -1 Lines 2176521728 -37 Branches 2087 2087 + Hits 1119111217 +26 + Misses 9680 9606 -74 - Partials894 905 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `28.84% <0.00%> (-10.58%)` | `7.00% <0.00%> (-3.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.36%`. > The diff coverage is `37.50%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 50.04% -1.37% + Complexity 3271 3029 -242 Files 878 1564 +686 Lines 2176533548 +11783 Branches 2087 3647+1560 + Hits 1119116790+5599 - Misses 968015940+6260 + Partials894 818 -76 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.25% <0.00%> (-49.51%)` | `0.00 <0.00> (-20.00)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (+12.19%)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `62.79% <88.23%> (+62.79%)` | `0.00 <0.00> (ø)` | | | [...skywalking/oap/server/core/query/type/HeatMap.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvdHlwZS9IZWF0TWFwLmphdmE=) | `18.30% <91.66%> (ø)` | `0.00 <0.00> (?)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `81.00% <95.45%> (-1.61%)` | `0.00 <0.00> (-20.00)` | | | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `81.25% <100.00%> (+35.93%)` | `7.00 <0.00> (ø)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `75.00% <100.00%> (+50.00%)` | `0.00 <0.00> (-1.00)` | :arrow_up: | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <100.00%> (+56.25%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `90.90%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.51%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 50.90% -0.52% + Complexity 3271 3253 -18 Files 878 877 -1 Lines 2176521728 -37 Branches 2087 2087 - Hits 1119111061 -130 - Misses 9680 9773 +93 Partials894 894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [...server/core/management/ui/template/UITemplate.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlLmphdmE=) | `58.82% <0.00%> (-41.18%)` | `2.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `3.93%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.47% -3.94% + Complexity 3271 3029 -242 Files 878 876 -2 Lines 2176521570 -195 Branches 2087 2036 -51 - Hits 1119110241 -950 - Misses 968010512 +832 + Partials894 817 -77 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.51%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 50.90% -0.52% + Complexity 3271 3253 -18 Files 878 877 -1 Lines 2176521728 -37 Branches 2087 2087 - Hits 1119111061 -130 - Misses 9680 9773 +93 Partials894 894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [...server/core/management/ui/template/UITemplate.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlLmphdmE=) | `58.82% <0.00%> (-41.18%)` | `2.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.52%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 50.89% -0.53% + Complexity 3271 3250 -21 Files 878 877 -1 Lines 2176521728 -37 Branches 2087 2087 - Hits 1119111058 -133 - Misses 9680 9776 +96 Partials894 894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [...server/core/management/ui/template/UITemplate.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlLmphdmE=) | `58.82% <0.00%> (-41.18%)` | `2.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.56%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 50.85% -0.57% + Complexity 3271 3249 -22 Files 878 877 -1 Lines 2176521718 -47 Branches 2087 2087 - Hits 1119111045 -146 - Misses 9680 9778 +98 - Partials894 895 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [...server/core/management/ui/template/UITemplate.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlLmphdmE=) | `58.82% <0.00%> (-41.18%)` | `2.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.54%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 50.87% -0.55% + Complexity 3271 3249 -22 Files 878 875 -3 Lines 2176521712 -53 Branches 2087 2087 - Hits 1119111045 -146 - Misses 9680 9772 +92 - Partials894 895 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | | | [...server/core/management/ui/template/UITemplate.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlLmphdmE=) | `58.82% <0.00%> (-41.18%)` | `2.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.02%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 50.39% -1.03% + Complexity 3271 3213 -58 Files 878 875 -3 Lines 2176521684 -81 Branches 2087 2082 -5 - Hits 1119110928 -263 - Misses 9680 9868 +188 + Partials894 888 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | | [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | | | [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-63.75%)` | `0.00% <0.00%> (-13.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.73%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.67% -1.74% + Complexity 3271 3179 -92 Files 878 875 -3 Lines 2176521681 -84 Branches 2087 2082 -5 - Hits 1119110771 -420 - Misses 968010024 +344 + Partials894 886 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.74%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.67% -1.75% + Complexity 3271 3178 -93 Files 878 875 -3 Lines 2176521681 -84 Branches 2087 2082 -5 - Hits 1119110770 -421 - Misses 968010024 +344 + Partials894 887 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.77%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.64% -1.78% + Complexity 3271 3177 -94 Files 878 875 -3 Lines 2176521681 -84 Branches 2087 2082 -5 - Hits 1119110763 -428 - Misses 968010030 +350 + Partials894 888 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `3.93%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.47% -3.94% + Complexity 3271 3029 -242 Files 878 876 -2 Lines 2176521570 -195 Branches 2087 2036 -51 - Hits 1119110241 -950 - Misses 968010512 +832 + Partials894 817 -77 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `2.05%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.36% -2.06% + Complexity 3271 3164 -107 Files 878 875 -3 Lines 2176521681 -84 Branches 2087 2082 -5 - Hits 1119110703 -488 - Misses 968010094 +414 + Partials894 884 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `4.02%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 47.39% -4.03% + Complexity 3271 3063 -208 Files 878 872 -6 Lines 2176521582 -183 Branches 2087 2071 -16 - Hits 1119110229 -962 - Misses 968010491 +811 + Partials894 862 -32 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.91%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.50% -1.92% + Complexity 3271 3164 -107 Files 878 873 -5 Lines 2176521622 -143 Branches 2087 2075 -12 - Hits 1119110703 -488 - Misses 968010035 +355 + Partials894 884 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.82%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.59% -1.83% + Complexity 3271 3164 -107 Files 878 872 -6 Lines 2176521582 -183 Branches 2087 2071 -16 - Hits 1119110703 -488 - Misses 9680 9995 +315 + Partials894 884 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.87%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## - Coverage 51.41% 49.54% -1.88% + Complexity 3271 3163 -108 Files 878 872 -6 Lines 2176521582 -183 Branches 2087 2071 -16 - Hits 1119110692 -499 - Misses 968010007 +327 + Partials894 883 -11 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00% <0.00%> (-12.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `13.15%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## = - Coverage 51.41% 38.26% -13.16% + Complexity 3271 2400 -871 = Files 878 872-6 Lines 2176521574 -191 Branches 2087 2056 -31 = - Hits 11191 8255 -2936 - Misses 968012695 +3015 + Partials894 624 -270 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `3.93%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.48% -3.94% + Complexity 3271 3029 -242 Files 878 875 -3 Lines 2176521566 -199 Branches 2087 2036 -51 - Hits 1119110241 -950 - Misses 968010508 +828 + Partials894 817 -77 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5416 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 168 -710 Lines 217654043-17722 Branches 2087 467 -1620 - Hits 11191 0-11191 + Misses 96804043 -5637 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [839 more](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5416 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 167 -711 Lines 217654027-17738 Branches 2087 463 -1624 - Hits 11191 0-11191 + Misses 96804027 -5653 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [840 more](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5416 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 164 -714 Lines 217653989-17776 Branches 2087 463 -1624 - Hits 11191 0-11191 + Misses 96803989 -5691 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [841 more](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5416 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 166 -712 Lines 217654001-17764 Branches 2087 463 -1624 - Hits 11191 0-11191 + Misses 96804001 -5679 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [841 more](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] EvanLjp commented on pull request #5416: Support segment status based on entry/first span only
EvanLjp commented on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-685174958 @wu-sheng org.apache.skywalking.oap.server.core.analysis.TimeBucketTest#testConversion the unit test is unstble. if the time is between 0:00 and 8:00,the result is error,reremember notic before  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `3.93%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.48% -3.94% + Complexity 3271 3029 -242 Files 878 875 -3 Lines 2176521566 -199 Branches 2087 2036 -51 - Hits 1119110241 -950 - Misses 968010508 +828 + Partials894 817 -77 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `3.90%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.51% -3.91% + Complexity 3271 3029 -242 Files 878 873 -5 Lines 2176521555 -210 Branches 2087 2036 -51 - Hits 1119110241 -950 - Misses 968010497 +817 + Partials894 817 -77 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `4.07%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.33% -4.08% + Complexity 3271 3015 -256 Files 878 873 -5 Lines 2176521555 -210 Branches 2087 2036 -51 - Hits 1119110204 -987 - Misses 968010537 +857 + Partials894 814 -80 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `4.21%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 47.20% -4.22% + Complexity 3271 3008 -263 Files 878 873 -5 Lines 2176521555 -210 Branches 2087 2036 -51 - Hits 1119110174-1017 - Misses 968010575 +895 + Partials894 806 -88 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 177 -701 Lines 217654202-17563 Branches 2087 479 -1608 - Hits 11191 0-11191 + Misses 96804202 -5478 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [823 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `8.63%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## - Coverage 51.41% 42.78% -8.64% + Complexity 3271 2720 -551 Files 878 855 -23 Lines 2176521007 -758 Branches 2087 1986 -101 - Hits 11191 8987-2204 - Misses 968011293+1613 + Partials894 727 -167 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `18.65%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## = - Coverage 51.41% 32.76% -18.66% + Complexity 3271 2044 -1227 = Files 878 855 -23 Lines 2176521007 -758 Branches 2087 1986 -101 = - Hits 11191 6883 -4308 - Misses 968013635 +3955 + Partials894 489 -405 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `17.89%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## = - Coverage 51.41% 33.52% -17.90% + Complexity 3271 2067 -1204 = Files 878 855 -23 Lines 2176521007 -758 Branches 2087 1986 -101 = - Hits 11191 7043 -4148 - Misses 968013471 +3791 + Partials894 493 -401 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `85.18% <100.00%> (-3.71%)` | `21.00 <0.00> (-2.00)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 177 -701 Lines 217654202-17563 Branches 2087 479 -1608 - Hits 11191 0-11191 + Misses 96804202 -5478 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [823 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `25.38%`. > The diff coverage is `0.75%`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5425 +/- ## = - Coverage 51.41% 26.02% -25.39% + Complexity 3271 1710 -1561 = Files 878 853 -25 Lines 2176520962 -803 Branches 2087 1985 -102 = - Hits 11191 5456 -5735 - Misses 968015133 +5453 + Partials894 373 -521 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00 <0.00> (ø)` | | | [.../analysis/meter/function/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-61.77%)` | `0.00 <0.00> (-20.00)` | | | [...r/core/analysis/meter/function/BucketedValues.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQnVja2V0ZWRWYWx1ZXMuamF2YQ==) | `0.00% <0.00%> (-25.00%)` | `0.00 <0.00> (-1.00)` | | | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...e/metric/promethues/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvUHJvbWV0aGV1c01ldHJpY0NvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (-73.62%)` | `0.00 <0.00> (-36.00)` | | | [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-82.61%)` | `0.00 <0.00> (-20.00)` | | | [...ng/oap/server/core/analysis/metrics/DataTable.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9EYXRhVGFibGUuamF2YQ==) | `77.77% <100.00%> (-11.12%)` | `19.00 <0.00> (-4.00)` | | | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 168 -710 Lines 217654073-17692 Branches 2087 471 -1616 - Hits 11191 0-11191 + Misses 96804073 -5607 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [833 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5416: Support segment status based on entry/first span only
codecov[bot] edited a comment on pull request #5416: URL: https://github.com/apache/skywalking/pull/5416#issuecomment-683747640 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=h1) Report > Merging [#5416](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `1.59%`. > The diff coverage is `73.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5416 +/- ## + Coverage 51.41% 53.01% +1.59% - Complexity 3271 3329 +58 Files 878 870 -8 Lines 2176521581 -184 Branches 2087 2072 -15 + Hits 1119111441 +250 + Misses 9680 9232 -448 - Partials894 908 +14 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5416?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...tener/strategy/FirstSpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9GaXJzdFNwYW5TZWdtZW50U3RhdHVzQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | | | [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `78.20% <66.66%> (+1.58%)` | `16.00 <0.00> (ø)` | | | [...r/provider/trace/parser/SegmentStatusStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50U3RhdHVzU3RyYXRlZ3kuamF2YQ==) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | | | [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...istener/strategy/AnySpanSegmentStatusAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9zdHJhdGVneS9BbnlTcGFuU2VnbWVudFN0YXR1c0FuYWx5emVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | | | [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | | | [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5416/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | | | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 175 -703 Lines 217654143-17622 Branches 2087 472 -1615 - Hits 11191 0-11191 + Misses 96804143 -5537 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [826 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 165 -713 Lines 217654019-17746 Branches 2087 464 -1623 - Hits 11191 0-11191 + Misses 96804019 -5661 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [836 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 176 -702 Lines 217654198-17567 Branches 2087 479 -1608 - Hits 11191 0-11191 + Misses 96804198 -5482 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [824 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 174 -704 Lines 217654192-17573 Branches 2087 479 -1608 - Hits 11191 0-11191 + Misses 96804192 -5488 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [826 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 161 -717 Lines 217653895-17870 Branches 2087 443 -1644 - Hits 11191 0-11191 + Misses 96803895 -5785 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [837 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 173 -705 Lines 217654153-17612 Branches 2087 478 -1609 - Hits 11191 0-11191 + Misses 96804153 -5527 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [827 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 160 -718 Lines 217653887-17878 Branches 2087 443 -1644 - Hits 11191 0-11191 + Misses 96803887 -5793 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [837 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 157 -721 Lines 217653854-17911 Branches 2087 439 -1648 - Hits 11191 0-11191 + Misses 96803854 -5826 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [840 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 175 -703 Lines 217654143-17622 Branches 2087 472 -1615 - Hits 11191 0-11191 + Misses 96804143 -5537 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [826 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 173 -705 Lines 217654153-17612 Branches 2087 478 -1609 - Hits 11191 0-11191 + Misses 96804153 -5527 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [827 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 174 -704 Lines 217654139-17626 Branches 2087 472 -1615 - Hits 11191 0-11191 + Misses 96804139 -5541 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [827 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 169 -709 Lines 217654100-17665 Branches 2087 474 -1613 - Hits 11191 0-11191 + Misses 96804100 -5580 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [831 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 167 -711 Lines 217654041-17724 Branches 2087 467 -1620 - Hits 11191 0-11191 + Misses 96804041 -5639 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [834 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] hanahmily commented on a change in pull request #5425: Introduce label system to histogram
hanahmily commented on a change in pull request #5425:
URL: https://github.com/apache/skywalking/pull/5425#discussion_r481462460
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/AvgHistogramPercentileFunction.java
##
@@ -168,38 +178,64 @@ public void combine(final Metrics metrics) {
@Override
public void calculate() {
if (!isCalculated) {
-final List sortedKeys =
summation.sortedKeys(Comparator.comparingInt(Integer::parseInt));
-for (String key : sortedKeys) {
-dataset.put(key, summation.get(key) / count.get(key));
-}
-
-long total = dataset.sumOfValues();
-
-int[] roofs = new int[ranks.size()];
-for (int i = 0; i < ranks.size(); i++) {
-roofs[i] = Math.round(total * ranks.get(i) * 1.0f / 100);
-}
-
-int count = 0;
-int loopIndex = 0;
-
-for (int i = 0; i < sortedKeys.size(); i++) {
-String key = sortedKeys.get(i);
-final Long value = dataset.get(key);
-
-count += value;
-for (int rankIdx = loopIndex; rankIdx < roofs.length;
rankIdx++) {
-int roof = roofs[rankIdx];
-
-if (count >= roof) {
-long latency = (i + 1 == sortedKeys.size()) ?
Long.MAX_VALUE : Long.parseLong(sortedKeys.get(i + 1));
-
percentileValues.put(String.valueOf(ranks.get(rankIdx)), latency);
-loopIndex++;
-} else {
-break;
+final Set keys = summation.keys();
+for (String key : keys) {
+long value = 0;
+if (count.get(key) != 0) {
+value = summation.get(key) / count.get(key);
+if (value == 0L && summation.get(key) > 0L) {
+value = 1;
}
}
+dataset.put(key, value);
}
+dataset.keys().stream()
+.map(key -> {
+if (key.contains(":")) {
+String[] kk = key.split(":");
+return Tuple.of(kk[0], key);
+} else {
+return Tuple.of(DEFAULT_GROUP, key);
+}
+})
+.collect(groupingBy(Tuple2::_1, mapping(Tuple2::_2,
Collector.of(
+DataTable::new,
+(dt, key) -> dt.put(key.contains(":") ? key.split(":")[1]
: key, dataset.get(key)),
+DataTable::append
+.forEach((group, subDataset) -> {
+long total;
+total = subDataset.sumOfValues();
+
+int[] roofs = new int[ranks.size()];
+for (int i = 0; i < ranks.size(); i++) {
+roofs[i] = Math.round(total * ranks.get(i) * 1.0f /
100);
+}
+
+int count = 0;
+final List sortedKeys =
subDataset.sortedKeys(Comparator.comparingLong(Long::parseLong));
+
+int loopIndex = 0;
+
+for (String key : sortedKeys) {
+final Long value = subDataset.get(key);
+
+count += value;
+for (int rankIdx = loopIndex; rankIdx < roofs.length;
rankIdx++) {
+int roof = roofs[rankIdx];
+
+if (count >= roof) {
+if (group.equals(DEFAULT_GROUP)) {
+
percentileValues.put(String.valueOf(ranks.get(rankIdx)), Long.parseLong(key));
+} else {
+
percentileValues.put(String.format("%s:%s", group, ranks.get(rankIdx)),
Long.parseLong(key));
Review comment:
Exactly. `:` is the splitter.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 174 -704 Lines 217654139-17626 Branches 2087 472 -1615 - Hits 11191 0-11191 + Misses 96804139 -5541 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [827 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] hanahmily commented on a change in pull request #5425: Introduce label system to histogram
hanahmily commented on a change in pull request #5425:
URL: https://github.com/apache/skywalking/pull/5425#discussion_r481461977
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/AvgHistogramPercentileFunction.java
##
@@ -125,11 +135,17 @@ public void accept(final MeterEntity entity, final
AvgPercentileArgument value)
this.entityId = entity.id();
+String template = "%s";
+if (!Strings.isNullOrEmpty(value.getBucketedValues().getGroup())) {
+template = value.getBucketedValues().getGroup() + ":%s";
+}
final long[] values = value.getBucketedValues().getValues();
for (int i = 0; i < values.length; i++) {
-String bucketName =
String.valueOf(value.getBucketedValues().getBuckets()[i]);
-summation.valueAccumulation(bucketName, values[i]);
-count.valueAccumulation(bucketName, 1L);
+long bucket = value.getBucketedValues().getBuckets()[i];
+String bucketName = bucket == Long.MIN_VALUE ?
Bucket.INFINITE_NEGATIVE : String.valueOf(bucket);
+String key = String.format(template, bucketName);
+summation.valueAccumulation(key, values[i]);
Review comment:
It's `:` which is composed of some lines above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5425: Introduce label system to histogram
hanahmily commented on a change in pull request #5425:
URL: https://github.com/apache/skywalking/pull/5425#discussion_r481461977
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/AvgHistogramPercentileFunction.java
##
@@ -125,11 +135,17 @@ public void accept(final MeterEntity entity, final
AvgPercentileArgument value)
this.entityId = entity.id();
+String template = "%s";
+if (!Strings.isNullOrEmpty(value.getBucketedValues().getGroup())) {
+template = value.getBucketedValues().getGroup() + ":%s";
+}
final long[] values = value.getBucketedValues().getValues();
for (int i = 0; i < values.length; i++) {
-String bucketName =
String.valueOf(value.getBucketedValues().getBuckets()[i]);
-summation.valueAccumulation(bucketName, values[i]);
-count.valueAccumulation(bucketName, 1L);
+long bucket = value.getBucketedValues().getBuckets()[i];
+String bucketName = bucket == Long.MIN_VALUE ?
Bucket.INFINITE_NEGATIVE : String.valueOf(bucket);
+String key = String.format(template, bucketName);
+summation.valueAccumulation(key, values[i]);
Review comment:
It's ":" which is composed of some lines above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 166 -712 Lines 217654001-17764 Branches 2087 463 -1624 - Hits 11191 0-11191 + Misses 96804001 -5679 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [834 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch meter-histogram updated (d5bdc64 -> a7e21f3)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch meter-histogram in repository https://gitbox.apache.org/repos/asf/skywalking.git. from d5bdc64 Update oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/AvgHistogramPercentileFunction.java add a7e21f3 Cleanup imports No new revisions were added by this update. Summary of changes: .../oap/server/core/analysis/meter/function/AvgHistogramFunction.java| 1 - 1 file changed, 1 deletion(-)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5425: Introduce label system to histogram
codecov[bot] edited a comment on pull request #5425: URL: https://github.com/apache/skywalking/pull/5425#issuecomment-684969687 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=h1) Report > Merging [#5425](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5425 +/- ## - Coverage 51.41% 0.00% -51.42% Files 878 171 -707 Lines 217654094-17671 Branches 2087 471 -1616 - Hits 11191 0-11191 + Misses 96804094 -5586 + Partials894 0 -894 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5425?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [830 more](https://codecov.io/gh/apache/skywalking/pull/5425/diff?src=pr=tree-more) | | -- [Continue to review full report at
