[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5887: URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5887: URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5887: URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5887: URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5889: URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox
wu-sheng commented on a change in pull request #12: URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530138473 ## File path: doc/custom-metrics-adapter.md ## @@ -0,0 +1,77 @@ +# Custom metrics Adapter + +This adapter contains an implementation of [external

[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox
hanahmily commented on a change in pull request #12: URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530139941 ## File path: doc/custom-metrics-adapter.md ## @@ -0,0 +1,77 @@ +# Custom metrics Adapter + +This adapter contains an implementation of [external

[GitHub] [skywalking-cli] fgksgf opened a new pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox
fgksgf opened a new pull request #76: URL: https://github.com/apache/skywalking-cli/pull/76 - Add flags of instance, endpoint and normal for metrics command - Fix format issue of `How-to-release.md` - Update `README.md` Resolve apache/skywalking#5890

[GitHub] [skywalking] fgksgf commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox
fgksgf commented on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733510093 @wu-sheng I added a bool flag named `unnormal`, it's not required. Because the default value of `normal` is `true`. If we create a `isNormal` flag, we probably have to add

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox
kezhenxu94 commented on a change in pull request #76: URL: https://github.com/apache/skywalking-cli/pull/76#discussion_r530155231 ## File path: assets/assets.gen.go ## @@ -17,6 +17,8 @@ // Code generated by go-bindata. DO NOT EDIT. // sources: +// .DS_Store (6.148kB)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox
kezhenxu94 edited a comment on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733525745 > > I added a bool flag named unnormal, it's not required. Because the default value of bool is true. > > If we create a isNormal flag, we probably have to add this

[GitHub] [skywalking] kezhenxu94 commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox
kezhenxu94 commented on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733525745 > > I added a bool flag named unnormal, it's not required. Because the default value of bool is true. > > If we create a isNormal flag, we probably have to add this flag

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox
kezhenxu94 commented on a change in pull request #76: URL: https://github.com/apache/skywalking-cli/pull/76#discussion_r530158976 ## File path: commands/metrics/single/single-metrics.go ## @@ -49,7 +49,9 @@ var Command = cli.Command{ metricsName :=

[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox
hanahmily commented on a change in pull request #12: URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530160629 ## File path: doc/custom-metrics-adapter.md ## @@ -0,0 +1,77 @@ +# Custom metrics Adapter + +This adapter contains an implementation of [external

[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox
wu-sheng commented on a change in pull request #12: URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530162327 ## File path: doc/custom-metrics-adapter.md ## @@ -0,0 +1,77 @@ +# Custom metrics Adapter + +This adapter contains an implementation of [external

[GitHub] [skywalking] rootsongjc edited a comment on issue #5534: Using Hugo to refactor Apache SkyWalking's website

2020-11-24 Thread GitBox
rootsongjc edited a comment on issue #5534: URL: https://github.com/apache/skywalking/issues/5534#issuecomment-731053218 The first version is basically finished, but there are still some problems left, which we can fix slowly. I will submit a PR. The next issues to be fixed in the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox
kezhenxu94 commented on a change in pull request #76: URL: https://github.com/apache/skywalking-cli/pull/76#discussion_r530155231 ## File path: assets/assets.gen.go ## @@ -17,6 +17,8 @@ // Code generated by go-bindata. DO NOT EDIT. // sources: +// .DS_Store (6.148kB)

[GitHub] [skywalking] fgksgf edited a comment on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox
fgksgf edited a comment on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733510093 @wu-sheng I added a bool flag named `unnormal`, it's not required. Because the default value of `bool` is `true`. If we create a `isNormal` flag, we probably have to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox
wu-sheng commented on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733524157 > I added a bool flag named unnormal, it's not required. Because the default value of bool is true. If we create a isNormal flag, we probably have to add this flag most of the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr=h1) Report > Merging

[GitHub] [skywalking] fgksgf commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox
fgksgf commented on issue #5890: URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733526264 Make sense to me This is an automated message from the Apache Git Service. To respond to the message, please log

<    1   2   3   4   5