Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
wankai123 commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926033228 ``` - name: consumer_group_count exp: rocketmq_consumer_offset.sum(['cluster','topic','group']).count(['group']) ``` I think the result of your expression is:

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
wu-sheng commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926119964 After the sum, why we still have group label to count? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Bug] skywalking agent randomly occupies some ports during runtime. [skywalking]

2024-02-04 Thread via GitHub
kamyuk commented on issue #11868: URL: https://github.com/apache/skywalking/issues/11868#issuecomment-1926089447 > This is by design on the gRPC side, you may can force using a source port but that is in general a limited usecase, since grpc already picks a random unused port. You normally

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
wankai123 commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926112212 >Yes, After the sum aggregation. I will serve UT tests up later `sum` is used to aggregate the value of the metrics, I think is unnecessary to use it here. -- This is an

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
wankai123 commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926122582 > I need to pre-aggregation on the ['cluster','topic','group'] dimension you should aggregate the dimension in func `count` directly. Please refer other aggregate func

Re: [PR] Bump phpseclib/phpseclib from 3.0.19 to 3.0.35 in /tests/php [skywalking-php]

2024-02-04 Thread via GitHub
jmjoy commented on PR #104: URL: https://github.com/apache/skywalking-php/pull/104#issuecomment-1926149127 @dependabot squash and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump phpseclib/phpseclib from 3.0.19 to 3.0.35 in /tests/php [skywalking-php]

2024-02-04 Thread via GitHub
jmjoy merged PR #104: URL: https://github.com/apache/skywalking-php/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-php) branch dependabot/composer/tests/php/phpseclib/phpseclib-3.0.35 deleted (was a236a1f)

2024-02-04 Thread jmjoy
This is an automated email from the ASF dual-hosted git repository. jmjoy pushed a change to branch dependabot/composer/tests/php/phpseclib/phpseclib-3.0.35 in repository https://gitbox.apache.org/repos/asf/skywalking-php.git was a236a1f Bump phpseclib/phpseclib from 3.0.19 to 3.0.35 in

(skywalking-php) branch master updated: Bump phpseclib/phpseclib from 3.0.19 to 3.0.35 in /tests/php (#104)

2024-02-04 Thread jmjoy
This is an automated email from the ASF dual-hosted git repository. jmjoy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-php.git The following commit(s) were added to refs/heads/master by this push: new 7c502f4 Bump phpseclib/phpseclib from

[PR] Remove partID for stream [skywalking-banyandb]

2024-02-04 Thread via GitHub
ButterBright opened a new pull request, #388: URL: https://github.com/apache/skywalking-banyandb/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
wankai123 commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926321428 From the rocketMQ official exporter doc I found these metrics samples: ``` # HELP rocketmq_producer_offset TopicOffset # TYPE rocketmq_producer_offset counter

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
peachisai commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926118902 > rocketmq_consumer_offset{cluster="DefaultCluster",broker="broker-a",topic="topic1",group="group3",} 347.0 ```

Re: [PR] Bump phpseclib/phpseclib from 3.0.19 to 3.0.35 in /tests/php [skywalking-php]

2024-02-04 Thread via GitHub
dependabot[bot] commented on PR #104: URL: https://github.com/apache/skywalking-php/pull/104#issuecomment-1926149171 Dependabot tried to merge this PR, but received the following error from GitHub: ``` At least 1 approving review is required by reviewers with write access. ```

[PR] Add hierarchy relations auto-matching for NGINX/APISIX. Fix `Nginx-Instance` metrics to instance level. [skywalking]

2024-02-04 Thread via GitHub
wankai123 opened a new pull request, #11870: URL: https://github.com/apache/skywalking/pull/11870 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [X] Update the [`CHANGES`

[PR] Add lock and version file for process control and compatibility [skywalking-banyandb]

2024-02-04 Thread via GitHub
ButterBright opened a new pull request, #389: URL: https://github.com/apache/skywalking-banyandb/pull/389 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11493. -- This is an automated

Re: [PR] Add `count` function for MAL down sampling. [skywalking]

2024-02-04 Thread via GitHub
peachisai commented on PR #11859: URL: https://github.com/apache/skywalking/pull/11859#issuecomment-1925733792 I will use `count` aggragation in place of the `count` downsampling -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add `count` function for MAL down sampling. [skywalking]

2024-02-04 Thread via GitHub
peachisai closed pull request #11859: Add `count` function for MAL down sampling. URL: https://github.com/apache/skywalking/pull/11859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
peachisai opened a new pull request, #11869: URL: https://github.com/apache/skywalking/pull/11869 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

Re: [PR] correct encode tag value method [skywalking-banyandb]

2024-02-04 Thread via GitHub
hanahmily merged PR #385: URL: https://github.com/apache/skywalking-banyandb/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-banyandb) branch main updated: correct encode tag value method (#385)

2024-02-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new c9436544 correct encode tag value

Re: [PR] Add unit tests for stream query [skywalking-banyandb]

2024-02-04 Thread via GitHub
hanahmily merged PR #387: URL: https://github.com/apache/skywalking-banyandb/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-banyandb) branch main updated: Add unit tests for stream query (#387)

2024-02-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 7aa10272 Add unit tests for stream

Re: [PR] Add `count` function for MAL down sampling. [skywalking]

2024-02-04 Thread via GitHub
wu-sheng commented on PR #11859: URL: https://github.com/apache/skywalking/pull/11859#issuecomment-192573 > I will use `count` aggragation in place of the `count` downsampling I am doubt about this logic. Because logically, count for downsampling only works for counting events,

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
wu-sheng commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1925744177 Please provide UTs for the new functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Bug] skywalking agent randomly occupies some ports during runtime. [skywalking]

2024-02-04 Thread via GitHub
Superskyyy commented on issue #11868: URL: https://github.com/apache/skywalking/issues/11868#issuecomment-1925894743 This is by design on the gRPC side, you may can force using a source port but that is in general a limited usecase, since grpc already picks a random unused port. You

Re: [PR] Add `count` aggregation function for MAL [skywalking]

2024-02-04 Thread via GitHub
peachisai commented on PR #11869: URL: https://github.com/apache/skywalking/pull/11869#issuecomment-1926086153 > ``` > - name: consumer_group_count > exp: rocketmq_consumer_offset.sum(['cluster','topic','group']).count(['group']) > ``` > > I think the result of your