[GitHub] peng-yongsheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP?

2018-04-10 Thread GitBox
peng-yongsheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP? URL: https://github.com/apache/incubator-skywalking/issues/1065#issuecomment-380322424 Sure, the host setting of agent gRPC module must bind on IP/HOST which your agent side can be connected.

[GitHub] gMan1990 opened a new issue #1065: agent_gRPC这里是不是得配置成自己的外网IP?

2018-04-10 Thread GitBox
gMan1990 opened a new issue #1065: agent_gRPC这里是不是得配置成自己的外网IP? URL: https://github.com/apache/incubator-skywalking/issues/1065

[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization

2018-04-10 Thread GitBox
peng-yongsheng commented on issue #1032: Collector performance optimization URL: https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223 ## Report digest ``` metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s) metric name:

[GitHub] coveralls commented on issue #1063: Add an incubating feature section for preparing to merge ElasticSearch HTTP implementor

2018-04-10 Thread GitBox
coveralls commented on issue #1063: Add an incubating feature section for preparing to merge ElasticSearch HTTP implementor URL: https://github.com/apache/incubator-skywalking/pull/1063#issuecomment-380321142 [![Coverage

[GitHub] peng-yongsheng opened a new issue #1064: Add annotation named SQLAs to help collector storage module extension

2018-04-10 Thread GitBox
peng-yongsheng opened a new issue #1064: Add annotation named SQLAs to help collector storage module extension URL: https://github.com/apache/incubator-skywalking/issues/1064 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Feature

[GitHub] wu-sheng commented on issue #1048: Create Setting-override-CN.md

2018-04-10 Thread GitBox
wu-sheng commented on issue #1048: Create Setting-override-CN.md URL: https://github.com/apache/incubator-skywalking/pull/1048#issuecomment-380318703 @w281015308 Sorry, I have to close this. @candyleer 's #1062 has been merged. It includes all Chinese documents. Thanks for your

[GitHub] wu-sheng closed pull request #1048: Create Setting-override-CN.md

2018-04-10 Thread GitBox
wu-sheng closed pull request #1048: Create Setting-override-CN.md URL: https://github.com/apache/incubator-skywalking/pull/1048 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] wu-sheng closed pull request #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
wu-sheng closed pull request #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] coveralls commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
coveralls commented on issue #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380317246 [![Coverage Status](https://coveralls.io/builds/16453361/badge)](https://coveralls.io/builds/16453361)

[GitHub] wu-sheng commented on issue #871: Add elasticSearch-http storage module.

2018-04-10 Thread GitBox
wu-sheng commented on issue #871: Add elasticSearch-http storage module. URL: https://github.com/apache/incubator-skywalking/pull/871#issuecomment-380315966 @cyberdak Related pr #1063 proposed, please see. If we agree with all things we have discussed, please consider to 1. Add

[GitHub] wu-sheng opened a new pull request #1063: Add an incubating feature section for preparing to merge ElasticSearch HTTP implementor

2018-04-10 Thread GitBox
wu-sheng opened a new pull request #1063: Add an incubating feature section for preparing to merge ElasticSearch HTTP implementor URL: https://github.com/apache/incubator-skywalking/pull/1063 @peng-yongsheng @cyberdak In case the SkyWalking iteration is fast, and ES HTTP

[GitHub] wu-sheng commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
wu-sheng commented on issue #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380312285 > dose it relate with this pr? this make me confused when i just update the documents only You update submodule

[GitHub] candyleer commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
candyleer commented on issue #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380312294 @wu-sheng yeah,i found it ,i will remove this dirty commit and commit again

[GitHub] wu-sheng closed issue #998: GraphQL type AppServerInfo#name rename and redefine.

2018-04-10 Thread GitBox
wu-sheng closed issue #998: GraphQL type AppServerInfo#name rename and redefine. URL: https://github.com/apache/incubator-skywalking/issues/998 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #998: GraphQL type AppServerInfo#name rename and redefine.

2018-04-10 Thread GitBox
wu-sheng commented on issue #998: GraphQL type AppServerInfo#name rename and redefine. URL: https://github.com/apache/incubator-skywalking/issues/998#issuecomment-380311275 Frontend has been fixed by https://github.com/apache/incubator-skywalking-ui/pull/154 Closing. Thanks

[GitHub] candyleer commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
candyleer commented on issue #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380310593 @peng-yongsheng travis-ci has failed cause of: ``` error: Server does not allow request for unadvertised object

[GitHub] candyleer commented on issue #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
candyleer commented on issue #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062#issuecomment-380308866 Direct uplink translation maybe not correct.please check

[GitHub] candyleer opened a new pull request #1062: chinese documents translation, sync with english

2018-04-10 Thread GitBox
candyleer opened a new pull request #1062: chinese documents translation, sync with english URL: https://github.com/apache/incubator-skywalking/pull/1062 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] peng-yongsheng commented on issue #1047: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox
peng-yongsheng commented on issue #1047: Refactor the collector configuration initialization. URL: https://github.com/apache/incubator-skywalking/issues/1047#issuecomment-380306733 Done This is an automated message from the

[GitHub] peng-yongsheng closed issue #1047: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox
peng-yongsheng closed issue #1047: Refactor the collector configuration initialization. URL: https://github.com/apache/incubator-skywalking/issues/1047 This is an automated message from the Apache Git Service. To respond to

[GitHub] peng-yongsheng closed issue #1050: Add a FAQ about SkyWalking upgrade

2018-04-10 Thread GitBox
peng-yongsheng closed issue #1050: Add a FAQ about SkyWalking upgrade URL: https://github.com/apache/incubator-skywalking/issues/1050 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] peng-yongsheng commented on issue #1050: Add a FAQ about SkyWalking upgrade

2018-04-10 Thread GitBox
peng-yongsheng commented on issue #1050: Add a FAQ about SkyWalking upgrade URL: https://github.com/apache/incubator-skywalking/issues/1050#issuecomment-380306680 Done This is an automated message from the Apache Git

[GitHub] weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380304104 @wu-sheng yes, I agree with your opinion because I also see the starting script. So I just

[GitHub] wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380303407 @weenyaimac I don't know that. They are two separated processes in OS, just start up by one

[GitHub] weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380300905 Ok, I will try my best. I also have another question with it. Why webapp process also quits

[GitHub] wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380300247 > Thanks. I see, and the document isn't right, it writes 'Elasticsearch 5.x' Yes. If you

[GitHub] weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
weenyaimac commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380300081 Thanks. I see, and the document isn't right, it writes 'Elasticsearch 5.x'

[GitHub] wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
wu-sheng commented on issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061#issuecomment-380299114 Hi, from the document, we only supported 5.x

[GitHub] wu-sheng closed issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
wu-sheng closed issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061 This is an automated message from the Apache Git Service. To

[GitHub] weenyaimac opened a new issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3

2018-04-10 Thread GitBox
weenyaimac opened a new issue #1061: Collector throws NoNodeAvailableException using Elasticsearch 6.2.3 URL: https://github.com/apache/incubator-skywalking/issues/1061 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or

[GitHub] wu-sheng commented on issue #1060: the menu icons cannot be displayed without internet

2018-04-10 Thread GitBox
wu-sheng commented on issue #1060: the menu icons cannot be displayed without internet URL: https://github.com/apache/incubator-skywalking/issues/1060#issuecomment-380295403 @hanahmily Please check whether this can be fixed in beta. I would not think this is a serious problem, but

[GitHub] breakenknife opened a new issue #1060: the menu icons cannot be displayed without internet

2018-04-10 Thread GitBox
breakenknife opened a new issue #1060: the menu icons cannot be displayed without internet URL: https://github.com/apache/incubator-skywalking/issues/1060 As the figure above shows,the smallicons of menu is missing.

[GitHub] coveralls commented on issue #1059: Update README_ZH.md

2018-04-10 Thread GitBox
coveralls commented on issue #1059: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/1059#issuecomment-380153358 [![Coverage Status](https://coveralls.io/builds/16440901/badge)](https://coveralls.io/builds/16440901) Coverage remained the same at

[GitHub] peng-yongsheng opened a new pull request #1059: Update README_ZH.md

2018-04-10 Thread GitBox
peng-yongsheng opened a new pull request #1059: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/1059 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Document Style issues when use *.

[GitHub] wu-sheng closed pull request #1052: Collector 5.0.0-alpha version upgrade FAQ.

2018-04-10 Thread GitBox
wu-sheng closed pull request #1052: Collector 5.0.0-alpha version upgrade FAQ. URL: https://github.com/apache/incubator-skywalking/pull/1052 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ.

2018-04-10 Thread GitBox
coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ. URL: https://github.com/apache/incubator-skywalking/pull/1052#issuecomment-379615075 [![Coverage Status](https://coveralls.io/builds/16438214/badge)](https://coveralls.io/builds/16438214) Coverage

[GitHub] coveralls commented on issue #1058: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox
coveralls commented on issue #1058: Refactor the collector configuration initialization. URL: https://github.com/apache/incubator-skywalking/pull/1058#issuecomment-380094356 [![Coverage Status](https://coveralls.io/builds/16437000/badge)](https://coveralls.io/builds/16437000)

[GitHub] coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ.

2018-04-10 Thread GitBox
coveralls commented on issue #1052: Collector 5.0.0-alpha version upgrade FAQ. URL: https://github.com/apache/incubator-skywalking/pull/1052#issuecomment-379615075 [![Coverage Status](https://coveralls.io/builds/16436683/badge)](https://coveralls.io/builds/16436683) Coverage

[GitHub] wu-sheng closed pull request #1057: fix #1055 and make code more readable

2018-04-10 Thread GitBox
wu-sheng closed pull request #1057: fix #1055 and make code more readable URL: https://github.com/apache/incubator-skywalking/pull/1057 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ascrutae commented on issue #1057: fix #1055 and make code more readable

2018-04-10 Thread GitBox
ascrutae commented on issue #1057: fix #1055 and make code more readable URL: https://github.com/apache/incubator-skywalking/pull/1057#issuecomment-380019836 This PR is passed. Here is the [test

[GitHub] hanahmily commented on issue #1058: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox
hanahmily commented on issue #1058: Refactor the collector configuration initialization. URL: https://github.com/apache/incubator-skywalking/pull/1058#issuecomment-380013410 I've got it This is an automated message from the

[GitHub] wu-sheng commented on issue #1058: Refactor the collector configuration initialization.

2018-04-10 Thread GitBox
wu-sheng commented on issue #1058: Refactor the collector configuration initialization. URL: https://github.com/apache/incubator-skywalking/pull/1058#issuecomment-380011255 @peng-yongsheng Your CI fails. This is an

[GitHub] wu-sheng commented on issue #1004: on the web ui startTime auto refresh?

2018-04-10 Thread GitBox
wu-sheng commented on issue #1004: on the web ui startTime auto refresh? URL: https://github.com/apache/incubator-skywalking/issues/1004#issuecomment-379986184 Fixed and closing this. This is an automated message from

[GitHub] candyleer commented on issue #1004: on the web ui startTime auto refresh?

2018-04-10 Thread GitBox
candyleer commented on issue #1004: on the web ui startTime auto refresh? URL: https://github.com/apache/incubator-skywalking/issues/1004#issuecomment-379986042 @xjr100419 this bug has been fixed in skywalking-ui module in