date:20180413

[GitHub] w281015308 commented on issue #1048: Create Setting-override-CN.md

2018-04-13 Thread GitBox

w281015308 commented on issue #1048: Create Setting-override-CN.md
URL: 
https://github.com/apache/incubator-skywalking/pull/1048#issuecomment-381204542
 
 
   Hi,Just saw the email .i am so sorry about the document translation. I am 
busy on the work recently. sorry.Eric发自我的iPhone-- Original 
--From: 吴晟 Wu Sheng  Date: Wed,Apr 
11,2018 11:51 AMTo: apache/incubator-skywalking 
Cc: Eric Wang , 
Mention Subject: Re: [apache/incubator-skywalking] 
Create Setting-override-CN.md(#1048)@w281015308 Sorry, I have to close this. 
@candyleer 's #1062 has been merged. It includes all Chinese documents.
   Thanks for your contributions.
   
   —You are receiving this because you were mentioned.Reply to this email 
directly, view it on GitHub, or mute the thread.
   
   
 
 
   
   
   
   
   
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/apache/incubator-skywalking","title":"apache/incubator-skywalking","subtitle":"GitHub
 
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open
 in 
GitHub","url":"https://github.com/apache/incubator-skywalking"}},"updates":{"snippets":[{"icon":"PERSON","message":"@wu-sheng
 in #1048: @w281015308 Sorry, I have to close this. @candyleer 's #1062 has 
been merged. It includes all Chinese documents.\r\n\r\nThanks for your 
contributions."}],"action":{"name":"View Pull 
Request","url":"https://github.com/apache/incubator-skywalking/pull/1048#issuecomment-380318703"}}}


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1073: Feature/1032

2018-04-13 Thread GitBox

coveralls commented on issue #1073: Feature/1032
URL: 
https://github.com/apache/incubator-skywalking/pull/1073#issuecomment-381190504
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16506300/badge)](https://coveralls.io/builds/16506300)
   
   Coverage decreased (-0.04%) to 20.831% when pulling 
**e17ab84f11dd64a22eb9751840f077c9a4321bea on peng-yongsheng:feature/1032** 
into **b4ded22c87df732e9f7b5efea96afd23f704b922 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1073: Feature/1032

2018-04-13 Thread GitBox

coveralls commented on issue #1073: Feature/1032
URL: 
https://github.com/apache/incubator-skywalking/pull/1073#issuecomment-381190504
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16506269/badge)](https://coveralls.io/builds/16506269)
   
   Coverage decreased (-0.04%) to 20.831% when pulling 
**e17ab84f11dd64a22eb9751840f077c9a4321bea on peng-yongsheng:feature/1032** 
into **b4ded22c87df732e9f7b5efea96afd23f704b922 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization

2018-04-13 Thread GitBox

peng-yongsheng commented on issue #1032: Collector performance optimization
URL: 
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
 
 
   ## Report digest
   ```
   metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
   metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
   metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total: 
12(s)
   ```
   Those points could be a source of performance bottlenecks.
   
   ## Performance optimization
   ### Segment parse
    Change cache component from Guava to Caffeine, [ Caffeine's 
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
   ```
   metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
   metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
   metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total: 
6(s)
   ```
    Make all the loggers class variable to have the static modifier.
   ```
   Before:
   /segment/parse
Avg=636584 (nanosecond), Success Rate=100%, Calls=14000, 
Total=8912189125 (nanosecond)
   
   After:
   /segment/parse
Avg=524138 (nanosecond), Success Rate=100%, Calls=14097, 
Total=7388775602 (nanosecond)
   ```
   
    Time stamp format to time bucket performance optimization.
   ```
   Before:
   /segment/parse
Avg=557410 (nanosecond), Success Rate=100%, Calls=14139, 
Total=7881231734 (nanosecond)
   /utils/timeBucket/getSecondTimeBucket
Avg=9768 (nanosecond), Success Rate=100%, Calls=17417, Total=170135908 
(nanosecond)
   /utils/timeBucket/getMinuteTimeBucket
Avg=7384 (nanosecond), Success Rate=100%, Calls=82536, Total=609514865 
(nanosecond)
   
   After:
   /segment/parse
Avg=503868 (nanosecond), Success Rate=100%, Calls=14085, 
Total=7096993057 (nanosecond)
   /utils/timeBucket/getSecondTimeBucket
Avg=13636 (nanosecond), Success Rate=100%, Calls=3664, Total=49964432 
(nanosecond)
   /utils/timeBucket/getMinuteTimeBucket
Avg=6148 (nanosecond), Success Rate=100%, Calls=27512, Total=169161105 
(nanosecond)
   ```
   
    Instance of and time bucket transform
   1. Add contains point method instead instance of for decide span listener 
class type.
   1. Transform minute time bucket just once.
   
   ```
   Before:
   /segment/parse
Avg=503868 (nanosecond), Success Rate=100%, Calls=14085, 
Total=7096993057 (nanosecond)
   After:
   /segment/parse
Avg=81916 (nanosecond), Success Rate=100%, Calls=455534, 
Total=37315774880 (nanosecond)
   ```
   
   ### Storage
    Short Column Name and fixed a persistence timer bug
   TPS before: 6k,   after: 10k
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng opened a new pull request #1073: Feature/1032

2018-04-13 Thread GitBox

peng-yongsheng opened a new pull request #1073: Feature/1032
URL: https://github.com/apache/incubator-skywalking/pull/1073
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [X] Improve performance
   
   - Related issues
   #1032
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   Fixed a bug that persistent timer started multiple times.
   Running about 10 minute, the result of collector performance test is above 
1w TPS when using MacBook 2017.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

2018-04-13 Thread GitBox

wu-sheng commented on a change in pull request #1072: add some basic  
testcase(apm-util and partial collector-ui-jetty-provider)
URL: 
https://github.com/apache/incubator-skywalking/pull/1072#discussion_r181404855
 
 

 ##
 File path: 
apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/test/java/org/apache/skywalking/apm/collector/ui/mutation/ConfigMutationTest.java
 ##
 @@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.collector.ui.mutation;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+/**
+ * this class may not be implemented ,so just test if it's null
+ * if update the class ,please update the testcase
 
 Review comment:
   You don't need such comment. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

2018-04-13 Thread GitBox

coveralls commented on issue #1072: add some basic  testcase(apm-util and 
partial collector-ui-jetty-provider)
URL: 
https://github.com/apache/incubator-skywalking/pull/1072#issuecomment-381118458
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16501753/badge)](https://coveralls.io/builds/16501753)
   
   Coverage increased (+1.08%) to 20.872% when pulling 
**0c1eda7100310c6649122af03e99980c4fd240c8 on candyleer:apm-commmons-testcase** 
into **daceca28eef61ba08f99e18b1ba23789b9f62db2 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

2018-04-13 Thread GitBox

candyleer commented on a change in pull request #1072: add some basic  
testcase(apm-util and partial collector-ui-jetty-provider)
URL: 
https://github.com/apache/incubator-skywalking/pull/1072#discussion_r181359802
 
 

 ##
 File path: 
apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/test/java/org/apache/skywalking/apm/collector/ui/query/AlarmQueryTestCase.java
 ##
 @@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.ui.query;
+
+import org.apache.skywalking.apm.collector.storage.ui.alarm.AlarmType;
+import org.apache.skywalking.apm.collector.storage.ui.common.Duration;
+import org.apache.skywalking.apm.collector.storage.ui.common.Pagination;
+import org.apache.skywalking.apm.collector.storage.ui.common.Step;
+import org.apache.skywalking.apm.collector.ui.service.AlarmService;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+import org.mockito.internal.util.reflection.Whitebox;
+
+import java.text.ParseException;
+
+/**
+ * @author peng-yongsheng
 
 Review comment:
   ok,this maybe copy paste error ,I will avoid the future


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

2018-04-13 Thread GitBox

candyleer commented on a change in pull request #1072: add some basic  
testcase(apm-util and partial collector-ui-jetty-provider)
URL: 
https://github.com/apache/incubator-skywalking/pull/1072#discussion_r181359802
 
 

 ##
 File path: 
apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/test/java/org/apache/skywalking/apm/collector/ui/query/AlarmQueryTestCase.java
 ##
 @@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.ui.query;
+
+import org.apache.skywalking.apm.collector.storage.ui.alarm.AlarmType;
+import org.apache.skywalking.apm.collector.storage.ui.common.Duration;
+import org.apache.skywalking.apm.collector.storage.ui.common.Pagination;
+import org.apache.skywalking.apm.collector.storage.ui.common.Step;
+import org.apache.skywalking.apm.collector.ui.service.AlarmService;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+import org.mockito.internal.util.reflection.Whitebox;
+
+import java.text.ParseException;
+
+/**
+ * @author peng-yongsheng
 
 Review comment:
   ok,this maybe format issue ,i will fix it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

2018-04-13 Thread GitBox

wu-sheng commented on a change in pull request #1072: add some basic  
testcase(apm-util and partial collector-ui-jetty-provider)
URL: 
https://github.com/apache/incubator-skywalking/pull/1072#discussion_r181356406
 
 

 ##
 File path: 
apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/test/java/org/apache/skywalking/apm/collector/ui/query/AlarmQueryTestCase.java
 ##
 @@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.ui.query;
+
+import org.apache.skywalking.apm.collector.storage.ui.alarm.AlarmType;
+import org.apache.skywalking.apm.collector.storage.ui.common.Duration;
+import org.apache.skywalking.apm.collector.storage.ui.common.Pagination;
+import org.apache.skywalking.apm.collector.storage.ui.common.Step;
+import org.apache.skywalking.apm.collector.ui.service.AlarmService;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+import org.mockito.internal.util.reflection.Whitebox;
+
+import java.text.ParseException;
+
+/**
+ * @author peng-yongsheng
 
 Review comment:
   You shouldn't add a class with other's author info.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] candyleer opened a new pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

2018-04-13 Thread GitBox

candyleer opened a new pull request #1072: add some basic  testcase(apm-util 
and partial collector-ui-jetty-provider)
URL: https://github.com/apache/incubator-skywalking/pull/1072
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   - [x] test case 
   
   - Related issues
   add some basic testcase for module apm-commons(apm-util) and partial 
collector-ui-jetty-provider
   please review this code if i code this testcase properly.
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1071: Support nginx opentracing moudle or openresty lua

2018-04-13 Thread GitBox

wu-sheng commented on issue #1071: Support nginx opentracing moudle or 
openresty lua
URL: 
https://github.com/apache/incubator-skywalking/issues/1071#issuecomment-381048617
 
 
   And there is no `opentracing moudle` concept. Please read OpenTracing 
specification.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fyobe opened a new issue #1071: Support nginx opentracing moudle or openresty lua

2018-04-13 Thread GitBox

fyobe opened a new issue #1071: Support nginx opentracing moudle or openresty 
lua
URL: https://github.com/apache/incubator-skywalking/issues/1071
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ X] Requirement
   - [ ] Feature or performance improvement
   ___
   ### Requirement or improvement
   - Support nginx opentracing moudle or openresty lua


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] w281015308 commented on issue #1048: Create Setting-override-CN.md

[GitHub] coveralls commented on issue #1073: Feature/1032

[GitHub] coveralls commented on issue #1073: Feature/1032

[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization

[GitHub] peng-yongsheng opened a new pull request #1073: Feature/1032

[GitHub] wu-sheng commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

[GitHub] coveralls commented on issue #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

[GitHub] candyleer commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

[GitHub] candyleer commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

[GitHub] wu-sheng commented on a change in pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

[GitHub] candyleer opened a new pull request #1072: add some basic testcase(apm-util and partial collector-ui-jetty-provider)

[GitHub] wu-sheng commented on issue #1071: Support nginx opentracing moudle or openresty lua

[GitHub] fyobe opened a new issue #1071: Support nginx opentracing moudle or openresty lua

13 matches

Site Navigation

Mail list logo

Footer information