candyleer opened a new pull request #1164: Fix Average Time zero and ClassCast
Exception
URL: https://github.com/apache/incubator-skywalking/pull/1164
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature pr
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus /
OpenZipkin
URL:
https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882
> apm-collector-thirdparty-agent
I didn't like the `agent` part, even we are using this in existed collector
modu
wu-sheng commented on issue #1162: Clean buffer files by default when restart
collector.
URL:
https://github.com/apache/incubator-skywalking/issues/1162#issuecomment-386517278
Fixed.
This is an automated message from the Apa
wu-sheng closed issue #1162: Clean buffer files by default when restart
collector.
URL: https://github.com/apache/incubator-skywalking/issues/1162
This is an automated message from the Apache Git Service.
To respond to the m
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386517079
@candyleer your blocking should be removed by now.
This is an automated
peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus /
OpenZipkin
URL:
https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517155
1. We need to support ZipKin and Jaeger agent. Suggest those to be maven
third party module's submodule, but also
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386503576
## Report @ 2018/05/04
### Issue
* ~~[Collector] Block Error~~
~~current listener is `ApplicationComponentSpanListener`~~
``
wu-sheng closed pull request #1163: Delete buffer directory when collector
restart.
URL: https://github.com/apache/incubator-skywalking/pull/1163
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
coveralls commented on issue #1163: Delete buffer directory when collector
restart.
URL:
https://github.com/apache/incubator-skywalking/pull/1163#issuecomment-386516811
[](https://coveralls.io/builds/16830169)
Covera
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus /
OpenZipkin
URL:
https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386514348
@candyleer Thanks for providing this sample data. I suggest we could work on
this first with a prototype.
1. Add a n
peng-yongsheng opened a new pull request #1163: Delete buffer directory when
collector restart.
URL: https://github.com/apache/incubator-skywalking/pull/1163
Please answer these questions before submitting pull request
- Why submit this pull request?
- [X] Bug fix
- Related
wu-sheng closed issue #1158: Support settings of collector module provide in
complex structure
URL: https://github.com/apache/incubator-skywalking/issues/1158
This is an automated message from the Apache Git Service.
To resp
wu-sheng commented on issue #1158: Support settings of collector module provide
in complex structure
URL:
https://github.com/apache/incubator-skywalking/issues/1158#issuecomment-386512621
This is not clear. I am going to close this for now.
---
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386309060
## Report @ 2018/05/03
* [Collector]
](https://coveralls.io/builds/16829425)
Coverage remained the
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386303917
## Report @ 2018/05/03
* [UI]
->B(http)->C(http) sample span data:
### A
```json
{
"traceId": "1520
wu-sheng commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386493183
Why do you want to push the setting? Right now, the agent will send VM info
every second, I think it is good enough.
---
zone1511 commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386491721
One concern is if we could actively push the config. Instead of waiting for
agent request and send back a response.
Sent
zone1511 commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386491286
I’m interested to provide if I have more detail. Right now I use another
framework to push config to agent which make the whole d
wu-sheng commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386481833
The idea is very simple. Every gRPC service has a Downstream response, of
course it is NOTHING in it for now. So if the backend c
zone1511 commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386481233
Do you have rough idea how it can be implement? Does the existing agent to
collector protocol allows downstream communication?
hanahmily commented on issue #1146: SkyWalking 5.0.0-beta e2e test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386479424
I have submitted an issue for this problem.
https://github.com/apache/incubator-skywalking/issues/1160
---
hanahmily opened a new issue #1160: Add unknown node image 404 error handler
URL: https://github.com/apache/incubator-skywalking/issues/1160
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [
wu-sheng commented on issue #1159: Does Trace Data Protocol have any upgrade
plan in 5.x series?
URL:
https://github.com/apache/incubator-skywalking/issues/1159#issuecomment-386479181
Thanks for be interesting in our project. We are going to release the
5.0.0-beta in this month.
>
wu-sheng commented on issue #1159: Does Trace Data Protocol have any upgrade
plan in 5.x series?
URL:
https://github.com/apache/incubator-skywalking/issues/1159#issuecomment-386478394
FYI @HouZhiHouJue , I just translate your issue, please keep it in English.
-
HouZhiHouJue opened a new issue #1159: Question:请问5.0的后续版本 后端协议还会有变更么
URL: https://github.com/apache/incubator-skywalking/issues/1159
skywalking是一个很好的开源项目，我这边准备直接在公司试用，但是由于5.0对比3.x有协议变更，为了避免升级的麻烦，准备直接上5.0，请问作者有什么好的建议没？另外，还有如题的疑问，辛苦作者
：）
wu-sheng opened a new issue #1158: Support settings of collector module provide
in complex structure
URL: https://github.com/apache/incubator-skywalking/issues/1158
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discus
wu-sheng closed pull request #1152: Add RunnableWrapper
URL: https://github.com/apache/incubator-skywalking/pull/1152
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull reque
wu-sheng commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386450555
it is to be decided.
This is an automated message from the Apach
zone1511 commented on issue #325: Support config downstream from collector
URL:
https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386361955
@wu-sheng what is the direction for implementing config downstream?
-
coveralls commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386243438
[](https://coveralls.io/builds/16819081)
Coverage decreased (-0.004%) to 23.
wu-sheng closed issue #1149: Change the way of duration calculation for segment
and thermodynamic
URL: https://github.com/apache/incubator-skywalking/issues/1149
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #1149: Change the way of duration calculation for
segment and thermodynamic
URL:
https://github.com/apache/incubator-skywalking/issues/1149#issuecomment-386332645
Done.
This is an automated messa
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386329944
@hanahmily Maybe you should take care this, I remember I mentioned this,
before.
--
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386329321
# Report @ 2018/05/03
## Issue
### Topology
- [UI]When a component icon is not added to
[skywalking-ui/public/img/nod
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386329321
# Report @ 2018/05/03
## Issue
### Topology
When a component icon is not added to
[skywalking-ui/public/img/node](htt
wu-sheng closed pull request #1157: The result of between minutes is incorrect.
URL: https://github.com/apache/incubator-skywalking/pull/1157
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386329321
#Report @ 2018/05/03
### Issue
### Topology
When a component icon is not added to
[skywalking-ui/public/img/node](htt
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386329321
# Report @ 2018/05/03
### Issue
### Topology
When a component icon is not added to
[skywalking-ui/public/img/node](ht
coveralls commented on issue #1157: The result of between minutes is incorrect.
URL:
https://github.com/apache/incubator-skywalking/pull/1157#issuecomment-386329203
[](https://coveralls.io/builds/16818230)
Coverage re
peng-yongsheng opened a new pull request #1157: The result of between minutes
is incorrect.
URL: https://github.com/apache/incubator-skywalking/pull/1157
Please answer these questions before submitting pull request
- Why submit this pull request?
- [X] Bug fix
___
### Bug fi
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386313170
@candyleer maybe you could pinpoint the issue? or provide the es data, like
@ascrutae did in his report.
--
coveralls commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386243438
[](https://coveralls.io/builds/16817033)
Coverage remained the same at 23.31
candyleer commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386309060
## Report @ 2018/05/03
* [Collector]
in dashbo
wu-sheng closed pull request #1156: Change the way of duration calculate.
URL: https://github.com/apache/incubator-skywalking/pull/1156
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
candyleer commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386300090
updated
This is an automated message from the Apache Git Service.
To respond to the
coveralls commented on issue #1156: Change the way of duration calculate.
URL:
https://github.com/apache/incubator-skywalking/pull/1156#issuecomment-386296183
[](https://coveralls.io/builds/16816182)
Coverage increase
peng-yongsheng commented on issue #915: The path of Collector buffer dictionary
is incorrect
URL:
https://github.com/apache/incubator-skywalking/issues/915#issuecomment-386295359
Setting the path in application.yml
```
analysis_segment_parser:
default:
bufferFilePath: ../
peng-yongsheng closed issue #915: The path of Collector buffer dictionary is
incorrect
URL: https://github.com/apache/incubator-skywalking/issues/915
This is an automated message from the Apache Git Service.
To respond to th
coveralls commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386243438
[](https://coveralls.io/builds/16816030)
Coverage decreased (-0.004%) to 23.
peng-yongsheng opened a new pull request #1156: Change the way of duration
calculate.
URL: https://github.com/apache/incubator-skywalking/pull/1156
Please answer these questions before submitting pull request
- Why submit this pull request?
- [X] Bug fix
- Related issues
Anarchists commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386286179
thanks,It's my fault that I didn't built the project correctly
--
Anarchists commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386286179
thanks,It's my fault that I didn't built the project correctly
--
Anarchists closed issue #1151: Could not resolve placeholder 'collector.path'
in value "${collector.path}"
URL: https://github.com/apache/incubator-skywalking/issues/1151
This is an automated message from the Apache Git Serv
wu-sheng closed issue #1032: Collector performance optimization
URL: https://github.com/apache/incubator-skywalking/issues/1032
This is an automated message from the Apache Git Service.
To respond to the message, please log o
wu-sheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-386283335
Done. Please consider post the backend performance report. Maybe we could
post that in InfoQ.
--
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386282460
@ascrutae @liuhaoyang All known and reported issues have been declared
**fixed**. Please run the test.
FYI @peng-yongsh
wu-sheng closed pull request #1155: Submodule/skywalking ui
URL: https://github.com/apache/incubator-skywalking/pull/1155
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitH
coveralls commented on issue #1155: Submodule/skywalking ui
URL:
https://github.com/apache/incubator-skywalking/pull/1155#issuecomment-386280824
[](https://coveralls.io/builds/16815323)
Coverage increased (+0.004%) to
hanahmily commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386273773
Fix UI issues in https://github.com/apache/incubator-skywalking/pull/1155
-
coveralls commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386243438
[](https://coveralls.io/builds/16814854)
Coverage remained the same at 23.30
hanahmily opened a new pull request #1155: Submodule/skywalking ui
URL: https://github.com/apache/incubator-skywalking/pull/1155
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve
coveralls commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386243438
[](https://coveralls.io/builds/16814162)
Coverage remained the same at 23.30
candyleer commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386260721
I am working on this movement now
This is an automated message from the Apache Git
wu-sheng closed issue #1154: 5.0.0-beta-SNAPSHOT
trace是正常的，点击dashboard,toplogy等菜单报错 'Field 'callsPerSec' in type 'Call' is
undefined'
URL: https://github.com/apache/incubator-skywalking/issues/1154
This is an automated me
wu-sheng commented on issue #1154: 5.0.0-beta-SNAPSHOT
trace是正常的，点击dashboard,toplogy等菜单报错 'Field 'callsPerSec' in type 'Call' is
undefined'
URL:
https://github.com/apache/incubator-skywalking/issues/1154#issuecomment-386252608
If you are not going to contribute or change codes, please d
wu-sheng closed pull request #1153: Name incorrect
URL: https://github.com/apache/incubator-skywalking/pull/1153
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (f
zhuangjianfa opened a new issue #1154: 5.0.0-beta-SNAPSHOT
trace是正常的，点击dashboard,toplogy等菜单报错 'Field 'callsPerSec' in type 'Call' is
undefined'
URL: https://github.com/apache/incubator-skywalking/issues/1154
2018-05-03 11:28:40,597 -
org.apache.skywalking.apm.collector.ui.jetty.handler.
coveralls commented on issue #1153: Name incorrect
URL:
https://github.com/apache/incubator-skywalking/pull/1153#issuecomment-386244376
[](https://coveralls.io/builds/16813527)
Coverage increased (+0.004%) to 23.31% w
coveralls commented on issue #1153: Name incorrect
URL:
https://github.com/apache/incubator-skywalking/pull/1153#issuecomment-386244376
[](https://coveralls.io/builds/16813084)
Coverage increased (+0.004%) to 21.656%
wu-sheng closed pull request #1137: Add collector agent test
URL: https://github.com/apache/incubator-skywalking/pull/1137
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
coveralls commented on issue #1137: Add collector agent test
URL:
https://github.com/apache/incubator-skywalking/pull/1137#issuecomment-385407180
[](https://coveralls.io/builds/16812939)
Coverage increased (+1.7%) to
coveralls commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386243438
[](https://coveralls.io/builds/16813042)
Coverage increased (+0.004%) to 21.
wu-sheng commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386240623
Please make us fix this in this pr.
This is an automated message from the Apache Git
candyleer commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386240395
Yes ,this is an `activation ` not a `plugin`.
This is an automated message from the
wu-sheng commented on issue #1152: Add RunnableWrapper
URL:
https://github.com/apache/incubator-skywalking/pull/1152#issuecomment-386237826
The annotations are in the toolkit, please make sure the activation matches
it.
This
peng-yongsheng opened a new pull request #1153: Name incorrect
URL: https://github.com/apache/incubator-skywalking/pull/1153
Renamed attributes and log info.
This is an automated message from the Apache Git Service.
To respond
candyleer opened a new pull request #1152: Add RunnableWrapper
URL: https://github.com/apache/incubator-skywalking/pull/1152
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve per
wu-sheng commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386235613
You should find it at here
![image](https://user-images.githubusercontent.com/5441976/39
candyleer commented on issue #1148: How to support async request?
URL:
https://github.com/apache/incubator-skywalking/issues/1148#issuecomment-386232987
it seems that it's hard to make it automatically for `skywalking`
This i
hanahmily closed pull request #166: Fix Alarm Link
URL: https://github.com/apache/incubator-skywalking-ui/pull/166
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request
Anarchists commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386228034
The release edition，I can't find the log file of webapp , so I choose using
master branch
Anarchists commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386229172
I unzip the skywalking-webapp.jar, and I did't find the application.yml file
Anarchists commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386228034
The release edition，I can't find the log file of webapp , so I choose using
master branch
wu-sheng commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386227750
`application.yml` in webapp.jar, it isn't a part of collector. This is a
part of webapp.
-
Anarchists commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386227315
I hava this package in the codes, but the file ( application.yml ) in the
catalog ( dist\
wu-sheng commented on issue #1151: Could not resolve placeholder
'collector.path' in value "${collector.path}"
URL:
https://github.com/apache/incubator-skywalking/issues/1151#issuecomment-386225535
BTW, if you use master branch code, you should make sure, you should know
well about how to
liuhaoyang opened a new pull request #166: Fix Alarm Link
URL: https://github.com/apache/incubator-skywalking-ui/pull/166
The `Alarm` link is invalid. Click the `Alarm` icon will redirect to the 404
page
This is an automated
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta integration test
URL:
https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386225487
# Report @ 2018/05/03
## Issue
### Topology
* **[UI]** The `Alarm` link is invalid. Click the `Alarm` icon will
redi
1 - 100 of 128 matches
Mail list logo
