[GitHub] wu-sheng closed pull request #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
wu-sheng closed pull request #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16845946/badge)](https://coveralls.io/builds/16845946) Coverage

[GitHub] wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386772477 Thanks everyone. Before and during release vote, feel free to open question. Especially for @liuhaoyang about .NET CORE related

[GitHub] ascrutae opened a new issue #167: The format about exception stack is irregular

2018-05-04 Thread GitBox
ascrutae opened a new issue #167: The format about exception stack is irregular URL: https://github.com/apache/incubator-skywalking-ui/issues/167 Here is the screen snapshot: ![286141525450248_

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386772017 @candyleer @liuhaoyang The 5.0.0-beta tested and we are going to send the vote mail about 5.0-beta release next week. I will close

[GitHub] ascrutae closed issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae closed issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #325: Support config downstream from collector

2018-05-04 Thread GitBox
wu-sheng commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386765599 push is just a concept, in network, except deal with TCP. directly, there is no real push. Also client ask server side for new

[GitHub] zone1511 commented on issue #325: Support config downstream from collector

2018-05-04 Thread GitBox
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386763046 Because some plugin needs dynamic configuration. For agent configuration pushing. It needs to provide several functions -

[GitHub] wu-sheng closed pull request #1173: Do not get alarm metric for overview and application topology.

2018-05-04 Thread GitBox
wu-sheng closed pull request #1173: Do not get alarm metric for overview and application topology. URL: https://github.com/apache/incubator-skywalking/pull/1173 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #1173: Do not get alarm metric for overview and application topology.

2018-05-04 Thread GitBox
coveralls commented on issue #1173: Do not get alarm metric for overview and application topology. URL: https://github.com/apache/incubator-skywalking/pull/1173#issuecomment-386621150 [![Coverage

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16836711/badge)](https://coveralls.io/builds/16836711) Coverage

[GitHub] wu-sheng commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
wu-sheng commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-386622696 Please add link into the doc readme. This is an automated

[GitHub] coveralls commented on issue #1173: Do not get alarm metric for overview and application topology.

2018-05-04 Thread GitBox
coveralls commented on issue #1173: Do not get alarm metric for overview and application topology. URL: https://github.com/apache/incubator-skywalking/pull/1173#issuecomment-386621150 [![Coverage

[GitHub] wu-sheng commented on issue #1160: Add unknown node image 404 error handler

2018-05-04 Thread GitBox
wu-sheng commented on issue #1160: Add unknown node image 404 error handler URL: https://github.com/apache/incubator-skywalking/issues/1160#issuecomment-386613720 This feature moves into beta2. And ask community contributor to help. FYI @liuhaoyang

[GitHub] wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386613235 @ascrutae @liuhaoyang @candyleer Maybe we should run second round test again. @ascrutae If your local test is OK, please

[GitHub] peng-yongsheng opened a new pull request #1173: Do not get alarm metric for overview and application topology.

2018-05-04 Thread GitBox
peng-yongsheng opened a new pull request #1173: Do not get alarm metric for overview and application topology. URL: https://github.com/apache/incubator-skywalking/pull/1173 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910 # ~~Report @ 2018/05/04[Ignored]~~ ## Issue ### Topology * ~~**[COLLECTOR]** the server alarm value is incorrect.

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386303917 ## ~~Report @ 2018/05/03[Fixed]~~ * [UI]

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386199704 # ~~Report @ 2018/05/03[Fixed]~~ the prefix description of Issue: |prefix|description| |:---|:---| |**[AGENT]** | This

[GitHub] wu-sheng commented on issue #1172: improvement:hope skywalking ui support multi environment data viewing

2018-05-04 Thread GitBox
wu-sheng commented on issue #1172: improvement:hope skywalking ui support multi environment data viewing URL: https://github.com/apache/incubator-skywalking/issues/1172#issuecomment-386608084 What do you mean `multi environment data viewing`? I am not following.

[GitHub] wu-sheng closed pull request #1171: Submodule/skywalking ui

2018-05-04 Thread GitBox
wu-sheng closed pull request #1171: Submodule/skywalking ui URL: https://github.com/apache/incubator-skywalking/pull/1171 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] HouZhiHouJue closed issue #1159: Does Trace Data Protocol have any upgrade plan in 5.x series?

2018-05-04 Thread GitBox
HouZhiHouJue closed issue #1159: Does Trace Data Protocol have any upgrade plan in 5.x series? URL: https://github.com/apache/incubator-skywalking/issues/1159 This is an automated message from the Apache Git Service. To

[GitHub] HouZhiHouJue commented on issue #1159: Does Trace Data Protocol have any upgrade plan in 5.x series?

2018-05-04 Thread GitBox
HouZhiHouJue commented on issue #1159: Does Trace Data Protocol have any upgrade plan in 5.x series? URL: https://github.com/apache/incubator-skywalking/issues/1159#issuecomment-386592365 ok, thanks. This is an automated

[GitHub] HouZhiHouJue opened a new issue #1172: improvement:hope skywalking ui support multi environment data viewing

2018-05-04 Thread GitBox
HouZhiHouJue opened a new issue #1172: improvement:hope skywalking ui support multi environment data viewing URL: https://github.com/apache/incubator-skywalking/issues/1172 for users ,this is more convenient,thanks. This is

[GitHub] hanahmily opened a new pull request #1171: Submodule/skywalking ui

2018-05-04 Thread GitBox
hanahmily opened a new pull request #1171: Submodule/skywalking ui URL: https://github.com/apache/incubator-skywalking/pull/1171 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ]

[GitHub] coveralls commented on issue #1170: Fix protobuf dirname for apm-remote-grpc-provider

2018-05-04 Thread GitBox
coveralls commented on issue #1170: Fix protobuf dirname for apm-remote-grpc-provider URL: https://github.com/apache/incubator-skywalking/pull/1170#issuecomment-386570135 [![Coverage Status](https://coveralls.io/builds/16833185/badge)](https://coveralls.io/builds/16833185)

[GitHub] brucewu-fly opened a new pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider

2018-05-04 Thread GitBox
brucewu-fly opened a new pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider URL: https://github.com/apache/incubator-skywalking/pull/1170 The directory should be `apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf` rather than

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16832558/badge)](https://coveralls.io/builds/16832558) Coverage

[GitHub] coveralls commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
coveralls commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386558445 [![Coverage Status](https://coveralls.io/builds/16832337/badge)](https://coveralls.io/builds/16832337)

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910 # Report @ 2018/05/04 ## Issue ### Topology * **[COLLECTOR]** the server alarm value is incorrect. Except is 1, but

[GitHub] peng-yongsheng closed pull request #1168: JDK 9 compile.

2018-05-04 Thread GitBox
peng-yongsheng closed pull request #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] liuhaoyang closed pull request #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang closed pull request #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #1168: JDK 9 compile.

2018-05-04 Thread GitBox
coveralls commented on issue #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386553512 [![Coverage Status](https://coveralls.io/builds/16831980/badge)](https://coveralls.io/builds/16831980) Coverage remained the same at 23.363%

[GitHub] liuhaoyang commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386553431 You're right. It is not appropriate to remove existing IDS.

[GitHub] wu-sheng commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
wu-sheng commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552128 Cannot support for now or forever? From my perspective, removing some existed IDs is a very dangerous and

[GitHub] wu-sheng commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
wu-sheng commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552511 `sqlite` is a difference component compared with `EntityFrameworkCore's in-memory database`. Right? So, you don't

[GitHub] liuhaoyang commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552033 @wu-sheng EntityFrameworkCore's in-memory database does not have built-in diagostics api, and a better way is to

[GitHub] wu-sheng commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
wu-sheng commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386550279 what do you mean cannot support? This is an automated

[GitHub] liuhaoyang opened a new pull request #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang opened a new pull request #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] liuhaoyang commented on issue #1168: JDK 9 compile.

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386547217 yes. I just use JDK9 to test. This is an automated message from the Apache Git Service.

[GitHub] wu-sheng commented on issue #1168: JDK 9 compile.

2018-05-04 Thread GitBox
wu-sheng commented on issue #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386546604 @liuhaoyang FYI, we didn't add jdk9 and jdk10 compile in CI. These cost too much. I still recommend to compile in JDK8.

[GitHub] peng-yongsheng opened a new pull request #1168: JDK 9 compile.

2018-05-04 Thread GitBox
peng-yongsheng opened a new pull request #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168 Please answer these questions before submitting pull request - Why submit this pull request? - [X] New feature provided ___ ### New feature or

[GitHub] wu-sheng opened a new issue #1167: Refactor the plugin component name to real library name

2018-05-04 Thread GitBox
wu-sheng opened a new issue #1167: Refactor the plugin component name to real library name URL: https://github.com/apache/incubator-skywalking/issues/1167 Since the component mapping has provided in collector side, please refactor all existed component plugins to their real component

[GitHub] wu-sheng opened a new issue #1166: Optimize topology query

2018-05-04 Thread GitBox
wu-sheng opened a new issue #1166: Optimize topology query URL: https://github.com/apache/incubator-skywalking/issues/1166 Add a new column for group query, in order to reduce the query cost. This is an automated message

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386199704 # Report @ 2018/05/03 the prefix description of Issue: |prefix|description| |:---|:---| |**[AGENT]** | This prefix

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16831128/badge)](https://coveralls.io/builds/16831128) Coverage

[GitHub] wu-sheng closed pull request #1165: Get conjectural node component name from component server name.

2018-05-04 Thread GitBox
wu-sheng closed pull request #1165: Get conjectural node component name from component server name. URL: https://github.com/apache/incubator-skywalking/pull/1165 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] coveralls commented on issue #1165: Get conjectural node component name from component server name.

2018-05-04 Thread GitBox
coveralls commented on issue #1165: Get conjectural node component name from component server name. URL: https://github.com/apache/incubator-skywalking/pull/1165#issuecomment-386533059 [![Coverage

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882 > apm-collector-thirdparty-agent I didn't like the `agent` part, even we are using this in existed collector

[GitHub] peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517155 1. We need to support ZipKin and Jaeger agent. Suggest those to be maven third party module's submodule, but

[GitHub] wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386530116 @liuhaoyang #1165 should fix your server type issue, but need your test case to recheck.

[GitHub] peng-yongsheng opened a new pull request #1165: Get conjectural node component name from component server name.

2018-05-04 Thread GitBox
peng-yongsheng opened a new pull request #1165: Get conjectural node component name from component server name. URL: https://github.com/apache/incubator-skywalking/pull/1165 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix

[GitHub] wu-sheng closed pull request #1164: Fix Average time zero

2018-05-04 Thread GitBox
wu-sheng closed pull request #1164: Fix Average time zero URL: https://github.com/apache/incubator-skywalking/pull/1164 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] coveralls commented on issue #1164: Fix Average time zero

2018-05-04 Thread GitBox
coveralls commented on issue #1164: Fix Average time zero URL: https://github.com/apache/incubator-skywalking/pull/1164#issuecomment-386524932 [![Coverage Status](https://coveralls.io/builds/16830508/badge)](https://coveralls.io/builds/16830508) Coverage remained the same at

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386199704 # Report @ 2018/05/03 the prefix description of Issue: |prefix|description| |:---|:---| |**[AGENT]** | This prefix

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386309060 ## ~~Report @ 2018/05/03 [Fixed]~~ * ~~[Collector] 0 maybe not correct~~

[GitHub] liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386225487 # ~~Report @ 2018/05/03 [Fixed]~~ ## Issue ### Topology * ~~**[UI]** The `Alarm` link is invalid. Click the `Alarm` icon

[GitHub] liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386225487 # ~~Report @ 2018/05/03~~ ## Issue ### Topology * ~~**[UI]** The `Alarm` link is invalid. Click the `Alarm` icon will

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386503576 ## ~~Report @ 2018/05/04 [Fixed]~~ ### Issue * ~~[Collector] Block Error~~ ~~current listener is

[GitHub] liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386225487 # Report @ 2018/05/03 ## Issue ### Topology * ~~**[UI]** The `Alarm` link is invalid. Click the `Alarm` icon will redirect

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386309060 ## Report @ 2018/05/03 [Fixed] * ~~[Collector] 0 maybe not correct~~

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386503576 ## Report @ 2018/05/04 [Fixed] ### Issue * ~~[Collector] Block Error~~ ~~current listener is

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386309060 ## Report @ 2018/05/03 [Fixed] * [Collector]

[GitHub] candyleer opened a new pull request #1164: Fix Average Time zero and ClassCast Exception

2018-05-04 Thread GitBox
candyleer opened a new pull request #1164: Fix Average Time zero and ClassCast Exception URL: https://github.com/apache/incubator-skywalking/pull/1164 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882 > apm-collector-thirdparty-agent I didn't like the `agent` part, even we are using this in existed collector

[GitHub] wu-sheng commented on issue #1162: Clean buffer files by default when restart collector.

2018-05-04 Thread GitBox
wu-sheng commented on issue #1162: Clean buffer files by default when restart collector. URL: https://github.com/apache/incubator-skywalking/issues/1162#issuecomment-386517278 Fixed. This is an automated message from the

[GitHub] wu-sheng closed issue #1162: Clean buffer files by default when restart collector.

2018-05-04 Thread GitBox
wu-sheng closed issue #1162: Clean buffer files by default when restart collector. URL: https://github.com/apache/incubator-skywalking/issues/1162 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386517079 @candyleer your blocking should be removed by now. This is an

[GitHub] peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517155 1. We need to support ZipKin and Jaeger agent. Suggest those to be maven third party module's submodule, but

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386503576 ## Report @ 2018/05/04 ### Issue * ~~[Collector] Block Error~~ ~~current listener is `ApplicationComponentSpanListener`~~

[GitHub] wu-sheng closed pull request #1163: Delete buffer directory when collector restart.

2018-05-04 Thread GitBox
wu-sheng closed pull request #1163: Delete buffer directory when collector restart. URL: https://github.com/apache/incubator-skywalking/pull/1163 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] coveralls commented on issue #1163: Delete buffer directory when collector restart.

2018-05-04 Thread GitBox
coveralls commented on issue #1163: Delete buffer directory when collector restart. URL: https://github.com/apache/incubator-skywalking/pull/1163#issuecomment-386516811 [![Coverage Status](https://coveralls.io/builds/16830169/badge)](https://coveralls.io/builds/16830169)

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386514348 @candyleer Thanks for providing this sample data. I suggest we could work on this first with a prototype. 1. Add a

[GitHub] wu-sheng closed issue #1158: Support settings of collector module provide in complex structure

2018-05-04 Thread GitBox
wu-sheng closed issue #1158: Support settings of collector module provide in complex structure URL: https://github.com/apache/incubator-skywalking/issues/1158 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1158: Support settings of collector module provide in complex structure

2018-05-04 Thread GitBox
wu-sheng commented on issue #1158: Support settings of collector module provide in complex structure URL: https://github.com/apache/incubator-skywalking/issues/1158#issuecomment-386512621 This is not clear. I am going to close this for now.