[GitHub] wu-sheng closed pull request #1180: Docs/fix grpc dirname

2018-05-05 Thread GitBox
wu-sheng closed pull request #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] coveralls commented on issue #1180: Docs/fix grpc dirname

2018-05-05 Thread GitBox
coveralls commented on issue #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180#issuecomment-386855287 [![Coverage Status](https://coveralls.io/builds/16852621/badge)](https://coveralls.io/builds/16852621) Coverage increased (+0.004%) to

[GitHub] brucewu-fly closed pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider

2018-05-05 Thread GitBox
brucewu-fly closed pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider URL: https://github.com/apache/incubator-skywalking/pull/1170 This is an automated message from the Apache Git Service. To respond to

[GitHub] brucewu-fly opened a new pull request #1180: Docs/fix grpc dirname

2018-05-05 Thread GitBox
brucewu-fly opened a new pull request #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180 The directory should be apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf rather than

[GitHub] coveralls commented on issue #1179: Fix first formula, like #1164

2018-05-05 Thread GitBox
coveralls commented on issue #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179#issuecomment-386851449 [![Coverage Status](https://coveralls.io/builds/16852285/badge)](https://coveralls.io/builds/16852285) Coverage remained the

[GitHub] candyleer opened a new pull request #1179: Fix first formula, like #1164

2018-05-05 Thread GitBox
candyleer opened a new pull request #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ]

[GitHub] wu-sheng opened a new issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng opened a new issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 ![image](https://user-images.githubusercontent.com/5441976/39664274-5d476350-50b3-11e8-84ca-85243c9becaa.png) In this topology, these is only one

[GitHub] wu-sheng closed issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng closed issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng commented on issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177#issuecomment-386845098 I have pinpointed this issue. We really need to refact all component libraries. This is an agent issue, caused by old design.

[GitHub] coveralls commented on issue #1178: Fix If traceId not exists result will return all traces

2018-05-05 Thread GitBox
coveralls commented on issue #1178: Fix If traceId not exists result will return all traces URL: https://github.com/apache/incubator-skywalking/pull/1178#issuecomment-386815145 [![Coverage Status](https://coveralls.io/builds/16848816/badge)](https://coveralls.io/builds/16848816)

[GitHub] candyleer opened a new pull request #1178: Fix If traceId not exists result will return all traces

2018-05-05 Thread GitBox
candyleer opened a new pull request #1178: Fix If traceId not exists result will return all traces URL: https://github.com/apache/incubator-skywalking/pull/1178 Please answer these questions before submitting pull request - Why submit this pull request? - [x ] Bug fix - [ ]

[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view

2018-05-05 Thread GitBox
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-386811807 Add new query service based on applicationId. And redesign the service view.

[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view

2018-05-05 Thread GitBox
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-386811713 Yes, it is. It is on the roadmap. This is an

[GitHub] wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0

2018-05-05 Thread GitBox
wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0 URL: https://github.com/apache/incubator-skywalking/issues/1174#issuecomment-386811653 FYI @peng-yongsheng This may be why there is service's applicationId is 0.

[GitHub] wu-sheng closed pull request #1175: Fix Parent Application Instance Id is 0

2018-05-05 Thread GitBox
wu-sheng closed pull request #1175: Fix Parent Application Instance Id is 0 URL: https://github.com/apache/incubator-skywalking/pull/1175 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] wu-sheng closed issue #1174: Duplicate Service Name And application id is 0

2018-05-05 Thread GitBox
wu-sheng closed issue #1174: Duplicate Service Name And application id is 0 URL: https://github.com/apache/incubator-skywalking/issues/1174 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng opened a new issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng opened a new issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 ![image](https://user-images.githubusercontent.com/5441976/39664274-5d476350-50b3-11e8-84ca-85243c9becaa.png) In this topology, these is only one

[GitHub] coveralls commented on issue #1175: Fix Parent Application Instance Id is 0

2018-05-05 Thread GitBox
coveralls commented on issue #1175: Fix Parent Application Instance Id is 0 URL: https://github.com/apache/incubator-skywalking/pull/1175#issuecomment-386809795 [![Coverage Status](https://coveralls.io/builds/16848406/badge)](https://coveralls.io/builds/16848406) Coverage

[GitHub] candyleer opened a new pull request #1175: ix #1174

2018-05-05 Thread GitBox
candyleer opened a new pull request #1175: ix #1174 URL: https://github.com/apache/incubator-skywalking/pull/1175 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance