[GitHub] brucewu-fly opened a new pull request #1180: Docs/fix grpc dirname
brucewu-fly opened a new pull request #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180 The directory should be apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf rather than apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/protobuf. Missing generated-sources/ Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues N/A ___ ### Bug fix - Bug description. Missing `generated-sources/` for protobuf dirname - How to fix? Replace `apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/protobuf` with `apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1179: Fix first formula, like #1164
coveralls commented on issue #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179#issuecomment-386851449 [](https://coveralls.io/builds/16852285) Coverage remained the same at 23.356% when pulling **ab17e263f129b2002699f30bfb6609cb29915816 on candyleer:fix_first_formula** into **4714f0e19e56ec4a9ad91daa4cfb1aee0462cd60 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new pull request #1179: Fix first formula, like #1164
candyleer opened a new pull request #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues like #1164 ,in `Application Metric` may strigger ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1177: The number of Kafka is incorrect
wu-sheng opened a new issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177  In this topology, these is only one Kafka, and same in reality env. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1177: The number of Kafka is incorrect
wu-sheng closed issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1177: The number of Kafka is incorrect
wu-sheng commented on issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177#issuecomment-386845098 I have pinpointed this issue. We really need to refact all component libraries. This is an agent issue, caused by old design. @peng-yongsheng @ascrutae This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new pull request #1178: Fix If traceId not exists result will return all traces
candyleer opened a new pull request #1178: Fix If traceId not exists result
will return all traces
URL: https://github.com/apache/incubator-skywalking/pull/1178
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
```java
http://localhost:8000/api/trace
{"variables":{"condition":{"traceId":"123","queryDuration":{"start":"2018-05-05
2302","end":"2018-05-05
2317","step":"MINUTE"},"paging":{"pageNum":1,"pageSize":20,"needTotal":true}}},"query":"\n
query BasicTraces($condition: TraceQueryCondition) {\n
queryBasicTraces(condition: $condition) {\n traces {\nkey:
segmentId\noperationName\nduration\nstart\n
isError\ntraceIds\n }\n total\n}\n }\n"}
```
this will return all traces in server.
```java
public TraceBrief queryBasicTraces(TraceQueryCondition condition) throws
ParseException {
long startSecondTimeBucket = 0;
long endSecondTimeBucket = 0;
String traceId = Const.EMPTY_STRING;
if (StringUtils.isNotEmpty(condition.getTraceId())) {
traceId = condition.getTraceId();
} else if (nonNull(condition.getQueryDuration())) {
startSecondTimeBucket =
DurationUtils.INSTANCE.startTimeDurationToSecondTimeBucket(condition.getQueryDuration().getStep(),
condition.getQueryDuration().getStart());
endSecondTimeBucket =
DurationUtils.INSTANCE.endTimeDurationToSecondTimeBucket(condition.getQueryDuration().getStep(),
condition.getQueryDuration().getEnd());
} else {
throw new UnexpectedException("The condition must contains
either queryDuration or traceId.");
}
long minDuration = condition.getMinTraceDuration();
long maxDuration = condition.getMaxTraceDuration();
String operationName = condition.getOperationName();
int applicationId = condition.getApplicationId();
PaginationUtils.Page page =
PaginationUtils.INSTANCE.exchange(condition.getPaging());
return getSegmentTopService().loadTop(startSecondTimeBucket,
endSecondTimeBucket, minDuration, maxDuration, operationName, traceId,
applicationId, page.getLimit(), page.getFrom());
}
```
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-386811807 Add new query service based on applicationId. And redesign the service view. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-386811713 Yes, it is. It is on the roadmap. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0
wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0 URL: https://github.com/apache/incubator-skywalking/issues/1174#issuecomment-386811653 FYI @peng-yongsheng This may be why there is service's applicationId is 0. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1175: Fix Parent Application Instance Id is 0
wu-sheng closed pull request #1175: Fix Parent Application Instance Id is 0
URL: https://github.com/apache/incubator-skywalking/pull/1175
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegmentRef.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegmentRef.java
index 78981a351..d51362958 100644
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegmentRef.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegmentRef.java
@@ -123,7 +123,6 @@ public TraceSegmentReference transform() {
TraceSegmentReference.Builder refBuilder =
TraceSegmentReference.newBuilder();
if (SegmentRefType.CROSS_PROCESS.equals(type)) {
refBuilder.setRefType(RefType.CrossProcess);
-
refBuilder.setParentApplicationInstanceId(parentApplicationInstanceId);
if (peerId == DictionaryUtil.nullValue()) {
refBuilder.setNetworkAddress(peerHost);
} else {
@@ -133,6 +132,7 @@ public TraceSegmentReference transform() {
refBuilder.setRefType(RefType.CrossThread);
}
+refBuilder.setParentApplicationInstanceId(parentApplicationInstanceId);
refBuilder.setEntryApplicationInstanceId(entryApplicationInstanceId);
refBuilder.setParentTraceSegmentId(traceSegmentId.transform());
refBuilder.setParentSpanId(spanId);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng opened a new issue #1177: The number of Kafka is incorrect
wu-sheng opened a new issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177  In this topology, these is only one Kafka, and same in reality env. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
