[GitHub] coveralls commented on issue #1190: Change the intercept point of block call way

2018-05-08 Thread GitBox
coveralls commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387471505 [![Coverage Status](https://coveralls.io/builds/16897626/badge)](https://coveralls.io/builds/16897626) Coverage

[GitHub] wu-sheng commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-08 Thread GitBox
wu-sheng commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387612233 FYI @peng-yongsheng Please just review this, don't merge this. Hold this for beta2.

[GitHub] wu-sheng commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
wu-sheng commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387612171 @hanahmily Even the pr is good enough, please hold this for beta2. We must make sure the codes froze. FYI

[GitHub] coveralls commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-08 Thread GitBox
coveralls commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387610938 [![Coverage Status](https://coveralls.io/builds/16897028/badge)](https://coveralls.io/builds/16897028)

[GitHub] candyleer commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
candyleer commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387607732 that's great This is an automated message from the

[GitHub] candyleer opened a new pull request #1194: Modify operationName search from match to match_phrase

2018-05-08 Thread GitBox
candyleer opened a new pull request #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] wu-sheng commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
wu-sheng commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387605003 Last 15 mins for quick search works for me. Info you that, we will add more links for trace query in beta2, which will

[GitHub] wu-sheng closed issue #1186: Webapp read timeout config

2018-05-08 Thread GitBox
wu-sheng closed issue #1186: Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/issues/1186 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng closed pull request #1192: Fix #1186 Webapp read timeout config

2018-05-08 Thread GitBox
wu-sheng closed pull request #1192: Fix #1186 Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/pull/1192 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] candyleer commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
candyleer commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387604376 haha , `data range` is a mistake..it's date a prototype about what i say

[GitHub] coveralls commented on issue #1192: Fix #1186 Webapp read timeout config

2018-05-08 Thread GitBox
coveralls commented on issue #1192: Fix #1186 Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/pull/1192#issuecomment-387599852 [![Coverage Status](https://coveralls.io/builds/16896712/badge)](https://coveralls.io/builds/16896712) Coverage

[GitHub] wu-sheng commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
wu-sheng commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387603796 > Latest 15 minutes This could be a new feature. > select component This is hard, I think. The

[GitHub] candyleer commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
candyleer commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387603360 add a radio to view `Latest 15 minutes`(`select` component?) data or use data range search ?

[GitHub] wu-sheng commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
wu-sheng commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387601964 > but another question. actually I want to a way to fetch the newest traces in a more convenient way instead of

[GitHub] candyleer commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
candyleer commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387601766 this looks good for this validation. but another question. actually I want to a way to fetch the newest traces in

[GitHub] wu-sheng closed pull request #1191: Update readme for beta release.

2018-05-08 Thread GitBox
wu-sheng closed pull request #1191: Update readme for beta release. URL: https://github.com/apache/incubator-skywalking/pull/1191 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] coveralls commented on issue #1191: Update readme for beta release.

2018-05-08 Thread GitBox
coveralls commented on issue #1191: Update readme for beta release. URL: https://github.com/apache/incubator-skywalking/pull/1191#issuecomment-387599877 [![Coverage Status](https://coveralls.io/builds/16896503/badge)](https://coveralls.io/builds/16896503) Coverage increased

[GitHub] coveralls commented on issue #1192: Fix #1186 Webapp read timeout config

2018-05-08 Thread GitBox
coveralls commented on issue #1192: Fix #1186 Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/pull/1192#issuecomment-387599852 [![Coverage Status](https://coveralls.io/builds/16896501/badge)](https://coveralls.io/builds/16896501) Coverage remained

[GitHub] wu-sheng commented on issue #1190: Change the intercept point of block call way

2018-05-08 Thread GitBox
wu-sheng commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387598053 FYI @flychao88 , please test on your site, and give us some feedback.

[GitHub] hanahmily opened a new pull request #1192: Fix #1186 Webapp read timeout config

2018-05-08 Thread GitBox
hanahmily opened a new pull request #1192: Fix #1186 Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/pull/1192 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided

[GitHub] wu-sheng opened a new pull request #1191: Update readme for beta release.

2018-05-08 Thread GitBox
wu-sheng opened a new pull request #1191: Update readme for beta release. URL: https://github.com/apache/incubator-skywalking/pull/1191 Make history, features and document links more clear. This is an automated message from

[GitHub] coveralls commented on issue #1190: Change the buired point of block call way

2018-05-08 Thread GitBox
coveralls commented on issue #1190: Change the buired point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387471505 [![Coverage Status](https://coveralls.io/builds/16887638/badge)](https://coveralls.io/builds/16887638) Coverage

[GitHub] ascrutae opened a new pull request #1190: Change the buired point of block call way

2018-05-08 Thread GitBox
ascrutae opened a new pull request #1190: Change the buired point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature

[GitHub] wu-sheng closed pull request #1184: Update FAQ doc

2018-05-08 Thread GitBox
wu-sheng closed pull request #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] coveralls commented on issue #1184: Update FAQ doc

2018-05-08 Thread GitBox
coveralls commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387086981 [![Coverage Status](https://coveralls.io/builds/16882278/badge)](https://coveralls.io/builds/16882278) Coverage remained the same at 23.358%

[GitHub] coveralls commented on issue #1184: Update FAQ doc

2018-05-08 Thread GitBox
coveralls commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387086981 [![Coverage Status](https://coveralls.io/builds/16882264/badge)](https://coveralls.io/builds/16882264) Coverage remained the same at 23.358%

[GitHub] wu-sheng closed issue #1013: Analysis dependencies of nodejs webpack

2018-05-08 Thread GitBox
wu-sheng closed issue #1013: Analysis dependencies of nodejs webpack URL: https://github.com/apache/incubator-skywalking/issues/1013 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng commented on issue #1013: Analysis dependencies of nodejs webpack

2018-05-08 Thread GitBox
wu-sheng commented on issue #1013: Analysis dependencies of nodejs webpack URL: https://github.com/apache/incubator-skywalking/issues/1013#issuecomment-387370287 Done. This is an automated message from the Apache Git

[GitHub] candyleer commented on issue #1184: Update FAQ doc

2018-05-08 Thread GitBox
candyleer commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387350056 no problem This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng closed pull request #1189: Update UI licenses

2018-05-08 Thread GitBox
wu-sheng closed pull request #1189: Update UI licenses URL: https://github.com/apache/incubator-skywalking/pull/1189 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1188: Span detail in trace view should be in message box

2018-05-08 Thread GitBox
wu-sheng commented on issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188#issuecomment-387333759 I and @hanahmily have some aggressive ideas, but we are afraid may effect the stable. So may choose an easy but

[GitHub] liuhaoyang commented on issue #1188: Span detail in trace view should be in message box

2018-05-08 Thread GitBox
liuhaoyang commented on issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188#issuecomment-387332715 Is it possible to support spans to collapse and expand based on dependencies? Just like zipkin:

[GitHub] wu-sheng opened a new issue #1188: Span detail in trace view should be in message box

2018-05-08 Thread GitBox
wu-sheng opened a new issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188 In Beta, we change the span in the bottom of the trace view, some one give us the feedback: > If the trace contains a lot of spans,

[GitHub] wu-sheng opened a new issue #1187: Link to trace query from Thermodynamic graph

2018-05-08 Thread GitBox
wu-sheng opened a new issue #1187: Link to trace query from Thermodynamic graph URL: https://github.com/apache/incubator-skywalking/issues/1187 User can click the each element in Thermodynamic graph, then query the traces in the given timeline and duration.

[GitHub] hanahmily opened a new issue #1186: Webapp read timeout config

2018-05-08 Thread GitBox
hanahmily opened a new issue #1186: Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/issues/1186 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement